Re: ACL tests

2014-02-11 Thread Sage Weil
On Wed, 12 Feb 2014, Guangliang Zhao wrote: > On Thu, Jan 30, 2014 at 04:20:46PM -0800, Sage Weil wrote: > > Hi Sage, > > Sorry for the late reply, I just returned from a long vacation :-) No problem. Welcome back! > I have found some issues which maybe relate the bugs you mentioned, and > the

Re: ACL tests

2014-02-11 Thread Guangliang Zhao
On Thu, Jan 30, 2014 at 04:20:46PM -0800, Sage Weil wrote: Hi Sage, Sorry for the late reply, I just returned from a long vacation :-) I have found some issues which maybe relate the bugs you mentioned, and the patches are coming soon. > Hi Guangliang, > > There were a few hiccups getting the

Re: [PATCH 2/5] ceph: remove zero-size xattr

2014-02-11 Thread Yan, Zheng
On 02/12/2014 10:43 AM, Sage Weil wrote: > On Wed, 12 Feb 2014, Yan, Zheng wrote: >> On 02/12/2014 01:25 AM, Alex Elder wrote: >>> On 02/11/2014 09:10 AM, Yan, Zheng wrote: On Tue, Feb 11, 2014 at 10:47 PM, Alex Elder wrote: > On 02/10/2014 11:30 PM, Yan, Zheng wrote: >> Signed-off-by

Re: [PATCH 2/5] ceph: remove zero-size xattr

2014-02-11 Thread Sage Weil
On Wed, 12 Feb 2014, Yan, Zheng wrote: > On 02/12/2014 01:25 AM, Alex Elder wrote: > > On 02/11/2014 09:10 AM, Yan, Zheng wrote: > >> On Tue, Feb 11, 2014 at 10:47 PM, Alex Elder wrote: > >>> On 02/10/2014 11:30 PM, Yan, Zheng wrote: > Signed-off-by: Yan, Zheng > >>> > >>> You really need to

Re: [PATCH 2/5] ceph: remove zero-size xattr

2014-02-11 Thread Yan, Zheng
On 02/12/2014 01:25 AM, Alex Elder wrote: > On 02/11/2014 09:10 AM, Yan, Zheng wrote: >> On Tue, Feb 11, 2014 at 10:47 PM, Alex Elder wrote: >>> On 02/10/2014 11:30 PM, Yan, Zheng wrote: Signed-off-by: Yan, Zheng >>> >>> You really need to explain better under what circumstances >>> a zero-s

Re: [ceph-users] poor data distribution

2014-02-11 Thread Sage Weil
On Wed, 12 Feb 2014, Dominik Mostowiec wrote: > Hi, > If this problem (with stucked active+remapped pgs after > reweight-by-utilisation) affects all ceph configurations or only > specific ones? > If specific: what is the reason in my case? Is this caused by crush > configuration (cluster architectu

Re: [ceph-users] poor data distribution

2014-02-11 Thread Dominik Mostowiec
Hi, If this problem (with stucked active+remapped pgs after reweight-by-utilisation) affects all ceph configurations or only specific ones? If specific: what is the reason in my case? Is this caused by crush configuration (cluster architecture, crush tunnables, ...), cluster size, architecture desi

Re: [PATCH 5/5] ceph: fix ceph_set_acl()

2014-02-11 Thread Alex Elder
On 02/10/2014 11:30 PM, Yan, Zheng wrote: > If acl is equivalent to file mode permission bits, ceph_set_acl() > needs to remove any existing acl xattr. Use __ceph_setxattr() to > handle both setting and removing acl xattr cases, it doesn't return > -ENODATA when there is no acl xattr. This looks g

Re: [PATCH 4/5] ceph: add missing init_acl() for mkdir() and atomic_open()

2014-02-11 Thread Alex Elder
On 02/10/2014 11:30 PM, Yan, Zheng wrote: This looks OK to me but you should get another opinion, I haven't really given it as thorough a review as I normally do. Reviewed-by: Alex Elder > Signed-off-by: Yan, Zheng > --- > fs/ceph/dir.c | 9 + > fs/ceph/file.c | 1 + > 2 files change

Re: [PATCH 2/5] ceph: remove zero-size xattr

2014-02-11 Thread Alex Elder
On 02/11/2014 09:10 AM, Yan, Zheng wrote: > On Tue, Feb 11, 2014 at 10:47 PM, Alex Elder wrote: >> On 02/10/2014 11:30 PM, Yan, Zheng wrote: >>> Signed-off-by: Yan, Zheng >> >> You really need to explain better under what circumstances >> a zero-size xattr is getting removed. >> >> But apparently

Re: wip-libcephfs-firefly-rb

2014-02-11 Thread Matt W. Benjamin
This should be it: https://github.com/linuxbox2/linuxbox-ceph/tree/wip-libcephfs-firefly-rb Matt - "Sage Weil" wrote: > On Sat, 8 Feb 2014, Matt W. Benjamin wrote: > > Hi, > > > > It looks to me like the rebase was already done--I thought Casey > needed me to finish that up, > > but e

Re: [PATCH 2/5] ceph: remove zero-size xattr

2014-02-11 Thread Yan, Zheng
On Tue, Feb 11, 2014 at 10:47 PM, Alex Elder wrote: > On 02/10/2014 11:30 PM, Yan, Zheng wrote: >> Signed-off-by: Yan, Zheng > > You really need to explain better under what circumstances > a zero-size xattr is getting removed. > > But apparently it's only when you're updating an xattr > (not bui

Re: wip-libcephfs-firefly-rb

2014-02-11 Thread Sage Weil
On Sat, 8 Feb 2014, Matt W. Benjamin wrote: > Hi, > > It looks to me like the rebase was already done--I thought Casey needed me to > finish that up, > but everything just built for me. What is the URL for the posted branch? Thanks! sage > > Matt > > - "Sage Weil" wrote: > > > Hey Ma

Re: [PATCH 3/5] ceph: fix ceph_removexattr()

2014-02-11 Thread Alex Elder
On 02/10/2014 11:30 PM, Yan, Zheng wrote: > Signed-off-by: Yan, Zheng You need a better explanation than "fix." We have the ENODATA thing (versus ENOATTR), but again what you have is fine. > --- > fs/ceph/xattr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph

Re: [PATCH 2/5] ceph: remove zero-size xattr

2014-02-11 Thread Alex Elder
On 02/10/2014 11:30 PM, Yan, Zheng wrote: > Signed-off-by: Yan, Zheng You really need to explain better under what circumstances a zero-size xattr is getting removed. But apparently it's only when you're updating an xattr (not building it up from a blob from storage). Why are you doing this? W

Re: [PATCH 1/5] ceph: properly handle XATTR_CREATE and XATTR_REPLACE

2014-02-11 Thread Alex Elder
On 02/10/2014 11:30 PM, Yan, Zheng wrote: > return -EEXIST if XATTR_CREATE is set and xattr alread exists. > return -ENODATA if XATTR_REPLACE is set but xattr does not exist. (I have a set of changes to this source file that I never got in; I'll see if I can dig them up and post them for review to

Re: Libvirt patch for Ubuntu 14.04 to create image format 2 by default

2014-02-11 Thread Wido den Hollander
On 01/17/2014 02:39 PM, Wido den Hollander wrote: Hi James (CC to devel), I've been trying to get a patch [0] into libvirt for the last couple of months to have libvirt create RBD images format 2 by default. The response from the RedHat people has been zero until thus far. Since this would be g