[PATCH 33/39] rbd: drop null test before destroy functions

Remove unneeded NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; @@ -if (x != NULL) { \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); x = NULL; -} // Signed-off-by: Julia Lawall <julia.law...@lip6

[PATCH 00/39] drop null test before destroy functions

Recent commits to kernel/git/torvalds/linux.git have made the following functions able to tolerate NULL arguments: kmem_cache_destroy (commit 3942d29918522) mempool_destroy (commit 4e3ca3e033d1) dma_pool_destroy (commit 44d7175da6ea) These patches remove the associated NULL tests for the files

Re: [ceph:for-linus 11/40] fs/ceph/mds_client.c:2865:1-10: second lock on line 2904

I haven't looked at all the called functions, to see if any of them drops the lock, but it could be worth a check. julia On Fri, 3 Jul 2015, kbuild test robot wrote: TO: Yan, Zheng z...@redhat.com CC: Ilya Dryomov idryo...@gmail.com CC: ceph-devel@vger.kernel.org tree:

Re: [PATCH 6/9] gpiolib: devres: use correct structure type name in sizeof

On Wed, 30 Jul 2014, Alexandre Courbot wrote: On Wed, Jul 30, 2014 at 12:16 AM, Julia Lawall julia.law...@lip6.fr wrote: From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has

[PATCH 4/9] reiserfs: use correct structure type name in sizeof

From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used

[PATCH 7/9] scsi: use correct structure type name in sizeof

From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used

[PATCH 9/9] uwb/whci: use correct structure type name in sizeof

From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used

[PATCH 8/9] iwlegacy: use correct structure type name in sizeof

From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used

[PATCH 6/9] gpiolib: devres: use correct structure type name in sizeof

From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used

[PATCH 5/9] scsi: use correct structure type name in sizeof

From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used

[PATCH 1/9] drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c: use correct structure type name in sizeof

From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used

[PATCH 2/9] CAPI: use correct structure type name in sizeof

From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used

[PATCH 3/9] i40e: use correct structure type name in sizeof

From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used

[PATCH 0/9] use correct structure type name in sizeof

These patches fix typos in the name of a type referenced in a sizeof command. These problems are not caught by the compiler, because they have no impact on execution - the size of a pointer is independent of the size of the pointed value. The semantic patch that finds these problems is shown

Re: [PATCH 2/3] fs/ceph/xattr.c: Use kasprintf

On Sun, 17 Oct 2010, Joe Perches wrote: On Sun, 2010-10-17 at 20:48 +0200, Julia Lawall wrote: Convert a sequence of kmalloc and memcpy to use kasprintf. The argument is checked for being a string by the presence of a previous call to strlen. [] diff --git a/fs/ceph/xattr.c b/fs/ceph

[PATCH 2/3] fs/ceph/xattr.c: Use kmemdup

!= a if (a == NULL || ...) S ... - memcpy(a,arg,len+1); // /smpl Signed-off-by: Julia Lawall ju...@diku.dk --- fs/ceph/xattr.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -u -p a/fs/ceph/xattr.c b/fs/ceph/xattr.c --- a/fs/ceph/xattr.c +++ b/fs/ceph/xattr.c @@ -716,10 +716,9