Re: [PATCH 04/11] ceph: Push file_update_time() into ceph_page_mkwrite()

2012-02-20 Thread Jan Kara
On Thu 16-02-12 13:04:37, Alex Elder wrote: On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote: CC: Sage Weil s...@newdream.net CC: ceph-devel@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz This will update the timestamp even if a write fault fails, which is different from

Re: [PATCH 04/11] ceph: Push file_update_time() into ceph_page_mkwrite()

2012-02-20 Thread Jan Kara
On Thu 16-02-12 11:13:53, Sage Weil wrote: On Thu, 16 Feb 2012, Alex Elder wrote: On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote: CC: Sage Weil s...@newdream.net CC: ceph-devel@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz This will update the timestamp even if a

[PATCH 04/11] ceph: Push file_update_time() into ceph_page_mkwrite()

2012-02-16 Thread Jan Kara
CC: Sage Weil s...@newdream.net CC: ceph-devel@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- fs/ceph/addr.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 173b1d2..12b139f 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c

Re: [PATCH 04/11] ceph: Push file_update_time() into ceph_page_mkwrite()

2012-02-16 Thread Alex Elder
On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote: CC: Sage Weil s...@newdream.net CC: ceph-devel@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz This will update the timestamp even if a write fault fails, which is different from before. Hard to avoid though. Looks good to me.

Re: [PATCH 04/11] ceph: Push file_update_time() into ceph_page_mkwrite()

2012-02-16 Thread Sage Weil
On Thu, 16 Feb 2012, Alex Elder wrote: On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote: CC: Sage Weil s...@newdream.net CC: ceph-devel@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz This will update the timestamp even if a write fault fails, which is different from before.