[PATCH 09/12] libceph: distinguish two phases of connect sequence

2012-06-21 Thread Alex Elder
Currently a ceph connection enters a CONNECTING state when it begins the process of (re-)connecting with its peer. Once the two ends have successfully exchanged their banner and addresses, an additional NEGOTIATING bit is set in the ceph connection's state to indicate the connection information

Re: [PATCH 09/12] libceph: distinguish two phases of connect sequence

2012-06-21 Thread Sage Weil
I get the feeling that all of these lists of clear/set_bit calls would go away if we - verify we are under the mutex at each of these sites - replace con-state with an enum Is there a reason you stopped short of doing that (besides time)? sage On Thu, 21 Jun 2012, Alex Elder wrote:

Re: [PATCH 09/12] libceph: distinguish two phases of connect sequence

2012-06-21 Thread Alex Elder
On 06/21/2012 01:44 PM, Sage Weil wrote: I get the feeling that all of these lists of clear/set_bit calls would go away if we - verify we are under the mutex at each of these sites - replace con-state with an enum Is there a reason you stopped short of doing that (besides time)? Time.