[PATCH 1/2 v2] rbd: allow importing from stdin

2012-05-16 Thread Christian Brunner
This patch allows importing images from stdin with the following command: rbd import --size=size in MB - [dest-image] v1 - v2: stat stdin as well Signed-off-by: Christian Brunner c...@muc.de --- src/rbd.cc | 26 +++--- 1 files changed, 19 insertions(+), 7 deletions(-)

Re: [PATCH 1/2 v2] rbd: allow importing from stdin

2012-05-16 Thread Tommi Virtanen
On Wed, May 16, 2012 at 3:25 PM, Yehuda Sadeh Weinraub yehud...@gmail.com wrote: I'd rather not pass size for stdin. We should instead make it so that we don't read size at all and just importing while !eof (or do that only when size is 0). We'd need to create the image with size=0 and update

Re: [PATCH 1/2 v2] rbd: allow importing from stdin

2012-05-16 Thread Josh Durgin
On 05/16/2012 04:51 PM, Tommi Virtanen wrote: On Wed, May 16, 2012 at 3:25 PM, Yehuda Sadeh Weinraub yehud...@gmail.com wrote: I'd rather not pass size for stdin. We should instead make it so that we don't read size at all and just importing while !eof (or do that only when size is 0). We'd

Re: [PATCH 1/2 v2] rbd: allow importing from stdin

2012-05-16 Thread Tommi Virtanen
On Wed, May 16, 2012 at 4:58 PM, Josh Durgin josh.dur...@inktank.com wrote: librbd prevents you from writing beyond the bounds of an image. If we keep that restriction, you'd need to resize the image to have enough space for the import, and resize down to the final size at the end. That's