Re: [PATCH 2/2] fs: fix dentry_lru_prune()

2013-03-09 Thread Dave Chinner
On Fri, Mar 08, 2013 at 02:40:46PM +0800, Yan, Zheng wrote: On 03/08/2013 02:27 PM, Dave Chinner wrote: On Fri, Mar 08, 2013 at 10:43:00AM +0800, Yan, Zheng wrote: On 03/08/2013 10:04 AM, Dave Chinner wrote: On Thu, Mar 07, 2013 at 07:37:36PM +0800, Yan, Zheng wrote: From: Yan, Zheng

[PATCH 2/2] fs: fix dentry_lru_prune()

2013-03-07 Thread Yan, Zheng
From: Yan, Zheng zheng.z@intel.com dentry_lru_prune() should always call file system's d_prune callback. Signed-off-by: Yan, Zheng zheng.z@intel.com --- fs/dcache.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index

Re: [PATCH 2/2] fs: fix dentry_lru_prune()

2013-03-07 Thread Dave Chinner
On Thu, Mar 07, 2013 at 07:37:36PM +0800, Yan, Zheng wrote: From: Yan, Zheng zheng.z@intel.com dentry_lru_prune() should always call file system's d_prune callback. Why? What bug does this fix? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send

Re: [PATCH 2/2] fs: fix dentry_lru_prune()

2013-03-07 Thread Yan, Zheng
On 03/08/2013 10:04 AM, Dave Chinner wrote: On Thu, Mar 07, 2013 at 07:37:36PM +0800, Yan, Zheng wrote: From: Yan, Zheng zheng.z@intel.com dentry_lru_prune() should always call file system's d_prune callback. Why? What bug does this fix? Ceph uses a flag to track if the dcache

Re: [PATCH 2/2] fs: fix dentry_lru_prune()

2013-03-07 Thread Dave Chinner
On Fri, Mar 08, 2013 at 10:43:00AM +0800, Yan, Zheng wrote: On 03/08/2013 10:04 AM, Dave Chinner wrote: On Thu, Mar 07, 2013 at 07:37:36PM +0800, Yan, Zheng wrote: From: Yan, Zheng zheng.z@intel.com dentry_lru_prune() should always call file system's d_prune callback. Why? What

Re: [PATCH 2/2] fs: fix dentry_lru_prune()

2013-03-07 Thread Yan, Zheng
On 03/08/2013 02:27 PM, Dave Chinner wrote: On Fri, Mar 08, 2013 at 10:43:00AM +0800, Yan, Zheng wrote: On 03/08/2013 10:04 AM, Dave Chinner wrote: On Thu, Mar 07, 2013 at 07:37:36PM +0800, Yan, Zheng wrote: From: Yan, Zheng zheng.z@intel.com dentry_lru_prune() should always call file