Re: [PATCH 3/3] ceph: messenger: change read_partial() to take end arg

2012-05-14 Thread Alex Elder
On 05/12/2012 07:11 PM, Sage Weil wrote: This looks correct, but seems like a more confusing calling convention to me. Before this patch it's basically a (start, len) logical range in the input stream.. after it's (end, len). It also seems to be more code? I'm trying to make this code more

Re: [PATCH 3/3] ceph: messenger: change read_partial() to take end arg

2012-05-14 Thread Alex Elder
On 05/12/2012 07:11 PM, Sage Weil wrote: This looks correct, but seems like a more confusing calling convention to me. Before this patch it's basically a (start, len) logical range in the input stream.. after it's (end, len). It also seems to be more code? sage On Thu, 10 May 2012, Alex

Re: [PATCH 3/3] ceph: messenger: change read_partial() to take end arg

2012-05-12 Thread Sage Weil
This looks correct, but seems like a more confusing calling convention to me. Before this patch it's basically a (start, len) logical range in the input stream.. after it's (end, len). It also seems to be more code? sage On Thu, 10 May 2012, Alex Elder wrote: Make the second argument to

[PATCH 3/3] ceph: messenger: change read_partial() to take end arg

2012-05-10 Thread Alex Elder
Make the second argument to read_partial() be the ending input byte position rather than the beginning offset it now represents. This amounts to moving the addition to + size into the caller. Signed-off-by: Alex Elder el...@inktank.com --- net/ceph/messenger.c | 59