Re: [PATCH 5/9] libceph: init osd-o_node in create_osd()

2012-12-17 Thread Alex Elder
On 12/14/2012 07:43 PM, Sage Weil wrote: We should drop this one, I think. See upstream commit 4c199a93a2d36b277a9fd209a0f2793f8460a215. When we added the similar call on teh request tree it caused some noise in linux-next and then got removed. Well, we need to initialize it. In

Re: [PATCH 5/9] libceph: init osd-o_node in create_osd()

2012-12-17 Thread Sage Weil
On Mon, 17 Dec 2012, Alex Elder wrote: On 12/14/2012 07:43 PM, Sage Weil wrote: We should drop this one, I think. See upstream commit 4c199a93a2d36b277a9fd209a0f2793f8460a215. When we added the similar call on teh request tree it caused some noise in linux-next and then got removed.

Re: [PATCH 5/9] libceph: init osd-o_node in create_osd()

2012-12-17 Thread Alex Elder
On 12/17/2012 10:45 AM, Sage Weil wrote: On Mon, 17 Dec 2012, Alex Elder wrote: On 12/14/2012 07:43 PM, Sage Weil wrote: We should drop this one, I think. See upstream commit 4c199a93a2d36b277a9fd209a0f2793f8460a215. When we added the similar call on teh request tree it caused some noise

Re: [PATCH 5/9] libceph: init osd-o_node in create_osd()

2012-12-14 Thread Sage Weil
We should drop this one, I think. See upstream commit 4c199a93a2d36b277a9fd209a0f2793f8460a215. When we added the similar call on teh request tree it caused some noise in linux-next and then got removed. sage On Thu, 13 Dec 2012, Alex Elder wrote: It turns out to be harmless but the

[PATCH 5/9] libceph: init osd-o_node in create_osd()

2012-12-13 Thread Alex Elder
It turns out to be harmless but the red-black node o_node in the ceph osd structure is not initialized in create_osd(). Add a call to rb_init_node() initialize it. Signed-off-by: Alex Elder el...@inktank.com --- net/ceph/osd_client.c |1 + 1 file changed, 1 insertion(+) diff --git