Re: [PATCH 6/8] rbd: define image specification structure

2012-10-30 Thread Josh Durgin
On 10/30/2012 05:40 AM, Alex Elder wrote: On 10/29/2012 05:13 PM, Josh Durgin wrote: A couple notes below, but looks good. I responded to all of your notes below. And I will update the code/comments as appropriate after we have a chance to talk about it but for the time being I'm going to com

Re: [PATCH 6/8] rbd: define image specification structure

2012-10-30 Thread Alex Elder
On 10/29/2012 05:13 PM, Josh Durgin wrote: > A couple notes below, but looks good. I responded to all of your notes below. And I will update the code/comments as appropriate after we have a chance to talk about it but for the time being I'm going to commit what I posted as-is.

Re: [PATCH 6/8] rbd: define image specification structure

2012-10-29 Thread Josh Durgin
A couple notes below, but looks good. Reviewed-by: Josh Durgin On 10/26/2012 04:03 PM, Alex Elder wrote: Group the fields that uniquely specify an rbd image into a new reference-counted rbd_spec structure. This structure will be used to describe the desired image when mapping an image, and wh

[PATCH 6/8] rbd: define image specification structure

2012-10-26 Thread Alex Elder
Group the fields that uniquely specify an rbd image into a new reference-counted rbd_spec structure. This structure will be used to describe the desired image when mapping an image, and when probing parent images in layered rbd devices. Replace the set of fields in the rbd device structure with a