Hi,
On 2014-09-29 11:18:03 -0400, Milosz Tanski wrote:
> Janne, I have a couple questions and forgive me if I missed something
> from the past.
>
> Did you consider using std::aligned_storage? That way you don't have
> to worry as much about portability yourself. Also, there is a
> boost::aligned
Janne, I have a couple questions and forgive me if I missed something
from the past.
Did you consider using std::aligned_storage? That way you don't have
to worry as much about portability yourself. Also, there is a
boost::aligned_storage as well if Ceph can't build against C++11
goodness.
A seco
Hi,
On 29/09/2014 14:34, Janne Grunau wrote:
> Hi,
>
> reworked patchset to address the comments in
> https://github.com/ceph/ceph/pull/2558
>
> variable alignment instead of the hardcoded 32-byte alignment
> fixed copy and paste error in a comment
> change buffer alignment for decoding too (mu
Hi,
reworked patchset to address the comments in
https://github.com/ceph/ceph/pull/2558
variable alignment instead of the hardcoded 32-byte alignment
fixed copy and paste error in a comment
change buffer alignment for decoding too (much simpler than the encoding
changes)
I'll do a github pull r