Re: [PATCH v4] ceph: add acl for cephfs

2013-11-10 Thread Guangliang Zhao
On Fri, Nov 08, 2013 at 05:40:32PM +0800, Li Wang wrote: Hi, It seems to me there are three issues, you can take a look below if they are really there, Thanks very much for your reviewing. On 11/08/2013 01:23 PM, Guangliang Zhao wrote: v4: check the validity before set/get_cached_acl()

Re: [PATCH v4] ceph: add acl for cephfs

2013-11-10 Thread Yan, Zheng
On 11/08/2013 05:40 PM, Li Wang wrote: Hi, It seems to me there are three issues, you can take a look below if they are really there, On 11/08/2013 01:23 PM, Guangliang Zhao wrote: v4: check the validity before set/get_cached_acl() v3: handle the attr change in ceph_set_acl() v2:

Re: [PATCH v4] ceph: add acl for cephfs

2013-11-08 Thread Li Wang
Hi, It seems to me there are three issues, you can take a look below if they are really there, On 11/08/2013 01:23 PM, Guangliang Zhao wrote: v4: check the validity before set/get_cached_acl() v3: handle the attr change in ceph_set_acl() v2: remove some redundant code in ceph_setattr()

[PATCH v4] ceph: add acl for cephfs

2013-11-07 Thread Guangliang Zhao
v4: check the validity before set/get_cached_acl() v3: handle the attr change in ceph_set_acl() v2: remove some redundant code in ceph_setattr() Signed-off-by: Guangliang Zhao lucienc...@gmail.com --- fs/ceph/Kconfig | 13 +++ fs/ceph/Makefile |1 + fs/ceph/acl.c| 326

Re: [PATCH v4] ceph: add acl for cephfs

2013-11-07 Thread Yan, Zheng
Hi, thank you for working on this. On 11/08/2013 01:23 PM, Guangliang Zhao wrote: v4: check the validity before set/get_cached_acl() v3: handle the attr change in ceph_set_acl() v2: remove some redundant code in ceph_setattr() Signed-off-by: Guangliang Zhao lucienc...@gmail.com ---