Re: FileStore performance: coalescing operations

2015-03-19 Thread Andreas Bluemle
Hi Sage, as discussed yesterday during the performance meeting, I have integratged pull reuest 3878 into v0.93 source code and re-tested: I can confirm that the changes show a significant benefit in the CPU consumption of the ceph-osd daemon for a given workload: the reduction in CPU cosumption fo

Re: FileStore performance: coalescing operations

2015-03-11 Thread Sage Weil
On Wed, 11 Mar 2015, Ning Yao wrote: > Can we also consider to coalesce two OP_SETATTR transaction to a > single OP_SETATTRS transaction? Yeah, definitely! sage > Regards > Ning Yao > > > 2015-03-05 15:04 GMT+08:00 Haomai Wang : > > I think the performance improvement can be refer to > > http

Re: FileStore performance: coalescing operations

2015-03-10 Thread Ning Yao
Can we also consider to coalesce two OP_SETATTR transaction to a single OP_SETATTRS transaction? Regards Ning Yao 2015-03-05 15:04 GMT+08:00 Haomai Wang : > I think the performance improvement can be refer to > https://github.com/ceph/ceph/pull/2972 which I did a simple benchmark > comparison. >

Re: FileStore performance: coalescing operations

2015-03-04 Thread Haomai Wang
I think the performance improvement can be refer to https://github.com/ceph/ceph/pull/2972 which I did a simple benchmark comparison. This coalescing should get a lighter improvement but I think obviously it should be better. On Thu, Mar 5, 2015 at 8:10 AM, Sage Weil wrote: > On Tue, 3 Mar 2015,

Re: FileStore performance: coalescing operations

2015-03-04 Thread Sage Weil
On Tue, 3 Mar 2015, Sage Weil wrote: > I think we should try to avoid the dups in the first place in the upper > layers before resorting to deduping in the FileStore. I took a stab at this: https://github.com/ceph/ceph/pull/3878 Here's what the txns look like now: { "ops": [

Re: FileStore performance: coalescing operations

2015-03-03 Thread Sage Weil
On Thu, 26 Feb 2015, Andreas Bluemle wrote: > Hi, > > during the performance weely meeting, I had mentioned > my experiences concerning the transaction structure > for write requests at the level of the FileStore. > Such a transaction not only contains the OP_WRITE > operation to the object in the

Re: FileStore performance: coalescing operations

2015-02-26 Thread Mark Nelson
On 02/26/2015 09:02 AM, Haomai Wang wrote: Hmm, we already obverse this duplicate omap keys set from pglog operations. And I think we need to resolve it in upper layer, of course, Can we resolve this higher up easily? I am struck that it might be easier to simply do the coalescing here. I

Re: FileStore performance: coalescing operations

2015-02-26 Thread Haomai Wang
Hmm, we already obverse this duplicate omap keys set from pglog operations. And I think we need to resolve it in upper layer, of course, coalescing omap operations in FileStore is also useful. @Somnath Do you do this dedup work in KeyValueStore already? On Thu, Feb 26, 2015 at 10:28 PM, Andreas

FileStore performance: coalescing operations

2015-02-26 Thread Andreas Bluemle
Hi, during the performance weely meeting, I had mentioned my experiences concerning the transaction structure for write requests at the level of the FileStore. Such a transaction not only contains the OP_WRITE operation to the object in the file system, but also a series of OP_OMAP_SETKEYS and OP_