Fix local messages and lost wake-up in SimpleMessenger

2012-08-13 Thread Alexandre Oliva
Don't wait for a signal if the dispatch queue is non-empty already, and support a non-NULL pipe for local responses. If we were to require pipe to be NULL for that, the response would be lost. Signed-off-by: Alexandre Oliva --- src/msg/SimpleMessenger.cc |4 ++-- 1 files changed, 2 insertio

Re: Fix local messages and lost wake-up in SimpleMessenger

2012-08-14 Thread Sage Weil
A huge pile of SimpleMessenger refactors, cleanups, and fixes (wip-msgr) was just merged into master, and this code was changed around quite a bit. Did you have a specific test case that was triggering the problem? If so, do you mind running it on the current master? Most of the cleanups/fixe

Re: Fix local messages and lost wake-up in SimpleMessenger

2012-08-14 Thread Alexandre Oliva
On Aug 14, 2012, Alexandre Oliva wrote: > Don't wait for a signal if the dispatch queue is non-empty already, > and support a non-NULL pipe for local responses. If we were to > require pipe to be NULL for that, the response would be lost. Although this patch applies to 0.50, I developed it on 0

Re: Fix local messages and lost wake-up in SimpleMessenger

2012-08-14 Thread Sage Weil
On Tue, 14 Aug 2012, Alexandre Oliva wrote: > On Aug 14, 2012, Alexandre Oliva wrote: > > > Don't wait for a signal if the dispatch queue is non-empty already, > > and support a non-NULL pipe for local responses. If we were to > > require pipe to be NULL for that, the response would be lost. >

Re: Fix local messages and lost wake-up in SimpleMessenger

2012-08-14 Thread Alexandre Oliva
On Aug 14, 2012, Sage Weil wrote: > Do you mind trying to reproduce this on the current master? Tried, but couldn't. It looks like it is indeed fixed in master, but not in 0.50. > BTW, if you have a script or anything you were using to test, that'd be > great to add to our test suite. It occ