Re: python facade pattern implementation in ceph and ceph-deploy is bad practice?

2015-07-16 Thread Travis Rhoden
> On Jul 14, 2015, at 1:47 AM, Owen Synge wrote: > > On 07/09/2015 09:58 PM, Travis Rhoden wrote: >> >>> On Jul 9, 2015, at 4:59 AM, Owen Synge wrote: >>> >>> On 07/09/2015 12:46 PM, John Spray wrote: Owen, >>> >>> Hi John, >>> >>> thanks for your reasonable mail. >>> Please can

Re: python facade pattern implementation in ceph and ceph-deploy is bad practice?

2015-07-14 Thread Owen Synge
On 07/09/2015 09:58 PM, Travis Rhoden wrote: > >> On Jul 9, 2015, at 4:59 AM, Owen Synge wrote: >> >> On 07/09/2015 12:46 PM, John Spray wrote: >>> Owen, >> >> Hi John, >> >> thanks for your reasonable mail. >> >>> Please can you say what your overall goal is with recent ceph-deploy >>> patches?

Re: python facade pattern implementation in ceph and ceph-deploy is bad practice?

2015-07-09 Thread Travis Rhoden
> On Jul 9, 2015, at 4:59 AM, Owen Synge wrote: > > On 07/09/2015 12:46 PM, John Spray wrote: >> Owen, > > Hi John, > > thanks for your reasonable mail. > >> Please can you say what your overall goal is with recent ceph-deploy >> patches? > > To give ceph-deploy code features we have in dow

Re: python facade pattern implementation in ceph and ceph-deploy is bad practice?

2015-07-09 Thread Travis Rhoden
Hi Owen, There are quite a few emails in this thread already, but there are points in each of them I would like to address. Up front let me say I hear and recognize your frustration. If you’ve felt ignored, I apologize. I think you’ve turned around a lot of patches, PR comments, and emails f

Re: python facade pattern implementation in ceph and ceph-deploy is bad practice?

2015-07-09 Thread Owen Synge
Small correction due to not proof reading enough. On 07/09/2015 06:28 PM, Owen Synge wrote: > Dear all, > > Lets put a positive spin on this thread and set all misunderstandings on > my side :) > > I propose that John clarified and I misunderstood the others in upstream > ceph-deploy's position,

Re: python facade pattern implementation in ceph and ceph-deploy is bad practice?

2015-07-09 Thread Owen Synge
Dear all, Lets put a positive spin on this thread and set all misunderstandings on my side :) I propose that John clarified and I misunderstood the others in upstream ceph-deploy's position, the style guide includes: (0) Opposes duplication of code. (1) Opposes duplication of code for each platf

Re: python facade pattern implementation in ceph and ceph-deploy is bad practice?

2015-07-09 Thread Owen Synge
> PPS I did not intentionally kill the branch and will investigate why its > missing. Correction it is not missing and is still here. https://github.com/ceph/ceph-deploy/pull/320 I still feel that I should close it in case people stop reviewing my patches though. Best regards Owen -- To unsubs

Re: python facade pattern implementation in ceph and ceph-deploy is bad practice?

2015-07-09 Thread Owen Synge
On 07/09/2015 12:46 PM, John Spray wrote: > Owen, Hi John, thanks for your reasonable mail. > Please can you say what your overall goal is with recent ceph-deploy > patches? To give ceph-deploy code features we have in downstream ceph-deploy to upstream. All I am trying to do is reduce copiou

Re: python facade pattern implementation in ceph and ceph-deploy is bad practice?

2015-07-09 Thread John Spray
Owen, Please can you say what your overall goal is with recent ceph-deploy patches? Whether a given structure is right or wrong is really a function of the overall direction. If you are aiming to make ceph-deploy into an extensible framework that can do things in parallel, then you need to

python facade pattern implementation in ceph and ceph-deploy is bad practice?

2015-07-09 Thread Owen Synge
Dear all, The facade pattern (or façade pattern) is a software design pattern commonly used with object-oriented programming. The name is by analogy to an architectural facade. (wikipedia) I am frustrated with the desire to "standardise" on the one bad practice implementations of the facade patte