Re: wip-addr

2015-10-12 Thread Sage Weil
On Mon, 12 Oct 2015, David Zafman wrote: > I don't understand how encode/decode of entity_addr_t is changing without > versioning in the encode/decode. This means that this branch is changing the > ceph-objectstore-tool export format if CEPH_FEATURE_MSG_ADDR2 is part of the > features. So we coul

Re: wip-addr

2015-10-12 Thread David Zafman
I don't understand how encode/decode of entity_addr_t is changing without versioning in the encode/decode. This means that this branch is changing the ceph-objectstore-tool export format if CEPH_FEATURE_MSG_ADDR2 is part of the features. So we could bump super_header::super_ver if the expor

Re: wip-addr

2015-10-10 Thread Sage Weil
On Sat, 10 Oct 2015, Haomai Wang wrote: > On Sat, Oct 10, 2015 at 5:49 AM, Sage Weil wrote: > Hey Marcus, > > On Fri, 2 Oct 2015, Marcus Watts wrote: > > wip-addr > > > > 1. where is it? > > 2. current state >

Re: wip-addr

2015-10-09 Thread Haomai Wang
resend to ML On Sat, Oct 10, 2015 at 11:20 AM, Haomai Wang wrote: > > > On Sat, Oct 10, 2015 at 5:49 AM, Sage Weil wrote: >> >> Hey Marcus, >> >> On Fri, 2 Oct 2015, Marcus Watts wrote: >> > wip-addr >> > >> > 1. where is it? >&g

Re: wip-addr

2015-10-09 Thread Sage Weil
Hey Marcus, On Fri, 2 Oct 2015, Marcus Watts wrote: > wip-addr > > 1. where is it? > 2. current state > 3. more info > 4. cheap fixes > 5. in case you were wondering why? > > 1. where is it? > > I've just pushed another update to wip-addr: > >

wip-addr

2015-10-02 Thread Marcus Watts
wip-addr 1. where is it? 2. current state 3. more info 4. cheap fixes 5. in case you were wondering why? 1. where is it? I've just pushed another update to wip-addr: g...@github.com:linuxbox2/linuxbox-ceph.git wip-addr 2. current state This version 1/ compiles 2/ ran an extr

Re: wip-addr

2015-08-25 Thread Sage Weil
On Tue, 25 Aug 2015, Marcus Watts wrote: > On Mon, Aug 24, 2015 at 11:01:45AM -0700, Sage Weil wrote: > ... > > I looked over the wip-addr branch a bit. I have two basic > > questions/concerns: > > > > 1) In commit > > >

Re: wip-addr

2015-08-25 Thread Marcus Watts
On Mon, Aug 24, 2015 at 11:01:45AM -0700, Sage Weil wrote: ... > I looked over the wip-addr branch a bit. I have two basic > questions/concerns: > > 1) In commit > > https://github.com/ceph/ceph/commit/73b09090466a43d5aceb979a4802de3f3f5bf24a > we switch the type fi

wip-addr

2015-08-24 Thread Sage Weil
Hi Marcus, I looked over the wip-addr branch a bit. I have two basic questions/concerns: 1) In commit https://github.com/ceph/ceph/commit/73b09090466a43d5aceb979a4802de3f3f5bf24a we switch the type field from sa_family to transport_type. This seems like the way to go, but we need