Re: Ιnstrumenting RADOS with Zipkin + LTTng

On Fri, Nov 07, 2014 at 02:32:51AM -0800, Sage Weil wrote: On Thu, 30 Oct 2014, Andrew Shewmaker wrote: Should I put effort into adding a --with-blkin or --with-zipkin option to autoconf? Is it statically or dynamically linked? Probably a first step is to get it in the gitbuilder

[PATCH 0/6] blkin (LTTng + Zipkin) tracing

The following patches are a cleaned up version of the work Marios Kogias first posted in August. http://www.spinics.net/lists/ceph-devel/msg19890.html The changes have been made against Ceph 0.80.1, and will be moved forward soon. With them Ceph can use Blkin, a library created by Marios Kogias

[PATCH 1/6] Initial support for blkin (LTTng + Zipkin) tracing

-off-by: Andrew Shewmaker ags...@gmail.com --- .gitmodules| 3 ++ src/Makefile-env.am| 2 +- src/blkin | 1 + src/common/TrackedOp.cc| 123 + src/common/TrackedOp.h | 21 src/msg/Message.cc

[PATCH 2/6] Initialize blkin tracing in ceph_mon

Signed-off-by: Andrew Shewmaker ags...@gmail.com --- src/ceph_mon.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ceph_mon.cc b/src/ceph_mon.cc index 4e84b4d..8b1784a 100644 --- a/src/ceph_mon.cc +++ b/src/ceph_mon.cc @@ -418,6 +418,8 @@ int main(int argc, const char **argv

[PATCH 3/6] OSD support for blkin (LTTng + Zipkin) tracing

not change member variable names to use m_ prefix since member vars in same class did not - Ref suffix added to TrackedOp shared_ptr vars to be consistent - note: did not add -Ref suffix to ZTrace*Ref vars Signed-off-by: Andrew Shewmaker ags...@gmail.com --- src/ceph_osd.cc

[PATCH 6/6] Documentation for testing blkin tracing

Signed-off-by: Andrew Shewmaker ags...@gmail.com --- doc/dev/trace.rst | 86 +++ 1 file changed, 86 insertions(+) create mode 100644 doc/dev/trace.rst diff --git a/doc/dev/trace.rst b/doc/dev/trace.rst new file mode 100644 index 000

[PATCH 4/6] Rados support for blkin (LTTng + Zipkin) tracing

Added traced versions of Rados aio_read/write These changes are Marios', with the following exceptions: - split out Rados support from other tracing changes - only Message.h includes blkin, as others include Message.h - whitespace issues have been fixed Signed-off-by: Andrew Shewmaker ags

[PATCH 5/6] Rados example application for blkin

This code is Marios', with the following exceptions: - split out example from other tracing changes - whitespace issues have been fixed - Makefile cleans up the new example Signed-off-by: Andrew Shewmaker ags...@gmail.com --- examples/librados/Makefile | 5 +- examples/librados

Re: [PATCH 0/6] blkin (LTTng + Zipkin) tracing

On Thu, Nov 13, 2014 at 08:14:48AM -0800, Sage Weil wrote: On Wed, 12 Nov 2014, Andrew Shewmaker wrote: snip In general, Blkin implements the tracing semantics described in the Dapper paper http://static.googleusercontent.com/media/research.google.com/el/pubs/archive/36356.pdf in order

[PATCH V2 0/7] BlkKin (LTTng + Zipkin) tracing patchset intro

The following patches are a cleaned up version of the work Marios Kogias first posted in August. http://www.spinics.net/lists/ceph-devel/msg19890.html The changes are against Ceph 0.80.1, and will be moved forward soon. Changes since V1: * split build changes into separate patch * conditional

[PATCH V2 5/6] Rados support for blkin (LTTng + Zipkin) tracing

* Adds traced versions of Rados aio_read/write Signed-off-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Filippos Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com --- src/include/rados/librados.h | 12 +++ src/librados/IoCtxImpl.cc| 75

[PATCH V2 3/6] Initialize blkin tracing in ceph_mon

Signed-off-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Filippos Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com --- src/ceph_mon.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ceph_mon.cc b/src/ceph_mon.cc index 4e84b4d..f16366c

[PATCH V2 6/6] Rados example for blkin (LTTng + Zipkin) tracing

Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com --- examples/librados/Makefile | 5 +- examples/librados/hello_blkin.c | 107 2 files changed, 110 insertions(+), 2 deletions(-) create mode 100644 examples/librados/hello_blkin.c

[PATCH V2 4/6] OSD support for blkin (LTTng + Zipkin) tracing

-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Filippos Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com --- src/ceph_osd.cc | 6 +++-- src/messages/MOSDOp.h | 13 + src/messages/MOSDOpReply.h| 13 + src

[PATCH V2 2/6] Initial support for blkin (LTTng + Zipkin) tracing

in same class did not * Ref suffix added to TrackedOp shared_ptr vars to be consistent note: did not add -Ref suffix to ZTrace*Ref vars in Message Signed-off-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Filippos Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker

[PATCH V2 1/6] Build support for BlkKin (LTTng + Zipkin) tracing

* Adds --with-blkin to autoconf (default without) * Adds BLKIN_LIBS to necessary automake files * Adds documentation for testing BlkKin tracing Signed-off-by: Andrew Shewmaker ags...@gmail.com Signed-off-by: Marios-Evaggelos Kogias marioskog...@gmail.com --- configure.ac | 11

Status of BlkKin (LTTng + Zipkin) tracing patchset

Hi, I wanted to let the list know that I've been working on rebasing the V2 BlkKin patchset on top of Ceph master. Unfortunatley, my basic tracing tests are failing. A 'rados put' spits out: 2014-12-22 09:13:32.172182 7f083019d700 0 -- 128.114.53.124:0/1013940 128.114.53.124:6808/13201

[PATCH V6 1/5] Build support for BlkKin (LTTng + Zipkin) tracing

* Adds --with-blkin to autoconf (default without) * Adds BLKIN_LIBS to necessary automake files * Adds documentation for testing BlkKin tracing * Adds ztrace initialization Signed-off-by: Andrew Shewmaker ags...@gmail.com Signed-off-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed

[no subject]

The following patches are based on the work of Marios Kogias, first posted in August. http://www.spinics.net/lists/ceph-devel/msg19890.html This patch is against HEAD as of March 10th, commit 5d5b510810e96503b9323b010149f7bd5b45db7c. It can also be found at

[PATCH V6 3/5] OSD support for blkin (LTTng + Zipkin) tracing

-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Filippos Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com Signed-off-by: Chendi.Xue chendi@intel.com --- 20 files changed, 323 insertions(+), 14 deletions(-) messages/MOSDOp.h | 13

[PATCH V6 2/5] Initial support for blkin (LTTng + Zipkin) tracing

-by: Andrew Shewmaker ags...@gmail.com Signed-off-by: Chendi.Xue chendi@intel.com --- src/common/TrackedOp.cc | 82 ++ src/common/TrackedOp.h| 26 ++ src/common/blkin_wrapper.h| 171 ++ src/msg/Message.cc

[PATCH V6 4/5] Rados support for blkin (LTTng + Zipkin) tracing

* Adds traced versions of Rados aio_read/write Signed-off-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Filippos Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com Signed-off-by: Chendi.Xue chendi@intel.com --- include/rados/librados.h | 13

[PATCH V6 5/5] Rados example for blkin (LTTng + Zipkin) tracing

Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com --- Makefile |9 hello_blkin.c | 107 ++ 2 files changed, 116 insertions(+) create mode 100644 examples/librados/hello_blkin.c diff --git a/examples

[PATCH V5 1/6] Build support for BlkKin (LTTng + Zipkin) tracing

* Adds --with-blkin to autoconf (default without) * Adds BLKIN_LIBS to necessary automake files * Adds documentation for testing BlkKin tracing Signed-off-by: Andrew Shewmaker ags...@gmail.com Signed-off-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Chendi.Xue chendi

[PATCH V5 2/6] Initial support for blkin (LTTng + Zipkin) tracing

-by: Andrew Shewmaker ags...@gmail.com Signed-off-by: Chendi.Xue chendi@intel.com --- src/common/TrackedOp.cc | 82 ++ src/common/TrackedOp.h| 26 ++ src/common/blkin_wrapper.h| 171 ++ src/msg/Message.cc

[PATCH V5 6/6] Rados example for blkin (LTTng + Zipkin) tracing

Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com --- examples/librados/Makefile | 9 examples/librados/hello_blkin.c | 107 2 files changed, 116 insertions(+) create mode 100644 examples/librados/hello_blkin.c diff --git

[PATCH V5 4/6] OSD support for blkin (LTTng + Zipkin) tracing

-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Filippos Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com Signed-off-by: Chendi.Xue chendi@intel.com --- src/ceph_osd.cc | 6 ++-- src/messages/MOSDOp.h | 14 +++- src

[PATCH V5 0/7] BlkKin (LTTng + Zipkin) tracing patchset intro

The following patches are a cleaned up version of the work Marios Kogias first posted in August. http://www.spinics.net/lists/ceph-devel/msg19890.html This patch is against HEAD as of March 2nd at 4:30pm Mountain. It can also be found at https://github.com/agshew/ceph/tree/wip-blkin-v5 Thanks to

[PATCH V5 3/6] Initialize ceph_mon trace, blkin (LTTng + Zipkin) tracing

Signed-off-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Filippos Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com --- src/ceph_mon.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ceph_mon.cc b/src/ceph_mon.cc index e0ca6e2..6c3f03f

[PATCH V5 5/6] Rados support for blkin (LTTng + Zipkin) tracing

* Adds traced versions of Rados aio_read/write Signed-off-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Filippos Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com Signed-off-by: Chendi.Xue chendi@intel.com --- src/include/rados/librados.h

[PATCH 1/6] Build support for BlkKin (LTTng + Zipkin) tracing

* Adds --with-blkin to autoconf (default without) * Adds BLKIN_LIBS to necessary automake files * Adds documentation for testing BlkKin tracing Signed-off-by: Andrew Shewmaker ags...@gmail.com Signed-off-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Chendi.Xue chendi

[PATCH 3/6] Initialize ceph_mon trace, blkin (LTTng + Zipkin) tracing

Signed-off-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Filippos Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com --- src/ceph_mon.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ceph_mon.cc b/src/ceph_mon.cc index e0ca6e2..6c3f03f

[PATCH 2/6] Initial support for blkin (LTTng + Zipkin) tracing

-by: Andrew Shewmaker ags...@gmail.com Signed-off-by: Chendi.Xue chendi@intel.com --- src/common/TrackedOp.cc | 82 + src/common/TrackedOp.h| 26 ++ src/common/blkin_wrapper.h| 180 ++ src/msg/Message.cc

[PATCH V4 0/7] BlkKin (LTTng + Zipkin) tracing patchset intro

The following patches are a cleaned up version of the work Marios Kogias first posted in August. http://www.spinics.net/lists/ceph-devel/msg19890.html This patch is against HEAD as of February 25th at 10am. It can also be found at https://github.com/agshew/ceph/tree/wip-blkin-v4 Thanks to Chendi

[PATCH 6/6] Rados example for blkin (LTTng + Zipkin) tracing

Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com --- examples/librados/Makefile | 9 examples/librados/hello_blkin.c | 107 2 files changed, 116 insertions(+) create mode 100644 examples/librados/hello_blkin.c diff --git

[PATCH 5/6] Rados support for blkin (LTTng + Zipkin) tracing

* Adds traced versions of Rados aio_read/write Signed-off-by: Marios-Evaggelos Kogias marioskog...@gmail.com Signed-off-by: Filippos Giannakos philipg...@grnet.gr Signed-off-by: Andrew Shewmaker ags...@gmail.com Signed-off-by: Chendi.Xue chendi@intel.com --- src/include/rados/librados.h