[ceph-users] Re: Bluestore cache parameter precedence

2020-02-04 Thread Igor Fedotov
Hi Boris, general settings (unless they are set to zero) override disk-specific settings . I.e. bluestore_cache_size overrides both bluestore_cache_size_hdd and bluestore_cache_size_ssd. Here is the code snippet in case you know C++   if (cct->_conf->bluestore_cache_size) {     cache_size

[ceph-users] Re: Bluestore cache parameter precedence

2020-02-04 Thread Boris Epstein
Hi Igor, Thanks! I think the code needs to be corrected - the choice criteria for which setting to use when cct->_conf->bluestore_cache_size == 0 should be as follows: 1) See what kind of storage you have. 2) Select type-appropriate storage. Is this code public-editable? I'll be happy to cor

[ceph-users] Re: Bluestore cache parameter precedence

2020-02-05 Thread Igor Fedotov
Hi Boris, not sure I understand why do you think it needs correction. IMO _use_rotational_settings() function does what you're suggesting plus it has some additional logic to be able to enforce specific device type. The latter is intended primarily for testing/debugging and enabled via 'blue

[ceph-users] Re: Bluestore cache parameter precedence

2020-02-11 Thread borepstein
Igor, You are exactly right - it is my fault, I have failed to read the code correctly. Cheers, Boris. ___ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-le...@ceph.io