Re: [PATCH] Implement the no_split_stack attribute.

2014-05-19 Thread Peter Collingbourne
Closed by commit rL209167 (authored by @pcc). http://reviews.llvm.org/D3817 Files: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/include/clang/Basic/AttrDocs.td cfe/trunk/lib/CodeGen/CGCall.cpp cfe/trunk/lib/Sema/SemaDeclAttr.cpp cfe/trunk/test/CodeGen/split-stacks.c cfe/trunk/test/

Re: [PATCH] Implement the no_split_stack attribute.

2014-05-19 Thread Aaron Ballman
LGTM! ~Aaron On Mon, May 19, 2014 at 5:08 PM, Peter Collingbourne wrote: > Add tests and docs > > http://reviews.llvm.org/D3817 > > Files: > include/clang/Basic/Attr.td > include/clang/Basic/AttrDocs.td > lib/CodeGen/CGCall.cpp > lib/Sema/SemaDeclAttr.cpp > test/CodeGen/split-stacks.c

Re: [PATCH] Implement the no_split_stack attribute.

2014-05-19 Thread Peter Collingbourne
Add tests and docs http://reviews.llvm.org/D3817 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/CGCall.cpp lib/Sema/SemaDeclAttr.cpp test/CodeGen/split-stacks.c test/CodeGenCXX/split-stacks.cpp test/SemaCXX/attr-no-split-stack.cpp Index: include/clang

Re: [PATCH] Implement the no_split_stack attribute.

2014-05-19 Thread Peter Collingbourne
On Sat, May 17, 2014 at 09:40:45AM -0400, Aaron Ballman wrote: > On Sat, May 17, 2014 at 2:23 AM, Peter Collingbourne wrote: > > This is a GNU attribute that allows split stacks to be turned off on a > > per-function basis. > > > > http://reviews.llvm.org/D3817 > > > > Files: > > include/clang/B

Re: [PATCH] Implement the no_split_stack attribute.

2014-05-17 Thread Aaron Ballman
On Sat, May 17, 2014 at 11:16 AM, Alp Toker wrote: > > On 17/05/2014 16:40, Aaron Ballman wrote: >> >> On Sat, May 17, 2014 at 2:23 AM, Peter Collingbourne >> wrote: >>> >>> This is a GNU attribute that allows split stacks to be turned off on a >>> per-function basis. >>> >>> http://reviews.llvm.

Re: [PATCH] Implement the no_split_stack attribute.

2014-05-17 Thread Alp Toker
On 17/05/2014 16:40, Aaron Ballman wrote: On Sat, May 17, 2014 at 2:23 AM, Peter Collingbourne wrote: This is a GNU attribute that allows split stacks to be turned off on a per-function basis. http://reviews.llvm.org/D3817 Files: include/clang/Basic/Attr.td lib/CodeGen/CGCall.cpp li

Re: [PATCH] Implement the no_split_stack attribute.

2014-05-17 Thread Aaron Ballman
On Sat, May 17, 2014 at 2:23 AM, Peter Collingbourne wrote: > This is a GNU attribute that allows split stacks to be turned off on a > per-function basis. > > http://reviews.llvm.org/D3817 > > Files: > include/clang/Basic/Attr.td > lib/CodeGen/CGCall.cpp > lib/Sema/SemaDeclAttr.cpp > test/

[PATCH] Implement the no_split_stack attribute.

2014-05-16 Thread Peter Collingbourne
This is a GNU attribute that allows split stacks to be turned off on a per-function basis. http://reviews.llvm.org/D3817 Files: include/clang/Basic/Attr.td lib/CodeGen/CGCall.cpp lib/Sema/SemaDeclAttr.cpp test/CodeGen/split-stacks.c Index: include/clang/Basic/Attr.td