angelgarcia updated this revision to Diff 32539.
angelgarcia marked 13 inline comments as done.
angelgarcia added a comment.
Fix comments.
http://reviews.llvm.org/D12081
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
olista01 created this revision.
olista01 added a subscriber: cfe-commits.
olista01 set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.
The ACLE (ARM C Language Extensions) 2.0 allows the __fp16 type to be
used as a functon argument or return type (ACLE
ABataev created this revision.
ABataev added reviewers: hans, fraggamuffin, ejstotzer, hfinkel.
ABataev added a subscriber: cfe-commits.
http://reviews.llvm.org/D12152
Files:
docs/UsersManual.rst
Index: docs/UsersManual.rst
===
alexfh closed this revision.
alexfh added a comment.
Committed revision 245434.
http://reviews.llvm.org/D12081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Wed Aug 19 08:13:12 2015
New Revision: 245434
URL: http://llvm.org/viewvc/llvm-project?rev=245434view=rev
Log:
[clang-tidy] Add use-nullptr check to clang-tidy.
Move UseNullptr from clang-modernize to modernize module in clang-tidy.
http://reviews.llvm.org/D12081
Patch by
loverszhaokai created this revision.
loverszhaokai added reviewers: gbenyei, krememek, rsmith, ABataev, majnemer.
loverszhaokai added a subscriber: cfe-commits.
Fix typos:
modeled - modelled
protcol- protocol
overriden- overridden
endianess -endianness
unmodeled -
alexfh added a comment.
Sorry for the long delay.
Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:40
@@ +39,3 @@
+ for (const auto *Ctor : CopyCtor-getParent()-ctors()) {
+if (Ctor-isMoveConstructor()
+Ctor-getAccess() = AS_protected
loverszhaokai created this revision.
loverszhaokai added reviewers: delesley, krememek.
loverszhaokai added a subscriber: cfe-commits.
Fix 4 typos:
Intialize - Initialize
accessable - accessible
modeled - modelled
http://reviews.llvm.org/D12144
Files:
angelgarcia added a comment.
Ok, thanks! :)
http://reviews.llvm.org/D12081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chapuni added a subscriber: cfe-commits.
chapuni added a comment.
Targeting msvc (-triple *-win32) implies a few -f options.
You can reproduce the failure with -fdelayed-template-parsing, or -triple
i686-win32.
Eyes might be increased if python version of check_clang_tidy.sh were
introduced.
aaron.ballman updated this revision to Diff 32559.
aaron.ballman added a comment.
Addressed review comments. I re-ran the updated patch against LLVM and Clang,
and there were some more false positives that I would like to address if
possible. It seems my previous run against the source base was
Author: rengolin
Date: Wed Aug 19 10:24:03 2015
New Revision: 245449
URL: http://llvm.org/viewvc/llvm-project?rev=245449view=rev
Log:
[AArch64] Quick fix for cxa demangler
This makes all libcxxabi tests pass on AArch64. Further changes and
new tests to come.
Patch by Keith Walker.
Modified:
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
I think this is ready to land now. Thanks, Eric.
http://reviews.llvm.org/D11555
___
cfe-commits mailing list
aaron.ballman marked 5 inline comments as done.
aaron.ballman added a comment.
http://reviews.llvm.org/D11784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vsukharev
Date: Wed Aug 19 09:50:18 2015
New Revision: 245445
URL: http://llvm.org/viewvc/llvm-project?rev=245445view=rev
Log:
[ARM] Proper generic cpus handling
generic cpu was wrongly handled as exact real CPU name of ARMv8.1A
architecture.
This has been fixed, now it is abstract
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:40
@@ +39,3 @@
+ for (const auto *Ctor : CopyCtor-getParent()-ctors()) {
+if (Ctor-isMoveConstructor()
+Ctor-getAccess() = AS_protected
alexfh wrote:
When I run the following test code through clang-tidy -checks=*, I get
a crash from some relatively strange behavior with FunctionDecl.
template class T struct remove_reference {typedef T type;};
template class T struct remove_referenceT {typedef T type;};
template class T struct
jmolloy added a subscriber: jmolloy.
Comment at: lib/CodeGen/TargetInfo.cpp:4717
@@ -4716,1 +4716,3 @@
+ // __fp16 gets passed as if it were an int or float, but with the top 32 bits
+ // unspecified.
Top 16 bits?
Comment at:
delesley added a comment.
Looks good for the thread safety stuff.
http://reviews.llvm.org/D12144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
In http://reviews.llvm.org/D11963#227444, @EricWF wrote:
I also just realized that this change will currently likely play havoc with
how libc++ and libc++abi build together. In order to build libc++ and
libc++abi together we would need to
1. Configure libc++
olista01 updated this revision to Diff 32558.
olista01 added a comment.
Fixed typo
Repository:
rL LLVM
http://reviews.llvm.org/D12148
Files:
lib/Basic/Targets.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Tools.cpp
test/CodeGen/arm-fp16-arguments.c
test/Preprocessor/arm-acle-6.5.c
Author: alexfh
Date: Wed Aug 19 12:50:22 2015
New Revision: 245471
URL: http://llvm.org/viewvc/llvm-project?rev=245471view=rev
Log:
[clang-tidy] Fix a bug in UseNullptrCheck.
http://reviews.llvm.org/D12162
Patch by Angel Garcia!
Modified:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thanks! LG
http://reviews.llvm.org/D12162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ahatanak created this revision.
ahatanak added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
Error out if user provides -mfloat-abi=hard or -mhard-float on the command line
since hard float abi isn't supported on apple platforms (except for non-darwin
platforms).
jfb added a comment.
Still lgtm, with minor comments.
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:364
@@ +363,3 @@
+ItaniumCXXABI(CGM, /* UseARMMethodPtrABI = */ true,
+ /* UseARMGuardVarABI = */ true) {}
+
It's more common to have no spaces
rjmccall added a comment.
LGTM.
http://reviews.llvm.org/D12128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
In http://reviews.llvm.org/D11963#227951, @jroelofs wrote:
In http://reviews.llvm.org/D11963#227441, @EricWF wrote:
@jroelofs What do you think of an approach like this?
Having two copies of the __config_site file makes me uncomfortable, but I
could put up with
Author: ericwf
Date: Wed Aug 19 12:17:21 2015
New Revision: 245461
URL: http://llvm.org/viewvc/llvm-project?rev=245461view=rev
Log:
[libcxxabi] Add install-libcxxabi target.
Summary:
Currently you can't install libc++abi from within the LLVM tree without
installing all of LLVM. This patch adds
jroelofs added a comment.
In http://reviews.llvm.org/D11963#228024, @EricWF wrote:
Wouldn't it still be a mess if you build both libc++ and libc++abi
out-of-tree? The user would have to be aware of these weird requirements.
Oh, yeah, true. Do we have any out-of-tree builders to make sure
ab added a comment.
Heh, this is http://reviews.llvm.org/D10556, no? :P
Repository:
rL LLVM
http://reviews.llvm.org/D12143
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
angelgarcia changed the visibility of this Differential Revision from All
Users to Public (No Login Required).
angelgarcia updated this revision to Diff 32576.
angelgarcia added a comment.
Use ArrayRef.
http://reviews.llvm.org/D12162
Files:
clang-tidy/modernize/UseNullptrCheck.cpp
Index:
Author: alexfh
Date: Wed Aug 19 11:54:51 2015
New Revision: 245458
URL: http://llvm.org/viewvc/llvm-project?rev=245458view=rev
Log:
[clang-tidy] Fix LoopConvertCheck bug.
Fix LoopConvertCheck bug: StringRef to temporaries.
Also add LLVM_ATTRIBUTE_UNUSED to ModernizeModuleAnchorDestination.
EricWF added a comment.
In http://reviews.llvm.org/D11963#227933, @jroelofs wrote:
In http://reviews.llvm.org/D11963#227444, @EricWF wrote:
I also just realized that this change will currently likely play havoc with
how libc++ and libc++abi build together. In order to build libc++ and
On Wed, Aug 19, 2015 at 11:33 AM, Aaron Ballman aa...@aaronballman.com wrote:
When I run the following test code through clang-tidy -checks=*, I get
a crash from some relatively strange behavior with FunctionDecl.
template class T struct remove_reference {typedef T type;};
template class
MaggieYi created this revision.
MaggieYi added a reviewer: krememek.
MaggieYi added a subscriber: cfe-commits.
Dear All,
I would like to propose a patch to solve an assertion failure reported by
Dmitry in https://llvm.org/bugs/show_bug.cgi?id=24184.
The assertion is caused by reusing a
alexfh closed this revision.
alexfh added a comment.
Committed revision 245458.
http://reviews.llvm.org/D12157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sorry to notice late (just diagnosed the issue from a failing boost::math
test), according to i686 ABI, long double size on x86 is 12 bytes (the
memory allocated, not the underlying 80 bits register), see
https://gcc.gnu.org/onlinedocs/gcc-3.2/gcc/i386-and-x86-64-Options.html
Author: ericwf
Date: Wed Aug 19 12:21:46 2015
New Revision: 245463
URL: http://llvm.org/viewvc/llvm-project?rev=245463view=rev
Log:
[libcxx] Allow use of atomic in C++03. Try 3.
Summary:
After putting this question up on cfe-dev I have decided that it would be best
to allow the use of `atomic`
Author: aaronballman
Date: Wed Aug 19 14:29:23 2015
New Revision: 245484
URL: http://llvm.org/viewvc/llvm-project?rev=245484view=rev
Log:
Replacing a custom AST matcher with some builtin AST matchers; NFC, and
existing tests should provide sufficient coverage.
Modified:
RKSimon abandoned this revision.
RKSimon added a comment.
In http://reviews.llvm.org/D12143#228006, @ab wrote:
Heh, this is http://reviews.llvm.org/D10556, no? :P
Yes you're right (and you remembered to kill the builtin defs) - please can you
add some more reviewers so that we can get it
On Tue, Aug 11, 2015 at 1:49 PM, Adrian Prantl apra...@apple.com wrote:
aprantl created this revision.
aprantl added reviewers: dblaikie, echristo.
aprantl added a subscriber: cfe-commits.
aprantl set the repository for this revision to rL LLVM.
This patch adds a -gmodules option to the
Prazek updated this revision to Diff 32587.
http://reviews.llvm.org/D12128
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/vtable-available-externally.cpp
Index: test/CodeGenCXX/vtable-available-externally.cpp
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM.
See discussion in http://reviews.llvm.org/D10555.
http://reviews.llvm.org/D10556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On Aug 19, 2015, at 1:12 PM, David Blaikie dblai...@gmail.com wrote:
On Tue, Aug 11, 2015 at 1:49 PM, Adrian Prantl apra...@apple.com
mailto:apra...@apple.com wrote:
aprantl created this revision.
aprantl added reviewers: dblaikie, echristo.
aprantl added a subscriber: cfe-commits.
(add the right list)
-- Forwarded message --
From: David Blaikie dblai...@gmail.com
Date: Wed, Aug 19, 2015 at 1:20 PM
Subject: Re: [PATCH] Have clang list the imported modules in the debug info
To: Adrian Prantl apra...@apple.com
Cc: Eric Christopher echri...@gmail.com, Zachary
Yes, it looks like a legacy issue. Documentation says so:
*https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/i386-and-x86-64-Options.html
https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/i386-and-x86-64-Options.html*
-m96bit-long-double-m128bit-long-doubleThese switches control the size of long
double
Author: prazek
Date: Wed Aug 19 15:09:09 2015
New Revision: 245489
URL: http://llvm.org/viewvc/llvm-project?rev=245489view=rev
Log:
Generating available_externally vtables bugfix
Bugfix revealed in r245264.
http://reviews.llvm.org/D12128
Modified:
I assume this is a merge request?
Richard: what do you think about r245459+r245462?
On Wed, Aug 19, 2015 at 10:22 AM, Yaron Keren yaron.ke...@gmail.com wrote:
Sorry to notice late (just diagnosed the issue from a failing boost::math
test), according to i686 ABI, long double size on x86 is 12
nmusgrave updated this revision to Diff 32608.
nmusgrave added a comment.
- More complex testing for destruction order. Tests class with base, virtual
base, trivial, and nontrivial member to ensure destruction order is correct.
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
Author: rsmith
Date: Wed Aug 19 15:49:38 2015
New Revision: 245497
URL: http://llvm.org/viewvc/llvm-project?rev=245497view=rev
Log:
Internal-linkage variables with constant-evaluatable initializers do not need
to be emitted. (Also reduces the set of variables that need to be eagerly
tra added a comment.
Ping.
http://reviews.llvm.org/D11694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
It looks like this would only happen for a late-parsed template that the
analysis code is checking before it is parsed. Should we really be running
these checks at all in that case?
Also, it looks like this code doesn't actually want the body at all, and
just wants to get the location of the
joerg accepted this revision.
joerg added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D12164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: rsmith
Date: Wed Aug 19 16:59:52 2015
New Revision: 245509
URL: http://llvm.org/viewvc/llvm-project?rev=245509view=rev
Log:
Add missing comment.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Sema.h
URL:
Justin Bogner m...@justinbogner.com writes:
Locally, it seems to fail two tests now:
Failing Tests (2):
Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp
Clang Tools :: clang-tidy/modernize-use-nullptr.cpp
I'll poke at it for a minute and see if there's something obvious I
Author: alexfh
Date: Wed Aug 19 18:03:23 2015
New Revision: 245517
URL: http://llvm.org/viewvc/llvm-project?rev=245517view=rev
Log:
[clang-tidy] Work around failure in Darwin.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp
Modified:
That didn't work either - both tests are still failing.
Alexander Kornienko ale...@google.com writes:
Something weird happens with options reading. Submitted a possible workaround
in r245517.
On Thu, Aug 20, 2015 at 12:48 AM, Justin Bogner m...@justinbogner.com wrote:
Locally, it seems
Locally, it seems to fail two tests now:
Failing Tests (2):
Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp
Clang Tools :: clang-tidy/modernize-use-nullptr.cpp
I'll poke at it for a minute and see if there's something obvious I can
do, but running the run line manually just
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rsmith.
george.burgess.iv added a subscriber: cfe-commits.
(Hoping the formatting works as one would expect)
Motivating examples:
Pre-patch:
```
__builtin_object_size((char*)foo, 0) != __builtin_object_size(foo, 0) //
Author: ericwf
Date: Wed Aug 19 17:35:56 2015
New Revision: 245513
URL: http://llvm.org/viewvc/llvm-project?rev=245513view=rev
Log:
Add files that got missed in r245512.
Added:
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.single/unique.ptr.single.asgn/move_convert.pass.cpp
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
This patch properly constrains the converting assignment operator in C++03. It
also fixes a bug where std::forward was given the wrong type.
The following two tests begin passing in C++03:
EricWF updated this revision to Diff 32631.
EricWF added a comment.
Update diff so it has more context.
http://reviews.llvm.org/D12173
Files:
include/memory
Index: include/memory
===
--- include/memory
+++ include/memory
@@
Yep, works for me locally. Thanks for fixing it.
Pete
On Aug 19, 2015, at 3:24 PM, Alexander Kornienko ale...@google.com wrote:
I've committed the check with minor modifications and without the offending
test in r245511. Could you verify that it works in your setup?
-- Alex
On Wed,
Author: rjmccall
Date: Wed Aug 19 17:42:36 2015
New Revision: 245514
URL: http://llvm.org/viewvc/llvm-project?rev=245514view=rev
Log:
Fix the layout of bitfields in ms_struct unions: their
alignment is ignored, and they always allocate a complete
storage unit.
Also, change the dumping of AST
Something weird happens with options reading. Submitted a possible
workaround in r245517.
On Thu, Aug 20, 2015 at 12:48 AM, Justin Bogner m...@justinbogner.com
wrote:
Locally, it seems to fail two tests now:
Failing Tests (2):
Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp
vsk added a subscriber: vsk.
vsk added a comment.
Just a minor nitpick.
Comment at: lib/AST/ExprConstant.cpp:51
@@ -50,1 +50,3 @@
+#include iostream
+
Do you need iostream?
http://reviews.llvm.org/D12169
___
dcoughlin updated the summary for this revision.
dcoughlin updated this revision to Diff 32638.
dcoughlin added a comment.
Update patch to address review comments. I've also updated the
CheckerDocumentation checker to document the new ObjCMessageNil callback.
This version of the patch also
dcoughlin marked 5 inline comments as done.
Comment at: include/clang/StaticAnalyzer/Core/CheckerManager.h:96
@@ -95,1 +95,3 @@
+enum class ObjCCheckerKind {
+ PreVisit,
xazax.hun wrote:
I do not really like the name ObjCCheckerKind, because it is not kind of
Author: ericwf
Date: Wed Aug 19 18:33:18 2015
New Revision: 245522
URL: http://llvm.org/viewvc/llvm-project?rev=245522view=rev
Log:
Cleanup failing dynarray tests
Added:
libcxx/trunk/test/libcxx/experimental/containers/sequences/dynarray/dynarray.cons/default_throws_bad_alloc.pass.cpp
Author: alexfh
Date: Wed Aug 19 18:57:34 2015
New Revision: 245524
URL: http://llvm.org/viewvc/llvm-project?rev=245524view=rev
Log:
[clang-tidy] Fix use-after-free in UseNullptrCheck.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp
tra added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:5944
@@ -5943,3 +5943,3 @@
ProcessDeclAttributes(S, NewVD, D);
-
+ bool ShouldHandleTargetErrors = DeclAttrsMatchCUDAMode(getLangOpts(), NewVD);
if (getLangOpts().CUDA) {
eliben wrote:
Since
Thanks for the spot yaron.
I had only tested x64 at the time as that's what the original bug report
was for.
I can confirm that your fix does infact fix i686
Many Thanks
Martell
On Wed, Aug 19, 2015 at 1:22 PM, Yaron Keren yaron.ke...@gmail.com wrote:
Yes, worth merging with Richard approval.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245502: [CUDA] Added stubs for __nvvm_atom_add_*_d()
builtins. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D11694?vs=31157id=32616#toc
Repository:
rL LLVM
Author: djasper
Date: Wed Aug 19 17:04:55 2015
New Revision: 245510
URL: http://llvm.org/viewvc/llvm-project?rev=245510view=rev
Log:
Remove empty destructors added in r245500. I got confused by my
YouCompleteMe setup which apparently doesn't find the base classes and
thus doesn't understand that
Author: rsmith
Date: Wed Aug 19 16:09:32 2015
New Revision: 245501
URL: http://llvm.org/viewvc/llvm-project?rev=245501view=rev
Log:
[modules] Don't needlessly bounce through Sema when updating exception
specifications.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified:
On Aug 19, 2015, at 2:38 PM, Alexander Kornienko ale...@google.com wrote:
The check has been reverted in r245493. Sorry for the breakage, I was hoping
that this commit fixes it.
No problem. Thanks for taking a look.
If you think the rest of the code is good and want to land it again then
On Wed, Aug 19, 2015 at 5:23 PM, Richard Smith rich...@metafoo.co.uk wrote:
It looks like this would only happen for a late-parsed template that the
analysis code is checking before it is parsed. Should we really be running
these checks at all in that case?
This code is being called from
I've committed the check with minor modifications and without the offending
test in r245511. Could you verify that it works in your setup?
-- Alex
On Wed, Aug 19, 2015 at 11:41 PM, Pete Cooper peter_coo...@apple.com
wrote:
On Aug 19, 2015, at 2:38 PM, Alexander Kornienko ale...@google.com
On Tue, Aug 11, 2015 at 1:37 PM, Manuel Klimek via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: klimek
Date: Tue Aug 11 06:37:48 2015
New Revision: 244586
URL: http://llvm.org/viewvc/llvm-project?rev=244586view=rev
Log:
Add an IncludeInserter to clang-tidy.
Will be used to
Author: djasper
Date: Wed Aug 19 16:02:27 2015
New Revision: 245500
URL: http://llvm.org/viewvc/llvm-project?rev=245500view=rev
Log:
Fix IncludeInserter to allow for more than one added header per file.
Also adapt tests a bit to make it possible to test this. Removed
checking the number of
Author: rtrieu
Date: Wed Aug 19 16:33:54 2015
New Revision: 245507
URL: http://llvm.org/viewvc/llvm-project?rev=245507view=rev
Log:
Fix -Wlogical-not-parentheses to work better with C code.
Remove the assumption of a Boolean type by checking if an expression is known
to have a boolean value.
The check has been reverted in r245493. Sorry for the breakage, I was
hoping that this commit fixes it.
On Wed, Aug 19, 2015 at 10:31 PM, Pete Cooper peter_coo...@apple.com
wrote:
Looks like its only a single test thats failing.
Would you mind if I remove this piece of the test until we can
eliben accepted this revision.
eliben added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D11950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On 10 August 2015 at 19:08, Nick Lewycky nlewy...@google.com wrote:
This simple-minded patch extends the case where we report no viable
conversion from 'X' to 'Y' to emit a more useful diagnostic no viable
conversion from returned value of type 'X' to function return type 'Y'
when used in
Author: alexfh
Date: Wed Aug 19 17:21:37 2015
New Revision: 245511
URL: http://llvm.org/viewvc/llvm-project?rev=245511view=rev
Log:
[clang-tidy] Add modernize-use-nullptr check, attempt 2.
This patch re-applies r245434 and r245471 reverted in r245493, and changes the
way custom null macros are
loverszhaokai added a comment.
Thanks. I am not a committer.
@rnk, could you commit this revision ? Thanks.
http://reviews.llvm.org/D12137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ericwf
Date: Wed Aug 19 20:22:17 2015
New Revision: 245531
URL: http://llvm.org/viewvc/llvm-project?rev=245531view=rev
Log:
Fix or disable C++11 tests in C++03 mode
Modified:
libcxxabi/trunk/test/catch_in_noexcept.pass.cpp
libcxxabi/trunk/test/catch_pointer_nullptr.pass.cpp
After looking at the code once again, I found an obvious use-after-free bug
which could have caused all of this (and for some reason only manifested
itself on Darwin). r245524 should fix the issue.
On Thu, Aug 20, 2015 at 1:44 AM, Justin Bogner m...@justinbogner.com
wrote:
That didn't work
Author: ericwf
Date: Wed Aug 19 19:10:22 2015
New Revision: 245525
URL: http://llvm.org/viewvc/llvm-project?rev=245525view=rev
Log:
Fix more uses of uninitialized values in dynarray
Modified:
libcxx/trunk/test/libcxx/experimental/containers/sequences/dynarray/dynarray.data/default.pass.cpp
timu added a comment.
If you are a committer, commit via svn and then close the revision.
If you are not, ask some committer to do that for you (sorry, I don't have
anything set up right now) and close when it lands.
http://reviews.llvm.org/D12137
alexfh updated this revision to Diff 32645.
alexfh added a comment.
Removed an unused import.
http://reviews.llvm.org/D12180
Files:
test/clang-tidy/arg-comments.cpp
test/clang-tidy/check_clang_tidy.py
test/clang-tidy/google-explicit-constructor.cpp
Author: alexfh
Date: Wed Aug 19 20:44:14 2015
New Revision: 245533
URL: http://llvm.org/viewvc/llvm-project?rev=245533view=rev
Log:
[clang-tidy] Add back a test with a custom NULL macro. Remove redundant default.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp
zaks.anna added a comment.
I have some minor nits but looks good otherwise. Thanks for fixing this!
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:290
@@ -289,2 +289,3 @@
const ProgramPointTag *Tag = nullptr) {
-
loverszhaokai added a comment.
What should I do now ? Close Revision ? Thanks.
http://reviews.llvm.org/D12137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Aug 19 20:08:03 2015
New Revision: 245529
URL: http://llvm.org/viewvc/llvm-project?rev=245529view=rev
Log:
Cleanup unique_ptr failure tests and convert them to Clang verify
Modified:
The tests are passing now
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/6531/.
Will now try to add back the piece of test that was removed and see whether
it works.
On Thu, Aug 20, 2015 at 2:00 AM, Alexander Kornienko ale...@google.com
wrote:
After looking at the code once
Author: ericwf
Date: Thu Aug 20 00:20:29 2015
New Revision: 245538
URL: http://llvm.org/viewvc/llvm-project?rev=245538view=rev
Log:
Fix a typo: abreviated - abbreviated - Patch from Kai Zhao
Modified:
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Thanks again! A lot of these look like my mistakes :S
http://reviews.llvm.org/D12183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF closed this revision.
EricWF added a comment.
commited as r245538.
http://reviews.llvm.org/D12183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Thu Aug 20 00:23:16 2015
New Revision: 245539
URL: http://llvm.org/viewvc/llvm-project?rev=245539view=rev
Log:
Fix a typo: overidden - overridden - Patch from Kai Zhao
Modified:
libcxx/trunk/src/new.cpp
Modified: libcxx/trunk/src/new.cpp
URL:
1 - 100 of 117 matches
Mail list logo
