Re: [PATCH] D12031: Const std::move() argument ClangTidy check

alexfh added a comment. Thank you for tackling this! A high-level comment: the check needs to be somewhat more general. Const-qualified variables are just a specific case of an rvalue. The check should warn on all usages of std::move with an rvalue argument (except in templates with arguments

r245675 - [Sema] Don't crash when diagnosing hack in libstdc++

Author: majnemer Date: Fri Aug 21 01:44:10 2015 New Revision: 245675 URL: http://llvm.org/viewvc/llvm-project?rev=245675&view=rev Log: [Sema] Don't crash when diagnosing hack in libstdc++ While working around a bug in certain standard library implementations, we would try to diagnose the issue so

r245674 - [OPENMP 4.1] Improved codegen for 'uval' qualifier of 'linear' clause.

Author: abataev Date: Fri Aug 21 01:41:23 2015 New Revision: 245674 URL: http://llvm.org/viewvc/llvm-project?rev=245674&view=rev Log: [OPENMP 4.1] Improved codegen for 'uval' qualifier of 'linear' clause. According to standard the 'uval' modifier declares the address of the original list item to

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

sfantao added a comment. Thanks for review. The new diff now uses a proxy function. See other comments inlined. Thanks again! Samuel Comment at: lib/CodeGen/CGExpr.cpp:1969-1970 @@ -1945,4 +1968,4 @@ else - return EmitCapturedFieldLValue(*this, CapturedStmtIn

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

sfantao updated this revision to Diff 32796. sfantao added a comment. Implement proxy function for target directive. Move the creation of the target region parameters from `CGOpenMPRuntime::emitTargetCall` to CodeGenFunction::EmitTargetDirective because we need to access the VLA Maps of the tar

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev updated this revision to Diff 32792. ABataev added a comment. Updated to latest version. http://reviews.llvm.org/D11182 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclBase.h include/clang/AST/DeclOpenMP.h include/clang/AST/RecursiveASTVisitor.h includ

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

filcab added a comment. It seems you missed some `\brief`. Other than that, no complaints on this side. Comment at: lib/CodeGen/CGExpr.cpp:2303 @@ -2302,4 +2302,3 @@ - if (TrapCond) -EmitTrapCheck(TrapCond); + if (TrapCond) EmitSanitizeTrapCheck(TrapCond); if (!FatalC

r245667 - Stop treating -static as overriding -fPIC: they are distinct.

Author: jyknight Date: Thu Aug 20 23:14:55 2015 New Revision: 245667 URL: http://llvm.org/viewvc/llvm-project?rev=245667&view=rev Log: Stop treating -static as overriding -fPIC: they are distinct. For some reason, clang had been treating a command like: clang -static -fPIC foo.c as if it should

r245666 - Fix a few things with -Winfinite-recursion. NFC

Author: rtrieu Date: Thu Aug 20 22:43:09 2015 New Revision: 245666 URL: http://llvm.org/viewvc/llvm-project?rev=245666&view=rev Log: Fix a few things with -Winfinite-recursion. NFC Now that -Winfinite-recursion no longer uses recursive calls to before path analysis, several bits of the code can

Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg wrote: > +Saleem and Renato; maybe you can take a look? Thanks for pointing this out! The patch is correct and pretty safe to apply for 3.7 I think since its a simple bug fix, and can result in VFP state corruption (the invalid memory access in th

[libunwind] r245665 - unwind: fix invalid memory access

Author: compnerd Date: Thu Aug 20 22:21:31 2015 New Revision: 245665 URL: http://llvm.org/viewvc/llvm-project?rev=245665&view=rev Log: unwind: fix invalid memory access Fix out-of-bounds array access when setting arm float registers. Patch by Leandro Graciá Gil! Modified: libunwind/trunk/sr

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

I'll update patch, Michael Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 20.08.2015 18:40, Michael Wong пишет: fraggamuffin added a comment. Comment at: lib/Parse/ParseDeclCXX.cpp:3011 @@ -3010,3 +3010,3 @@ if (Tok.is(tok::annot_pra

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev added a subscriber: ABataev. ABataev added a comment. I'll update patch, Michael Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 20.08.2015 18:40, Michael Wong пишет: > fraggamuffin added a comment. > > > Comment at: lib/Parse/Pars

Re: [PATCH] D12152: [OPENMP] Info about OpenMP Support in Users Manual

ABataev updated this revision to Diff 32790. ABataev added a comment. Update after review from Kelvin http://reviews.llvm.org/D12152 Files: docs/UsersManual.rst Index: docs/UsersManual.rst === --- docs/UsersManual.rst +++ docs/U

r245664 - [modules] When we see a definition of a function for which we already have a

Author: rsmith Date: Thu Aug 20 22:04:33 2015 New Revision: 245664 URL: http://llvm.org/viewvc/llvm-project?rev=245664&view=rev Log: [modules] When we see a definition of a function for which we already have a non-visible definition, skip the new definition to avoid ending up with a function with

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

jmgao updated this revision to Diff 32788. jmgao marked 7 inline comments as done. jmgao added a comment. clang-format, remove \brief from modified doxygen comments. http://reviews.llvm.org/D12181 Files: docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOp

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

On Thu, Aug 20, 2015 at 6:39 PM, Michael Zolotukhin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > mzolotukhin created this revision. > mzolotukhin added reviewers: hfinkel, doug.gregor, t.p.northover, ab, > mcrosier. > mzolotukhin added a subscriber: cfe-commits. > Herald added a subscrib

Re: [PATCH] D12169: Relax constexpr rules to improve __builtin_object_size's accuracy

george.burgess.iv added inline comments. Comment at: lib/AST/ExprConstant.cpp:4763 @@ +4762,3 @@ + /// arithmetic. + bool UseStrictCastingRules; + rsmith wrote: > This should be handled as an `EvaluationMode`. Works for me. Comment at: lib/AST/

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

majnemer added a subscriber: majnemer. majnemer added a comment. What does it mean to have the attribute applied to non-pointer types like `int __attribute__((nontemporal)) i;` ? The ACLE doesn't say but making it erroneous might make sense. Perhaps it would be good to have a semantic test wh

[PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

mzolotukhin created this revision. mzolotukhin added reviewers: hfinkel, doug.gregor, t.p.northover, ab, mcrosier. mzolotukhin added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Currently there is no way to generate nontemporal memory accesses for some architectures, e.g. for AA

[libunwind] r245660 - Creating release candidate rc3 from release_370 branch

Author: hans Date: Thu Aug 20 19:49:55 2015 New Revision: 245660 URL: http://llvm.org/viewvc/llvm-project?rev=245660&view=rev Log: Creating release candidate rc3 from release_370 branch Added: libunwind/tags/RELEASE_370/rc3/ (props changed) - copied from r245659, libunwind/branches/re

[libcxx] r245653 - Creating release candidate rc3 from release_370 branch

Author: hans Date: Thu Aug 20 19:49:32 2015 New Revision: 245653 URL: http://llvm.org/viewvc/llvm-project?rev=245653&view=rev Log: Creating release candidate rc3 from release_370 branch Added: libcxx/tags/RELEASE_370/rc3/ (props changed) - copied from r245652, libcxx/branches/release_

[libcxxabi] r245654 - Creating release candidate rc3 from release_370 branch

Author: hans Date: Thu Aug 20 19:49:35 2015 New Revision: 245654 URL: http://llvm.org/viewvc/llvm-project?rev=245654&view=rev Log: Creating release candidate rc3 from release_370 branch Added: libcxxabi/tags/RELEASE_370/rc3/ (props changed) - copied from r245653, libcxxabi/branches/re

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

filcab added a subscriber: filcab. filcab added a comment. Looks good, thanks for working on this. I added some code style comments. Comment at: lib/CodeGen/CGExpr.cpp:2399 @@ -2385,1 +2398,3 @@ + +void CodeGenFunction::EmitTrapCheck(llvm::Value *Checked, const std::string &Tra

Re: [PATCH] D4724: Add framework for iterative compilation to clang

petarj added a comment. This patch can now be abandoned, as an updated version is available at http://reviews.llvm.org/D12200 . http://reviews.llvm.org/D4724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

jmgao updated this revision to Diff 32776. jmgao marked 2 inline comments as done. jmgao added a comment. Make methods private http://reviews.llvm.org/D12181 Files: docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGExpr.cpp lib/

Re: [PATCH] D12169: Relax constexpr rules to improve __builtin_object_size's accuracy

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:4763 @@ +4762,3 @@ + /// arithmetic. + bool UseStrictCastingRules; + This should be handled as an `EvaluationMode`. Comment at: lib/AST/ExprConstant.cpp:4879-4907 @@ +4878,31 @@

Re: [PATCH] D12122: [CUDA] Add appropriate host/device attribute to target-specific builtins.

tra added a comment. Reverted in r245592 due to breaking internal tests. Repository: rL LLVM http://reviews.llvm.org/D12122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12215: [UBSan] Add the ability to print more precise error kind in summary line.

samsonov added inline comments. Comment at: lib/ubsan/ubsan_handlers.cc:57-58 @@ -57,2 +56,4 @@ + if (!Pointer) { +R.setErrorType(ErrorType::NullPointerUse); Diag(Loc, DL_Error, "%0 null pointer of type %1") << TypeCheckKinds[Data->TypeCheckKind] << Data->Type; --

Re: [PATCH] D12164: Stop treating -static as overriding -fPIC: they are distinct.

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. lgtm http://reviews.llvm.org/D12164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

jmgao updated this revision to Diff 32769. jmgao added a comment. Doc fix, 80 col http://reviews.llvm.org/D12181 Files: docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h lib/Frontend/Comp

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

jmgao updated this revision to Diff 32768. jmgao added a comment. Make option fit in 80 cols http://reviews.llvm.org/D12181 Files: docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h lib/Fr

Re: [PATCH] D12215: [UBSan] Add the ability to print more precise error kind in summary line.

rsmith added inline comments. Comment at: lib/ubsan/ubsan_handlers.cc:57-58 @@ -57,2 +56,4 @@ + if (!Pointer) { +R.setErrorType(ErrorType::NullPointerUse); Diag(Loc, DL_Error, "%0 null pointer of type %1") << TypeCheckKinds[Data->TypeCheckKind] << Data->Type;

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

jmgao added a comment. In http://reviews.llvm.org/D12181#229467, @rsmith wrote: > In http://reviews.llvm.org/D12181#229358, @rsmith wrote: > > > Can you please give a brief description of the motivation for this change? > > When would it be appropriate to use this rather than `-ftrap-function`?

Re: [PATCH] D12215: [UBSan] Add the ability to print more precise error kind in summary line.

samsonov added inline comments. Comment at: lib/ubsan/ubsan_handlers.cc:57-58 @@ -57,2 +56,4 @@ + if (!Pointer) { +R.setErrorType(ErrorType::NullPointerUse); Diag(Loc, DL_Error, "%0 null pointer of type %1") << TypeCheckKinds[Data->TypeCheckKind] << Data->Type; --

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

I feel very silly now. After testing the testcase again on svn it still works. It appears the OP was looking for this patch to go onto the 3.6 branch and was applying my patch to that. I'll know in future to recheck the testcase afterwards myself in future. Apologies for the noise guys. Yaron I

Re: [PATCH] D12215: [UBSan] Add the ability to print more precise error kind in summary line.

rsmith added inline comments. Comment at: lib/ubsan/ubsan_handlers.cc:57-58 @@ -57,2 +56,4 @@ + if (!Pointer) { +R.setErrorType(ErrorType::NullPointerUse); Diag(Loc, DL_Error, "%0 null pointer of type %1") << TypeCheckKinds[Data->TypeCheckKind] << Data->Type;

r245637 - [Static Analyzer] Made it easier to test new checkers using the test suite.

Author: xazax Date: Thu Aug 20 17:59:49 2015 New Revision: 245637 URL: http://llvm.org/viewvc/llvm-project?rev=245637&view=rev Log: [Static Analyzer] Made it easier to test new checkers using the test suite. Modified: cfe/trunk/utils/analyzer/SATestBuild.py Modified: cfe/trunk/utils/analyzer

Re: [PATCH] D12215: [UBSan] Add the ability to print more precise error kind in summary line.

samsonov added inline comments. Comment at: lib/ubsan/ubsan_flags.inc:26 @@ +25,2 @@ +UBSAN_FLAG(bool, report_error_type, false, +"Print specific error type instead of 'undefined-behavior' in summary.") filcab wrote: > Do we care that much about keeping t

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

rsmith added a comment. In http://reviews.llvm.org/D12181#229358, @rsmith wrote: > Can you please give a brief description of the motivation for this change? > When would it be appropriate to use this rather than `-ftrap-function`? I'd still like an answer to this. It's not clear to me what th

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

> > There is no testcase for PR24398 nor the OP reporting the problem was > actually solved. Martell? I'm just re-looking through it now. X86TargetInfo sets LongDoubleFormat = &llvm::APFloat::x87DoubleExtended; X86_64TargetInfo then sets LongDoubleWidth = LongDoubleAlign = 128; X86_32TargetInfo t

Re: [PATCH] D12215: [UBSan] Add the ability to print more precise error kind in summary line.

filcab added a subscriber: filcab. filcab added a comment. Looks good. Comment at: lib/ubsan/ubsan_flags.inc:26 @@ +25,2 @@ +UBSAN_FLAG(bool, report_error_type, false, +"Print specific error type instead of 'undefined-behavior' in summary.") Do we care

Re: r245621 - [analyzer] Fix for PR24112 (scan-build doesn't work with --use-analyzer="path to clang++.exe").

It looks like the answer is no, paths to clang and clang++ executables are used to initialize CLANG and CLANG_CXX environment variables. Can't we just use the --driver-mode flag instead of trying to mangle the executable name? Peter On Thu, Aug 20, 2015 at 09:52:39PM -, Anton Yartsev via

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

samsonov added a comment. Overall, this looks reasonable to me, but I'd like Richard to confirm he's fine with this change as well. Comment at: docs/UsersManual.rst:1121 @@ +1120,3 @@ + Instruct code generator to emit a function call to the specified + function name instead

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

Hi, I've just done this exactly this in r245618 (32 bit) and r245620 (64 bits). mingw i686 long double values were correct before r245084 and wrong after it. mingw x86_64 long double values were not modified at all by r245084 for the reason you stated, so I agree and do not see how this non-chang

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

I've reverted r245456 in r245623. Thanks, Hans On Thu, Aug 20, 2015 at 2:56 PM, Richard Smith wrote: > The cumulative effect of all the patches so far has been to revert this > change from trunk. Hans, can you revert it on the branch too? > > Thanks. > > On Wed, Aug 19, 2015 at 1:51 PM, Martell

Re: r245621 - [analyzer] Fix for PR24112 (scan-build doesn't work with --use-analyzer="path to clang++.exe").

Can't we just use the --driver-mode flag instead of trying to mangle the executable name? Peter On Thu, Aug 20, 2015 at 09:52:39PM -, Anton Yartsev via cfe-commits wrote: > Author: ayartsev > Date: Thu Aug 20 16:52:39 2015 > New Revision: 245621 > > URL: http://llvm.org/viewvc/llvm-project?r

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

jmgao updated this revision to Diff 32756. jmgao added a comment. Improve comment http://reviews.llvm.org/D12181 Files: docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h lib/Frontend/Comp

Re: r245609 - PR24483: Delete some dead/incorrect code that triggered assertions.

Hans, it looked like you might have wanted PR24483 fixed for 3.7. If so, this patch is safe for branch. On Thu, Aug 20, 2015 at 1:45 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Aug 20 15:45:25 2015 > New Revision: 245609 > > URL: http://llvm

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

jmgao updated this revision to Diff 32755. jmgao marked 2 inline comments as done. jmgao added a comment. Address comments http://reviews.llvm.org/D12181 Files: docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGExpr.cpp lib/Code

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

The cumulative effect of all the patches so far has been to revert this change from trunk. Hans, can you revert it on the branch too? Thanks. On Wed, Aug 19, 2015 at 1:51 PM, Martell Malone wrote: > Thanks for the spot yaron. > I had only tested x64 at the time as that's what the original bug r

r245621 - [analyzer] Fix for PR24112 (scan-build doesn't work with --use-analyzer="path to clang++.exe").

Author: ayartsev Date: Thu Aug 20 16:52:39 2015 New Revision: 245621 URL: http://llvm.org/viewvc/llvm-project?rev=245621&view=rev Log: [analyzer] Fix for PR24112 (scan-build doesn't work with --use-analyzer="path to clang++.exe"). Don't derive the path_to_clang++ from the path_to_clang if the pa

r245620 - Revert the 64bit part of r245084; long double values were not changed by

Author: yrnkrn Date: Thu Aug 20 16:51:46 2015 New Revision: 245620 URL: http://llvm.org/viewvc/llvm-project?rev=245620&view=rev Log: Revert the 64bit part of r245084; long double values were not changed by it as they are already set correctly by X86_64TargetInfo and X86TargetInfo. Modified:

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

OK, so here's the problem: The right way to fix this seems to be to delete the assignments to LongDouble* from the MinGWX86_32TargetInfo constructor; the X86_32TargetInfo and X86TargetInfo base classes already set them to the right values. Likewise we can delete the assignments to LongDouble* from

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

jmgao marked 8 inline comments as done. Comment at: tools/clang/lib/CodeGen/CGExpr.cpp:2388 @@ +2387,3 @@ + } + return EmitTrapCheck(Checked); +} samsonov wrote: > This is confusing. So, you have the following behavior whenever you need to > emit a check for `-

Re: r245344 - [sanitizer] Add -lutil to static runtime link flags.

Reverted in r245619. On Wed, Aug 19, 2015 at 10:49 AM, H.J. Lu wrote: > On Tue, Aug 18, 2015 at 1:36 PM, Evgeniy Stepanov via cfe-commits > wrote: >> Author: eugenis >> Date: Tue Aug 18 15:36:11 2015 >> New Revision: 245344 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=245344&view=rev >> Lo

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added a comment. Alright, let's hash it, then. Repository: rL LLVM http://reviews.llvm.org/D11958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r245619 - Revert r245344.

Author: eugenis Date: Thu Aug 20 16:47:16 2015 New Revision: 245619 URL: http://llvm.org/viewvc/llvm-project?rev=245619&view=rev Log: Revert r245344. That change is causing strange test failures on Fedora 22 (PR24503), and it does not have any effect with Gold linker anyway (PR15823, https://sour

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

On Thu, Aug 20, 2015 at 2:45 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > aprantl added inline comments. > > > Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 > @@ -163,1 +163,4 @@ > > +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or no

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 @@ -163,1 +163,4 @@ +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or not debug info should contain + ///< external references to a PCH or module. +

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

samsonov added a comment. See https://llvm.org/bugs/show_bug.cgi?id=24443 (it's worth including this reference to change description). http://reviews.llvm.org/D12181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D12215: [UBSan] Add the ability to print more precise error kind in summary line.

samsonov created this revision. samsonov added reviewers: rsmith, pcc. samsonov added a subscriber: cfe-commits. http://reviews.llvm.org/D12215 Files: lib/ubsan/ubsan_checks.inc lib/ubsan/ubsan_diag.cc lib/ubsan/ubsan_diag.h lib/ubsan/ubsan_flags.inc lib/ubsan/ubsan_handlers.cc lib/ub

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added a comment. Maybe this is missing the point, but a hash collision between module files with different formats should be highly unlikely because we add the module format into the hash. llvm::hash_code Hash = llvm::hash_combine(DirName.lower(), FileName.lower(),

r245618 - Revert the 32bit part of r245084; mingw values were correct before it.

Author: yrnkrn Date: Thu Aug 20 16:36:14 2015 New Revision: 245618 URL: http://llvm.org/viewvc/llvm-project?rev=245618&view=rev Log: Revert the 32bit part of r245084; mingw values were correct before it. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

> On Aug 19, 2015, at 2:15 PM, Richard Smith wrote: > > rsmith added a subscriber: rsmith. > > > Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 > @@ -163,1 +163,4 @@ > > +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or not debug info should > contain > +

r245616 - Do not crash when static analysis encounters a FunctionDecl that has a delayed template parse of its body.

Author: aaronballman Date: Thu Aug 20 16:27:35 2015 New Revision: 245616 URL: http://llvm.org/viewvc/llvm-project?rev=245616&view=rev Log: Do not crash when static analysis encounters a FunctionDecl that has a delayed template parse of its body. Added: cfe/trunk/test/Analysis/delayed-templat

Re: FunctionDecl::getBody() returning nullptr

On Thu, Aug 20, 2015 at 5:18 PM, Richard Smith wrote: > On Wed, Aug 19, 2015 at 2:52 PM, Aaron Ballman > wrote: >> >> On Wed, Aug 19, 2015 at 5:23 PM, Richard Smith >> wrote: >> > It looks like this would only happen for a late-parsed template that the >> > analysis code is checking before it is

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

OK, based on testing, mingw i686 aligns long doubles to 4 bytes: sh-4.3$ cat < a.cpp #include int main() { struct { char c[1]; long double d; } s; std::cout<<&s.c<: > On Wed, Aug 19, 2015 at 11:42 AM, Yaron Keren > wrote: > >> Yes, it looks like a legacy issue. Documentation says

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

rsmith added a comment. Can you please give a brief description of the motivation for this change? When would it be appropriate to use this rather than `-ftrap-function`? Please also include an update for the Clang documentation to describe the new flag. http://reviews.llvm.org/D12181

Re: Second Lit tests C++11 compatibility patch: using preprocessor to filter expected-error

On Tue, Aug 18, 2015 at 12:20 PM, Li, Charles via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Justin and Richard, > > >> +// RUN: %clang_cc1 -E -C -P -triple x86_64-apple-darwin10 %s > %t1.c > >> +// RUN: %clang_cc1 -fsyntax-only -verify -triple > >> +x86_64-apple-darwin10 %t1.c > > > I

Re: [PATCH] D11194: Instantiate function declarations in instantiated functions.

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. LGTM with a couple of tweaks. Thanks! Comment at: lib/AST/DeclBase.cpp:276 @@ +275,3 @@ + return false; +LDC = LDC->getParent(); + }

Re: FunctionDecl::getBody() returning nullptr

On Wed, Aug 19, 2015 at 2:52 PM, Aaron Ballman wrote: > On Wed, Aug 19, 2015 at 5:23 PM, Richard Smith > wrote: > > It looks like this would only happen for a late-parsed template that the > > analysis code is checking before it is parsed. Should we really be > running > > these checks at all in

Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

+Saleem and Renato; maybe you can take a look? On Tue, Aug 18, 2015 at 11:24 AM, Leandro Graciá Gil wrote: > Hi, > > Please find attached a patch fixing an out-of-bounds array access present in > the current libunwind top of tree code. > > The problem is caused by subtracting the wrong base regis

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

On Wed, Aug 19, 2015 at 11:42 AM, Yaron Keren wrote: > Yes, it looks like a legacy issue. Documentation says so: > > *https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/i386-and-x86-64-Options.html > * > > -m96bit-long-double-m1

Re: r245560 - Fix crash with two typos in the arguments of a function

Merged in r245615. Thanks, Hans On Thu, Aug 20, 2015 at 12:13 PM, Richard Smith wrote: > LGTM for branch. > > On Aug 20, 2015 9:47 AM, "Hans Wennborg" wrote: >> >> It was requested that this be merged to 3.7. >> >> Richard: OK for merging? >> >> Thanks, >> Hans >> >> On Thu, Aug 20, 2015 at 6:1

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

ismailp updated this revision to Diff 32745. ismailp added a comment. - Renamed `Out` parameter to `Stm`. - Removed assertion that checks whether an ExplodedNode has an edge to itself. - Added '-analyzer-viz-egraph-ubigraph' to an analyzer invocation in a test. http://reviews.llvm.org/D12119 Fi

Re: [PATCH] D12212: [Headers][X86] Add -O0 assembly tests for intrinsics.

RKSimon added a comment. Definitely like this idea - hopefully it'll make it safer to remove unnecessary builtins. Comment at: avx2-builtins-codegen.c:182 @@ -151,1 +181,3 @@ + // FIXME-CHECK-ASM: vpxor %ymm{{.*}} + // FIXME-CHECK-ASM: vandps {{.*}}, %ymm{{.*}} return _mm2

r245609 - PR24483: Delete some dead/incorrect code that triggered assertions.

Author: rsmith Date: Thu Aug 20 15:45:25 2015 New Revision: 245609 URL: http://llvm.org/viewvc/llvm-project?rev=245609&view=rev Log: PR24483: Delete some dead/incorrect code that triggered assertions. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp cfe/trunk/test/SemaTemplate/instantiate-va

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

jmgao updated this revision to Diff 32736. jmgao added a comment. Uploading diff with arcanist. http://reviews.llvm.org/D12181 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprScalar.cpp lib/CodeGen/CodeGenFunction

r245607 - Fix test on Windows to accept both gcc and gcc.exe.

Author: yrnkrn Date: Thu Aug 20 15:37:58 2015 New Revision: 245607 URL: http://llvm.org/viewvc/llvm-project?rev=245607&view=rev Log: Fix test on Windows to accept both gcc and gcc.exe. Modified: cfe/trunk/test/Driver/biarch.c Modified: cfe/trunk/test/Driver/biarch.c URL: http://llvm.org/vi

[PATCH] D12212: [Headers][X86] Add -O0 assembly tests for intrinsics.

ab created this revision. ab added reviewers: spatel, RKSimon. ab added subscribers: cfe-commits, chandlerc, silvas, qcolombet. We agreed in D10555 that, as long as we don't affect -O0 codegen too much, it's OK to use native constructs rather than intrinsics. Let's test that, starting with AVX2

Re: [PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

jroelofs added a comment. I like it! http://reviews.llvm.org/D12209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10556: [Headers][X86] Replace avx2.pbroadcast intrinsics with native IR.

This revision was automatically updated to reflect the committed changes. Closed by commit rL245605: [Headers][X86] Use __builtin_shufflevector in AVX2 broadcasts. (authored by ab). Changed prior to commit: http://reviews.llvm.org/D10556?vs=27973&id=32729#toc Repository: rL LLVM http://revi

r245605 - [Headers][X86] Use __builtin_shufflevector in AVX2 broadcasts.

Author: ab Date: Thu Aug 20 15:27:21 2015 New Revision: 245605 URL: http://llvm.org/viewvc/llvm-project?rev=245605&view=rev Log: [Headers][X86] Use __builtin_shufflevector in AVX2 broadcasts. This lets us optimize them better. We agreed to remove the intrinsics, instead of combining them later, a

[PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

EricWF created this revision. EricWF added reviewers: mclow.lists, beanz, jroelofs. EricWF added a subscriber: cfe-commits. On Mac OS X overwriting `/usr/lib/libc++.dylib` can cause your computer to fail to boot. This patch tries to make it harder to do that accidentally. If `CMAKE_SYSTEM_NAME`

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

silvas added inline comments. Comment at: docs/BuildingLibcxx.rst:57 @@ +56,3 @@ + select a safe place to install libc++. + + * ``make install-libcxx install-libcxxabi`` --- Will install the libraries and the headers silvas wrote: > jroelofs wrote: > > I feel l

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

silvas added inline comments. Comment at: docs/BuildingLibcxx.rst:57 @@ +56,3 @@ + select a safe place to install libc++. + + * ``make install-libcxx install-libcxxabi`` --- Will install the libraries and the headers jroelofs wrote: > I feel like a warning is n

r245603 - [CMake] Exclude 'bootstrap' target from 'all' where possible.

Author: cbieneman Date: Thu Aug 20 15:12:18 2015 New Revision: 245603 URL: http://llvm.org/viewvc/llvm-project?rev=245603&view=rev Log: [CMake] Exclude 'bootstrap' target from 'all' where possible. EXCLUDE_FROM_ALL in ExternalProject is only available on CMake 3.1 and later. Modified: cfe/tr

r245604 - [CMake] Simplifying logic for USES_TERMINAL on bootstrap targets.

Author: cbieneman Date: Thu Aug 20 15:12:20 2015 New Revision: 245604 URL: http://llvm.org/viewvc/llvm-project?rev=245604&view=rev Log: [CMake] Simplifying logic for USES_TERMINAL on bootstrap targets. In CMake variables that haven't been set are evaluated to empty strings, so we don't need to s

[libcxx] r245601 - Remove completed items from TODO.TXT

Author: ericwf Date: Thu Aug 20 14:22:35 2015 New Revision: 245601 URL: http://llvm.org/viewvc/llvm-project?rev=245601&view=rev Log: Remove completed items from TODO.TXT Modified: libcxx/trunk/TODO.TXT Modified: libcxx/trunk/TODO.TXT URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/TOD

[clang-tools-extra] r245600 - Change the test to use the new python script instead of the more verbose RUN line.

Author: aaronballman Date: Thu Aug 20 14:21:07 2015 New Revision: 245600 URL: http://llvm.org/viewvc/llvm-project?rev=245600&view=rev Log: Change the test to use the new python script instead of the more verbose RUN line. Modified: clang-tools-extra/trunk/test/clang-tidy/misc-move-constructo

Re: r245595 - [Sparc] Add '-EL' when invoking gcc to link little-endian binaries.

On Thu, Aug 20, 2015 at 06:32:27PM -, Douglas Katzman via cfe-commits wrote: > Modified: cfe/trunk/test/Driver/biarch.c > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/biarch.c?rev=245595&r1=245594&r2=245595&view=diff > ===

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

jroelofs added inline comments. Comment at: docs/BuildingLibcxx.rst:57 @@ +56,3 @@ + select a safe place to install libc++. + + * ``make install-libcxx install-libcxxabi`` --- Will install the libraries and the headers I feel like a warning is not enough... per

Re: r245560 - Fix crash with two typos in the arguments of a function

LGTM for branch. On Aug 20, 2015 9:47 AM, "Hans Wennborg" wrote: > It was requested that this be merged to 3.7. > > Richard: OK for merging? > > Thanks, > Hans > > On Thu, Aug 20, 2015 at 6:11 AM, Olivier Goffart via cfe-commits > wrote: > > Author: ogoffart > > Date: Thu Aug 20 08:11:14 2015 >

Re: [PATCH] D11380: Implement LFTS searchers. Boyer_Moore and Boyer_Moore_Horspool

EricWF added a comment. Added more review comments for the boyer_moore searcher. Comment at: include/experimental/functional:256 @@ +255,3 @@ + +public: // TODO private: +_RandomAccessIterator1 __first_; Is this for testing? Comment

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

samsonov added a comment. Please upload the patch with more context (see http://llvm.org/docs/Phabricator.html). Comment at: tools/clang/include/clang/Driver/Options.td:610 @@ -608,1 +609,3 @@ + Flags<[CC1Option, CoreOption]>, +

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

EricWF added inline comments. Comment at: docs/BuildingLibcxx.rst:56 @@ +55,3 @@ +Mac users, remember to be careful when replacing the system's libc++. +**Your system will not be able to boot without a functioning libc++.** + jroelofs wrote: > Is there a way to ma

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

EricWF updated this revision to Diff 32718. EricWF marked an inline comment as done. EricWF updated the summary for this revision. EricWF added a comment. Address review comments. http://reviews.llvm.org/D12129 Files: CMakeLists.txt cmake/Modules/HandleOutOfTreeLLVM.cmake cmake/config-ix.

Re: [PATCH] D12201: [Sparc] Add '-EL' when invoking gcc to link little-endian binaries.

This revision was automatically updated to reflect the committed changes. Closed by commit rL245595: [Sparc] Add '-EL' when invoking gcc to link little-endian binaries. (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D12201?vs=32715&id=32716#toc Repository: rL LLVM htt

r245595 - [Sparc] Add '-EL' when invoking gcc to link little-endian binaries.

Author: dougk Date: Thu Aug 20 13:32:26 2015 New Revision: 245595 URL: http://llvm.org/viewvc/llvm-project?rev=245595&view=rev Log: [Sparc] Add '-EL' when invoking gcc to link little-endian binaries. Differential Revision: http://reviews.llvm.org/D12201 Modified: cfe/trunk/lib/Driver/Tools.c

  1   2   >