r245786 - [CUDA] Change initializer for CUDA device code based on CUDA documentation.

2015-08-21 Thread Jingyue Wu via cfe-commits
Author: jingyue Date: Sat Aug 22 00:49:28 2015 New Revision: 245786 URL: http://llvm.org/viewvc/llvm-project?rev=245786&view=rev Log: [CUDA] Change initializer for CUDA device code based on CUDA documentation. Summary: According to CUDA documentation, global variables declared with __device__, __

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

2015-08-21 Thread Ted Kremenek via cfe-commits
krememek added inline comments. Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749 @@ -748,3 @@ - - assert (Src != Dst && "Self-edges are not allowed."); - Did you look at the test case that causes this assertion to fail? I think it would be good

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

2015-08-21 Thread Ted Kremenek via cfe-commits
krememek added inline comments. Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:778 @@ -780,3 +777,3 @@ -UbigraphViz::UbigraphViz(std::unique_ptr Out, StringRef Filename) -: Out(std::move(Out)), Filename(Filename), Cntr(0) { +UbigraphViz::UbigraphViz(std::unique

[PATCH] D12262: [OpenMP] Capture global variables in target regions.

2015-08-21 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: ABataev, rjmccall, hfinkel. sfantao added a subscriber: cfe-commits. All global variables that are not enclosed in a declare target region must be captured in the target region as local variables do. Currently, there is no support for decla

r245780 - [modules] Remove some dead code after r245779.

2015-08-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Aug 21 21:09:38 2015 New Revision: 245780 URL: http://llvm.org/viewvc/llvm-project?rev=245780&view=rev Log: [modules] Remove some dead code after r245779. Modified: cfe/trunk/include/clang/Serialization/ASTReader.h cfe/trunk/lib/Serialization/ASTReader.cpp cfe

r245779 - [modules] Rearrange how redeclaration chains are loaded, to remove a walk over

2015-08-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Aug 21 20:47:18 2015 New Revision: 245779 URL: http://llvm.org/viewvc/llvm-project?rev=245779&view=rev Log: [modules] Rearrange how redeclaration chains are loaded, to remove a walk over all modules and reduce the number of declarations we load when loading a redeclaration

Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

2015-08-21 Thread Saleem Abdulrasool via cfe-commits
On Fri, Aug 21, 2015 at 11:02 AM, Hans Wennborg wrote: > On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool > wrote: > > On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg > wrote: > >> > >> +Saleem and Renato; maybe you can take a look? > > > > > > Thanks for pointing this out! > > > > The patch

r245778 - [ARM NEON] Remove special-case for f16 vcvt handling. NFCI.

2015-08-21 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Fri Aug 21 20:30:13 2015 New Revision: 245778 URL: http://llvm.org/viewvc/llvm-project?rev=245778&view=rev Log: [ARM NEON] Remove special-case for f16 vcvt handling. NFCI. We can use the 'H' typespec modifier to use 128-bit vectors directly in the only two users of this special-c

Re: [PATCH] D11468: [Static Analyzer] The first implementation of nullability checker.

2015-08-21 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Partial review... Comment at: lib/StaticAnalyzer/Checkers/Checkers.td:137 @@ +136,3 @@ +def NullPassedToNonnullChecker : Checker<"NullPassedToNonnull">, + HelpText<"Warns when a null pointer is passed to a nonnull pointer.">, + DescFile<"NullabilityC

r245771 - When building a pseudo-object assignment, and the RHS is

2015-08-21 Thread John McCall via cfe-commits
Author: rjmccall Date: Fri Aug 21 19:35:27 2015 New Revision: 245771 URL: http://llvm.org/viewvc/llvm-project?rev=245771&view=rev Log: When building a pseudo-object assignment, and the RHS is a contextually-typed expression that semantic analysis will probably need to invasively rewrite, don't inc

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

2015-08-21 Thread Naomi Musgrave via cfe-commits
nmusgrave added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1578 @@ +1577,3 @@ +if (CGF.CGM.FieldHasTrivialDestructorBody(Context, Field) || +Field->getType()->isPointerType()) { + // Start sanitizing at this field eugenis wro

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

2015-08-21 Thread Evgeniy Stepanov via cfe-commits
eugenis added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1578 @@ +1577,3 @@ +if (CGF.CGM.FieldHasTrivialDestructorBody(Context, Field) || +Field->getType()->isPointerType()) { + // Start sanitizing at this field Why do you ne

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

2015-08-21 Thread Richard Smith via cfe-commits
On Fri, Aug 21, 2015 at 4:59 PM, Michael Zolotukhin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > mzolotukhin added a comment. > > Thanks for the feedback everyone! > I think at this point I'll try to return to builtins then. In my original > patch I didn't have type overloading, so I'll

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

2015-08-21 Thread Michael Zolotukhin via cfe-commits
mzolotukhin added a comment. Thanks for the feedback everyone! I think at this point I'll try to return to builtins then. In my original patch I didn't have type overloading, so I'll need some time to add this. We can return back to type attributes later if we'd like to. And do I understand it

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

2015-08-21 Thread Naomi Musgrave via cfe-commits
nmusgrave added inline comments. Comment at: lib/CodeGen/CGCXX.cpp:41 @@ +40,3 @@ + if (getCodeGenOpts().SanitizeMemoryUseAfterDtor && Layout.getFieldCount() > 0 + && HasTrivialDestructorBody(Context, D->getParent(), D->getParent())) { +return true;

r245763 - [ARM NEON] Use the common naming scheme for vcvt f16 builtins. NFC.

2015-08-21 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Fri Aug 21 18:34:20 2015 New Revision: 245763 URL: http://llvm.org/viewvc/llvm-project?rev=245763&view=rev Log: [ARM NEON] Use the common naming scheme for vcvt f16 builtins. NFC. We had "vcvt_f16" and "VCVT_HIGH_F16": for other FP types, this naming is used for intrinsics with i

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

2015-08-21 Thread Naomi Musgrave via cfe-commits
nmusgrave added inline comments. Comment at: lib/CodeGen/CGCXX.cpp:41 @@ +40,3 @@ + if (getCodeGenOpts().SanitizeMemoryUseAfterDtor && Layout.getFieldCount() > 0 + && HasTrivialDestructorBody(Context, D->getParent(), D->getParent())) { +return true;

r245761 - [ARM NEON] Factor out FP-prototype checking. NFC.

2015-08-21 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Fri Aug 21 18:24:18 2015 New Revision: 245761 URL: http://llvm.org/viewvc/llvm-project?rev=245761&view=rev Log: [ARM NEON] Factor out FP-prototype checking. NFC. Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp URL: http:

Improved Diagnostics and Extended vectorize(enable)

2015-08-21 Thread Tyler Nowicki via cfe-commits
Hi, I’ve been working on the vectorization diagnostics a little more. The first patch makes sure the analysis diagnostics are printed unless a disabling hint is provided. And the two pairs of LLVM and Clang patches make the diagnostic messages easier to understand and extend the vectorize(enabl

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

2015-08-21 Thread Evgeniy Stepanov via cfe-commits
eugenis added inline comments. Comment at: lib/CodeGen/CGCXX.cpp:41 @@ +40,3 @@ + if (getCodeGenOpts().SanitizeMemoryUseAfterDtor && Layout.getFieldCount() > 0 + && HasTrivialDestructorBody(Context, D->getParent(), D->getParent())) { +return true; I'

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

2015-08-21 Thread Naomi Musgrave via cfe-commits
nmusgrave updated this revision to Diff 32873. nmusgrave marked 2 inline comments as done. nmusgrave added a comment. - Poisoning on field-by-field basis, with collective poisoning of trivial members when possible. - Cleaned up implementation of calculating region to poison in dtor. http://revi

[PATCH] D12251: Analyzer: Calculate field offset correctly

2015-08-21 Thread Ismail Pazarbasi via cfe-commits
ismailp created this revision. ismailp added reviewers: krememek, zaks.anna. ismailp added a subscriber: cfe-commits. `StoreManager::getLValueFieldOrIvar` should return loc as base + field-offset, instead of just base. http://reviews.llvm.org/D12251 Files: lib/StaticAnalyzer/Core/Store.cpp t

Re: [PATCH] D11468: [Static Analyzer] The first implementation of nullability checker.

2015-08-21 Thread Gábor Horváth via cfe-commits
xazax.hun updated this revision to Diff 32869. xazax.hun added a comment. - Updated to the latest trunk. - Relaxed an assert in ExprEngine which turned out to be unsound. - The individual checks can be turned on or off. - Added some framework specific heuristic to reduce the number of false posit

LLVM buildmaster will be restarted tonight

2015-08-21 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

2015-08-21 Thread Sean Silva via cfe-commits
silvas added inline comments. Comment at: test/Modules/auto-module-import.m:89 @@ +88,3 @@ + expected-error {{import of module 'NoUmbrella.A' appears within function 'includeNotAtTopLevel'}} \ + expected-note {{consider ma

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

2015-08-21 Thread Richard Smith via cfe-commits
On Fri, Aug 21, 2015 at 10:35 AM, Michael Zolotukhin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Yes, I've considered a builitin as an alternative. In fact, I started with > it as it was easier to implement, but then decided to switch to type > attribute due to the following reasons: >

Re: [PATCH] D12123: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.

2015-08-21 Thread Devin Coughlin via cfe-commits
dcoughlin marked an inline comment as done. dcoughlin added a comment. http://reviews.llvm.org/D12123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12123: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.

2015-08-21 Thread Devin Coughlin via cfe-commits
dcoughlin updated this revision to Diff 32864. dcoughlin added a comment. Update comments to correct nil/non-nil mistakes. http://reviews.llvm.org/D12123 Files: include/clang/StaticAnalyzer/Core/Checker.h include/clang/StaticAnalyzer/Core/CheckerManager.h lib/StaticAnalyzer/Checkers/CallA

Re: [PATCH] D12047: test/SemaObjC: Remove cruft in unused getter test

2015-08-21 Thread Alexey Denisov via cfe-commits
AlexDenisov accepted this revision. AlexDenisov added a reviewer: AlexDenisov. AlexDenisov added a comment. This revision is now accepted and ready to land. Committed, r245731. http://reviews.llvm.org/D12047 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D11433: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events.

2015-08-21 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Please, commit this after committing the nullability checker so that this could have tests. Two tests need to be added: 1. the reference case 2. the attribute nonnull case Also, I'd suggest adding a field to ImplicitNullDerefEvent instead of creating a new event. h

r245731 - [SemaObjC] Remove unused code from test.

2015-08-21 Thread Alex Denisov via cfe-commits
Author: alexdenisov Date: Fri Aug 21 15:28:16 2015 New Revision: 245731 URL: http://llvm.org/viewvc/llvm-project?rev=245731&view=rev Log: [SemaObjC] Remove unused code from test. Patch by modocache (Brian Gesiak). Modified: cfe/trunk/test/SemaObjC/access-property-getter.m Modified: cfe/trun

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

2015-08-21 Thread Richard Smith via cfe-commits
On Fri, Aug 21, 2015 at 12:14 PM, Michael Zolotukhin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > mzolotukhin added a comment. > > Oh, I see. So, you meant something like this? > > void foo(std::vector av, float * > b, int N) { > for (auto a: av) // << `a` doesn't have nontemp

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

2015-08-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D12221#230263, @mzolotukhin wrote: > Oh, I see. So, you meant something like this? > > void foo(std::vector av, float * b, > int N) { > for (auto a: av) // << `a` doesn't have nontemporal attribute here > for (int i = 0;

r245727 - Revert "Generating assumption loads of vptr after ctor call (fixed)"

2015-08-21 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Fri Aug 21 14:49:41 2015 New Revision: 245727 URL: http://llvm.org/viewvc/llvm-project?rev=245727&view=rev Log: Revert "Generating assumption loads of vptr after ctor call (fixed)" Reverting because of 245721 This reverts commit 552658e2b60543c928030b09cc9b5dfcb40c3f28. Remo

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

2015-08-21 Thread Richard Smith via cfe-commits
rsmith added a comment. Thanks for the rework, the general approach here seems reasonable. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7680 @@ +7679,3 @@ +def err_omp_section_length_undefined : Error< + "section length is unspecified, but subscripted value is not an

Re: [PATCH] D11433: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events.

2015-08-21 Thread Gábor Horváth via cfe-commits
xazax.hun updated this revision to Diff 32854. xazax.hun added a comment. Only send implicit dereference events, when the null pointer was bound to a reference. http://reviews.llvm.org/D11433 Files: lib/StaticAnalyzer/Checkers/NonNullParamChecker.cpp Index: lib/StaticAnalyzer/Checkers/NonNu

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

2015-08-21 Thread Michael Zolotukhin via cfe-commits
mzolotukhin added a comment. Oh, I see. So, you meant something like this? void foo(std::vector av, float * b, int N) { for (auto a: av) // << `a` doesn't have nontemporal attribute here for (int i = 0; i < N; i++) a[i] = b[i]+1; } One can easily work around it by usi

r245721 - Generating assumption loads of vptr after ctor call (fixed)

2015-08-21 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Fri Aug 21 13:28:00 2015 New Revision: 245721 URL: http://llvm.org/viewvc/llvm-project?rev=245721&view=rev Log: Generating assumption loads of vptr after ctor call (fixed) Generating call assume(icmp %vtable, %global_vtable) after constructor call for devirtualization purpose

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

2015-08-21 Thread Dan Albert via cfe-commits
danalbert added reviewers: mclow.lists, EricWF. danalbert added a comment. FYI this was found because it can cause issues when used with GCC. http://reviews.llvm.org/D12247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D12243: Properly provide alignment of 'byval' arguments down to llvm.

2015-08-21 Thread James Y Knight via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245719: Properly provide alignment of 'byval' arguments down to llvm. (authored by jyknight). Changed prior to commit: http://reviews.llvm.org/D12243?vs=32839&id=32847#toc Repository: rL LLVM http:/

r245719 - Properly provide alignment of 'byval' arguments down to llvm.

2015-08-21 Thread James Y Knight via cfe-commits
Author: jyknight Date: Fri Aug 21 13:19:06 2015 New Revision: 245719 URL: http://llvm.org/viewvc/llvm-project?rev=245719&view=rev Log: Properly provide alignment of 'byval' arguments down to llvm. This is important in the case that the LLVM-inferred llvm-struct alignment is not the same as the cl

[PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

2015-08-21 Thread Yiran Wang via cfe-commits
yiranwang created this revision. yiranwang added a subscriber: cfe-commits. In libc++, there are some usage of aligned_storage which uses "sizeof" bytes of raw data. This is problematic a bit, as the trailing padding area will be counted by "sizeof", and it leads to out of bound access. For exam

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

2015-08-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D12221#230187, @mzolotukhin wrote: > **Aaron**, > As far as I understand, type attributes doesn't result in such complications > (as opposed to type qualifiers, e.g. `__restrict__`). That is, it doesn't > change the canonical type, it o

Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

2015-08-21 Thread Hans Wennborg via cfe-commits
On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool wrote: > On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg wrote: >> >> +Saleem and Renato; maybe you can take a look? > > > Thanks for pointing this out! > > The patch is correct and pretty safe to apply for 3.7 I think since its a > simple bug fi

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

2015-08-21 Thread Samuel Antao via cfe-commits
sfantao added a comment. In http://reviews.llvm.org/D11361#229744, @ABataev wrote: > Another one thing I forget to mention. Current implementation of > CGOpenMPRuntime is libomp-specific. You're trying to add functionality that > is libtarget-specific. Maybe it is a good idea to separate suppor

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

2015-08-21 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 32843. sfantao added a comment. Address reviewer concerns. http://reviews.llvm.org/D11361 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp test/OpenMP/target_codegen.cpp Index: test/OpenMP/target_cod

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

2015-08-21 Thread Michael Zolotukhin via cfe-commits
mzolotukhin added a comment. Hi all, Thanks for the feedback, please find my answers below: > What does it mean to have the attribute applied to non-pointer types like int > __attribute__((nontemporal)) i; ? The ACLE doesn't say but making it > erroneous might make sense. Perhaps it would be g

Re: [PATCH] D12240: [AArch64] Define the macro __ARM_FP16_ARGS

2015-08-21 Thread Ahmed Bougacha via cfe-commits
ab added a subscriber: ab. ab accepted this revision. ab added a reviewer: ab. ab added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D12240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12243: Properly provide alignment of 'byval' arguments down to llvm.

2015-08-21 Thread David Majnemer via cfe-commits
majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D12243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D12244: Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64] targets

2015-08-21 Thread Alexandros Lamprineas via cfe-commits
labrinea created this revision. labrinea added subscribers: cfe-commits, llvm-commits. Herald added subscribers: rengolin, aemerson. Implementation and testing of ACLE 2.0 macros, for details see the above document: [[ http://infocenter.arm.com/help/topic/com.arm.doc.ihi0053c/IHI0053C_acle_2_0.p

[PATCH] D12243: Properly provide alignment of 'byval' arguments down to llvm.

2015-08-21 Thread James Y Knight via cfe-commits
jyknight created this revision. jyknight added a reviewer: majnemer. jyknight added a subscriber: cfe-commits. This is important in the case that the LLVM-inferred llvm-struct alignment is not the same as the clang-known C-struct alignment. http://reviews.llvm.org/D12243 Files: lib/CodeGen/CGC

Re: [PATCH] D12109: [WinEH] Update to new EH pad/ret signatures (with tokens required)

2015-08-21 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D12109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

2015-08-21 Thread Josh Gao via cfe-commits
jmgao marked 4 inline comments as done. jmgao added a comment. http://reviews.llvm.org/D12181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

2015-08-21 Thread Josh Gao via cfe-commits
jmgao marked an inline comment as done. Comment at: lib/CodeGen/CGExpr.cpp:2303 @@ -2302,4 +2302,3 @@ - if (TrapCond) -EmitTrapCheck(TrapCond); + if (TrapCond) EmitSanitizeTrapCheck(TrapCond); if (!FatalCond && !RecoverableCond) Yes http://reviews.llv

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

2015-08-21 Thread Josh Gao via cfe-commits
jmgao updated this revision to Diff 32833. jmgao added a comment. Remove more `\brief`s http://reviews.llvm.org/D12181 Files: docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h lib/Fronten

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

2015-08-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This doesn't seem like a fundamental property of a type, to me. If I understand properly, this has more to do with specific instances of memory access. By making it part

r245706 - Fix typo - symetric -> symmetric.

2015-08-21 Thread Eric Christopher via cfe-commits
Author: echristo Date: Fri Aug 21 11:24:01 2015 New Revision: 245706 URL: http://llvm.org/viewvc/llvm-project?rev=245706&view=rev Log: Fix typo - symetric -> symmetric. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp Modified: cfe/trunk/lib/Sema/SemaOverload.cpp URL: http://llvm.org/viewvc/ll

Re: [PATCH] D11976: [libclang] Return deduced type for auto type, not the one written in the source.

2015-08-21 Thread Oleksandr Senkovych via cfe-commits
blackjack added a subscriber: blackjack. blackjack added a comment. With this patch applied, class variables type is printed as : http://i.imgur.com/CXHnjwJ.png http://reviews.llvm.org/D11976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

2015-08-21 Thread Samuel Benzaquen via cfe-commits
sbenza added inline comments. Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:20 @@ +19,3 @@ + const auto* CallMove = result.Nodes.getNodeAs("call-move"); + if (CallMove->getNumArgs() != 1) return; + const Expr* Arg = CallMove->getArg(0); You can move

[PATCH] D12240: [AArch64] Define the macro __ARM_FP16_ARGS

2015-08-21 Thread Keith Walker via cfe-commits
keith.walker.arm created this revision. keith.walker.arm added reviewers: olista01, rengolin, cfe-commits. Herald added subscribers: rengolin, aemerson. The ACLE (ARM C Language Extensions) 2.0 defines that the predefined macro __ARM_FP16_ARGS should be defined if __fp16 can be used as an argument

Re: [PATCH] D12109: [WinEH] Update to new EH pad/ret signatures (with tokens required)

2015-08-21 Thread Joseph Tremoulet via cfe-commits
JosephTremoulet updated this revision to Diff 32831. JosephTremoulet added a comment. rebase http://reviews.llvm.org/D12109 Files: lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGException.cpp lib/CodeGen/MicrosoftCXXABI.cpp Index: lib/CodeGen/MicrosoftCXXABI.cpp

Re: [PATCH] D12231: Add use-auto check to modernize module.

2015-08-21 Thread Angel Garcia via cfe-commits
angelgarcia closed this revision. angelgarcia added a comment. Committed revision 245703. http://reviews.llvm.org/D12231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r245703 - [clang-tidy] Migrate UseAuto from clang-modernize to clang-tidy.

2015-08-21 Thread Angel Garcia Gomez via cfe-commits
Author: angelgarcia Date: Fri Aug 21 10:08:51 2015 New Revision: 245703 URL: http://llvm.org/viewvc/llvm-project?rev=245703&view=rev Log: [clang-tidy] Migrate UseAuto from clang-modernize to clang-tidy. http://reviews.llvm.org/D12231 Added: clang-tools-extra/trunk/clang-tidy/modernize/UseAut

Re: [PATCH] D12231: Add use-auto check to modernize module.

2015-08-21 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D12231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[clang-tools-extra] r245701 - Test commit!

2015-08-21 Thread Angel Garcia Gomez via cfe-commits
Author: angelgarcia Date: Fri Aug 21 08:55:16 2015 New Revision: 245701 URL: http://llvm.org/viewvc/llvm-project?rev=245701&view=rev Log: Test commit! Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrC

Re: [PATCH] D12234: [mips][p5600] Add -mcpu=p5600 option.

2015-08-21 Thread Simon Atanasyan via cfe-commits
atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D12234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

r245698 - Remove unused diagnostic.

2015-08-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Aug 21 07:29:47 2015 New Revision: 245698 URL: http://llvm.org/viewvc/llvm-project?rev=245698&view=rev Log: Remove unused diagnostic. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td URL: http

r245700 - [RecordLayoutBuilder] Remove duplicated diagnostic argument. NFC.

2015-08-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Aug 21 07:51:01 2015 New Revision: 245700 URL: http://llvm.org/viewvc/llvm-project?rev=245700&view=rev Log: [RecordLayoutBuilder] Remove duplicated diagnostic argument. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/AST/RecordLayout

[clang-tools-extra] r245699 - [clang-tidy] Remove check_clang_tidy.sh that has been replaced with check_clang_tidy.py.

2015-08-21 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Fri Aug 21 07:41:14 2015 New Revision: 245699 URL: http://llvm.org/viewvc/llvm-project?rev=245699&view=rev Log: [clang-tidy] Remove check_clang_tidy.sh that has been replaced with check_clang_tidy.py. Removed: clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.sh

Re: [PATCH] D12231: Add use-auto check to modernize module.

2015-08-21 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 32818. angelgarcia added a comment. Fix comments: change warning message and minor fixes. http://reviews.llvm.org/D12231 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseAutoCheck.cpp

[PATCH] D12234: [mips][p5600] Add -mcpu=p5600 option.

2015-08-21 Thread Daniel Sanders via cfe-commits
dsanders created this revision. dsanders added reviewers: vkalintiris, atanasyan. dsanders added a subscriber: cfe-commits. dsanders added a dependency: D12193: [mips][p5600] Added P5600 processor and initial scheduler.. Depends on D12193 http://reviews.llvm.org/D12234 Files: lib/Basic/Target

Re: [PATCH] D12231: Add use-auto check to modernize module.

2015-08-21 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:45 @@ +44,3 @@ + + // The following test is based on DeclPrinter::VisitVarDecl() or find if an + // initializer is implicit or not. I can't parse it with 'or'. Did you mean something

r245697 - [OPENMP 4.1] Add codegen for 'simdlen' clause.

2015-08-21 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Aug 21 07:19:04 2015 New Revision: 245697 URL: http://llvm.org/viewvc/llvm-project?rev=245697&view=rev Log: [OPENMP 4.1] Add codegen for 'simdlen' clause. Add emission of metadata for simd loops in presence of 'simdlen' clause. If 'simdlen' clause is provided without 'saf

Re: [PATCH] D12231: Add use-auto check to modernize module.

2015-08-21 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 32816. angelgarcia added a comment. Apply clang-format to the code. http://reviews.llvm.org/D12231 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseAutoCheck.cpp clang-tidy/modernize

Re: [PATCH] D12231: Add use-auto check to modernize module.

2015-08-21 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 32815. angelgarcia marked 10 inline comments as done. angelgarcia added a comment. Fix comments. I did not include the 'hasDeclaration()" call in the 'standardIterator' function because its return type is internal::PolymorphicMatcherWithParam1< internal:

r245694 - clang-format: Be more conservative about specially indenting blocks in C++.

2015-08-21 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Fri Aug 21 06:44:57 2015 New Revision: 245694 URL: http://llvm.org/viewvc/llvm-project?rev=245694&view=rev Log: clang-format: Be more conservative about specially indenting blocks in C++. This is a bit of a step back of what we did in r222531, as there are some corner cases

r245693 - [OPENMP 4.1] Add ast-print tests for 'val', 'uval' and 'ref' modifiers.

2015-08-21 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Aug 21 06:32:42 2015 New Revision: 245693 URL: http://llvm.org/viewvc/llvm-project?rev=245693&view=rev Log: [OPENMP 4.1] Add ast-print tests for 'val', 'uval' and 'ref' modifiers. Modified: cfe/trunk/test/OpenMP/simd_ast_print.cpp Modified: cfe/trunk/test/OpenMP/sim

r245692 - [OPENMP 4.1] Initial support for 'simdlen' clause.

2015-08-21 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Aug 21 06:14:16 2015 New Revision: 245692 URL: http://llvm.org/viewvc/llvm-project?rev=245692&view=rev Log: [OPENMP 4.1] Initial support for 'simdlen' clause. Add parsing/sema analysis for 'simdlen' clause in simd directives. Also add check that if both 'safelen' and 'si

Re: [PATCH] D12231: Add use-auto check to modernize module.

2015-08-21 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:45 @@ +44,3 @@ + + // The following test is based on DeclPrinter::VisitVarDecl() o find if an + // initializer is implicit o not. s/o find/to find/? s/o not/or not/? ==

Re: [clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.

2015-08-21 Thread Yaron Keren via cfe-commits
Whenever is any special character in the filename, such as space or backslash (Windows), some examples: On Windows: --- ".\\a.cpp" 2015-08-21 00:22:57.885370200 +0300 +++ b.cpp 2015-08-21 01:05:28.726269900 +0300 --- ./a.cpp 2015-08-21 00:22:57.885370200 +0300 +++ b.cpp 2015-08-2

[clang-tools-extra] r245688 - Make test EOL tolerant by moving the symbol ot the first line

2015-08-21 Thread Yaron Keren via cfe-commits
Author: yrnkrn Date: Fri Aug 21 05:46:46 2015 New Revision: 245688 URL: http://llvm.org/viewvc/llvm-project?rev=245688&view=rev Log: Make test EOL tolerant by moving the symbol ot the first line before any EOL changes the byte offset count and enable it on Windows. Modified: clang-tools-extr

Re: [clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.

2015-08-21 Thread Alexander Kornienko via cfe-commits
On Fri, Aug 21, 2015 at 11:27 AM, Yaron Keren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: yrnkrn > Date: Fri Aug 21 04:27:24 2015 > New Revision: 245683 > > URL: http://llvm.org/viewvc/llvm-project?rev=245683&view=rev > Log: > Tweak clang-tidy-diff.py to recognize "filename" in

[PATCH] D12231: Add use-auto check to modernize module.

2015-08-21 Thread Angel Garcia via cfe-commits
angelgarcia created this revision. angelgarcia added a reviewer: alexfh. angelgarcia added subscribers: cfe-commits, klimek. angelgarcia changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Migrate UseAuto from clang-modernize to clang-tidy. http

r245685 - [CMake][Standalone] Detect Python. Python is used for Lit testing.

2015-08-21 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Fri Aug 21 04:38:46 2015 New Revision: 245685 URL: http://llvm.org/viewvc/llvm-project?rev=245685&view=rev Log: [CMake][Standalone] Detect Python. Python is used for Lit testing. Modified: cfe/trunk/CMakeLists.txt Modified: cfe/trunk/CMakeLists.txt URL: http://llvm.org

r245684 - Untabify.

2015-08-21 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Fri Aug 21 04:37:53 2015 New Revision: 245684 URL: http://llvm.org/viewvc/llvm-project?rev=245684&view=rev Log: Untabify. Modified: cfe/trunk/CMakeLists.txt Modified: cfe/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=245684&

[clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.

2015-08-21 Thread Yaron Keren via cfe-commits
Author: yrnkrn Date: Fri Aug 21 04:27:24 2015 New Revision: 245683 URL: http://llvm.org/viewvc/llvm-project?rev=245683&view=rev Log: Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput. Modified: clang-tools-extra/trunk/clang-tidy/tool/clang-tidy-diff.py Modified: clang-tool

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

2015-08-21 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Another one thing I forget to mention. Current implementation of CGOpenMPRuntime is libomp-specific. You're trying to add functionality that is libtarget-specific. Maybe it is a good idea to separate support for libomp and libtarget runtime libraries? http://reviews.l

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

2015-08-21 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2887 @@ +2886,3 @@ +llvm::Value * +CGOpenMPRuntime::emitTargetOutlinedFunction(CodeGenFunction &CGF, +const OMPExecutableDirective &D, I don't th

r245679 - Expand mingw-long-double.c to test for long double alignment.

2015-08-21 Thread Yaron Keren via cfe-commits
Author: yrnkrn Date: Fri Aug 21 03:26:31 2015 New Revision: 245679 URL: http://llvm.org/viewvc/llvm-project?rev=245679&view=rev Log: Expand mingw-long-double.c to test for long double alignment. Added: cfe/trunk/test/CodeGen/mingw-long-double.c Removed: cfe/trunk/test/CodeGen/mingw-long-

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

2015-08-21 Thread Yaron Keren via cfe-commits
The testcase from r245459 was not reverted and still in SVN. 2015-08-21 2:05 GMT+03:00 Martell Malone : > I feel very silly now. > After testing the testcase again on svn it still works. > It appears the OP was looking for this patch to go onto the 3.6 branch and > was applying my patch to that.

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

2015-08-21 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. A few more comments. Comment at: test/clang-tidy/move-const-arg.cpp:1 @@ +1,2 @@ +// RUN: $(dirname %s)/check_clang_tidy.sh %s move-const-arg %t +// REQUIRES: shell Please use check_clang_tidy.py instead: // RUN: %python %S/check_clan