Hi Richard,
We wouldn't be able to link with libs matching libinker=*.{dylib,so,...},
I guess. If that is a big problem and you'd prefer that we keep this as a
private patch, let me know.
Thank you,
Filipe
On Mon, Aug 24, 2015 at 6:45 PM, Richard Smith rich...@metafoo.co.uk
wrote:
On Mon,
Guys, talking about implicitly captured variables we have to deal with 2
locations: 1) point of real capturing (it is the point of '=' or ''
symbols in lambda capture-list); 2) a point of first use of variable
inside lambda's body.
When we're talking about diagnostic for implicitly captured
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Looks good to me.
http://reviews.llvm.org/D12123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexfh added a comment.
Thanks! Still looks good.
http://reviews.llvm.org/D12321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
andreybokhanko updated this revision to Diff 33083.
andreybokhanko added a comment.
John,
I implemented precisely what you described (or so I believe :-))
Patch is updated; please re-review.
This patch implements support for functions, but not variables yet -- the patch
is big enough already,
Comparing the result of InitListExpr::getSyntacticForm between r224986
and r245836 I've discovered that integer to char implicit cast for
integer literal 3 is no longer added to AST for C++ (while it is present
in C).
This is the source used to test:
char v[10] = { 3 };
Taken in account that:
Looks like the initial mail didn't hit the mailing list? Does someone want
to restart this review and/or forward that initial mail with the
patch/description/etc?
On Mon, Aug 24, 2015 at 11:00 PM, Eric Christopher via cfe-commits
cfe-commits@lists.llvm.org wrote:
echristo added a comment.
Author: dnovillo
Date: Tue Aug 25 10:25:13 2015
New Revision: 245941
URL: http://llvm.org/viewvc/llvm-project?rev=245941view=rev
Log:
Convert SampleProfile pass into a Module pass.
Eventually, we will need sample profiles to be incorporated into the
inliner's cost models. To do this, we need
angelgarcia updated this revision to Diff 33081.
angelgarcia added a comment.
Add test.
http://reviews.llvm.org/D12321
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
test/clang-tidy/modernize-loop-convert-extra.cpp
Index: test/clang-tidy/modernize-loop-convert-extra.cpp
Author: abataev
Date: Tue Aug 25 09:24:04 2015
New Revision: 245937
URL: http://llvm.org/viewvc/llvm-project?rev=245937view=rev
Log:
[OPENMP 4.0] Initial support for array sections.
Adds parsing/sema analysis/serialization/deserialization for array sections in
OpenMP constructs (introduced in
On Tue, Aug 18, 2015 at 9:05 PM, Alexey Bataev via cfe-commits
cfe-commits@lists.llvm.org wrote:
ABataev created this revision.
ABataev added reviewers: echristo, rjmccall, rsmith.
ABataev added a subscriber: cfe-commits.
When variables are implicitly captured in lambdas, debug info
I though about this. I think it will be more convenient for user to see
the diagnostic on the first use of the variable rather than on '=' or
'' symbol.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
25.08.2015 18:07, David Blaikie пишет:
On Tue, Aug 18,
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a comment.
Comment at: test/clang-tidy/modernize-loop-convert-extra.cpp:636
@@ +635,3 @@
+ SE = container.end(); SI != SE; ++SI) {
+ }
+}
Author: abataev
Date: Tue Aug 25 10:15:12 2015
New Revision: 245939
URL: http://llvm.org/viewvc/llvm-project?rev=245939view=rev
Log:
Fix possible crash on null base or type for array elements.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
cfe/trunk/test/OpenMP/task_depend_messages.cpp
rnk closed this revision.
rnk added a comment.
Looks like this landed as r245817.
http://reviews.llvm.org/D12137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: xazax
Date: Tue Aug 25 11:38:05 2015
New Revision: 245951
URL: http://llvm.org/viewvc/llvm-project?rev=245951view=rev
Log:
[Static Analyzer] Fix tests to reflect the change in the diagnostic message.
Modified:
cfe/trunk/test/Analysis/generics.m
Modified:
Debug info points to the real place where it is captured, while
diagnostics points to the first use of implicitly captured variable.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
25.08.2015 18:22, David Blaikie пишет:
On Tue, Aug 25, 2015 at 8:18 AM,
Author: majnemer
Date: Tue Aug 25 11:44:38 2015
New Revision: 245953
URL: http://llvm.org/viewvc/llvm-project?rev=245953view=rev
Log:
[Sema] Handle leading and trailing __ for GNU attributes
GNU attributes can have a leading and trailing __ appended/prepended to
the attribute name. While the
Author: angelgarcia
Date: Tue Aug 25 10:44:00 2015
New Revision: 245942
URL: http://llvm.org/viewvc/llvm-project?rev=245942view=rev
Log:
Avoid LoopConvertCheck replacements in template instantiations.
Summary: Prevent LoopConvertCheck from doing replacements in template
instantiations, and add
filcab updated this revision to Diff 33085.
filcab marked 3 inline comments as done.
filcab added a comment.
Addressed comments.
http://reviews.llvm.org/D11737
Files:
include/clang/Driver/Options.td
test/Driver/fuse-ld.c
Index: test/Driver/fuse-ld.c
pcc updated this revision to Diff 33175.
pcc added a comment.
- Add apology for lack of documentation
http://reviews.llvm.org/D11857
Files:
docs/ControlFlowIntegrity.rst
docs/ControlFlowIntegrityDesign.rst
include/clang/AST/Mangle.h
include/clang/Basic/Sanitizers.def
EricWF updated this revision to Diff 33179.
EricWF added a comment.
Remove all functions in the dylib and make them inline.
http://reviews.llvm.org/D12354
Files:
include/__debug
include/algorithm
include/regex
src/debug.cpp
test/libcxx/algorithms/debug_less.pass.cpp
Author: kremenek
Date: Tue Aug 25 22:11:31 2015
New Revision: 246003
URL: http://llvm.org/viewvc/llvm-project?rev=246003view=rev
Log:
Add missing newline.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246005: Modify DeclaratorChuck::getFunction to be passed an
Exception Specification… (authored by nwilson).
Changed prior to commit:
http://reviews.llvm.org/D11789?vs=33093id=33177#toc
Repository:
Author: nwilson
Date: Tue Aug 25 23:19:36 2015
New Revision: 246005
URL: http://llvm.org/viewvc/llvm-project?rev=246005view=rev
Log:
Modify DeclaratorChuck::getFunction to be passed an Exception Specification
SourceRange
Summary:
- Store the exception specification range's begin and end
Author: echristo
Date: Tue Aug 25 23:23:11 2015
New Revision: 246006
URL: http://llvm.org/viewvc/llvm-project?rev=246006view=rev
Log:
Update file comment to more accurately describe what's implemented.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
Author: majnemer
Date: Wed Aug 26 00:13:19 2015
New Revision: 246014
URL: http://llvm.org/viewvc/llvm-project?rev=246014view=rev
Log:
[Sema] Don't assume CallExpr::getDirectCallee will succeed
We tried to provide a very nice diagnostic when diagnosing an assignment
to a const int produced by a
EricWF updated this revision to Diff 33180.
EricWF added a comment.
Cleanup the diff and remove extra changes.
http://reviews.llvm.org/D12354
Files:
include/__debug
include/algorithm
test/libcxx/algorithms/debug_less.pass.cpp
test/support/debug_mode.h
Index: test/support/debug_mode.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245923: [X86] Expose the various _rot intrinsics on non-MS
platforms (authored by mkuper).
Changed prior to commit:
http://reviews.llvm.org/D12271?vs=32925id=33050#toc
Repository:
rL LLVM
Author: mkuper
Date: Tue Aug 25 02:21:33 2015
New Revision: 245923
URL: http://llvm.org/viewvc/llvm-project?rev=245923view=rev
Log:
[X86] Expose the various _rot intrinsics on non-MS platforms
_rotl, _rotwl and _lrotl (and their right-shift counterparts) are official x86
intrinsics, and should
labrinea updated this revision to Diff 33054.
labrinea added a comment.
_ARM_FP16_FORMAT_IEEE and _ARM_FP16_ARGS should be defined unconditionally.
When hardware does not support them library calls are emitted.
http://reviews.llvm.org/D12244
Files:
lib/Basic/Targets.cpp
Author: angelgarcia
Date: Tue Aug 25 03:39:34 2015
New Revision: 245926
URL: http://llvm.org/viewvc/llvm-project?rev=245926view=rev
Log:
Tests no longer need the 'REQUIRES: SHELL' line.
Summary: Update python script, so that it doesn't print that line in new tests.
Reviewers: alexfh
echristo added a comment.
How about:
13. [apple,
14. banana,
15. cherry]{
16. printf(apple = %d\n,apple);
17. printf(banana = %d\n,banana);
18. printf(cherry = %d\n,cherry);
Should be 13, 14, 15 yes?
-eric
http://reviews.llvm.org/D12134
___
silvas added a subscriber: silvas.
silvas added a comment.
In http://reviews.llvm.org/D12271#231204, @rnk wrote:
This looks good.
As a larger issue, LLVM fast isel definitely won't pattern match this series
of shifts and selects to rotl at -O0. There are some users who want
branchless
awi added a subscriber: awi.
awi added a comment.
Hello,
I like your patch very much. I looks similar to my patch from January, so I am
confident it solves my problem, but it does so a little more elegantly at some
places.
I tried it with my two sources files main.cpp and main2.cpp. While
nmusgrave updated this revision to Diff 33100.
nmusgrave marked an inline comment as done.
nmusgrave added a comment.
- Check flags before dtor sanitizing
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
nwilson added a comment.
Ping
http://reviews.llvm.org/D11789
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nwilson updated this revision to Diff 33093.
http://reviews.llvm.org/D11789
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/DeclSpec.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseExpr.cpp
lib/Parse/ParseExprCXX.cpp
lib/Sema/DeclSpec.cpp
lib/Sema/SemaDecl.cpp
rjmccall added a comment.
You should add a test that actually checks that your feature works.
Comment at: lib/CodeGen/CGClass.cpp:1279
@@ +1278,3 @@
+ if (CGM.getCodeGenOpts().StrictVPtrs BaseVPtrsInitialized)
+CXXThisValue =
sepavloff created this revision.
sepavloff added a subscriber: cfe-commits.
Instantiation of static class members can be not obvious in some cases. Using
modules can cause problems even more difficult to diagnose. PR24425 describes
one of such cases. As a way to assist a user, compiler could
Author: nico
Date: Tue Aug 25 13:43:32 2015
New Revision: 245965
URL: http://llvm.org/viewvc/llvm-project?rev=245965view=rev
Log:
Revert r245879. Speculative, might have caused crbug.com/524604
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trunk/lib/CodeGen/CGCall.h
jroelofs accepted this revision.
This revision is now accepted and ready to land.
Comment at: CMakeLists.txt:105
@@ +104,3 @@
+if (${CMAKE_SYSTEM_NAME} MATCHES Darwin AND NOT
LIBCXX_OVERRIDE_DARWIN_INSTALL)
+ if (${CMAKE_INSTALL_PREFIX} STREQUAL /usr)
+message(WARNING
rjmccall added a comment.
This looks generally like what I'm looking for, thanks! Some comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:1129
@@ +1128,3 @@
+if (GV GV != GetGlobalValue(getMangledName(D)))
+ continue;
+
This is a pretty expensive
RKSimon created this revision.
RKSimon added reviewers: echristo, mkuper, silvas, craig.topper.
RKSimon added a subscriber: cfe-commits.
RKSimon set the repository for this revision to rL LLVM.
Follow up to D12272
This adds the missing 3dnow intrinsics _m_to_float / _m_from_float and removes
On Tue, Aug 25, 2015 at 1:39 PM, Filipe Cabecinhas
filcab+llvm.phabrica...@gmail.com wrote:
Hi Richard,
On Tue, Aug 25, 2015 at 11:01 AM, Richard Smith rich...@metafoo.co.uk
wrote:
On Aug 25, 2015 10:26 AM, Filipe Cabecinhas
filcab+llvm.phabrica...@gmail.com wrote:
Hi Richard,
We
ayartsev updated this revision to Diff 33134.
http://reviews.llvm.org/D9040
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/malloc.c
Index: test/Analysis/malloc.c
===
--- test/Analysis/malloc.c
+++
ayartsev added a comment.
Please review!
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:158
@@ +157,3 @@
+/// zero-allocated memory returned by 'realloc(ptr, 0)'.
+struct ReallocSizeZero {
+ void Profile(llvm::FoldingSetNodeID ID) const {
zaks.anna
Author: nicholas
Date: Tue Aug 25 17:33:16 2015
New Revision: 245985
URL: http://llvm.org/viewvc/llvm-project?rev=245985view=rev
Log:
Make sure that we evaluate __attribute__((enable_if)) on a method with no
overloads. Patch by Ettore Speziale!
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
eugenis added inline comments.
Comment at: lib/CodeGen/CGCXX.cpp:31
@@ -30,1 +30,3 @@
+static bool HasTrivialField(CodeGenModule CGM, const CXXDestructorDecl *D) {
+ for (const auto *Field : D-getParent()-fields())
I think this should be called
Hi Richard,
On Tue, Aug 25, 2015 at 11:01 AM, Richard Smith rich...@metafoo.co.uk
wrote:
On Aug 25, 2015 10:26 AM, Filipe Cabecinhas
filcab+llvm.phabrica...@gmail.com wrote:
Hi Richard,
We wouldn't be able to link with libs matching
libinker=*.{dylib,so,...}, I guess. If that is a
george.burgess.iv updated this revision to Diff 33104.
george.burgess.iv added a comment.
Talked with Richard, and we both agree that adding 4 EvaluationModes is too
much for the use case. So, we decided to add a flag to LValue to denote that
the LValueBase is invalid. This allows us to get by
sfantao updated this revision to Diff 33111.
sfantao added a comment.
Move map type and device id enums from CGOpenMPRuntime.h to CGOpenMPRuntime.cpp.
http://reviews.llvm.org/D11361
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
sfantao added a comment.
Thanks for the review!
In http://reviews.llvm.org/D11361#232045, @ABataev wrote:
Samuel, Yes, I thought about different files and different classes. Runtime
for offloading codegen is not a part of libomp and it would be good to have
separate runtime handler class
Yes, you're right, and it will be 13, 14, 15. It is implemented already
and this patch does not break this.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
25.08.2015 9:00, Eric Christopher пишет:
echristo added a comment.
How about:
13. [apple,
14. banana,
Author: mkuper
Date: Tue Aug 25 06:42:31 2015
New Revision: 245929
URL: http://llvm.org/viewvc/llvm-project?rev=245929view=rev
Log:
Revert r245923 since it breaks mingw.
Removed:
cfe/trunk/test/CodeGen/x86-rot-intrinsics.c
Modified:
cfe/trunk/lib/Headers/Intrin.h
dcoughlin added a comment.
Thanks for adding handling of the symbolic cases! Some more comments inline.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:825
@@ -816,1 +824,3 @@
+ProgramStateRef CStringChecker::IsFirstBufInBound(CheckerContext C,
+
mkuper added inline comments.
Comment at: lib/Headers/Intrin.h:961
@@ +960,3 @@
+static __inline__ void __DEFAULT_FN_ATTRS _lgdt(void *__ptr) {
+ __builtin_ia32_lgdt(__ptr);
+}
compnerd wrote:
Why does this need a builtin? Is an inline assembly block using
xazax.hun updated this revision to Diff 33151.
xazax.hun marked 30 inline comments as done.
xazax.hun added a comment.
Addressed the comments.
Added some more tests.
Added a design document.
http://reviews.llvm.org/D11468
Files:
docs/analyzer/nullability.rst
Author: ab
Date: Tue Aug 25 18:42:55 2015
New Revision: 245992
URL: http://llvm.org/viewvc/llvm-project?rev=245992view=rev
Log:
[Headers] Require x86-registered for r245987 codegen tests.
Modified:
cfe/trunk/test/CodeGen/avx2-builtins.c
Modified: cfe/trunk/test/CodeGen/avx2-builtins.c
URL:
On Tue, Aug 25, 2015 at 3:51 PM Hal Finkel hfin...@anl.gov wrote:
Hi Eric,
Can you please update the test case for this change?
Hmm? The testcases are pretty exhaustive and should be checking exactly
what's here. (i.e. I don't expect a functional change).
-eric
Thanks again,
Hal
-
Hi Eric,
Can you please update the test case for this change?
Thanks again,
Hal
- Original Message -
From: Eric Christopher via cfe-commits cfe-commits@lists.llvm.org
To: cfe-commits@lists.llvm.org
Sent: Monday, August 24, 2015 7:59:11 PM
Subject: r245914 - Reimplement the PPC
- Original Message -
From: Eric Christopher echri...@gmail.com
To: Hal Finkel hfin...@anl.gov
Cc: cfe-commits@lists.llvm.org
Sent: Tuesday, August 25, 2015 5:51:50 PM
Subject: Re: r245914 - Reimplement the PPC explicit option checking to be a
bit more obvious
On Tue, Aug 25, 2015
ahatanak created this revision.
ahatanak added a reviewer: vsk.
ahatanak added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
This patch corrects http://reviews.llvm.org/D12155, which didn't take into
account the fact that aapcs ABI can be selected on darwin platforms.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245987: [Headers][X86] Add -O0 assembly tests for avx2
intrinsics. (authored by ab).
Changed prior to commit:
http://reviews.llvm.org/D12212?vs=32732id=33147#toc
Repository:
rL LLVM
Author: ab
Date: Tue Aug 25 18:09:05 2015
New Revision: 245987
URL: http://llvm.org/viewvc/llvm-project?rev=245987view=rev
Log:
[Headers][X86] Add -O0 assembly tests for avx2 intrinsics.
We agreed for r245605 that, as long as we don't affect -O0 codegen
too much, it's OK to use native constructs
vsk added a comment.
Yep, this looks fine. Out of curiosity, what happens if we permit the MachO +
!useAAPCS + FloatABI=hard case?
http://reviews.llvm.org/D12344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: rksimon
Date: Tue Aug 25 16:27:46 2015
New Revision: 245975
URL: http://llvm.org/viewvc/llvm-project?rev=245975view=rev
Log:
[X86] Remove unnecessary MMX declarations from Intrin.h
As discussed in PR23648 - the intrinsics _m_from_int, _m_to_int and _m_prefetch
are defined in mmintrin.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245975: [X86] Remove unnecessary MMX declarations from
Intrin.h (authored by RKSimon).
Changed prior to commit:
http://reviews.llvm.org/D12272?vs=32926id=33124#toc
Repository:
rL LLVM
angelgarcia updated this revision to Diff 33066.
angelgarcia added a comment.
Use the full message once in the test, and truncate all the other patterns.
http://reviews.llvm.org/D12287
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
Author: djasper
Date: Tue Aug 25 08:40:51 2015
New Revision: 245934
URL: http://llvm.org/viewvc/llvm-project?rev=245934view=rev
Log:
clang-format: Add space before member function reference qualifiers.
Before:
SomeType MemberFunction(const Deleted );
After:
SomeType MemberFunction(const
Author: echristo
Date: Tue Aug 25 08:45:24 2015
New Revision: 245935
URL: http://llvm.org/viewvc/llvm-project?rev=245935view=rev
Log:
Extract handling of user defined features into a function so we can
specialize it on the targets.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
rsmith added inline comments.
Comment at: include/clang/Basic/Attr.td:2074-2078
@@ +2073,7 @@
+ let Documentation = [OMPDeclareSimdDocs];
+ let AdditionalMembers = [{
+ void printPrettyPragma(raw_ostream OS, const PrintingPolicy Policy) const {
+OS \n;
+ }
+ }];
+}
72 matches
Mail list logo
