[PATCH] D12722: cortex-r5f and cortex-m4f are unknown names for clang

2015-09-09 Thread Alexandros Lamprineas via cfe-commits
labrinea created this revision. labrinea added reviewers: rengolin, richard.barton.arm. labrinea added a subscriber: cfe-commits. Tests are currently passing but warning messages are suppressed. http://reviews.llvm.org/D12722 Files: test/CodeGen/arm-target-features.c Index:

Re: [PATCH] D12722: cortex-r5f and cortex-m4f are unknown names for clang

2015-09-09 Thread Renato Golin via cfe-commits
rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. As required by http://reviews.llvm.org/D12692. LGTM, thanks! http://reviews.llvm.org/D12722 ___ cfe-commits mailing list

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

2015-09-09 Thread Alexandros Lamprineas via cfe-commits
labrinea added a comment. Ping http://reviews.llvm.org/D12633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12719: ScalarEvolution assume hanging bugfix

2015-09-09 Thread Sanjoy Das via cfe-commits
sanjoy added a comment. I don't think this is an infinite loop (Piotr, can you please verify this?), it is probably an O(n!) recursion where n == number of the assumptions. ScalarEvolution::isImpliedCond already guards for infinite loops via MarkPendingLoopPredicate. However, if you have

Re: [PATCH] D12719: ScalarEvolution assume hanging bugfix

2015-09-09 Thread Sanjoy Das via cfe-commits
> Both tests are protected by there being exactly one latch in the loop (we > exit early if there's not one latch). I'm not sure what makes the > LoopContinuePredicate check safer? You can have a loop with a single latch but an arbitrary number of assumes (= n). In such a loop, you'll still end

Re: [PATCH] D12725: [analyzer] A fix for substraction of an integer from a pointer.

2015-09-09 Thread Artem Dergachev via cfe-commits
NoQ updated this revision to Diff 34320. http://reviews.llvm.org/D12725 Files: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp test/Analysis/ptr-arith.c Index: test/Analysis/ptr-arith.c === --- test/Analysis/ptr-arith.c +++

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

2015-09-09 Thread Renato Golin via cfe-commits
rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:4785 @@ +4784,3 @@ +if (Opts.C99 && !Opts.Freestanding) { + Builder.defineMacro("__ARM_FP_FENV_ROUNDING", "1"); + Builder.defineMacro("__STDC_IEC_559__", "1"); I'm not convinced by

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

2015-09-09 Thread Alexandros Lamprineas via cfe-commits
labrinea added inline comments. Comment at: lib/Basic/Targets.cpp:4785 @@ +4784,3 @@ +if (Opts.C99 && !Opts.Freestanding) { + Builder.defineMacro("__ARM_FP_FENV_ROUNDING", "1"); + Builder.defineMacro("__STDC_IEC_559__", "1"); rengolin wrote: > I'm

r247144 - [Solaris] Use the GCC Installation detector to add the C++ include paths.

2015-09-09 Thread Rafael Espindola via cfe-commits
Author: rafael Date: Wed Sep 9 08:36:00 2015 New Revision: 247144 URL: http://llvm.org/viewvc/llvm-project?rev=247144=rev Log: [Solaris] Use the GCC Installation detector to add the C++ include paths. Patch by Xan López! Added: cfe/trunk/test/Driver/solaris-header-search.cpp Modified:

MPI-Checker patch for Clang Static Analyzer

2015-09-09 Thread Alexander Droste via cfe-commits
Hi, this is a patch to add static analysis functionality for MPI code written in C, in form of a checker to Clang's Static Analyzer. In comparison to the code currently published on GitHub https://github.com/0ax1/MPI-Checker I excluded the unmatched point-to-point call check, unreachable call

[PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

2015-09-09 Thread Artem Dergachev via cfe-commits
NoQ created this revision. NoQ added reviewers: zaks.anna, krememek. NoQ added subscribers: cfe-commits, dergachev.a. In Clang Static Analyzer, when the symbol is referenced by an index value of an element region, it does not prevent garbage collection (reaping) of that symbol. Hence, if the

Re: Preventing several replacements on a macro call.

2015-09-09 Thread Angel Garcia via cfe-commits
+cfe-commits On Tue, Sep 8, 2015 at 6:56 PM, Angel Garcia wrote: > Hi Ted, > > I was working on a clang-tidy check, and today I discovered that it was > unable to do several replacements in different arguments of the same macro > call. At first, I thought it was a bug,

[PATCH] D12732: Add a deprecation notice to the clang-modernize documentation.

2015-09-09 Thread Alexander Kornienko via cfe-commits
alexfh created this revision. alexfh added reviewers: klimek, revane. alexfh added a subscriber: cfe-commits. Add a deprecation notice to the clang-modernize documentation. Remove the reference to the external JIRA tracker. http://reviews.llvm.org/D12732 Files: docs/clang-modernize.rst

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

2015-09-09 Thread Renato Golin via cfe-commits
rengolin added reviewers: rsmith, t.p.northover. rengolin added a comment. Adding Richard Smith, as he was the one choosing C99/!freestanding for runtime rounding. Comment at: lib/Basic/Targets.cpp:4790 @@ -4779,1 +4789,3 @@ +if (!Opts.C11) +

[PATCH] D12736: [PATCH] AST traversal from types to decls

2015-09-09 Thread Aaron Ballman via cfe-commits
aaron.ballman created this revision. aaron.ballman added a reviewer: klimek. aaron.ballman added a subscriber: cfe-commits. Herald added a subscriber: klimek. The AST matching code that traverses from types to decls misses a lot of possible conversions. This patch adds all of the conversions I

[PATCH] D12734: Another patch for modernize-loop-convert.

2015-09-09 Thread Angel Garcia via cfe-commits
angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. 1. Avoid converting loops that iterate over the size of a container and don't use its elements, as this would result in an unused-result warning. 2. Never capture the

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

2015-09-09 Thread Rachel Craik via cfe-commits
rcraik updated this revision to Diff 34339. rcraik added a comment. I've updated the message to make it a bit clearer that this is a portability concern. Are there any further concerns with this patch? http://reviews.llvm.org/D10018 Files: include/clang/Basic/DiagnosticGroups.td

Re: r247049 - Module Debugging: Emit debug type information into clang modules.

2015-09-09 Thread Adrian Prantl via cfe-commits
> On Sep 8, 2015, at 8:05 PM, David Blaikie wrote: > > > > On Tue, Sep 8, 2015 at 12:20 PM, Adrian Prantl via cfe-commits > > wrote: > Author: adrian > Date: Tue Sep 8 14:20:27 2015 > New Revision: 247049 >

Re: [PATCH] D12505: [X86] Set MaxVectorAlign for non-Darwin targets as well.

2015-09-09 Thread Eric Christopher via cfe-commits
echristo added a comment. (This ACK btw means "yes we should do this on all platforms", not that it's necessarily safe on any platform, see my mail on the original thread). -eric http://reviews.llvm.org/D12505 ___ cfe-commits mailing list

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

2015-09-09 Thread Naomi Musgrave via cfe-commits
nmusgrave updated this revision to Diff 34373. nmusgrave added a comment. - Cleaned up impl. http://reviews.llvm.org/D12712 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/sanitize-dtor-derived-class.cpp test/CodeGenCXX/sanitize-dtor-vtable.cpp Index:

r247218 - Fix Clang-tidy misc-use-override warnings, other minor fixes

2015-09-09 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Sep 9 19:24:40 2015 New Revision: 247218 URL: http://llvm.org/viewvc/llvm-project?rev=247218=rev Log: Fix Clang-tidy misc-use-override warnings, other minor fixes Patch by Eugene Zelenko! Differential Revision: http://reviews.llvm.org/D12741 Modified:

Re: [PATCH] D12741: [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes

2015-09-09 Thread Hans Wennborg via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247218: Fix Clang-tidy misc-use-override warnings, other minor fixes (authored by hans). Changed prior to commit: http://reviews.llvm.org/D12741?vs=34385=34393#toc Repository: rL LLVM

Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

2015-09-09 Thread Dave Lee via cfe-commits
kastiglione added a comment. Thank you @klimek. http://reviews.llvm.org/D12471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10414: Attach function attribute "arm-restrict-it" instead of passing arm-restrict-it as a backend-option

2015-09-09 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 34379. ahatanak added a comment. Based on the feedback from reviewers for the llvm patch (http://reviews.llvm.org/D10416), I made changes to fix the handling of -mrestrict-it and -mno-restrict-it in the driver. The driver now passes subtarget feature

Re: r246229 - [X86] Conditionalize Darwin MaxVectorAlign on the presence of AVX.

2015-09-09 Thread Eric Christopher via cfe-commits
On Mon, Aug 31, 2015 at 4:03 PM Ahmed Bougacha wrote: > On Thu, Aug 27, 2015 at 7:19 PM, Eric Christopher > wrote: > >> Hi Ahmed, >> >> A quick note: I think this is going to fail in the presence of the target >> attribute. I.e. if someone decorates

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

2015-09-09 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good now. Thank you for the hard work! I'll commit the patch for you. http://reviews.llvm.org/D12462 ___ cfe-commits mailing list

[PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

2015-09-09 Thread Vedant Kumar via cfe-commits
vsk created this revision. vsk added reviewers: majnemer, rjmccall. vsk added a subscriber: cfe-commits. When personality function references were moved from LandingPadInst to Function, we forgot to update SimplifyPersonality(). This is an

Re: [PATCH] D12505: [X86] Set MaxVectorAlign for non-Darwin targets as well.

2015-09-09 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This seems reasonable to me, I can't see why it wouldn't be ok. Thanks! -eric http://reviews.llvm.org/D12505 ___ cfe-commits mailing list

[PATCH] D12739: [CUDA] Allow trivial constructors as initializer for __shared__ variables.

2015-09-09 Thread Artem Belevich via cfe-commits
tra created this revision. tra added reviewers: jingyue, eliben, wengxt, jholewinski. tra added a subscriber: cfe-commits. r245786 (D12241) disabled all initializers for __shared__ variables. It also prevents placement of records in __shared__ space as they have constructor as their

Re: [PATCH] D12741: [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes

2015-09-09 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D12741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r247203 - convert builtin_unpredictable on a switch into metadata for LLVM

2015-09-09 Thread Sanjay Patel via cfe-commits
Author: spatel Date: Wed Sep 9 17:39:06 2015 New Revision: 247203 URL: http://llvm.org/viewvc/llvm-project?rev=247203=rev Log: convert builtin_unpredictable on a switch into metadata for LLVM Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp cfe/trunk/test/CodeGen/builtin-unpredictable.c

r247207 - Fix access control for lookups using the Microsoft __super extension.

2015-09-09 Thread John McCall via cfe-commits
Author: rjmccall Date: Wed Sep 9 18:04:17 2015 New Revision: 247207 URL: http://llvm.org/viewvc/llvm-project?rev=247207=rev Log: Fix access control for lookups using the Microsoft __super extension. rdar://22464808 Added: cfe/trunk/test/SemaCXX/microsoft-super.cpp Modified:

r247209 - ARC: Fix the precise-lifetime suppression of returns_inner_pointer

2015-09-09 Thread John McCall via cfe-commits
Author: rjmccall Date: Wed Sep 9 18:37:17 2015 New Revision: 247209 URL: http://llvm.org/viewvc/llvm-project?rev=247209=rev Log: ARC: Fix the precise-lifetime suppression of returns_inner_pointer receiver extension for message sends via property syntax. rdar://22172983 Modified:

Re: [PATCH] D12741: [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes

2015-09-09 Thread Hans Wennborg via cfe-commits
hans added a comment. In http://reviews.llvm.org/D12741#242907, @hans wrote: > It seems this broke the build for some reason. I have reverted it in r247222. > > Example build breakages: > http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-fast/builds/11687/steps/compile/logs/stdio, >

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

2015-09-09 Thread Kostya Serebryany via cfe-commits
kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM with a nit Comment at: test/CodeGen/cfi-icall.c:1 @@ +1,2 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux -fsanitize=cfi-icall -fsanitize-trap=cfi-icall -emit-llvm -o -

r247222 - Revert r247218: "Fix Clang-tidy misc-use-override warnings, other minor fixes"

2015-09-09 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Sep 9 19:37:18 2015 New Revision: 247222 URL: http://llvm.org/viewvc/llvm-project?rev=247222=rev Log: Revert r247218: "Fix Clang-tidy misc-use-override warnings, other minor fixes" Seems it broke the Polly build. From

r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

2015-09-09 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Wed Sep 9 20:46:39 2015 New Revision: 247233 URL: http://llvm.org/viewvc/llvm-project?rev=247233=rev Log: EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC) This reapply a variant commit r247179 after post-commit review from D.Blaikie. Hopefully I

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

2015-09-09 Thread David Blaikie via cfe-commits
On Wed, Sep 9, 2015 at 6:46 PM, Mehdi Amini via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mehdi_amini > Date: Wed Sep 9 20:46:39 2015 > New Revision: 247233 > > URL: http://llvm.org/viewvc/llvm-project?rev=247233=rev > Log: > EmitRecord* API change: accepts ArrayRef instead of a

r247228 - Don't crash when emitting a block under returns_nonnull.

2015-09-09 Thread John McCall via cfe-commits
Author: rjmccall Date: Wed Sep 9 19:57:46 2015 New Revision: 247228 URL: http://llvm.org/viewvc/llvm-project?rev=247228=rev Log: Don't crash when emitting a block under returns_nonnull. rdar://22071955 Added: cfe/trunk/test/CodeGen/sanitize-blocks.c Modified:

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

2015-09-09 Thread Vedant Kumar via cfe-commits
vsk updated the summary for this revision. vsk updated this revision to Diff 34408. vsk added a comment. Thanks for the review. - Addressed if (!U) bug. - Added test which loads a personality function, confirmed that we crash without the proper `if (!F)' check. http://reviews.llvm.org/D12743

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

2015-09-09 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247238: CFI: Introduce -fsanitize=cfi-icall flag. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D11857?vs=33175=34403#toc Repository: rL LLVM http://reviews.llvm.org/D11857

r247238 - CFI: Introduce -fsanitize=cfi-icall flag.

2015-09-09 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Wed Sep 9 21:17:40 2015 New Revision: 247238 URL: http://llvm.org/viewvc/llvm-project?rev=247238=rev Log: CFI: Introduce -fsanitize=cfi-icall flag. This flag causes the compiler to emit bit set entries for functions as well as runtime bitset checks at indirect call sites.

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

2015-09-09 Thread hfin...@anl.gov via cfe-commits
hfinkel added a comment. In http://reviews.llvm.org/D11815#242616, @ahatanak wrote: > Hal, do you have any thoughts on the points Vasileios brought up? Currently, > many of the targets don't guarantee that the realigned stack is at least as > aligned as the default alignment required by the

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

2015-09-09 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. Hal, do you have any thoughts on the points Vasileios brought up? Currently, many of the targets don't guarantee that the realigned stack is at least as aligned as the default alignment required by the ABI. Is this the behavior end-users expect when they use

r247176 - [libclang] Add missing clang_CompileCommand_* functions in libclang.exports.

2015-09-09 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Wed Sep 9 13:54:16 2015 New Revision: 247176 URL: http://llvm.org/viewvc/llvm-project?rev=247176=rev Log: [libclang] Add missing clang_CompileCommand_* functions in libclang.exports. Modified: cfe/trunk/tools/libclang/libclang.exports Modified:

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

2015-09-09 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:4320-4325 @@ -4319,2 +4319,8 @@ "number of elements must be either one or match the size of the vector">; +def warn_bitfield_width_longer_than_necessary : Warning< + "size of bit-field %0 (%1

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

2015-09-09 Thread Naomi Musgrave via cfe-commits
nmusgrave updated this revision to Diff 34357. nmusgrave added a comment. - Fixed testing callback emission order to account for vptr. Vptr poisoned after all virtual and member destructors are invoked, in order to prevent a data race an on the virtual function invoked by a class instance.

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

2015-09-09 Thread Naomi Musgrave via cfe-commits
nmusgrave marked an inline comment as done. nmusgrave added a comment. http://reviews.llvm.org/D12712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

2015-09-09 Thread Mehdi Amini via cfe-commits
Hi David, Thanks for the review. > On Sep 9, 2015, at 1:14 PM, David Blaikie wrote: > > > > On Wed, Sep 9, 2015 at 1:08 PM, Mehdi Amini via cfe-commits > > wrote: > Author: mehdi_amini > Date: Wed Sep 9

r247183 - Revert "EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)"

2015-09-09 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Wed Sep 9 15:35:37 2015 New Revision: 247183 URL: http://llvm.org/viewvc/llvm-project?rev=247183=rev Log: Revert "EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)" This reverts commit r247179. From: Mehdi Amini

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

2015-09-09 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Thank you for the fixes. I really like this way of structuring the warnings more. We might need to polish the text in the messages a bit, and maybe also change the case without definitions, but overall this seems fine. I have a few more comments.

Re: [PATCH] D12627: Fix a small bug in clang where generating some temporary files would have an extra period before the extension.

2015-09-09 Thread Argyrios Kyrtzidis via cfe-commits
Committed in r247160, thanks! > On Sep 3, 2015, at 10:16 PM, Cameron Esfahani wrote: > > dirty created this revision. > dirty added a reviewer: akyrtzi. > dirty added a subscriber: cfe-commits. > > Fix a small bug in clang where generating some temporary files would >

RE: [PATCH] D12624: Top-level anonymous namespaces are missing import DW_TAG_imported_module and nested anonymous namespaces are not

2015-09-09 Thread Robinson, Paul via cfe-commits
This seems pretty fine-grained for a CodeGenOpt (not that I've looked there, perhaps there are examples of similarly fine grained things already there?)- I'm curious to understand the preference towards that rather than perhaps the more general "Debugger tuning" sort of thing Paul's

Re: [PATCH] D11797: [LIbClang] Report the named type for ElaboratedType

2015-09-09 Thread Sergey Kalinichev via cfe-commits
skalinichev updated this revision to Diff 34350. skalinichev added a comment. Yes, I've noticed that inconsistency too. But, seems like, this is an unrelated issue: TemplateSpecializationType type for some reasons uses id instead of qid (See also all other tests with templates in

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

2015-09-09 Thread Yiran Wang via cfe-commits
yiranwang added a comment. Thank you, Eric. Also, could you please help to commit the change? I personally do not have the permissions to change libc++ code, thanks a lot. http://reviews.llvm.org/D12247 ___ cfe-commits mailing list

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

2015-09-09 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a comment. On my understanding share contains architecture-independent files. clang-format files installation is also part of CMake build only. http://reviews.llvm.org/D12700 ___ cfe-commits mailing list

Re: [PATCH] D12624: Top-level anonymous namespaces are missing import DW_TAG_imported_module and nested anonymous namespaces are not

2015-09-09 Thread Adrian Prantl via cfe-commits
> On Sep 8, 2015, at 3:08 PM, Paul Robinson > wrote: > > probinson added inline comments. > > > Comment at: lib/CodeGen/CGDebugInfo.cpp:3263-3264 > @@ +3262,4 @@ > + const NamespaceDecl *NSDecl = UD.getNominatedNamespace(); > + if

Re: r247049 - Module Debugging: Emit debug type information into clang modules.

2015-09-09 Thread David Blaikie via cfe-commits
On Wed, Sep 9, 2015 at 9:26 AM, Adrian Prantl wrote: > > On Sep 8, 2015, at 8:05 PM, David Blaikie wrote: > > > > On Tue, Sep 8, 2015 at 12:20 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: adrian >> Date: Tue Sep 8

r247160 - Fix a small bug in clang where generating some temporary files would have an extra period before the extension.

2015-09-09 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Wed Sep 9 11:48:47 2015 New Revision: 247160 URL: http://llvm.org/viewvc/llvm-project?rev=247160=rev Log: Fix a small bug in clang where generating some temporary files would have an extra period before the extension. Patch by Cameron Esfahani! Modified:

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

2015-09-09 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Not sure whether the scripts should go to share/clang or some other place. Sylvestre should know what's the common practice. Also, configure builds are still used for building packages, AFAIU, so they have to be modified as well (preferably, in the same patch).

r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

2015-09-09 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Wed Sep 9 15:08:51 2015 New Revision: 247179 URL: http://llvm.org/viewvc/llvm-project?rev=247179=rev Log: EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC) From: Mehdi Amini Modified:

Re: [PATCH] D12128: Generating available_externally vtables bugfix

2015-09-09 Thread Piotr Padlewski via cfe-commits
Prazek accepted this revision. Prazek added a reviewer: Prazek. Prazek added a comment. This revision is now accepted and ready to land. Have to accept revision to close it http://reviews.llvm.org/D12128 ___ cfe-commits mailing list

Re: [PATCH] D12571: [Analyzer] Fix assertions in commit r246345 (pr22954).

2015-09-09 Thread pierre gousseau via cfe-commits
pgousseau added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:843 @@ +842,3 @@ + if (!Length) +return true; + dcoughlin wrote: > There doesn't seem to be a test that cares about this returning true (as > compared to false).

Re: [PATCH] D12571: [Analyzer] Fix assertions in commit r246345 (pr22954).

2015-09-09 Thread pierre gousseau via cfe-commits
pgousseau updated the summary for this revision. pgousseau updated this revision to Diff 34359. pgousseau added a comment. Following Devin's review: Correct test for unknown length and unknown destination buffer. Add comment to 'IsFirstBufInBound' behavior regarding unknown states. Remove

PATCH: Expose the 'file' that is associated with a compile database command

2015-09-09 Thread Argyrios Kyrtzidis via cfe-commits
Hi, The attached patch exposes the ‘file’ entry in a compilation database command, via the CompileCommand structure. compile_db_file.patch Description: Binary data ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

2015-09-09 Thread Evgeniy Stepanov via cfe-commits
eugenis added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1685 @@ +1684,3 @@ +// function +Poison(CGF, VTablePtr, PoisonSize); + } Did you mean to move this chunk to the other cleanup class? Is there a test that would fail if vptr is

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

2015-09-09 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12586 @@ -12585,3 +12585,3 @@ if (!FieldTy->isDependentType()) { uint64_t TypeSize = Context.getTypeSize(FieldTy); if (Value.getZExtValue() > TypeSize) { rsmith wrote: >

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

2015-09-09 Thread Piotr Dziwinski via cfe-commits
piotrdz updated this revision to Diff 34358. piotrdz marked 6 inline comments as done. piotrdz added a comment. Again, addressed all review issues. I hope this is the final version http://reviews.llvm.org/D12462 Files: clang-tidy/readability/CMakeLists.txt

Re: [PATCH] D12453: [CUDA] Allow function overloads based on host/device attributes.

2015-09-09 Thread Artem Belevich via cfe-commits
tra updated this revision to Diff 34368. tra added a comment. Implemented pcc@'s suggestion to disallow mixing HD and H/D functions. Removed name mangling as it's no longer needed. Restriction on HD overloading guarantees that we'll emit only one viable function during particular side of