Re: [PATCH] D12664: Fixed comparison.

jtouton added a comment. Can I get this reviewed? http://reviews.llvm.org/D12664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

On Tue, Sep 15, 2015 at 12:50 PM, Aaron Ballman wrote: > aaron.ballman added reviewers: rtrieu, rsmith. > aaron.ballman added a comment. > > There is a -Wpessimizing-move frontend warning that Richard added not too > long ago, which tells the user to remove calls to

Re: [PATCH] D3967: [Proposal] [Analyzer] Individual options for checkers

a.sidorin abandoned this revision. a.sidorin added a comment. Abandon this change since the patch based on this is committed in http://reviews.llvm.org/D7905 http://reviews.llvm.org/D3967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ + + if (auto *VAT = dyn_cast(ElementType.getTypePtr())) { +auto VATInfo = CGF.getVLASize(VAT); +Size = llvm::ConstantInt::get( +CGM.SizeTy, +

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

sylvestre.ledru added a comment. share/clang is fine, thanks. http://reviews.llvm.org/D12700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12600: [mips] Added support for using the command line options -Wa, -msoft-float and -Wa, -mhard-float.

dsanders accepted this revision. dsanders added a comment. This revision is now accepted and ready to land. LGTM It's not for this patch but I think we need a general solution to the -Wa,... options. It seems wrong to implement each assembler option twice (both with and without the '-Wa,').

Re: [PATCH] D6551: Improvements to scan-build.

sylvestre.ledru closed this revision. sylvestre.ledru added a comment. To close this review. http://reviews.llvm.org/D6551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12903: Allow the -load option in the driver and pass it through to -cc1

john.brawn created this revision. john.brawn added a subscriber: cfe-commits. john.brawn set the repository for this revision to rL LLVM. Currently -load is only allowed in the -cc1 command, which makes it rather awkward to use. Allowing it in the driver and passing it through to -cc1 is much

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

alexfh added a comment. In http://reviews.llvm.org/D12700#246948, @sylvestre.ledru wrote: > share/clang is fine, thanks. Then we need to make a similar change to the configure build. Eugene, can you do this? http://reviews.llvm.org/D12700 ___

[PATCH] D12904: fix for assertion fail for pragma weak on typedef

amusman created this revision. amusman added reviewers: rsmith, ABataev. amusman added a subscriber: cfe-commits. Can you please review a fix for assertion fail on the following small test: typedef int __td3; #pragma weak td3 = __td3 Assertion failed: (isa(ND) || isa(ND)), function

[clang-tools-extra] r247798 - [clang-tidy] Added a style guide link.

Author: alexfh Date: Wed Sep 16 08:54:16 2015 New Revision: 247798 URL: http://llvm.org/viewvc/llvm-project?rev=247798=rev Log: [clang-tidy] Added a style guide link. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/google-runtime-int.rst Modified:

Re: [PATCH] D12903: Allow the -load option in the driver and pass it through to -cc1

rengolin added a subscriber: rengolin. rengolin added a comment. Hi John, Can you expand a bit more on why you need this, what's the use case, and hopefully attach a test for them? cheers, --renato Repository: rL LLVM http://reviews.llvm.org/D12903

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

honggyu.kim added a comment. In http://reviews.llvm.org/D10305#242159, @zaks.anna wrote: > honggyu.kim, > > Uniquing HTML reports is out of the scope of this patch and should be > discussed elsewhere (either send a design idea to cfe-dev, send a patch for > review, or file a bugzilla request).

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

On Wed, Sep 16, 2015 at 12:47 AM, Akira Hatanaka wrote: > ahatanak added inline comments. > > > Comment at: include/clang/Basic/Attr.td:894 > @@ -893,1 +893,3 @@ > > +def DisableTailCalls : InheritableAttr { > + let Spellings = [GNU<"disable_tail_calls">, >

[clang-tools-extra] r247806 - [clang-tidy] google-runtime-int: made the matcher more restricting, added a test for a false positive

Author: alexfh Date: Wed Sep 16 10:08:46 2015 New Revision: 247806 URL: http://llvm.org/viewvc/llvm-project?rev=247806=rev Log: [clang-tidy] google-runtime-int: made the matcher more restricting, added a test for a false positive This should be NFC. Modified:

[clang-tools-extra] r247803 - [clang-tidy] Make google-runtime-int configurable.

Author: alexfh Date: Wed Sep 16 09:36:22 2015 New Revision: 247803 URL: http://llvm.org/viewvc/llvm-project?rev=247803=rev Log: [clang-tidy] Make google-runtime-int configurable. Added: clang-tools-extra/trunk/test/clang-tidy/google-runtime-int-std.cpp Modified:

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

On Wed, Sep 16, 2015 at 12:46 AM, Akira Hatanaka wrote: > ahatanak updated this revision to Diff 34872. > ahatanak added a comment. > > Sorry for the delay in my response. > > I had discussions with the users who requested this feature and it turns out > they were asking for

Re: [PATCH] D12903: Allow the -load option in the driver and pass it through to -cc1

john.brawn added a comment. In http://reviews.llvm.org/D12903#247055, @rengolin wrote: > Hi John, > > Can you expand a bit more on why you need this, what's the use case, and > hopefully attach a test for them? The use-case is loading llvm plugins that add optimization passes via the

[PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

honggyu.kim created this revision. honggyu.kim added reviewers: jordan_rose, krememek, zaks.anna, danielmarjamaki, babati, dcoughlin. honggyu.kim added subscribers: cfe-commits, phillip.power, seaneveson, j.trofimovich, hk.kang, eszasip, dkrupp, o.gyorgy, xazax.hun, premalatha_mvs. This patch

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

honggyu.kim added a comment. issue_hash is generated with hash value rather than line offset from function as below: issue_hash765b04830932fef5631bf3c48c4d2db2 http://reviews.llvm.org/D12906 ___ cfe-commits mailing list

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

honggyu.kim added a comment. I think we can enhance the bug comparison method one by one rather than making a big change at once. The point of this patch is to make "issue_hash" field in plist more robust while still using existing CmpRuns.py for comparison. I would like to hear any kind of

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

Okay, I'm sold on this being a clang-tidy check instead, thank you both for weighing in! I would love to see a check that covers more than just constructor initialization contexts, which suggests a separate checker from misc-move-constructor-init so that we don't have the same general idea split

r247808 - [sanitizers] Enable memory sanitizer on clang

Author: azanella Date: Wed Sep 16 10:11:21 2015 New Revision: 247808 URL: http://llvm.org/viewvc/llvm-project?rev=247808=rev Log: [sanitizers] Enable memory sanitizer on clang This patch enables MSan for aarch64/linux Modified: cfe/trunk/lib/Driver/ToolChains.cpp Modified:

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

On Wed, Sep 16, 2015 at 5:15 PM, Aaron Ballman wrote: > Okay, I'm sold on this being a clang-tidy check instead, thank you > both for weighing in! > > I would love to see a check that covers more than just constructor > initialization contexts, which suggests a separate

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

On Wed, Sep 16, 2015 at 11:41 AM, Alexander Kornienko wrote: > On Wed, Sep 16, 2015 at 5:15 PM, Aaron Ballman > wrote: >> >> Okay, I'm sold on this being a clang-tidy check instead, thank you >> both for weighing in! >> >> I would love to see a check

Re: [PATCH] D12901: [Static Analyzer] Intersecting ranges and 64 bit to 32 bit truncations causing "System is over constrained." assertions.

pgousseau updated this revision to Diff 34900. pgousseau added a comment. Added some comments. http://reviews.llvm.org/D12901 Files: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp lib/StaticAnalyzer/Core/SimpleConstraintManager.h

[clang-tools-extra] r247812 - [clang-tidy] Ignore spaces in -checks=

Author: alexfh Date: Wed Sep 16 11:16:53 2015 New Revision: 247812 URL: http://llvm.org/viewvc/llvm-project?rev=247812=rev Log: [clang-tidy] Ignore spaces in -checks= Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp Modified:

Re: PATCH: Expose the 'file' that is associated with a compile database command

In r247832. > On Sep 12, 2015, at 5:19 AM, Manuel Klimek wrote: > > Test would be awesome :) Thx! > > On Fri, Sep 11, 2015 at 10:44 PM Argyrios Kyrtzidis > wrote: > In r247468, thanks for reviewing! > > >> On Sep 11,

[libcxx] r247827 - Add endianness configuration block for GCC.

Author: danalbert Date: Wed Sep 16 13:10:47 2015 New Revision: 247827 URL: http://llvm.org/viewvc/llvm-project?rev=247827=rev Log: Add endianness configuration block for GCC. Previously GCC using libc++ would just leak endian.h for every include. Modified: libcxx/trunk/include/__config

r247828 - [analyzer] Improved behavior if Clang was not found, part II

Author: ayartsev Date: Wed Sep 16 13:12:15 2015 New Revision: 247828 URL: http://llvm.org/viewvc/llvm-project?rev=247828=rev Log: [analyzer] Improved behavior if Clang was not found, part II - scan-build help: display 'Could not query Clang for the list of available checkers.' + the reason why

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

An update: I didn't find a single bug with this check in a large codebase. Turns out that it's rather useless. I'm inclined to kill it. On Sun, Sep 13, 2015 at 11:22 AM, Alexander Kornienko wrote: > I've also found a bunch of similar cases in our codebase, and I'm trying > to

Re: PATCH: Expose the 'file' that is associated with a compile database command

Thanks! On Wed, Sep 16, 2015 at 11:30 AM Argyrios Kyrtzidis wrote: > In r247832. > > On Sep 12, 2015, at 5:19 AM, Manuel Klimek wrote: > > Test would be awesome :) Thx! > > On Fri, Sep 11, 2015 at 10:44 PM Argyrios Kyrtzidis >

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

On Wed, Sep 16, 2015 at 2:21 PM, Alexander Kornienko wrote: > An update: I didn't find a single bug with this check in a large codebase. > Turns out that it's rather useless. I'm inclined to kill it. How bad is the false positive rate? ~Aaron > > > On Sun, Sep 13, 2015 at

Re: recordDecl() AST matcher

Quick ping. I know this is a fairly gigantic patch, but I'm hoping for a relatively quick review turnaround because of potential merge conflicts with people doing a fair amount of work on clang-tidy lately. Everything should be pretty straight-forward (it's all just renames, no semantic changes

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

eugenis added a comment. Hi Eric, have you had a chance to take another look at this? It is blocking http://reviews.llvm.org/D11740. http://reviews.llvm.org/D11963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12774: createUniqueFile() is documented to create the file in the temporary directory unless it's supplied an absolute path.Make sure the output filepath supplied to createUniqueFile() in

+ Anna > On Sep 14, 2015, at 1:25 PM, Cameron Esfahani wrote: > > dirty added a comment. > > Ping? > > > http://reviews.llvm.org/D12774 > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

dcoughlin updated this revision to Diff 34917. dcoughlin added a comment. Added checks for null generated error nodes in the few cases in checkers were they were missing and updated comments. http://reviews.llvm.org/D12780 Files:

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

On Wed, Sep 16, 2015 at 8:05 AM, Aaron Ballman wrote: > On Wed, Sep 16, 2015 at 12:47 AM, Akira Hatanaka > wrote: > > ahatanak added inline comments. > > > > > > Comment at: include/clang/Basic/Attr.td:894 > > @@ -893,1 +893,3 @@ > >

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

zaks.anna added a comment. Thanks! Will do. http://reviews.llvm.org/D10305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

All found results were intended usages of sizeof on containers. 100% false positive rate that is. On 16 Sep 2015 21:23, "Aaron Ballman" wrote: > On Wed, Sep 16, 2015 at 2:21 PM, Alexander Kornienko > wrote: > > An update: I didn't find a single bug

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ + + if (auto *VAT = dyn_cast(ElementType.getTypePtr())) { +auto VATInfo = CGF.getVLASize(VAT); +Size = llvm::ConstantInt::get( +CGM.SizeTy, +

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

sfantao added inline comments. Comment at: lib/CodeGen/CGStmtOpenMP.cpp:80-81 @@ -67,1 +79,4 @@ II = ().Idents.get("vla"); + if (UseOnlyReferences) +ArgType = getContext().getLValueReferenceType( +ArgType, /*SpelledAsLValue=*/false);

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

It was about a hundred in a huge codebase. It's definitely manageable, but the experiment has shown that this kind of a mistake is not likely to happen. On 16 Sep 2015 23:25, "Aaron Ballman" wrote: > On Wed, Sep 16, 2015 at 5:21 PM, Alexander Kornienko

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

On Wed, Sep 16, 2015 at 5:33 PM, Alexander Kornienko wrote: > It was about a hundred in a huge codebase. It's definitely manageable, but > the experiment has shown that this kind of a mistake is not likely to > happen. Fair enough, let's axe it until we see evidence it may

Re: [PATCH] D12747: Implement [depr.c.headers]

On Mon, Sep 14, 2015 at 7:07 AM, Marshall Clow wrote: > mclow.lists added a comment. > > I have two concerns about this patch (w/o commenting on the actual code). > > 1. Until very recently, I was under the impression that C libraries > _either_ defined a macro, or had a

r247859 - [analyzer] Add generateErrorNode() APIs to CheckerContext.

Author: dcoughlin Date: Wed Sep 16 17:03:05 2015 New Revision: 247859 URL: http://llvm.org/viewvc/llvm-project?rev=247859=rev Log: [analyzer] Add generateErrorNode() APIs to CheckerContext. The analyzer trims unnecessary nodes from the exploded graph before reporting path diagnostics. However,

r247843 - [WinEH] Pass the catch adjectives to catchpad directly

Author: rnk Date: Wed Sep 16 15:15:55 2015 New Revision: 247843 URL: http://llvm.org/viewvc/llvm-project?rev=247843=rev Log: [WinEH] Pass the catch adjectives to catchpad directly This avoids building a fake LLVM IR global variable just to ferry an i32 down into LLVM codegen. It also puts a nail

Re: [PATCH] D11279: Initial patch for PS4 toolchain

kromanova added a comment. test/Driver/Inputs/scei-ps4_tree/target/include_common/ and test/Driver/Inputs/scei-ps4_tree/target/include/ are expected to be present by a test ps4-header-search.c. This test checks that these directories are found in the header search path. If these directories

[PATCH] D12917: [CUDA] Allow parsing of host and device code simultaneously.

tra created this revision. tra added reviewers: echristo, eliben, jpienaar. tra added a subscriber: cfe-commits. Herald added subscribers: dschuff, jfb. The patch: - adds -aux-triple option to specify target triple - propagates aux target info to AST context and Preprocessor - pulls in

[PATCH] D12919: [clang-format] Make configure installation consistent with CMake

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. During D12700 review I was asked to make configure installation consistent with CMake. Since I modeled

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

strager updated this revision to Diff 34946. strager marked 2 inline comments as done. strager added a comment. Address @djasper's comments. http://reviews.llvm.org/D11693 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

strager updated this revision to Diff 34947. strager added a comment. Rebase. http://reviews.llvm.org/D10370 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp

Re: r247618 - C11 _Bool bitfield diagnostic

On Wed, Sep 16, 2015 at 5:27 PM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Sep 15, 2015 at 5:50 PM, Richard Smith > wrote: > >> On Tue, Sep 15, 2015 at 12:38 PM, Nico Weber wrote: >> >>> With this patch, we warn on

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

Eugene.Zelenko set the repository for this revision to rL LLVM. Eugene.Zelenko updated this revision to Diff 34953. Eugene.Zelenko added a comment. I added installation in configure. See also http://reviews.llvm.org/D12919 for further configure improvements idea. Repository: rL LLVM

Re: [PATCH] D10371: clang-format: Support @synchronized.

strager updated this revision to Diff 34957. strager added a comment. Rebase. Fix style issues. http://reviews.llvm.org/D10371 Files: lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

r247862 - analyzer-plugin/MainCallChecker.cpp: s/generateSink/generateErrorNode/, corresponding to r247859.

Author: chapuni Date: Wed Sep 16 17:57:23 2015 New Revision: 247862 URL: http://llvm.org/viewvc/llvm-project?rev=247862=rev Log: analyzer-plugin/MainCallChecker.cpp: s/generateSink/generateErrorNode/, corresponding to r247859. Modified: cfe/trunk/examples/analyzer-plugin/MainCallChecker.cpp

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

> On Sep 16, 2015, at 4:01 PM, NAKAMURA Takumi wrote: > > Did you forget to update examples/analyzer-plugin? Fixed in r247862. Yes — thank you! Devin ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D7714: missing-namespace-std check for clang-tidy

jbcoe abandoned this revision. jbcoe added a comment. This work needs such extensive revision that I'll submit a new version when I start work on it again. Repository: rL LLVM http://reviews.llvm.org/D7714 ___ cfe-commits mailing list

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai updated this revision to Diff 34943. zhengkai marked 8 inline comments as done. http://reviews.llvm.org/D12379 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp lib/Frontend/DiagnosticRenderer.cpp test/Index/fix-its.m test/Misc/caret-diags-macros.c

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

silvas requested changes to this revision. silvas added a reviewer: silvas. This revision now requires changes to proceed. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7774 @@ -7771,1 +7773,3 @@ "@import of module '%0' in implementation of '%1'; use #import">; +def

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

chapuni added a subscriber: chapuni. chapuni added a comment. Did you forget to update examples/analyzer-plugin? Fixed in r247862. Repository: rL LLVM http://reviews.llvm.org/D12780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai added inline comments. Comment at: lib/Frontend/DiagnosticRenderer.cpp:312 @@ +311,3 @@ + +static bool retrieveBeginLocation(SourceLocation , + FileID , rtrieu wrote: > Why not return a SourceLocation instead of passing one in

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

sfantao updated the summary for this revision. sfantao updated this revision to Diff 34955. sfantao added a comment. Rebase on top of last changes in http://reviews.llvm.org/D12871. http://reviews.llvm.org/D12614 Files: include/clang/Basic/DiagnosticDriverKinds.td

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Sure. :) Review is based off the attachment I grabbed from here: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150824/136904.html A few nits: - test/Sema/enable_if.cpp line 24: Please use __attribute__(( instead of __attribute(( - Can we have a similar test for a function that

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

sfantao added inline comments. Comment at: lib/CodeGen/CGStmtOpenMP.cpp:121-123 @@ -103,4 +120,5 @@ +ArgLVal.getAddress(), ArgLVal.getType()->castAs()); auto *ExprArg = EmitLoadOfLValue(ArgLVal, SourceLocation()).getScalarVal(); auto VAT =

[PATCH] D12916: [Static Analyzer] Use generics related information to infer dynamic types.

xazax.hun created this revision. xazax.hun added reviewers: zaks.anna, dcoughlin, jordan_rose. xazax.hun added a subscriber: cfe-commits. This patch makes the DynamicTypePropagation checker utilize the information about generics. Using this additional information more precise inlining can be

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

sfantao updated this revision to Diff 34936. sfantao added a comment. Fix imprecision in previous diff. http://reviews.llvm.org/D12871 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp lib/CodeGen/CodeGenFunction.h

Re: [PATCH] D11279: Initial patch for PS4 toolchain

echristo added a comment. In http://reviews.llvm.org/D11279#247402, @kromanova wrote: > Hi Eric, > I don't mind changing .keep into README. However, originally we did it for > consistency purpose. If you grep for .keep in > /llvm/tools/clang/test/Driver/Inputs directory, you will find

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

strager marked 4 inline comments as done. Comment at: lib/Format/UnwrappedLineParser.cpp:1057-1058 @@ +1056,4 @@ + while (!eof()) { +// FIXME: Once we have an expression parser in the UnwrappedLineParser, +// replace this by using parseAssigmentExpression()

Re: r247618 - C11 _Bool bitfield diagnostic

On Tue, Sep 15, 2015 at 5:50 PM, Richard Smith wrote: > On Tue, Sep 15, 2015 at 12:38 PM, Nico Weber wrote: > >> With this patch, we warn on `bool a : 4;`, yet we don't warn on `bool b` >> (which has 8 bits storage, 1 bit value). Warning on `bool b`

Re: [PATCH] D12832: [Driver] Added support for Windows 10 SDK

ikudrin added a comment. Ping? http://reviews.llvm.org/D12832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12921: clang-format: Support 'template<>' (no space).

strager created this revision. strager added a reviewer: djasper. strager added subscribers: cfe-commits, abdulras, sas. Herald added a subscriber: klimek. Some styles don't put a space between 'template' and the opening '<'. Introduce SpaceAfterTemplateKeyword which, when set to false, causes

Re: [PATCH] D12922: Add support for function attribute "notail"

ahatanak added a comment. The llvm-side patch is here: http://reviews.llvm.org/D12923 http://reviews.llvm.org/D12922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12832: [Driver] Added support for Windows 10 SDK

majnemer added a subscriber: majnemer. Comment at: cfe/trunk/lib/Driver/MSVCToolChain.cpp:263 @@ +262,3 @@ + std::sscanf(RegistrySDKVersion.c_str(), "v%d.", ); + if (Major > 7 && Major < 10) { +// Windows SDK 8.x installs libraries in a folder whose names depend on the

[PATCH] D12922: Add support for function attribute "notail"

ahatanak created this revision. ahatanak added a reviewer: aaron.ballman. ahatanak added a subscriber: cfe-commits. This patch adds support for a new function attribute "notail". The attribute is used to disable tail call optimization on calls to functions marked with the attribute. This is

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

dcoughlin added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:321 @@ +320,3 @@ +// sink, we assume that a client requesting a transition to a state that is +// the same as the predecessor state has made a mistake. We return

Re: [PATCH] D12889: [Static Analyzer] Generics Checker: When an ObjC method returns a specialized object, track it properly.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:680 @@ +679,3 @@ +return nullptr; + + QualType ResultType = Method->getReturnType().substObjCTypeArgs( zaks.anna wrote: > From above: > QualType

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev added a comment. Ping. http://reviews.llvm.org/D9040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits