Author: ctopper
Date: Tue Sep 29 00:08:30 2015
New Revision: 248778
URL: http://llvm.org/viewvc/llvm-project?rev=248778&view=rev
Log:
Revert part of r248776. One of the changes worked on my local build, but not on
the bots.
Modified:
cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyTIL.
Author: ctopper
Date: Mon Sep 28 23:53:28 2015
New Revision: 248776
URL: http://llvm.org/viewvc/llvm-project?rev=248776&view=rev
Log:
Simplify or remove calls to makeArrayRef based on feedback from David Blaikie.
NFC.
Modified:
cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyTIL.h
Author: rjmccall
Date: Mon Sep 28 23:37:40 2015
New Revision: 248775
URL: http://llvm.org/viewvc/llvm-project?rev=248775&view=rev
Log:
Honor the casted-to alignment of an explicit cast even when
Sema thinks the cast is a no-op, as it does when (e.g.) the
only thing that changes is an alignment att
Author: ctopper
Date: Mon Sep 28 23:30:07 2015
New Revision: 248774
URL: http://llvm.org/viewvc/llvm-project?rev=248774&view=rev
Log:
Remove 'const' from some ArrayRef arguments since they're passed by value
anyway. NFC
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk
Author: ctopper
Date: Mon Sep 28 23:30:05 2015
New Revision: 248773
URL: http://llvm.org/viewvc/llvm-project?rev=248773&view=rev
Log:
Pass ArrayRef by value. NFC.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
Modified: cfe/trunk/lib/AST/ExprConstant.cpp
URL:
http://llvm.org/viewvc/llvm-proje
compnerd added a comment.
Ah. Well, Im tempted to say that we should avoid the option. Generally,
making the backend options visible is undesirable since there is no guarantee
of stability there. This simplifies that, and if users start using that, we
would not be able to change those as eas
hintonda added a comment.
Mainly aesthetic. It was the only one of the group, -Xassembler, -Xlinker,
-Xpreprocessor, and -Xclang, that didn't have a corresponding comma separated
option, so I figured it might be a good addition.
http://reviews.llvm.org/D13229
__
compnerd added a comment.
While I can certainly appreciate the simplification this may afford, Im not
sure if adding a new option here is really that valuable. Options being added
to the frontend are expensive because they can't be changed or removed. If gcc
has a similar frontend option, we
cuda_runtime.h may be a better choice. nvcc -includes it during both host
and device compilation and this wrapper file is intended to serve a similar
purpose and will probably end up being -included by cc1 in the end.
--Artem
On Mon, Sep 28, 2015 at 6:26 PM, Eric Christopher
wrote:
> echristo
echristo added a comment.
Why not just call it cuda.h and use #include next for it and then fix it up?
-eric
http://reviews.llvm.org/D13171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
hintonda added a comment.
Here are a few examples from existing tests showing how this option could be
used:
-Xclang -analyzer-max-loop -Xclang 34
becomes:
-Wc,-analyzer-max-loop,34
-Xclang -analyzer-checker=debug.ConfigDumper -Xclang -analyzer-max-loop
-Xclang 34
becomes:
-Wc,-a
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: adrian
Date: Mon Sep 28 18:56:10 2015
New Revision: 248762
URL: http://llvm.org/viewvc/llvm-project?rev=248762&view=rev
Log:
Unique-pointerify these pointers an plug a memory leak.
Thanks to echristo for noticing!
Modified:
cfe/trunk/include/clang/CodeGen/CodeGenABITypes.h
cfe/tru
Thanks, Eric!
Should be fixed in r248762.
-- adrian
> On Sep 28, 2015, at 4:40 PM, Eric Christopher wrote:
>
> Actually using the right list now...
>
> On Mon, Sep 28, 2015 at 4:39 PM Eric Christopher wrote:
> Hi Adrian,
>
>
>: CGO(new CodeGenOptions),
> -CGM(new CodeGen::CodeGenMo
Author: dblaikie
Date: Mon Sep 28 18:48:52 2015
New Revision: 248760
URL: http://llvm.org/viewvc/llvm-project?rev=248760&view=rev
Log:
Add an explicitly defaulted copy ctor (and FIXME) to Command since its copy
ctor is currently used (and actually slices derived objects... ) in some
diagnostics
Author: dblaikie
Date: Mon Sep 28 18:48:49 2015
New Revision: 248759
URL: http://llvm.org/viewvc/llvm-project?rev=248759&view=rev
Log:
Remove trivial dtor that was making uses of the copy ctor -Wdeprecated unclean
And also remove an unused variable that's now diagnosed by
-Wunused-variable since
Author: dblaikie
Date: Mon Sep 28 18:48:55 2015
New Revision: 248761
URL: http://llvm.org/viewvc/llvm-project?rev=248761&view=rev
Log:
Remove the only use of LookupResult's implicit copy ctor
LookupResult should not be copyable, it's not readily copyable and can
only be copied when it's in specif
Actually using the right list now...
On Mon, Sep 28, 2015 at 4:39 PM Eric Christopher wrote:
> Hi Adrian,
>
>
>>: CGO(new CodeGenOptions),
>> -CGM(new CodeGen::CodeGenModule(C, *CGO, M, TD, C.getDiagnostics(),
>> +HSO(new HeaderSearchOptions),
>> +PPO(new PreprocessorOptions),
>>
Hi Joerg:
This change would allow users to pass multiple options, or options with
arguments, to cc1 without having to use -Xclang multiple times.
Recently, the -load option was added, at least partly, because passing
-Xclang multiple times was cumbersome. (I like that change btw)
Had -Wc, been a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248753: [CUDA] 32-bit NVPTX should have 32-bit long type.
(authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D13181?vs=35772&id=35918#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: tra
Date: Mon Sep 28 17:54:08 2015
New Revision: 248753
URL: http://llvm.org/viewvc/llvm-project?rev=248753&view=rev
Log:
[CUDA] 32-bit NVPTX should have 32-bit long type.
Currently it's 64-bit which will lead to mismatch between host and
device code if we compile for i386.
Differential
On Mon, Sep 28, 2015 at 09:54:53PM +, don hinton via cfe-commits wrote:
> Add -Wc, option (similar to -Wl,) to go along with -Xclang.
> This makes it easier to pass multiple options to cc1.
How is this better than -mllvm and -Xclang? There is no precendence case for
this with GCC really and I
hintonda created this revision.
hintonda added a subscriber: cfe-commits.
Add -Wc, option (similar to -Wl,) to go along with -Xclang. This
makes it easier to pass multiple options to cc1.
http://reviews.llvm.org/D13229
Files:
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
Index: lib
djasper created this revision.
djasper added a reviewer: klimek.
djasper added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Recognize main module header as well as different #include categories. This
should now mimic the behavior of llvm/utils/sort_includes.py as well as
clang-t
wschmidt accepted this revision.
wschmidt added a comment.
This revision is now accepted and ready to land.
Sorry, forgot to accept.
Repository:
rL LLVM
http://reviews.llvm.org/D13190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
xazax.hun added a comment.
I will look into it. Do you prefer to revert the patch this it is fixed?
Repository:
rL LLVM
http://reviews.llvm.org/D12652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: prazek
Date: Mon Sep 28 15:30:22 2015
New Revision: 248734
URL: http://llvm.org/viewvc/llvm-project?rev=248734&view=rev
Log:
Generate assume loads only with -fstrict-vtable-pointers
Temporary fix till InstCombine and other possible passes will be
efficient to handle multiple assumes.
Mod
echristo added a subscriber: echristo.
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
One inline comment reword.
Comment at: lib/CodeGen/CGClass.cpp:2111
@@ -2110,1 +2110,3 @@
+ // FIXME: It looks like InstCombine is very ineffic
rnk added a subscriber: rnk.
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D13223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Prazek created this revision.
Prazek added reviewers: rsmith, samsonov, majnemer.
Prazek added a subscriber: cfe-commits.
Temporary fix till InstCombine and other possible passes will be efficient to
handle multiple assumes.
http://reviews.llvm.org/D13223
Files:
lib/CodeGen/CGClass.cpp
test
The (vague) idea was to make clear that the header is *not* part of cuda
distribution.
That said, the file could use a better name.
Do any of these sound better?
* fix_cuda_headers.h
* adapt_cuda_headers.h
* cuda_shim.h
--Artem
On Sat, Sep 26, 2015 at 12:20 PM, Eric Christopher
wrote:
> echri
dougk added a comment.
I think the best thing to do is introduce new cc1 arguments that control the
Opts explicitly, and cease accepting the equivalent driver arguments in cc1.
I would propose '-gdwarf-version={2|3|4}' and
'-gdebug-info-kind={line-tables|limited|full}'
http://reviews.llvm.org/
aaron.ballman updated this revision to Diff 35900.
aaron.ballman marked 2 inline comments as done.
aaron.ballman added a comment.
Addresses review comments, also adds a documentation file.
http://reviews.llvm.org/D12945
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cp
Author: aaronballman
Date: Mon Sep 28 14:27:37 2015
New Revision: 248729
URL: http://llvm.org/viewvc/llvm-project?rev=248729&view=rev
Log:
Fixing a sphinx warning.
Modified:
clang-tools-extra/trunk/docs/modularize.rst
Modified: clang-tools-extra/trunk/docs/modularize.rst
URL:
http://llvm.or
dougk created this revision.
dougk added reviewers: chandlerc, jyknight.
dougk added a subscriber: cfe-commits.
Both the Driver and the cc1 frontend play games with various combinations of
'g' group options.
It would be nice if at least the frontend could be sane, leaving the decision
of what OS
zaks.anna added a comment.
Looks like this patch is causing regressions:
https://llvm.org/bugs/show_bug.cgi?id=24914
Repository:
rL LLVM
http://reviews.llvm.org/D12652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: papin_g
Date: Mon Sep 28 12:53:04 2015
New Revision: 248723
URL: http://llvm.org/viewvc/llvm-project?rev=248723&view=rev
Log:
[clang-tidy] add option to specify build path
Summary:
compile_commands.json is usually generated in the build directory.
Projects like LLVM/Clang enforce out-of-s
Hey Hal
Thanks for the review. I really appreciate it given the scale of this.
> On Sep 25, 2015, at 1:13 PM, Hal Finkel wrote:
>
> Hi Pete,
>
> Thanks for working on this.
>
> + class IntegerAlignment {
> + private:
> +uint64_t Align;
>
> You explain in the patch summary why this is he
rjmccall added a comment.
LGTM, thanks.
http://reviews.llvm.org/D12793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
labrinea created this revision.
labrinea added reviewers: cfe-commits, rengolin.
Herald added subscribers: rengolin, aemerson.
Tests are misssing for armv6m + darwin as well.
http://reviews.llvm.org/D13217
Files:
lib/Basic/Targets.cpp
lib/Driver/Tools.cpp
test/Driver/arm-alignment.c
Index
On Mon, Sep 28, 2015 at 12:36 PM, Alexander Kornienko via cfe-commits
wrote:
> alexfh added inline comments.
>
>
> Comment at: clang-tidy/misc/NewDeleteOverloadsCheck.cpp:170
> @@ +169,3 @@
> +const auto &OI = std::find_if(
> +Overloads.begin(), Overloads.end(), [&](co
alexfh added inline comments.
Comment at: clang-tidy/misc/NewDeleteOverloadsCheck.cpp:170
@@ +169,3 @@
+const auto &OI = std::find_if(
+Overloads.begin(), Overloads.end(), [&](const FunctionDecl *FD) {
+ if (FD == O)
aaron.ballman wrote:
> ale
aaron.ballman marked 4 inline comments as done.
aaron.ballman added a comment.
http://reviews.llvm.org/D13071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman updated this revision to Diff 35881.
aaron.ballman added a comment.
Addressing review comments.
http://reviews.llvm.org/D13071
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/NewDeleteOverloadsCheck.cpp
clang-tidy/misc/NewDeleteOver
Yes that's already planned.
On Mon, Sep 28, 2015, 5:10 PM David Blaikie wrote:
> On Sat, Sep 26, 2015 at 11:21 PM, Manuel Klimek via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Yep. We'll make it better by limiting the size, but trivially copyable is
>> an improvement, as there are o
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/NewDeleteOverloadsCheck.cpp:170
@@ +169,3 @@
+const auto &OI = std::find_if(
+Overloads.begin(), Overloads.end(), [&](const FunctionDecl *FD) {
+ if (FD == O)
alexfh wrote:
> aar
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/NewDeleteOverloadsCheck.cpp:168
@@ +167,3 @@
+ SmallVector Diagnose;
+ for (const auto *O : Overloads) {
+const auto &OI = std::find_if(
alexfh wrote:
> aaron.ballman wrote:
> > alexfh wrote:
>
alexfh added inline comments.
Comment at: clang-tidy/misc/NewDeleteOverloadsCheck.cpp:168
@@ +167,3 @@
+ SmallVector Diagnose;
+ for (const auto *O : Overloads) {
+const auto &OI = std::find_if(
aaron.ballman wrote:
> alexfh wrote:
> > Please don't use "O",
aaron.ballman added a comment.
Thank you for the review!
Comment at: clang-tidy/misc/NewDeleteOverloadsCheck.cpp:66
@@ +65,3 @@
+namespace {
+OverloadedOperatorKind GetCorrespondingOverload(const FunctionDecl *FD) {
+ switch (FD->getOverloadedOperator()) {
alex
alexfh added inline comments.
Comment at: clang-tidy/misc/NonCopyableObjects.cpp:21
@@ +20,3 @@
+ static const char *TypeNames[] = {
+"::pthread_cond_t",
+"::pthread_mutex_t",
aaron.ballman wrote:
> alexfh wrote:
> > How about making these lists configura
alexfh added inline comments.
Comment at: clang-tidy/misc/NewDeleteOverloadsCheck.cpp:66
@@ +65,3 @@
+namespace {
+OverloadedOperatorKind GetCorrespondingOverload(const FunctionDecl *FD) {
+ switch (FD->getOverloadedOperator()) {
http://llvm.org/docs/CodingStanda
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/NonCopyableObjects.cpp:21
@@ +20,3 @@
+ static const char *TypeNames[] = {
+"::pthread_cond_t",
+"::pthread_mutex_t",
alexfh wrote:
> How about making these lists configurable or adding a li
angelgarcia updated this revision to Diff 35873.
angelgarcia added a comment.
Also replace on aliases.
http://reviews.llvm.org/D13166
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/MakeUniqueCheck.cpp
clang-tidy/modernize/MakeUniqueCheck.h
clang-tidy/modernize/Modernize
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
http://reviews.llvm.org/D13071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman updated this revision to Diff 35872.
aaron.ballman added a comment.
Added documentation, fixed else after return.
~Aaron
http://reviews.llvm.org/D13071
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/NewDeleteOverloadsCheck.cpp
cla
On Sat, Sep 26, 2015 at 11:21 PM, Manuel Klimek via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Yep. We'll make it better by limiting the size, but trivially copyable is
> an improvement, as there are orders of magnitude more loops over small
> copyable types than over large ones.
>
We see
On Sat, Sep 26, 2015 at 8:44 PM, Craig Topper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ctopper
> Date: Sat Sep 26 22:44:08 2015
> New Revision: 248678
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248678&view=rev
> Log:
> Use llvm::makeArrayRef. NFC.
>
> Modified:
> cf
jketema updated this revision to Diff 35871.
jketema added a comment.
Sync with updates to the llvm part of this patch
http://reviews.llvm.org/D13127
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/arm-neon-misc.c
test/CodeGen/arm-vector-align.c
test/CodeGen/vld_dup.c
Index: test/CodeGen
wschmidt added a comment.
Other than the FIXME removal, this LGTM! Very good and careful work. Thanks
for taking care of this!
Comment at: lib/Headers/altivec.h:13788
@@ -13416,3 +13787,3 @@
removed with -mno-crypto). This is under development.
*/
#ifdef __CRYPTO__
---
Author: djasper
Date: Mon Sep 28 09:29:45 2015
New Revision: 248714
URL: http://llvm.org/viewvc/llvm-project?rev=248714&view=rev
Log:
clang-format: [JS] Support pseudo-keywords
JavaScript allows keywords to appear in IdenfierName positions, e.g.
fields, or object literal members, but not as plain
djasper closed this revision.
djasper added a comment.
Submitted as r248714.
http://reviews.llvm.org/D13213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper closed this revision.
djasper added a comment.
Submitted as r248713.
http://reviews.llvm.org/D13211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Mon Sep 28 09:28:08 2015
New Revision: 248713
URL: http://llvm.org/viewvc/llvm-project?rev=248713&view=rev
Log:
clang-format: [JS] handle let (ES6)
Patch by Martin Probst. Thank you!
Modified:
cfe/trunk/lib/Format/FormatToken.h
cfe/trunk/lib/Format/TokenAnnotator.cp
klimek added a comment.
In http://reviews.llvm.org/D13166#254730, @angelgarcia wrote:
> This raises a question. Do we want to do replacements when we use an alias
> for std::unique_ptr? That fact that something is an unique_ptr might be an
> implementation detail that should not be exposed, but
mprobst updated this revision to Diff 35867.
mprobst marked an inline comment as done.
mprobst added a comment.
Use isOneOf instead of startsWith.
http://reviews.llvm.org/D13211
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineParser.cpp
unittests/Fo
angelgarcia added a comment.
This raises a question. Do we want to do replacements when we use an alias
for std::unique_ptr? That fact that something is an unique_ptr might be an
implementation detail that should not be exposed, but it could also happen
that the alias is there only for brevity. Wh
alexfh added a comment.
In http://reviews.llvm.org/D12839#254384, @flx wrote:
> I changed the check to also produce a fix that wraps the argument in
> std::move().
>
> When I modified the test include -isystem %S/Inputs/Headers it broke and only
> produces warnings but no fixes anymore. Is ther
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D13213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
mprobst created this revision.
mprobst added reviewers: djasper, klimek.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
JavaScript allows keywords to appear in IdenfierName positions, e.g. fields, or
object literal members, but not as plain identifiers.
http://reviews
klimek added inline comments.
Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:75-76
@@ +74,4 @@
+ std::string Identifier = removeWhitespace(ExprStr.substr(0, LAngle));
+ if (Identifier != "unique_ptr" && Identifier != "std::unique_ptr")
+return;
+ SourceLocation Constr
angelgarcia updated this revision to Diff 35864.
angelgarcia added a comment.
I think this is a bit better than before.
http://reviews.llvm.org/D13166
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/MakeUniqueCheck.cpp
clang-tidy/modernize/MakeUniqueCheck.h
clang-tidy/mo
On Sun, Sep 27, 2015 at 2:45 PM Stefan Bühler via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> it seems moderation didn't approve the phabricator mails for D12834.
> (I have no intention to be subscribed to the list just to get
> phabricator mails through. For now I am subscribed but
foutrelis added a comment.
Thanks for the review.
Can you please commit the patch to `clang-tools-extra/trunk` (since I don't
have commit rights)?
http://reviews.llvm.org/D13206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
klimek closed this revision.
klimek added a comment.
Submitted in r248710
http://reviews.llvm.org/D13206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: klimek
Date: Mon Sep 28 08:26:39 2015
New Revision: 248710
URL: http://llvm.org/viewvc/llvm-project?rev=248710&view=rev
Log:
Install clang-query by default.
It is already installed by the autotools build, and it is useful for
developers who are not working on LLVM/Clang itself.
Modified:
djasper accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Format/TokenAnnotator.cpp:2087
@@ -2087,1 +2086,3 @@
+// above.
+!Line.startsWith(Keywords.kw_var) && !Line.startsWith(Keywords.kw_let))
// Object literals on th
mprobst created this revision.
mprobst added reviewers: klimek, djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
clang-format: [JS] handle let (ES6).
http://reviews.llvm.org/D13211
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
lib/Format/
djasper created this revision.
djasper added a reviewer: klimek.
djasper added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Add individual brace flags for the different aspects of wrapping braces and
make Allman, GNU, etc. just presets for them.
This patch isn't complete yet, st
klimek added a subscriber: klimek.
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
LG
As we already a) install it from auto-tools and b) this tool is useful for
non-llvm/clang devs
http://reviews.llvm.org/
foutrelis created this revision.
foutrelis added a subscriber: cfe-commits.
It has been requested in a bug report downstream in Arch Linux to include the
clang-query tool as part of our clang-tools-extra package. [1]
This point has also been brought up on the cfe-dev list and the LLVM bug
track
foutrelis added a comment.
Just a note that this change is specific to CMake since autotools already
installs clang-query (along with some other tools).
http://reviews.llvm.org/D13206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
angelgarcia added a comment.
How can Lexer::getSourceText give us the range? My problem precisely is
that I couldn't find any way to obtain the range of the constructor call
without the template arguments.
http://reviews.llvm.org/D13166
___
cfe-comm
danielmarjamaki added a comment.
Thanks! Very good comments.
I will look at the comments asap. but unfortunately I don't have time right now.
I expect that I can continue working on this warning in a few weeks.
Comment at: include/clang/AST/DeclBase.h:279
@@ +278,3 @@
+ /// b
rmaprath added a comment.
Gentle ping.
http://reviews.llvm.org/D13054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
In http://reviews.llvm.org/D13166#254520, @angelgarcia wrote:
> Two tests in which 'getTokenLength' returns 0.
Thanks for the tests - question is: I would have expected us to use something
like Lexer::getSourceText, which should give us the full range in the first
test
alexfh added inline comments.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:577-578
@@ -578,3 +576,4 @@
Diag << FixItHint::CreateReplacement(
-CharSourceRange::getTokenRange(Range), Failure.Fixup);
+SourceRange(SourceLocation::getFro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248700: [clang-tidy] Code factorization and cleanup in
IdentifierNamingCheck (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D13079?vs=35818&id=35842#toc
Repository:
rL LLVM
h
Author: alexfh
Date: Mon Sep 28 03:59:12 2015
New Revision: 248700
URL: http://llvm.org/viewvc/llvm-project?rev=248700&view=rev
Log:
[clang-tidy] Code factorization and cleanup in IdentifierNamingCheck
This is to level the ground a little bit, in preparation for the changes in
http://reviews.llv
angelgarcia updated this revision to Diff 35841.
angelgarcia added a comment.
Two tests in which 'getTokenLength' returns 0.
http://reviews.llvm.org/D13166
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/MakeUniqueCheck.cpp
clang-tidy/modernize/MakeUniqueCheck.h
clang-ti
Author: alexfh
Date: Mon Sep 28 03:52:55 2015
New Revision: 248699
URL: http://llvm.org/viewvc/llvm-project?rev=248699&view=rev
Log:
[clang-tidy] Removed a stray empty line in the docs.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/google-build-explicit-make-pair.rst
Modified:
c
ABataev added a comment.
The bad thing is that the same problem can be reproduced not only in frontend,
but also in opt tool. The test I wrote (test/Other/empty.ll) also failed with
the same message.
And Yaron is right, I need to mix several outputs in stdout. What should I do
in this case?
h
klimek added inline comments.
Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:26-28
@@ +25,5 @@
+/// \brief Returns the length of the token that goes since the beggining of the
+/// constructor call until the '<' of the template. This token should either be
+/// 'unique_ptr'
angelgarcia updated this revision to Diff 35839.
angelgarcia marked an inline comment as done.
angelgarcia added a comment.
Remove 'hasCanonicalType'.
http://reviews.llvm.org/D13166
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/MakeUniqueCheck.cpp
clang-tidy/modernize/Ma
angelgarcia added inline comments.
Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:25-27
@@ +24,5 @@
+
+/// \brief Returns the length of the token that goes since the beggining of the
+/// constructor call until the '<' of the template. This token should either be
+/// 'uniqu
grimar created this revision.
grimar added reviewers: rsmith, echristo.
grimar added subscribers: cfe-commits, grimar.
Microsoft Visual Studio Community 2015
Version 14.0.23107.0 D14REL
When building in release mode, MSVS failed with:
57>c:\access_softek\llvm\tools\clang\lib\ast\astcontext.cpp(3
nemanjai updated this revision to Diff 35838.
nemanjai added a comment.
I forgot the test cases in the original upload. This patch contains the test
cases and is ready for review.
Repository:
rL LLVM
http://reviews.llvm.org/D13190
Files:
include/clang/Basic/BuiltinsPPC.def
lib/Headers/a
> On Sep 27, 2015, at 5:56 PM, Joerg Sonnenberger
> wrote:
> On Tue, Sep 08, 2015 at 08:06:00AM -, John McCall via cfe-commits wrote:
>> Author: rjmccall
>> Date: Tue Sep 8 03:05:57 2015
>> New Revision: 246985
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=246985&view=rev
>> Log:
>> Co
97 matches
Mail list logo
