neil.hickey created this revision.
neil.hickey added a reviewer: cfe-commits.
This patch adds the reserved operator ^^ when compiling for OpenCL, which
results in a more meaningful error message.
http://reviews.llvm.org/D13280
Files:
include/clang/Basic/DiagnosticParseKinds.td
include/clang
Alexander_Droste added a comment.
> We gave a talk about building checkers a while back; even though it does not
> talk about the bug reporter visitors, it might be worth watching if you
> haven't already seen it.
I have watched it some months ago but I'm sure it is a good idea to revisit the
Author: abataev
Date: Wed Sep 30 04:22:36 2015
New Revision: 248880
URL: http://llvm.org/viewvc/llvm-project?rev=248880&view=rev
Log:
[OPENMP 4.1] Sema analysis for array sections in 'reduction' clause.
OpenMP 4.1 allows to use array sections|subscript expressions in 'reduction'
clauses. Added se
sbaranga accepted this revision.
sbaranga added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Hi all,
Address spaces are not handled in custom semantic checks of atomic Builtins.
If there are two pointers passed to the Builtin, it doesn't allow the second
(non-atomic) one to be qualified with an address space.
This patch removed this restriction by recording the address space
Author: alexfh
Date: Wed Sep 30 05:41:53 2015
New Revision: 248886
URL: http://llvm.org/viewvc/llvm-project?rev=248886&view=rev
Log:
[clang-tidy] Better diagnostic in tests when clang-tidy fails.
Modified:
clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.py
Modified: clang-tools-extr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL24: [ARM][NEON] Use address space in
vld([1234]|[234]lane) and vst([1234]|… (authored by jketema).
Changed prior to commit:
http://reviews.llvm.org/D13127?vs=35871&id=36082#toc
Repository:
rL LLV
Author: jketema
Date: Wed Sep 30 05:56:56 2015
New Revision: 24
URL: http://llvm.org/viewvc/llvm-project?rev=24&view=rev
Log:
[ARM][NEON] Use address space in vld([1234]|[234]lane) and
vst([1234]|[234]lane) instructions
This is the clang commit associated with llvm r248887.
This commit
Author: stulova
Date: Wed Sep 30 06:48:15 2015
New Revision: 248891
URL: http://llvm.org/viewvc/llvm-project?rev=248891&view=rev
Log:
[OpenCL 2.0] Fix wrong atomic type detection in the diagnostics of allowed types
Modified:
cfe/trunk/lib/Sema/SemaType.cpp
cfe/trunk/test/Parser/opencl-ato
Author: alexfh
Date: Wed Sep 30 07:48:42 2015
New Revision: 248895
URL: http://llvm.org/viewvc/llvm-project?rev=248895&view=rev
Log:
[clang-tidy] Fix an assertion in the readability-braces-around-statements check.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/BracesAroundStatement
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added reviewers: rsmith, rjmccall.
d.zobnin.bugzilla added a subscriber: cfe-commits.
This patch fixes an assertion failure, caused by EmitCall function producing
llvm::InvokeInst* when llvm::CallInst* is needed (when multiplication of
c
Author: stulova
Date: Wed Sep 30 08:18:52 2015
New Revision: 248896
URL: http://llvm.org/viewvc/llvm-project?rev=248896&view=rev
Log:
[OpenCL 2.0] This change adds extra diagnostics to atomic types
Applied restrictions from OpenCL v2.0 s6.13.11.8
that mainly disallow operations on atomic types (e
Author: alexfh
Date: Wed Sep 30 08:32:42 2015
New Revision: 248899
URL: http://llvm.org/viewvc/llvm-project?rev=248899&view=rev
Log:
[clang-tidy] Added missing check lines, made the checking stricter.
Modified:
clang-tools-extra/trunk/test/clang-tidy/diagnostic.cpp
Modified: clang-tools-extr
petpav01 created this revision.
petpav01 added a subscriber: cfe-commits.
Libc++ provides valarray transcendentals with replacement types. These
functions are implemented either as `template` or `template`, where `_Expr` can be `__val_expr` or `valarray`.
The patch provides additional function t
angelgarcia updated this revision to Diff 36099.
angelgarcia added a comment.
Add some comments.
http://reviews.llvm.org/D13249
Files:
include/clang/AST/RecursiveASTVisitor.h
Index: include/clang/AST/RecursiveASTVisitor.h
===
--
Author: stulova
Date: Wed Sep 30 08:49:55 2015
New Revision: 248902
URL: http://llvm.org/viewvc/llvm-project?rev=248902&view=rev
Log:
[OpenCL] Add missing OpenCL LangOpts in address space compatibility checks
and test checking broken (due to CL specific diagnostics) C functionality
Mtest/Sem
klimek added a reviewer: rsmith.
klimek added a comment.
+richard to tell us whether that comment is correct :)
http://reviews.llvm.org/D13249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: djasper
Date: Wed Sep 30 08:59:29 2015
New Revision: 248904
URL: http://llvm.org/viewvc/llvm-project?rev=248904&view=rev
Log:
clang-format: Use Rewriter again to write the output files.
This has two advantages:
1. Atomic writes.
2. Proper handling of line endings (hopefully solving llvm.o
Author: jyknight
Date: Wed Sep 30 09:04:23 2015
New Revision: 248905
URL: http://llvm.org/viewvc/llvm-project?rev=248905&view=rev
Log:
Fix FunctionParmPackExpr::Create() to take a ParmVarDecl* array.
FunctionParmPackExpr actually stores an array of ParmVarDecl* (and
accessors return that). But, t
klimek added inline comments.
Comment at: include/clang/AST/RecursiveASTVisitor.h:2066-2089
@@ -2058,26 +2065,26 @@
-// InitListExpr is a tricky one, because we want to do all our work on
-// the syntactic form of the listexpr, but this method takes the
-// semantic form by defa
aaron.ballman closed this revision.
aaron.ballman added a comment.
I settled on "expression has opaque data structure type 'FILE'; type should
only be used as a pointer and not dereferenced" but we can tweak if that still
isn't quite right.
Committed in r248907.
Thank you for the reviews!
~Aa
Author: aaronballman
Date: Wed Sep 30 09:09:38 2015
New Revision: 248907
URL: http://llvm.org/viewvc/llvm-project?rev=248907&view=rev
Log:
Adding a checker (misc-non-copyable-objects) that detects situations where a
non-copyable C type is being dereferenced, such as FILE or pthread_mutex_t.
Corr
alexfh added a comment.
In http://reviews.llvm.org/D12945#256509, @aaron.ballman wrote:
> I settled on "expression has opaque data structure type 'FILE'; type should
> only be used as a pointer and not dereferenced" but we can tweak if that
> still isn't quite right.
Seems good. Thank you!
Author: stulova
Date: Wed Sep 30 09:08:20 2015
New Revision: 248906
URL: http://llvm.org/viewvc/llvm-project?rev=248906&view=rev
Log:
[OpenCL 2.0] Enable program scope variables, Section 6.5.1.
- Remove virtual SC_OpenCLWorkGroupLocal storage type specifier
as it conflicts with static local vari
Hi,
Sorry for the slow reply. I'm a bit behind on cfe-commits and it seems I
dropped out of the CC list so it didn't land in my inbox.
Do you mean something like this?:
for (...) {
...
switch (C.getDefaultToolChain().getArch()) {
default:
break;
angelgarcia updated this revision to Diff 36106.
angelgarcia added a comment.
Use only one function.
I find somewhat frustating that getSemanticForm() returns nullptr if the object
is already in its semantic form (and the same for isSyntacticForm()). Something
like QualType::getNonReferenceType
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
This fixes https://llvm.org/bugs/show_bug.cgi?id=22196 .
Also add a non-trivially copyable type to fix some tests that were meant to be
about using const-refs, but were ch
Author: dougk
Date: Wed Sep 30 10:55:59 2015
New Revision: 248912
URL: http://llvm.org/viewvc/llvm-project?rev=248912&view=rev
Log:
Alias "-ggdbN" to "-gN" options, fixing some incompatibilities.
* assembling from a .s file mistook -ggdb0 for -g
* -ggdb1 is supposed to mean basically -g1, not -gN
On Wed, Sep 30, 2015 at 02:19:58PM +, Daniel Sanders via cfe-commits wrote:
> Hi,
>
> Sorry for the slow reply. I'm a bit behind on cfe-commits and it seems I
> dropped out of the CC list so it didn't land in my inbox.
>
> Do you mean something like this?:
> for (...) {
> ...
>
hfinkel added a comment.
You should start a new differential for this, so that you can get a clean
summary e-mail with a description sent to cfe-commits. There's some overlap,
but you'll also get potentially-different reviewers here.
http://reviews.llvm.org/D12979
__
DavidEGrayson updated this revision to Diff 36117.
DavidEGrayson added a comment.
I changed the patch in two ways: it now returns ExprError() is the third
argument is wrong (for consistency with the other argument checking code). I
removed an outdated comment for EncompassingIntegerType.
Thank
ismailp updated this revision to Diff 36123.
ismailp added a comment.
- Don't try to calculate field offset for Objective-C instance variables
- Added test for Objective-C instance variables
- Added a non-null pointer in test
http://reviews.llvm.org/D12251
Files:
lib/StaticAnalyzer/Core/Store
ismailp marked 3 inline comments as done.
Comment at: test/Analysis/array-struct-region.cpp:128
@@ +127,3 @@
+#if __cplusplus
+ clang_analyzer_eval((void *)&PFONew->secondField != (void *)&PFONew); //
expected-warning{{TRUE}}
+#endif
I might be missing something
> On 2015-Sep-23, at 10:28, Teresa Johnson wrote:
>
> tejohnson updated this revision to Diff 35527.
> tejohnson added a comment.
>
> Updated the patch for the new LLVM/gold patch
> (http://reviews.llvm.org/D13107).
>
> Two changes:
>
> - I put back the original change to pass a new plugin o
junbuml added a comment.
In this clang change, I added a state flag (bool IsColdRegion) in
CodeGenFunction and set/reset the flag in EmitCXXThrowExpr(). In EmitCall(),
the NoInline attribute would be added if IsColdRegion is true. As of now, this
change only handles throw statements because I d
junbuml edited subscribers, added: cfe-commits; removed: llvm-commits.
junbuml updated this revision to Diff 36107.
http://reviews.llvm.org/D12979
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGException.cpp
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGenCXX/thro
Author: rnk
Date: Wed Sep 30 12:30:48 2015
New Revision: 248925
URL: http://llvm.org/viewvc/llvm-project?rev=248925&view=rev
Log:
[Sema] Avoid crashing during this-> insertion recovery
We get into this bad state when someone defines a new member function
for a class but forgets to add the declara
Prazek updated this revision to Diff 36125.
http://reviews.llvm.org/D13279
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/virtual-function-calls.cpp
Index: test/CodeGenCXX/virtual-function-calls.cpp
===
--- test/CodeGenCXX
On Wed, Sep 30, 2015 at 10:19 AM, Duncan P. N. Exon Smith
wrote:
>
>> On 2015-Sep-23, at 10:28, Teresa Johnson wrote:
>>
>> tejohnson updated this revision to Diff 35527.
>> tejohnson added a comment.
>>
>> Updated the patch for the new LLVM/gold patch
>> (http://reviews.llvm.org/D13107).
>>
>>
Prazek updated this revision to Diff 36130.
http://reviews.llvm.org/D13279
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/virtual-function-calls.cpp
Index: test/CodeGenCXX/virtual-function-calls.cpp
===
--- test/CodeGenCXX
> On 2015-Sep-30, at 10:40, Teresa Johnson wrote:
>
> On Wed, Sep 30, 2015 at 10:19 AM, Duncan P. N. Exon Smith
> wrote:
>>
>>> On 2015-Sep-23, at 10:28, Teresa Johnson wrote:
>>>
>>> tejohnson updated this revision to Diff 35527.
>>> tejohnson added a comment.
>>>
>>> Updated the patch for
Author: rikka
Date: Wed Sep 30 13:23:35 2015
New Revision: 248928
URL: http://llvm.org/viewvc/llvm-project?rev=248928&view=rev
Log:
Don't correct non-class using declarations to class members.
Such declarations would be invalid anyway, and trying to make the
correction will lead to a crash. Fixes
dcoughlin added inline comments.
Comment at: test/Analysis/array-struct-region.cpp:128
@@ +127,3 @@
+#if __cplusplus
+ clang_analyzer_eval((void *)&PFONew->secondField != (void *)&PFONew); //
expected-warning{{TRUE}}
+#endif
ismailp wrote:
> I might be missing s
Hi,
I think this change breaks cmake build. Please consider the attached fix (I
can't push atm).
thank you,
Jan
On Wed, Sep 30, 2015 at 8:59 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Wed Sep 30 08:59:29 2015
> New Revision: 248904
>
> URL: h
This breaks your *build*? How?
On Wed, Sep 30, 2015 at 9:19 PM, Jan Vesely wrote:
> Hi,
> I think this change breaks cmake build. Please consider the attached fix
> (I can't push atm).
>
> thank you,
> Jan
>
> On Wed, Sep 30, 2015 at 8:59 AM, Daniel Jasper via cfe-commits <
> cfe-commits@lists.l
Author: djasper
Date: Wed Sep 30 14:28:47 2015
New Revision: 248929
URL: http://llvm.org/viewvc/llvm-project?rev=248929&view=rev
Log:
clang-format: Add clangRewrite dependency to fix cmake build.
Modified:
cfe/trunk/tools/clang-format/CMakeLists.txt
Modified: cfe/trunk/tools/clang-format/CMa
cmake build hopefully fixed in r248929. How is the patch you have attached
related?
On Wed, Sep 30, 2015 at 9:24 PM, Daniel Jasper wrote:
> This breaks your *build*? How?
>
> On Wed, Sep 30, 2015 at 9:19 PM, Jan Vesely
> wrote:
>
>> Hi,
>> I think this change breaks cmake build. Please consider
On Wed, Sep 30, 2015 at 11:11 AM, Duncan P. N. Exon Smith
wrote:
>
>> On 2015-Sep-30, at 10:40, Teresa Johnson wrote:
>>
>> On Wed, Sep 30, 2015 at 10:19 AM, Duncan P. N. Exon Smith
>> wrote:
>>>
On 2015-Sep-23, at 10:28, Teresa Johnson wrote:
tejohnson updated this revision to D
junbuml created this revision.
junbuml added reviewers: hfinkel, mcrosier, reames, ashutosh.nema, majnemer.
junbuml added subscribers: gberry, cfe-commits.
It might be reasonably to avoid inlining CallSites invoked in
exception handling context so that we can reduce code size blow-up in
EH regions
junbuml abandoned this revision.
junbuml added a comment.
Move this clang change in http://reviews.llvm.org/D13304
http://reviews.llvm.org/D12979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Ah, very sorry, I was looking at the wrong patch. So I did make the same
change :-)
On Wed, Sep 30, 2015 at 9:30 PM, Daniel Jasper wrote:
> cmake build hopefully fixed in r248929. How is the patch you have attached
> related?
>
> On Wed, Sep 30, 2015 at 9:24 PM, Daniel Jasper wrote:
>
>> This b
Author: bruno
Date: Wed Sep 30 14:55:07 2015
New Revision: 248932
URL: http://llvm.org/viewvc/llvm-project?rev=248932&view=rev
Log:
[DarwinDriver] Use -lto_library to specify the path for libLTO.dylib
Usually, when using LTO with a clang installation newer than the
system's one, there's a libLTO.
Author: bruno
Date: Wed Sep 30 15:11:02 2015
New Revision: 248935
URL: http://llvm.org/viewvc/llvm-project?rev=248935&view=rev
Log:
Revert "[DarwinDriver] Use -lto_library to specify the path for libLTO.dylib"
Revert r248932. Bots complaining about new warnings where they shouldn't.
Modified:
Nice!
On 30 September 2015 at 15:55, Bruno Cardoso Lopes via cfe-commits
wrote:
> Author: bruno
> Date: Wed Sep 30 14:55:07 2015
> New Revision: 248932
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248932&view=rev
> Log:
> [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib
>
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added inline comments.
Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPITypes.h:67
@@ +66,3 @@
+ // Every time a request is 'set' a new 'RequestId' gets created.
+ // Therefore, the 'UserKind' does not need to be profiled.
+ const int RequestId{Reque
Author: dgregor
Date: Wed Sep 30 16:27:42 2015
New Revision: 248949
URL: http://llvm.org/viewvc/llvm-project?rev=248949&view=rev
Log:
Don't inherit availability information when implementing a protocol requirement.
When an Objective-C method implements a protocol requirement, do not
inherit any a
+echristo, +espindola, +pcc
> On 2015-Sep-30, at 12:39, Teresa Johnson wrote:
>
> On Wed, Sep 30, 2015 at 11:11 AM, Duncan P. N. Exon Smith
> wrote:
>>
>>> On 2015-Sep-30, at 10:40, Teresa Johnson wrote:
>>>
>>> On Wed, Sep 30, 2015 at 10:19 AM, Duncan P. N. Exon Smith
>>> wrote:
Author: dgregor
Date: Wed Sep 30 16:34:33 2015
New Revision: 248950
URL: http://llvm.org/viewvc/llvm-project?rev=248950&view=rev
Log:
Don't inherit the "unavailable" attribute from an overridden superclass method.
Fixes rdar://problem/22922259.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
c
rtrieu accepted this revision.
rtrieu added a comment.
Fix the comments, then it should be ready to commit.
Comment at: lib/Analysis/CFG.cpp:49
@@ +48,3 @@
+tryNormalizeBinaryOperator(const BinaryOperator *B) {
+ auto TryTransformToIntOrEnumConstant = [](const Expr *E) -> const
Author: jingyue
Date: Wed Sep 30 16:49:32 2015
New Revision: 248951
URL: http://llvm.org/viewvc/llvm-project?rev=248951&view=rev
Log:
[CUDA] fix codegen for __nvvm_atom_cas_*
Summary: __nvvm_atom_cas_* returns the old value instead of whether the swap
succeeds.
Reviewers: eliben, tra
Subscribe
Author: majnemer
Date: Wed Sep 30 17:07:43 2015
New Revision: 248953
URL: http://llvm.org/viewvc/llvm-project?rev=248953&view=rev
Log:
[Sema] Don't crash when friending an unqualified templated constructor
Unqualified templated constructors cannot be friended and our lack of a
diagnostic led to v
flx updated this revision to Diff 36151.
flx marked an inline comment as done.
flx added a comment.
Thanks for catching the last issues, Alex. I rebuilt and ran all tests using
llvm-lit -v . for clang-tidy and they pass.
http://reviews.llvm.org/D12839
Files:
clang-tidy/misc/MoveConstructorIn
mgehre created this revision.
mgehre added a subscriber: cfe-commits.
This check flags all uses of reinterpret_cast in C++ code.
Use of these casts can violate type safety and cause the program to
access a variable that is actually of type X to be accessed as if it
were of an unrelated type Z.
T
vsk added a subscriber: vsk.
vsk added a comment.
The patch lgtm. Has there been a discussion on cfe-dev about adopting these
guidelines?
I count well over 500 uses of reinterpret_cast in llvm+clang, so we might not
all be on the same page on this.
http://reviews.llvm.org/D13313
__
michaelwu created this revision.
michaelwu added a subscriber: cfe-commits.
Right now clang_Cursor_getMangling will attempt to mangle any declaration, even
if the declaration isn't mangled (extern "C"). This results in a partially
mangled name which isn't useful for much. This patch makes
clang
zarko created this revision.
zarko added reviewers: rnk, echristo, klimek.
zarko added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer, klimek.
This diff adds `addTargetAndModeForProgramName`, a utility function that will
add appropriate `-target foo` and `--d
davidxl created this revision.
davidxl added reviewers: bogner, rsmith.
davidxl added subscribers: cfe-commits, llvm-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
With PGO, the instrumented binary needs to dump __llvm_prf_data,
__llvm_prf_cnts, and __llvm_prf_names data sect
davidxl added a comment.
With this patch, 11M bytes (text section) can be shaved off clang build with
instrumentation.
http://reviews.llvm.org/D13319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
dcoughlin added a comment.
> What do people think about me creating a new patch based on your feedback?
I don't think you need to create a new review -- we can update this one and
keep the history.
> The aim would be to widen any non-exiting loops by invalidation. The initial
> patch would
vsk added a comment.
LGTM, thanks.
http://reviews.llvm.org/D12774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
Clang changes LGTM.
http://reviews.llvm.org/D13319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a subscriber: rsmith.
Comment at: tools/libclang/CIndex.cpp:3895
@@ +3894,3 @@
+ // Don't mangle if we don't need to.
+ if (!MC->shouldMangleCXXName(ND))
+return cxstring::createEmpty();
You should use `shouldMangleDeclName` here instead; this w
David Li writes:
> davidxl created this revision.
> davidxl added reviewers: bogner, rsmith.
> davidxl added subscribers: cfe-commits, llvm-commits.
> Herald added subscribers: srhines, danalbert, tberghammer.
>
> With PGO, the instrumented binary needs to dump __llvm_prf_data,
> __llvm_prf_cnts,
Author: adrian
Date: Wed Sep 30 19:48:51 2015
New Revision: 248974
URL: http://llvm.org/viewvc/llvm-project?rev=248974&view=rev
Log:
Module debugging: Emit Objective-C interfaces in their module scope when
building a clang module.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
cfe/trunk/
rsmith added inline comments.
Comment at: lib/Driver/ToolChains.cpp:2191-2193
@@ +2190,5 @@
+
+ SmallString<128> Path(getDriver().ResourceDir);
+ llvm::sys::path::append(Path, "prf_data.x");
+ CmdArgs.push_back(Args.MakeArgString(Path));
+ return true;
Please
Author: bwilson
Date: Wed Sep 30 19:53:13 2015
New Revision: 248975
URL: http://llvm.org/viewvc/llvm-project?rev=248975&view=rev
Log:
Fix printing of parameterized Objective-C interfaces.
This change was accidentally omitted from Doug's change in r241541.
Modified:
cfe/trunk/lib/AST/DeclPrin
Author: dirty
Date: Wed Sep 30 20:24:59 2015
New Revision: 248977
URL: http://llvm.org/viewvc/llvm-project?rev=248977&view=rev
Log:
createUniqueFile() is documented to create the file in the temporary directory
unless it's supplied an absolute path.
Make sure the output filepath supplied to crea
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248977: createUniqueFile() is documented to create the file
in the temporary… (authored by dirty).
Changed prior to commit:
http://reviews.llvm.org/D12774?vs=35463&id=36172#toc
Repository:
rL LLVM
h
On Wed, Sep 30, 2015 at 5:42 PM, Justin Bogner wrote:
> David Li writes:
>> davidxl created this revision.
>> davidxl added reviewers: bogner, rsmith.
>> davidxl added subscribers: cfe-commits, llvm-commits.
>> Herald added subscribers: srhines, danalbert, tberghammer.
>>
>> With PGO, the instrum
wristow created this revision.
wristow added reviewers: aaron.ballman, ygao, alexr, silvas, compnerd,
cfe-commits.
In versions of clang prior to r238238, __declspec was recognized as a
keyword in all modes. It was then changed to only be enabled when
Microsoft or Borland extensions were enabled
davidxl abandoned this revision.
davidxl added a comment.
Will split the patch into 3.
http://reviews.llvm.org/D13319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
wristow abandoned this revision.
wristow added a comment.
This has been superseded by http://reviews.llvm.org/D13322.
http://reviews.llvm.org/D11207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
compnerd added inline comments.
Comment at: include/clang/Basic/LangOptions.def:93
@@ -92,2 +92,3 @@
LANGOPT(WChar , 1, CPlusPlus, "wchar_t keyword")
+LANGOPT(DeclSpecKeyword , 1, 0, "Microsoft __declspec keyword support")
BENIGN_LANGOPT(DollarIdents , 1, 1, "'$'
Author: chandlerc
Date: Wed Sep 30 21:21:34 2015
New Revision: 248980
URL: http://llvm.org/viewvc/llvm-project?rev=248980&view=rev
Log:
Patch over a really horrible bug in our vector builtins that showed up
recently when we started using direct conversion to model sign
extension. The __v16qi type
This seems a little odd, could you explain in a bit more detail? Me not
understanding I imagine. :)
-eric
On Wed, Sep 30, 2015, 7:48 PM Luke Zarko wrote:
> zarko created this revision.
> zarko added reviewers: rnk, echristo, klimek.
> zarko added a subscriber: cfe-commits.
> Herald added subscr
echristo added a subscriber: echristo.
echristo added a comment.
This seems a little odd, could you explain in a bit more detail? Me not
understanding I imagine. :)
-eric
http://reviews.llvm.org/D13318
___
cfe-commits mailing list
cfe-commits@lists
chandlerc created this revision.
chandlerc added a reviewer: rsmith.
chandlerc added a subscriber: cfe-commits.
This further testing uncovered that AVX-2 has a broken cmpgt for 8-bit
elements, and has for a long time. This is fixed in the same way as
SSE4 handles the case.
The other ISA extension
Note that http://reviews.llvm.org/D13324 is the promised improved fix here,
awaiting review. =]
On Wed, Sep 30, 2015 at 7:23 PM Chandler Carruth via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chandlerc
> Date: Wed Sep 30 21:21:34 2015
> New Revision: 248980
>
> URL: http://llvm.org
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev created this revision.
ABataev added a reviewer: rjmccall.
ABataev added a subscriber: cfe-commits.
Currently codegen crashes trying to emit casting to `bool &`. It happens
because `bool` type is converted to `i1` and later then lvalue for reference is
converted to `i1*`. But when codege
rsmith added a subscriber: rsmith.
Comment at: include/clang/Basic/LangOptions.def:93
@@ -92,2 +92,3 @@
LANGOPT(WChar , 1, CPlusPlus, "wchar_t keyword")
+LANGOPT(DeclSpecKeyword , 1, 0, "Microsoft __declspec keyword support")
BENIGN_LANGOPT(DollarIdents , 1, 1, "
Author: prazek
Date: Wed Sep 30 22:50:41 2015
New Revision: 248982
URL: http://llvm.org/viewvc/llvm-project?rev=248982&view=rev
Log:
Decorating virtual functions load with invariant.load
http://reviews.llvm.org/D13279
Modified:
cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp
cfe/trunk/test/CodeG
Author: prazek
Date: Wed Sep 30 23:19:45 2015
New Revision: 248984
URL: http://llvm.org/viewvc/llvm-project?rev=248984&view=rev
Log:
Test fix
Modified:
cfe/trunk/test/CodeGenCXX/virtual-function-calls.cpp
Modified: cfe/trunk/test/CodeGenCXX/virtual-function-calls.cpp
URL:
http://llvm.org/vi
On Wed, Sep 30, 2015 at 8:52 PM Piotr Padlewski via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: prazek
> Date: Wed Sep 30 22:50:41 2015
> New Revision: 248982
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248982&view=rev
> Log:
> Decorating virtual functions load with invariant.l
davidxl created this revision.
davidxl added reviewers: rsmith, bogner.
davidxl added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
This is the patch-1. Driver tests are also added. See
http://reviews.llvm.org/D13319 for description.
http://reviews.llvm.or
davidxl removed subscribers: tberghammer, danalbert, srhines.
davidxl updated this revision to Diff 36186.
http://reviews.llvm.org/D13326
Files:
include/clang/Driver/ToolChain.h
lib/Driver/SanitizerArgs.cpp
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib
Xinliang David Li writes:
> On Wed, Sep 30, 2015 at 5:42 PM, Justin Bogner wrote:
>> David Li writes:
>>> davidxl created this revision.
>>> davidxl added reviewers: bogner, rsmith.
>>> davidxl added subscribers: cfe-commits, llvm-commits.
>>> Herald added subscribers: srhines, danalbert, tbergh
davidxl updated this revision to Diff 36190.
davidxl added a comment.
fix broken test (by clang-format).
http://reviews.llvm.org/D13326
Files:
include/clang/Driver/ToolChain.h
lib/Driver/SanitizerArgs.cpp
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib
Author: ericwf
Date: Thu Oct 1 01:15:26 2015
New Revision: 248986
URL: http://llvm.org/viewvc/llvm-project?rev=248986&view=rev
Log:
Dont link -lrt in the testsuite on linux unless using sanitizers.
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/con
1 - 100 of 101 matches
Mail list logo