r250645 - Use std::is_sorted instead of a manual loop.

2015-10-17 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun Oct 18 00:29:21 2015 New Revision: 250645 URL: http://llvm.org/viewvc/llvm-project?rev=250645&view=rev Log: Use std::is_sorted instead of a manual loop. Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp URL: http://llvm

r250647 - Make a bunch of static arrays const.

2015-10-17 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun Oct 18 00:29:26 2015 New Revision: 250647 URL: http://llvm.org/viewvc/llvm-project?rev=250647&view=rev Log: Make a bunch of static arrays const. Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/lib/CodeGen/TargetInfo.cpp

r250646 - Add an unnecessary makeArrayRef I add earlier. I didn't realize range-based for loops worked with arrays.

2015-10-17 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun Oct 18 00:29:23 2015 New Revision: 250646 URL: http://llvm.org/viewvc/llvm-project?rev=250646&view=rev Log: Add an unnecessary makeArrayRef I add earlier. I didn't realize range-based for loops worked with arrays. Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp Mod

[clang-tools-extra] r250641 - Make a bunch of static arrays const.

2015-10-17 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun Oct 18 00:14:41 2015 New Revision: 250641 URL: http://llvm.org/viewvc/llvm-project?rev=250641&view=rev Log: Make a bunch of static arrays const. Modified: clang-tools-extra/trunk/clang-modernize/UseAuto/UseAutoMatchers.cpp clang-tools-extra/trunk/clang-modernize/

Re: [PATCH] D13765: clang-format: [JS] Handle string literals spanning character classes.

2015-10-17 Thread Martin Probst via cfe-commits
mprobst updated this revision to Diff 37695. mprobst marked 3 inline comments as done. mprobst added a comment. - add test - review comments, fix unary handling. - Extract canPrecedeRegexLiteral function. http://reviews.llvm.org/D13765 Files: lib/Format/Format.cpp unittests/Format/FormatTes

Re: [PATCH] D13765: clang-format: [JS] Handle string literals spanning character classes.

2015-10-17 Thread Martin Probst via cfe-commits
mprobst added inline comments. Comment at: lib/Format/Format.cpp:860 @@ +859,3 @@ +} +if (Prev) { + if (Prev->isOneOf(tok::plusplus, tok::minusminus)) { djasper wrote: > I understand and I actually find that hard to understand. I think a better > sol

r250632 - clang/test/Driver/ps4-linker-non-win.c: Tweak for cygwin like ps4-linker-win.c@250403. Cygwin seeks dependent libs along $PATH.

2015-10-17 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat Oct 17 18:54:54 2015 New Revision: 250632 URL: http://llvm.org/viewvc/llvm-project?rev=250632&view=rev Log: clang/test/Driver/ps4-linker-non-win.c: Tweak for cygwin like ps4-linker-win.c@250403. Cygwin seeks dependent libs along $PATH. Modified: cfe/trunk/test/Drive

r250631 - clang/test/Driver/ps4-linker-non-win.c: Make %T/ps4-ld executable, or the driver wouldn't find it.

2015-10-17 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat Oct 17 18:47:02 2015 New Revision: 250631 URL: http://llvm.org/viewvc/llvm-project?rev=250631&view=rev Log: clang/test/Driver/ps4-linker-non-win.c: Make %T/ps4-ld executable, or the driver wouldn't find it. Modified: cfe/trunk/test/Driver/ps4-linker-non-win.c Modif

r250630 - clang/test/Driver/ps4-linker-non-win.c: Make sure that %T/ps4-ld would be used but *fails*.

2015-10-17 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat Oct 17 18:15:16 2015 New Revision: 250630 URL: http://llvm.org/viewvc/llvm-project?rev=250630&view=rev Log: clang/test/Driver/ps4-linker-non-win.c: Make sure that %T/ps4-ld would be used but *fails*. Modified: cfe/trunk/test/Driver/ps4-linker-non-win.c Modified: cf

Re: r250440 - clang-format: Basic escaping when outputting XML.

2015-10-17 Thread Daniel Jasper via cfe-commits
Added in r250629. On Thu, Oct 15, 2015 at 11:43 AM, Nico Weber wrote: > test? > > On Thu, Oct 15, 2015 at 11:39 AM, Daniel Jasper via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: djasper >> Date: Thu Oct 15 13:39:31 2015 >> New Revision: 250440 >> >> URL: http://llvm.org/viewv

r250629 - clang-format: Add test for (properly escaped) XML output.

2015-10-17 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Sat Oct 17 17:44:19 2015 New Revision: 250629 URL: http://llvm.org/viewvc/llvm-project?rev=250629&view=rev Log: clang-format: Add test for (properly escaped) XML output. Added: cfe/trunk/test/Format/xmloutput.cpp Added: cfe/trunk/test/Format/xmloutput.cpp URL: http://l

r250621 - Replace a static compare function with a lambda. NFC

2015-10-17 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 17 15:18:46 2015 New Revision: 250621 URL: http://llvm.org/viewvc/llvm-project?rev=250621&view=rev Log: Replace a static compare function with a lambda. NFC Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp URL: htt

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-10-17 Thread Michael Wu via cfe-commits
michaelwu added a comment. Visibility can be set via command line args without any attributes in the AST, so I don't think that's sufficient. http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

r250617 - Use a range-based for loop. Use std::end instead of pointer+array_lengthof. NFC

2015-10-17 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 17 12:10:43 2015 New Revision: 250617 URL: http://llvm.org/viewvc/llvm-project?rev=250617&view=rev Log: Use a range-based for loop. Use std::end instead of pointer+array_lengthof. NFC Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp Modified: cfe/trunk/lib/Basic/

Re: [PATCH] D13765: clang-format: [JS] Handle string literals spanning character classes.

2015-10-17 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: lib/Format/Format.cpp:828 @@ +827,3 @@ + // Returns \c true if \p Tok can only be followed by an operand in JavaScript. + bool PrecedesOperand(FormatToken *Tok) { +// NB: This is not entirely correct, as an r_paren can introduce an

Re: r250473 - Add an error when calling a builtin that requires features that don't

2015-10-17 Thread Eric Christopher via cfe-commits
On Sat, Oct 17, 2015 at 4:30 AM Dimitry Andric wrote: > On 16 Oct 2015, at 01:47, Eric Christopher via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > Author: echristo > > Date: Thu Oct 15 18:47:11 2015 > > New Revision: 250473 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=25047

Re: r250473 - Add an error when calling a builtin that requires features that don't

2015-10-17 Thread Dimitry Andric via cfe-commits
On 16 Oct 2015, at 01:47, Eric Christopher via cfe-commits wrote: > > Author: echristo > Date: Thu Oct 15 18:47:11 2015 > New Revision: 250473 > > URL: http://llvm.org/viewvc/llvm-project?rev=250473&view=rev > Log: > Add an error when calling a builtin that requires features that don't > match

Re: r250473 - Add an error when calling a builtin that requires features that don't

2015-10-17 Thread Eric Christopher via cfe-commits
I'm reasonably certain you forgot to rebuild or ran make test in the wrong directory. Two reasons: a) This is pretty much my first patch. I mean, identical and I tried that. b) I actually tried this one and got: Testing Time: 217.41s Failing Tests (68): Clang :: CodeGen/

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

2015-10-17 Thread David Majnemer via cfe-commits
majnemer added a comment. @rsmith, I've kept the caching of the `BuiltinTemplateDecl` for `__make_integer_seq` as we keep falling into the `LookupBuiltin`. Is there more that must be done to get "normal" lookups to find the decl? http://reviews.llvm.org/D13786 __

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

2015-10-17 Thread David Majnemer via cfe-commits
majnemer updated this revision to Diff 37676. majnemer added a comment. - Add test for __make_integer_seq http://reviews.llvm.org/D13786 Files: include/clang/AST/ASTContext.h include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclTemplate.h include/clang/AST/RecursiveASTVisit

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

2015-10-17 Thread David Majnemer via cfe-commits
majnemer updated this revision to Diff 37675. majnemer added a comment. - Make __make_integer_seq parameters as implicit - Remove Sema::Ident___make_integer_seq - Remove extraneous whitespace change http://reviews.llvm.org/D13786 Files: include/clang/AST/ASTContext.h include/clang/AST/DataR

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

2015-10-17 Thread David Majnemer via cfe-commits
majnemer updated this revision to Diff 37674. majnemer added a comment. - Rename BuiltinTemplateNameKind to BuiltinTemplateKind http://reviews.llvm.org/D13786 Files: include/clang/AST/ASTContext.h include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclTemplate.h include/clang

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

2015-10-17 Thread David Majnemer via cfe-commits
majnemer updated this revision to Diff 37673. majnemer added a comment. - Remove TemplateName::BuiltinTemplate http://reviews.llvm.org/D13786 Files: include/clang/AST/ASTContext.h include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclTemplate.h include/clang/AST/RecursiveAST

Re: r250473 - Add an error when calling a builtin that requires features that don't

2015-10-17 Thread Justin Bogner via cfe-commits
Eric Christopher writes: > Can't be. We don't know we're going to make the call until we code gen. :) Okay... but then why don't any tests fail with the attached? It looks like it does the right thing in a very cursory test, as well. commit 63d58fd0b4b77c9486901c103ec70c974d0c2553 Author: Justin

[PATCH] D13844: [libclang] Visit TypeAliasTemplateDecl

2015-10-17 Thread Sergey Kalinichev via cfe-commits
skalinichev created this revision. skalinichev added a reviewer: klimek. skalinichev added a subscriber: cfe-commits. This adds support for TypeAliasTemplateDecl in LibClang http://reviews.llvm.org/D13844 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_cursor_kind.py

Re: [PATCH] D13554: [X86] Enable soft float ABI for x86

2015-10-17 Thread Michael Kuperstein via cfe-commits
mkuper added a comment. It's ok, thanks a lot for taking the time to review it! http://reviews.llvm.org/D13554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-10-17 Thread Sergey Kalinichev via cfe-commits
skalinichev added a comment. Isn't r246931 what you're looking for? > Index: expose visibility attribute > > Expose the previously unexposed visibility attribute via the python and C > bindings. Can't you use/improve that API instead? http://reviews.llvm.org/D13388 __