[libcxx] r251220 - Update C++ status from Kona

2015-10-24 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Oct 25 01:02:23 2015 New Revision: 251220 URL: http://llvm.org/viewvc/llvm-project?rev=251220&view=rev Log: Update C++ status from Kona Modified: libcxx/trunk/www/cxx1z_status.html libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/cxx1z_status.html URL: ht

r251218 - [analyzer] scan-build: Teach ccc-analyzer about -Xclang.

2015-10-24 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Sat Oct 24 20:30:18 2015 New Revision: 251218 URL: http://llvm.org/viewvc/llvm-project?rev=251218&view=rev Log: [analyzer] scan-build: Teach ccc-analyzer about -Xclang. Update ccc-analyzer to forward both -Xclang and its following argument to the the compiler driver. Previ

r251214 - Simplify boolean conditional return statements in lib/Basic.

2015-10-24 Thread Rafael Espindola via cfe-commits
Author: rafael Date: Sat Oct 24 18:15:31 2015 New Revision: 251214 URL: http://llvm.org/viewvc/llvm-project?rev=251214&view=rev Log: Simplify boolean conditional return statements in lib/Basic. Patch by Richard. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets

Re: [PATCH] D10012: Refactor: Simplify boolean conditional return statements in lib/CodeGen

2015-10-24 Thread Rafael Espíndola via cfe-commits
r251213 On 24 October 2015 at 14:58, Richard wrote: > LegalizeAdulthood updated this revision to Diff 38317. > LegalizeAdulthood added a comment. > > Update to latest. > I do not have commit access. > > > http://reviews.llvm.org/D10012 > > Files: > lib/CodeGen/BranchFolding.cpp > lib/CodeGen/

Re: [PATCH] D10019: Refactor: Simplify boolean conditional return statements in lib/Sema

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38324. LegalizeAdulthood added a comment. Update from latest. Update from comments. I do not have commit access. http://reviews.llvm.org/D10019 Files: lib/Sema/SemaChecking.cpp lib/Sema/SemaCodeComplete.cpp lib/Sema/SemaDecl.cpp lib/Sema/S

[clang-tools-extra] r251204 - Test commit

2015-10-24 Thread Piotr Dziwinski via cfe-commits
Author: piotrdz Date: Sat Oct 24 15:11:47 2015 New Revision: 251204 URL: http://llvm.org/viewvc/llvm-project?rev=251204&view=rev Log: Test commit Modified: clang-tools-extra/trunk/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp Modified: clang-tools-extra/trunk/clang-t

Re: [PATCH] D10014: Refactor: Simplify boolean conditional return statements in lib/Edit

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. In http://reviews.llvm.org/D10014#178294, @calabrese wrote: > I like the idea of all of these changes (this change list and the others), > but just a suggestion -- it looks like when the branch of the original > condition returns false, as was the case in the

Re: [PATCH] D10014: Refactor: Simplify boolean conditional return statements in lib/Edit

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38323. LegalizeAdulthood added a comment. Update from latest. I do not have commit access. http://reviews.llvm.org/D10014 Files: lib/Edit/RewriteObjCFoundationAPI.cpp Index: lib/Edit/RewriteObjCFoundationAPI.cpp

Re: [PATCH] D10017: Refactor: Simplify boolean conditional return statements in lib/Lex

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38322. LegalizeAdulthood added a comment. Update to latest. I do not have commit access. http://reviews.llvm.org/D10017 Files: lib/Lex/PPDirectives.cpp lib/Lex/PPMacroExpansion.cpp Index: lib/Lex/PPMacroExpansion.cpp =

Re: [PATCH] D10010: Refactor: Simplify boolean conditional return statements in lib/AST

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38321. LegalizeAdulthood added a comment. Update from latest. I do not have commit access. http://reviews.llvm.org/D10010 Files: lib/AST/ASTContext.cpp lib/AST/ASTDiagnostic.cpp lib/AST/Decl.cpp lib/AST/DeclCXX.cpp lib/AST/Expr.cpp lib

Re: [PATCH] D10022: Refactor: Simplify boolean conditional return statements in lib/StaticAnalyzer/Core

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:692-693 @@ -691,4 +691,2 @@ CXXBasePaths Paths(false, false, false); - if (RD->lookupInBases( - [DeclName](const CXXBaseSpecifier *Specifier, CXXBasePath &Path)

Re: [PATCH] D10022: Refactor: Simplify boolean conditional return statements in lib/StaticAnalyzer/Core

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38319. LegalizeAdulthood added a comment. Update from latest http://reviews.llvm.org/D10022 Files: lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp lib/StaticAnalyzer/Core/SValBuilder.cpp lib/StaticAnalyzer/Core/SymbolManager.cpp Index:

Re: [PATCH] D10011: Refactor: Simplify boolean conditional return statements in lib/Basic

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38318. LegalizeAdulthood added a comment. Update to latest. I do not have commit access. http://reviews.llvm.org/D10011 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp ==

Re: [PATCH] D10012: Refactor: Simplify boolean conditional return statements in lib/CodeGen

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38317. LegalizeAdulthood added a comment. Update to latest. I do not have commit access. http://reviews.llvm.org/D10012 Files: lib/CodeGen/BranchFolding.cpp lib/CodeGen/CodeGenPrepare.cpp lib/CodeGen/LiveDebugVariables.cpp lib/CodeGen/Mach

Re: [PATCH] D10024: Refactor: Simplify boolean conditional return statements in tools/libclang

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38315. LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. Update to latest. Update from comments. I don't have commit access. http://reviews.llvm.org/D10024 Files: tools/libclang/CIndex.cpp tools/libclang/In

Re: [libcxx] r249929 - Split out of .

2015-10-24 Thread Michael Zolotukhin via cfe-commits
Hi Eric, Understood, thanks! Michael > On Oct 24, 2015, at 1:18 AM, Eric Fiselier wrote: > > Hi Michael, > > Sorry I'm holding this patch up in review. The fix is quite "novel" and I > want to make sure we get it right. If we can't land it over the weekend I'll > ask Richard to revert while

Getting fully qualified names of random qualtypes

2015-10-24 Thread Sterling Augustine via cfe-commits
As requested on cfe-dev, enclosed is a patch (that needs some style-related work) to calculate the complete fully qualified name of arbitrary Qualtypes, including recursively expanding template parameters and subtypes. Seems to me like it follows most of the conventions described here: http://llv

Re: [PATCH] D13954: CodeGen: Fix LLVM assertion if Swift and Clang emit Objective-C class reference in same LLVM module

2015-10-24 Thread Slava Pestov via cfe-commits
Unfortunately the asm label attribute doesn’t seem to work in this case, at least on Darwin. I get two symbols in the IR, with the asm label having the \01 prefix from MangleContext::mangleName(): @"\01OBJC_CLASS_$_NSNumber" = common global %struct.art_class* null, align 8

Re: [PATCH] D13954: CodeGen: Fix LLVM assertion if Swift and Clang emit Objective-C class reference in same LLVM module

2015-10-24 Thread Slava Pestov via cfe-commits
slavapestov added a subscriber: slavapestov. slavapestov added a comment. Unfortunately the asm label attribute doesn’t seem to work in this case, at least on Darwin. I get two symbols in the IR, with the asm label having the \01 prefix from MangleContext::mangleName(): @"\01OBJC_CLASS_$_NSNumb

Re: [PATCH] D10025: Refactor: Simplify boolean conditional return statements in clang-apply-replacements

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. I do not have commit access; someone will need to commit this for me. http://reviews.llvm.org/D10025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D10025: Refactor: Simplify boolean conditional return statements in clang-apply-replacements

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38313. LegalizeAdulthood added a comment. Update to latest http://reviews.llvm.org/D10025 Files: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp Index: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp ==

Re: [PATCH] D10023: Refactor: Simplify boolean conditional return statements in lib/StaticAnalyzer/Frontend

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38312. LegalizeAdulthood added a comment. Update to latest. This changeset needs reveiw; I am unsure of who to add as specific reviewers. http://reviews.llvm.org/D10023 Files: lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp Index: lib/Stati

Re: [PATCH] D10021: Refactor: Simplify boolean conditional return statements in lib/StaticAnalyzer/Checkers

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38311. LegalizeAdulthood added a comment. Update to latest. This changeset needs review; I am unsure who to add as specific reviewers. http://reviews.llvm.org/D10021 Files: lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp lib/StaticAn

Re: [PATCH] D10020: Refactor: Simplify boolean conditional return statements in lib/Serialization

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. This changeset needs review, but I'm unsure of who to add as explicit reviewers. http://reviews.llvm.org/D10020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D10020: Refactor: Simplify boolean conditional return statements in lib/Serialization

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38310. LegalizeAdulthood added a comment. Update to latest http://reviews.llvm.org/D10020 Files: lib/Serialization/ASTReader.cpp lib/Serialization/ASTWriter.cpp Index: lib/Serialization/ASTWriter.cpp ==

Re: [PATCH] D10016: Refactor: Simplify boolean conditional return statements in lib/Frontend

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. This changeset needs review; I'm unsure of who to add as explicit reviewers. http://reviews.llvm.org/D10016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D10016: Refactor: Simplify boolean conditional return statements in lib/Frontend

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38309. LegalizeAdulthood added a comment. Update to latest http://reviews.llvm.org/D10016 Files: lib/Frontend/VerifyDiagnosticConsumer.cpp Index: lib/Frontend/VerifyDiagnosticConsumer.cpp

Re: [PATCH] D14014: Checker of proper vfork usage

2015-10-24 Thread Aleksei Sidorin via cfe-commits
a.sidorin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:47 @@ +46,3 @@ + + bool isChildProcess(const ProgramStateRef State) const; + ygribov wrote: > a.sidorin wrote: > > I think it's a good idea to make some functions static and

Re: [PATCH] D14014: Checker of proper vfork usage

2015-10-24 Thread Yury Gribov via cfe-commits
ygribov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:149 @@ +148,3 @@ + + // see if it's an ordinary assignment + do { ygribov wrote: > a.sidorin wrote: > > You can use early return to escape do{}. > In this particular case - y

Re: [PATCH] D14014: Checker of proper vfork usage

2015-10-24 Thread Yury Gribov via cfe-commits
ygribov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:47 @@ +46,3 @@ + + bool isChildProcess(const ProgramStateRef State) const; + a.sidorin wrote: > I think it's a good idea to make some functions static and/or move them out >

Re: [PATCH] D14014: Checker of proper vfork usage

2015-10-24 Thread Aleksei Sidorin via cfe-commits
a.sidorin added a comment. I put some suggestions in inline comments. Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:47 @@ +46,3 @@ + + bool isChildProcess(const ProgramStateRef State) const; + I think it's a good idea to make some functions static an

Re: [libcxx] r249929 - Split out of .

2015-10-24 Thread Eric Fiselier via cfe-commits
Hi Michael, Sorry I'm holding this patch up in review. The fix is quite "novel" and I want to make sure we get it right. If we can't land it over the weekend I'll ask Richard to revert while we work on it. /Eric On Oct 23, 2015 10:13 PM, "Michael Zolotukhin via cfe-commits" < cfe-commits@lists.ll

Re: [libcxx] r249929 - Split out of .

2015-10-24 Thread Michael Zolotukhin via cfe-commits
Hi Richard, Is this patch ready for commit, or were you just checking an idea? Our bots are still failing to build povray, so we’re really looking forward for some fix:) Thanks, Michael > On Oct 15, 2015, at 6:21 PM, Manman Ren via cfe-commits > wrote: > >> >> On Oct 15, 2015, at 1:41 PM, R

r251182 - clang/module.modulemap: s/Basic/BuiltinsR600.def/Basic/BuiltinsAMDGPU.def/

2015-10-24 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat Oct 24 02:16:41 2015 New Revision: 251182 URL: http://llvm.org/viewvc/llvm-project?rev=251182&view=rev Log: clang/module.modulemap: s/Basic/BuiltinsR600.def/Basic/BuiltinsAMDGPU.def/ Modified: cfe/trunk/include/clang/module.modulemap Modified: cfe/trunk/include/clan