Re: Implict casts disappeared from syntactic init list expressions in C++

Ping (I still need your feedback so that I can open a properly documented issue on bugzilla). Il 09/10/2015 09:58, Abramo Bagnara ha scritto: > Il 08/10/2015 23:36, Richard Smith ha scritto: >> There are some other open problems in this area: >> >> - RecursiveASTVisitor on nested InitListExprs is

Re: [PATCH] D13610: [CodeGen] Fix CodeGenModule::CreateGlobalInitOrDestructFunction

This revision was automatically updated to reflect the committed changes. Closed by commit rL251734: [CodeGen] Call SetInternalFunctionAttributes to attach function (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D13610?vs=37001&id=38835#toc Repository: rL LLVM http

r251734 - [CodeGen] Call SetInternalFunctionAttributes to attach function

Author: ahatanak Date: Fri Oct 30 20:28:07 2015 New Revision: 251734 URL: http://llvm.org/viewvc/llvm-project?rev=251734&view=rev Log: [CodeGen] Call SetInternalFunctionAttributes to attach function attributes to internal functions. This patch fixes CodeGenModule::CreateGlobalInitOrDestructFuncti

Re: [PATCH] D14149: __builtin_signbit fix for ppcf128 type

rjmccall added a comment. LGTM, thanks! Repository: rL LLVM http://reviews.llvm.org/D14149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r251041 - Define weak and __weak to mean ARC-style weak references, even in MRC.

> On Oct 30, 2015, at 5:39 PM, Nico Weber wrote: > Hi John, > > this breaks programs that use __weak and target 10.6, like so: > > $ cat test.m > #import > @interface I : NSObject { > __weak NSObject* foo_; > } > - (NSObject*)foo; > @end > > @implementation I > - (NSObject *)foo { > return

r251729 - Sema: correct typo recovery with blocks

Author: compnerd Date: Fri Oct 30 19:39:15 2015 New Revision: 251729 URL: http://llvm.org/viewvc/llvm-project?rev=251729&view=rev Log: Sema: correct typo recovery with blocks Handle blocks in the tree transform for the typo correction as otherwise, the capture may miss. This would trigger an ass

Re: r251712 - Support watchOS and tvOS in compiler-rt builds

Do we need to port this to CMake as well? On Fri, Oct 30, 2015 at 9:30 AM, Tim Northover via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: tnorthover > Date: Fri Oct 30 11:30:51 2015 > New Revision: 251712 > > URL: http://llvm.org/viewvc/llvm-project?rev=251712&view=rev > Log: > Supp

[PATCH] D14212: Make hasLHS and hasRHS matchers available for ArraySubscriptExpr

alexfh created this revision. alexfh added a reviewer: klimek. alexfh added a subscriber: cfe-commits. Herald added a subscriber: klimek. The hasBase and hasIndex don't tell anything about the position of the base and the index in the code, so we need hasLHS and hasRHS in some cases. http://revie

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:458 @@ +457,3 @@ +StringRef Value = A->getValue(); +bool Valid = llvm::StringSwitch(Value) + .Case("default", true) tinti wrote: > compnerd wrote: > > If `llvm::EABI::EABIVer

Re: r251713 - CGExprConstant.cpp: Appease Modules.

I know. The builder was red for weeks (or months). Please be patient for my work. It's green now. I'll file bugs, two issues, when I got a slack time. 2015年10月30日(金) 9:44 Richard Smith : > On Oct 30, 2015 6:39 AM, "NAKAMURA Takumi via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > > >

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:524 @@ +523,3 @@ + .Case("5", llvm::EABI::Eabi5) + .Case("gnu", llvm::EABI::Gnu) + .Default(llvm::EABI::Default); compnerd wrote: > I'd really rather see this written in the LLVM

Re: r251713 - CGExprConstant.cpp: Appease Modules.

On Oct 30, 2015 6:39 AM, "NAKAMURA Takumi via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > > Author: chapuni > Date: Fri Oct 30 11:37:27 2015 > New Revision: 251713 > > URL: http://llvm.org/viewvc/llvm-project?rev=251713&view=rev > Log: > CGExprConstant.cpp: Appease Modules. Why? Please don

r251713 - CGExprConstant.cpp: Appease Modules.

Author: chapuni Date: Fri Oct 30 11:37:27 2015 New Revision: 251713 URL: http://llvm.org/viewvc/llvm-project?rev=251713&view=rev Log: CGExprConstant.cpp: Appease Modules. Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp URL: http://llvm.o

r251708 - Watch and TV OS: wire up basic ABI choices

Author: tnorthover Date: Fri Oct 30 11:30:36 2015 New Revision: 251708 URL: http://llvm.org/viewvc/llvm-project?rev=251708&view=rev Log: Watch and TV OS: wire up basic ABI choices This sets the mostly expected Darwin default ABI options for these two platforms. Active changes from these defaults

r251712 - Support watchOS and tvOS in compiler-rt builds

Author: tnorthover Date: Fri Oct 30 11:30:51 2015 New Revision: 251712 URL: http://llvm.org/viewvc/llvm-project?rev=251712&view=rev Log: Support watchOS and tvOS in compiler-rt builds Hopefully autotools will be deprecated soon and this entire file can go away, but until then... Modified: cf

r251710 - ARMv7k: implement ABI changes for watchOS from standard iOS.

Author: tnorthover Date: Fri Oct 30 11:30:45 2015 New Revision: 251710 URL: http://llvm.org/viewvc/llvm-project?rev=251710&view=rev Log: ARMv7k: implement ABI changes for watchOS from standard iOS. Added: cfe/trunk/test/CodeGen/armv7k-abi.c cfe/trunk/test/CodeGenCXX/armv7k.cpp cfe/tru

Re: [PATCH] D14204: Fix crash in redundant-void-arg check.

alexfh added inline comments. Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:131 @@ -130,1 +130,3 @@ StringRef GrammarLocation) { + if (Range.getBegin().isMacroID() || Range.getEnd().isMacroID()) +return; What happens if instead you pass the

r251711 - Support tvOS and watchOS availability attributes

Author: tnorthover Date: Fri Oct 30 11:30:49 2015 New Revision: 251711 URL: http://llvm.org/viewvc/llvm-project?rev=251711&view=rev Log: Support tvOS and watchOS availability attributes Added: cfe/trunk/test/Sema/attr-availability-tvos.c cfe/trunk/test/Sema/attr-availability-watchos.c Mod

r251709 - Disable SjLj exceptions for watchOS

Author: tnorthover Date: Fri Oct 30 11:30:41 2015 New Revision: 251709 URL: http://llvm.org/viewvc/llvm-project?rev=251709&view=rev Log: Disable SjLj exceptions for watchOS Modified: cfe/trunk/include/clang/Driver/ToolChain.h cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/To

r251706 - Support watchOS and tvOS driver options

Author: tnorthover Date: Fri Oct 30 11:30:27 2015 New Revision: 251706 URL: http://llvm.org/viewvc/llvm-project?rev=251706&view=rev Log: Support watchOS and tvOS driver options This patch should add support for almost all command-line options and driver tinkering necessary to produce a correct "c

r251707 - Preprocessor: define correct tvOS and watchOS version macros

Author: tnorthover Date: Fri Oct 30 11:30:30 2015 New Revision: 251707 URL: http://llvm.org/viewvc/llvm-project?rev=251707&view=rev Log: Preprocessor: define correct tvOS and watchOS version macros Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/test/Frontend/darwin-version.c Modifie

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

DavidEGrayson added a comment. Thanks, John! Looks like it's actually committed in rL251651 . Thanks for handling the volatile pointers correctly (I didn't know I had to do something special for them) and giving me credit in the commit message! http://revi

r251703 - Modules: Add a declaration in clang/Serialization/GlobalModuleIndex.h.

Author: chapuni Date: Fri Oct 30 10:54:34 2015 New Revision: 251703 URL: http://llvm.org/viewvc/llvm-project?rev=251703&view=rev Log: Modules: Add a declaration in clang/Serialization/GlobalModuleIndex.h. Modified: cfe/trunk/include/clang/Serialization/GlobalModuleIndex.h Modified: cfe/trunk

[PATCH] D14205: [x86] Front-end part of MCU psABI support

andreybokhanko created this revision. andreybokhanko added reviewers: rnk, DavidKreitzer, mkuper. andreybokhanko added a subscriber: cfe-commits. This patch implements front-end parts of MCU psABI (https://docs.google.com/viewer?a=v&pid=sites&srcid=ZGVmYXVsdGRvbWFpbnx4MzJhYml8Z3g6NzFhMGYzMjUzZDQz

[PATCH] D14204: Fix crash in redundant-void-arg check.

angelgarcia created this revision. angelgarcia added reviewers: klimek, LegalizeAdulthood. angelgarcia added subscribers: alexfh, cfe-commits. When applying this check to the unit tests, it would hit an assertion: llvm/tools/clang/lib/Lex/Lexer.cpp:1056: clang::SourceLocation clang::Lexer::getSou

[PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

xazax.hun created this revision. xazax.hun added reviewers: zaks.anna, dcoughlin. xazax.hun added subscribers: cfe-commits, dkrupp. This patch is intended to improve pointer arithmetic checker. >From now on it tries to only warn, when the pointer arithmetic is likely to >cause an error. For exam

r251702 - Reapply r251621 "[Analyzer] Widening loops which do not exit"

Author: seaneveson Date: Fri Oct 30 10:23:57 2015 New Revision: 251702 URL: http://llvm.org/viewvc/llvm-project?rev=251702&view=rev Log: Reapply r251621 "[Analyzer] Widening loops which do not exit" It was not the cause of the build bot failure. Added: cfe/trunk/include/clang/StaticAnalyzer/

r251701 - clang/module.modulemap: Exclude Frontend/PCHContainerOperations.h in Clang_Frontend.

Author: chapuni Date: Fri Oct 30 10:14:55 2015 New Revision: 251701 URL: http://llvm.org/viewvc/llvm-project?rev=251701&view=rev Log: clang/module.modulemap: Exclude Frontend/PCHContainerOperations.h in Clang_Frontend. FIXME: It should be dissolved to interface and impl. Modified: cfe/trunk

Re: [PATCH] D14188: Format: support inline namespaces

compnerd closed this revision. compnerd added a comment. SVN r251690 with the mod. http://reviews.llvm.org/D14188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

compnerd added a comment. This looks like what I had in mind wrt use of `-meabi`. Comment at: lib/CodeGen/BackendUtil.cpp:524 @@ +523,3 @@ + .Case("5", llvm::EABI::Eabi5) + .Case("gnu", llvm::EABI::Gnu) + .Default(llvm::EABI::Default); I'd reall

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti removed rL LLVM as the repository for this revision. tinti updated this revision to Diff 38803. tinti added a comment. Add context http://reviews.llvm.org/D14184 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/BackendUtil.cpp lib/Driver/T

[PATCH] D14198: Make the modernize-loop-convert's const-detection smarter.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: alexfh, cfe-commits. Now, it detects that several kinds of usages are can't modify the elements. Examples: -When an usage is a call to a const member function or operator of the element. -If th

Re: r251695 - Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots.

On 30 October 2015 at 11:42, Vasileios Kalintiris wrote: > I'm sorry for any inconvenience I might have caused. I was waiting to commit > this early in the morning, near the end of the week, when the commit activity > is low. This shouldn't be done even during weekends or low commit activity.

RE: r251695 - Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots.

Hi Renato, > Please, don't do this. If you need investigation, you can ask the bot owner > (me) to help you. I'm sorry for any inconvenience I might have caused. I was waiting to commit this early in the morning, near the end of the week, when the commit activity is low. > For now, if you hav

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

rengolin added reviewers: jroelofs, t.p.northover. rengolin added subscribers: jroelofs, t.p.northover. rengolin added a comment. You forgot to add the context. It makes a big difference in the driver code. :) But overall, looks good to me. @jroelofs @compnerd @t.p.northover, can you see anythin

r251698 - Revert "[mips] Add support for the new mips-mti-linux toolchain."

Author: vkalintiris Date: Fri Oct 30 06:28:39 2015 New Revision: 251698 URL: http://llvm.org/viewvc/llvm-project?rev=251698&view=rev Log: Revert "[mips] Add support for the new mips-mti-linux toolchain." This reverts commits r251633. I'll investigate the test failure off trunk in order to keep th

r251697 - Revert r251621 "[Analyzer] Widening loops which do not exit" (bot failure)

Author: seaneveson Date: Fri Oct 30 06:13:07 2015 New Revision: 251697 URL: http://llvm.org/viewvc/llvm-project?rev=251697&view=rev Log: Revert r251621 "[Analyzer] Widening loops which do not exit" (bot failure) Seems to be causing clang-cmake-mips build bot to fail (timeout) http://lab.llvm.org

r251696 - Revert "Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots."

Author: rengolin Date: Fri Oct 30 06:12:36 2015 New Revision: 251696 URL: http://llvm.org/viewvc/llvm-project?rev=251696&view=rev Log: Revert "Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots." This reverts commit r251695. Debug is meant to be done off tree, not use

Re: r251695 - Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots.

On 30 October 2015 at 10:35, Vasileios Kalintiris via cfe-commits wrote: > Author: vkalintiris > Date: Fri Oct 30 05:35:38 2015 > New Revision: 251695 > > URL: http://llvm.org/viewvc/llvm-project?rev=251695&view=rev > Log: > Try to run and investigate the mips-mti-linux.c test failure on ARM build

r251695 - Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots.

Author: vkalintiris Date: Fri Oct 30 05:35:38 2015 New Revision: 251695 URL: http://llvm.org/viewvc/llvm-project?rev=251695&view=rev Log: Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots. This should be a NFC for every toolchain other than mips-mti-linux (where we pri

[clang-tools-extra] r251694 - Only copy small types in modernize-loop-convert.

Author: angelgarcia Date: Fri Oct 30 04:37:57 2015 New Revision: 251694 URL: http://llvm.org/viewvc/llvm-project?rev=251694&view=rev Log: Only copy small types in modernize-loop-convert. Summary: If the size of the type is above a certain bound, we'll take a const reference. This bound can be se

Re: [PATCH] D14176: Only copy small types in modernize-loop-convert.

This revision was automatically updated to reflect the committed changes. Closed by commit rL251694: Only copy small types in modernize-loop-convert. (authored by angelgarcia). Changed prior to commit: http://reviews.llvm.org/D14176?vs=38736&id=38789#toc Repository: rL LLVM http://reviews.l

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris updated this revision to Diff 38788. vkalintiris added a comment. s/__NetBSD_\)/__NetBSD__\)/ http://reviews.llvm.org/D13673 Files: CMakeLists.txt include/__config include/__config_site.in include/__locale include/support/musl/xlocale.h src/locale.cpp Index: src/locale.

r251693 - Add "equalsNode" for types and "isCopyAssignmentOperator" matchers.

Author: angelgarcia Date: Fri Oct 30 04:35:51 2015 New Revision: 251693 URL: http://llvm.org/viewvc/llvm-project?rev=251693&view=rev Log: Add "equalsNode" for types and "isCopyAssignmentOperator" matchers. Summary: This matchers are going to be used in modernize-use-default, but are generic enou