Re: [PATCH] D14880: Fixed some buggy edge-cases in UseOverrideCheck.cpp

2015-11-21 Thread Sam Baxter via cfe-commits
baxtersa added a comment. I don't know who to add as reviewers here, so if someone in the know could do that that would be great! http://reviews.llvm.org/D14880 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14858: Support building tsan on android.

2015-11-21 Thread Dimitry Ivanov via cfe-commits
dimitry added a comment. The only difference is that main executable group is not RTLD_GLOBAL in android (it is RTLD_GLOBAL in glibc) - so the symbols of DT_NEEDED libraries are not visible by default; the way to enforce this for you library on android is to use -z global ld option

Re: [PATCH] D14877: Fix ICE on lowering of constexpr vector splats

2015-11-21 Thread Richard Smith via cfe-commits
It would seem cleaner to build an ImplicitCastExpr node in Sema between the operand and the splat node. On Nov 20, 2015 11:04 AM, "George Burgess IV" wrote: > george.burgess.iv created this revision. > george.burgess.iv added a reviewer: rsmith. > george.burgess.iv

Re: [PATCH] D9600: Add scan-build python implementation

2015-11-21 Thread Devin Coughlin via cfe-commits
dcoughlin added a comment. Thanks Laszlo! Is there a more descriptive name than "intercept-build" (I realize scan-build is pretty general too). It seems to me the point of the intercept-build tool is to generate the compilation database. I think it would be helpful if the tool name indicated

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

2015-11-21 Thread hfin...@anl.gov via cfe-commits
hfinkel added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:3547 @@ +3546,3 @@ +// Round up address of argument to alignment +llvm::Value *overflow_arg_area = OverflowArea.getPointer(); +uint32_t Align =

r253812 - [coroutines] Materialize the awaitable before generating the await_* calls.

2015-11-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Nov 21 21:13:02 2015 New Revision: 253812 URL: http://llvm.org/viewvc/llvm-project?rev=253812=rev Log: [coroutines] Materialize the awaitable before generating the await_* calls. Modified: cfe/trunk/lib/Sema/SemaCoroutine.cpp Modified:

r253815 - Test: Update mingw-useld.c to reflect r253813

2015-11-21 Thread Martell Malone via cfe-commits
Author: martell Date: Sat Nov 21 23:45:03 2015 New Revision: 253815 URL: http://llvm.org/viewvc/llvm-project?rev=253815=rev Log: Test: Update mingw-useld.c to reflect r253813 Modified: cfe/trunk/test/Driver/mingw-useld.c Modified: cfe/trunk/test/Driver/mingw-useld.c URL:

r253816 - [coroutines] Build implicit return_value / return_void calls for co_return.

2015-11-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Nov 22 01:05:16 2015 New Revision: 253816 URL: http://llvm.org/viewvc/llvm-project?rev=253816=rev Log: [coroutines] Build implicit return_value / return_void calls for co_return. Modified: cfe/trunk/include/clang/AST/StmtCXX.h cfe/trunk/lib/Sema/SemaCoroutine.cpp

r253813 - Driver: Specifically tell the linker the target for mingw-w64

2015-11-21 Thread Martell Malone via cfe-commits
Author: martell Date: Sat Nov 21 23:40:06 2015 New Revision: 253813 URL: http://llvm.org/viewvc/llvm-project?rev=253813=rev Log: Driver: Specifically tell the linker the target for mingw-w64 Cross compiling from linux and OSX results in Error: Exec format. This is because the linker is expecting

r253817 - [coroutines] Check for overload sets in co_yield / co_return operands being resolved by a call to yield_value / return_value before rejecting them.

2015-11-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Nov 22 01:33:28 2015 New Revision: 253817 URL: http://llvm.org/viewvc/llvm-project?rev=253817=rev Log: [coroutines] Check for overload sets in co_yield / co_return operands being resolved by a call to yield_value / return_value before rejecting them. Modified:

Re: [PATCH] D14877: Fix ICE on lowering of constexpr vector splats

2015-11-21 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. Comment at: lib/CodeGen/CGExprConstant.cpp:1362-1363 @@ -1360,3 +1361,4 @@ +Inits[I] = llvm::ConstantFP::get(VMContext, Elt.getFloat()); else -Inits.push_back(llvm::ConstantFP::get(VMContext, Elt.getFloat())); +

Re: [PATCH] D9600: Add scan-build python implementation

2015-11-21 Thread Jonathan Roelofs via cfe-commits
On 11/21/15 9:50 AM, Devin Coughlin wrote: dcoughlin added a comment. Thanks Laszlo! Is there a more descriptive name than "intercept-build" (I realize scan-build is pretty general too). It seems to me the point of the intercept-build tool is to generate the compilation database. I think it

r253811 - [coroutines] Factor out co_await representation into common base class for co_await and co_yield, and use it to hold await_* calls.

2015-11-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Nov 21 20:57:17 2015 New Revision: 253811 URL: http://llvm.org/viewvc/llvm-project?rev=253811=rev Log: [coroutines] Factor out co_await representation into common base class for co_await and co_yield, and use it to hold await_* calls. Modified:

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

2015-11-21 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. Clang tidy can pass per checker configuration to the static analyzer at the moment. I think it should not be hard to extend it. http://reviews.llvm.org/D14629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r253772 - clang-format: Make sorting includes respect // clang-format off

2015-11-21 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Sat Nov 21 03:17:08 2015 New Revision: 253772 URL: http://llvm.org/viewvc/llvm-project?rev=253772=rev Log: clang-format: Make sorting includes respect // clang-format off Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/unittests/Format/SortIncludesTest.cpp