r253900 - clang-format: Re-add code path deleted in r253873 and add missing test.

Author: djasper Date: Mon Nov 23 13:11:45 2015 New Revision: 253900 URL: http://llvm.org/viewvc/llvm-project?rev=253900=rev Log: clang-format: Re-add code path deleted in r253873 and add missing test. Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp

Re: [PATCH] D13731: [Analyzer] Supporting function attributes in .model files.

pgousseau added a comment. Ping! http://reviews.llvm.org/D13731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r253909 - Make clang_Cursor_getMangling not mangle if the declaration isn't mangled

Author: ehsan Date: Mon Nov 23 13:56:46 2015 New Revision: 253909 URL: http://llvm.org/viewvc/llvm-project?rev=253909=rev Log: Make clang_Cursor_getMangling not mangle if the declaration isn't mangled Right now clang_Cursor_getMangling will attempt to mangle any declaration, even if the

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

ehsan accepted this revision. ehsan added a reviewer: ehsan. ehsan added a comment. Landed in r253909. http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

sepavloff added a comment. Unit test, of course, checks import facility but i would say this is overkill. You need to create tests for all nodes you implement in imported, this is huge amount of work. I would propose you to move tests from http://reviews.llvm.org/D14224 for nodes that are

Re: r253859 - Fix calculation of shifted cursor/code positions. Specifically support

On 23 November 2015 at 10:41, Daniel Jasper wrote: > Seen and fixed, I think.. Still looks broken... :) http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/7684 http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/2616

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

ABataev updated this revision to Diff 40901. ABataev marked an inline comment as done. http://reviews.llvm.org/D13336 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/StmtNodes.td

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

ABataev marked an inline comment as done. Comment at: lib/Sema/SemaPseudoObject.cpp:1627 @@ -1579,1 +1626,3 @@ +cast(Base->IgnoreParens())->getBaseExpr()); +return MSPropertyRefRebuilder(S, BaseOVE->getSourceExpr()).rebuild(E); } else { rjmccall

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

ABataev added a comment. Ok, extracted all MCU specific changes to separate target class. http://reviews.llvm.org/D14864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r253863 - [OpenCL 2.0] Apply default address space (AS).

Author: stulova Date: Mon Nov 23 05:14:44 2015 New Revision: 253863 URL: http://llvm.org/viewvc/llvm-project?rev=253863=rev Log: [OpenCL 2.0] Apply default address space (AS). If AS of a variable/parameter declaration is not set by the source, OpenCL v2.0 s6.5 defines explicit rules for default

RE: [Patch][OpenCL] Custom atomic Builtin check ignores address space of a non-atomic pointer

Ping! Re-attaching the final patch. -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Anastasia Stulova via cfe-commits Sent: 21 October 2015 11:49 To: 'Pekka Jääskeläinen'; cfe-commits@lists.llvm.org Subject: RE: [Patch][OpenCL] Custom atomic

r253859 - Fix calculation of shifted cursor/code positions. Specifically support

Author: djasper Date: Mon Nov 23 02:33:48 2015 New Revision: 253859 URL: http://llvm.org/viewvc/llvm-project?rev=253859=rev Log: Fix calculation of shifted cursor/code positions. Specifically support the case where a specific range is replaced by new text. Previously, the calculation would shift

Re: [PATCH] D14441: [OpenCL] Pipe types support.

Anastasia added a subscriber: Anastasia. Comment at: include/clang/AST/Type.h:5018 @@ +5017,3 @@ +/// PipeType - OpenCL20. +/// +class PipeType : public Type, public llvm::FoldingSetNode { Any reason for an empty comment line here? Comment at:

r253861 - Fix clang-format test. I believe that the new behavior is better.

Author: djasper Date: Mon Nov 23 02:50:52 2015 New Revision: 253861 URL: http://llvm.org/viewvc/llvm-project?rev=253861=rev Log: Fix clang-format test. I believe that the new behavior is better. Modified: cfe/trunk/test/Format/cursor.cpp Modified: cfe/trunk/test/Format/cursor.cpp URL:

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

ABataev updated this revision to Diff 40904. http://reviews.llvm.org/D14864 Files: lib/Basic/Targets.cpp test/Sema/callingconv-iamcu.c Index: lib/Basic/Targets.cpp === --- lib/Basic/Targets.cpp +++ lib/Basic/Targets.cpp @@

r253860 - clang-format: Make moving of the Cursor work properly when sorting #includes.

Author: djasper Date: Mon Nov 23 02:36:35 2015 New Revision: 253860 URL: http://llvm.org/viewvc/llvm-project?rev=253860=rev Log: clang-format: Make moving of the Cursor work properly when sorting #includes. Modified: cfe/trunk/include/clang/Format/Format.h cfe/trunk/lib/Format/Format.cpp

Re: r253859 - Fix calculation of shifted cursor/code positions. Specifically support

On 23 November 2015 at 08:33, Daniel Jasper via cfe-commits wrote: > Author: djasper > Date: Mon Nov 23 02:33:48 2015 > New Revision: 253859 > > URL: http://llvm.org/viewvc/llvm-project?rev=253859=rev > Log: > Fix calculation of shifted cursor/code positions.

[PATCH] D14919: Fix IssueHash generation

o.gyorgy created this revision. o.gyorgy added reviewers: zaks.anna, xazax.hun, dcoughlin, jordan_rose. o.gyorgy added a subscriber: cfe-commits. Fixing IssueHash generation. There were some problems with the current version. If the Decl *D pointer is nullptr the NormalizeLine would crash while

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

spetrovic updated this revision to Diff 40915. spetrovic marked an inline comment as done. http://reviews.llvm.org/D14871 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/ppc-varargs-struct.c Index: test/CodeGen/ppc-varargs-struct.c

Re: [PATCH] D14441: [OpenCL] Pipe types support.

Anastasia added inline comments. Comment at: include/clang/AST/Type.h:5019 @@ +5018,3 @@ +/// +class PipeType : public Type, public llvm::FoldingSetNode { + QualType ElementType; Not related to this change though, but I was just thinking that it might be

Re: [PATCH] D14796: Preserve exceptions information during calls code generation.

sfantao updated this revision to Diff 40977. sfantao added a comment. Fix typo in comment. http://reviews.llvm.org/D14796 Files: include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprComplex.cpp lib/CodeGen/CGObjC.cpp

Re: [PATCH] D14796: Preserve exceptions information during calls code generation.

sfantao added a comment. Committed in r253926! Thanks, Samuel Comment at: lib/CodeGen/CGCall.cpp:1420 @@ +1419,3 @@ + // If we have information about the function prototype, we can learn + // attributes form there. + AddAttributesFromFunctionProtoType(getContext(),

[clang-tools-extra] r253929 - Fix test failure introduced by r253859. I believe that the new behavior

Author: djasper Date: Mon Nov 23 16:28:56 2015 New Revision: 253929 URL: http://llvm.org/viewvc/llvm-project?rev=253929=rev Log: Fix test failure introduced by r253859. I believe that the new behavior in r253859 makes sense in many cases and thus, I have fixed the implementation of

Re: r253859 - Fix calculation of shifted cursor/code positions. Specifically support

Fixed in r253929. On Mon, Nov 23, 2015 at 10:59 PM, Daniel Jasper wrote: > Oh, that is a different one. Looking into it. > > > On Mon, Nov 23, 2015 at 9:14 PM, Renato Golin > wrote: > >> On 23 November 2015 at 10:41, Daniel Jasper

r253932 - clang-c/Index.h: Move \brief. [-Wdocumentation]

Author: chapuni Date: Mon Nov 23 16:51:26 2015 New Revision: 253932 URL: http://llvm.org/viewvc/llvm-project?rev=253932=rev Log: clang-c/Index.h: Move \brief. [-Wdocumentation] Modified: cfe/trunk/include/clang-c/Index.h Modified: cfe/trunk/include/clang-c/Index.h URL:

Re: r253859 - Fix calculation of shifted cursor/code positions. Specifically support

Oh, that is a different one. Looking into it. On Mon, Nov 23, 2015 at 9:14 PM, Renato Golin wrote: > On 23 November 2015 at 10:41, Daniel Jasper wrote: > > Seen and fixed, I think.. > > Still looks broken... :) > >

r253926 - Preserve exceptions information during calls code generation.

Author: sfantao Date: Mon Nov 23 16:04:44 2015 New Revision: 253926 URL: http://llvm.org/viewvc/llvm-project?rev=253926=rev Log: Preserve exceptions information during calls code generation. This patch changes the generation of CGFunctionInfo to contain the FunctionProtoType if it is available.

r253950 - [modules] Add -cc1 flag -fmodules-embed-all-files.

Author: rsmith Date: Mon Nov 23 22:22:21 2015 New Revision: 253950 URL: http://llvm.org/viewvc/llvm-project?rev=253950=rev Log: [modules] Add -cc1 flag -fmodules-embed-all-files. This flag causes all files that were read by the compilation to be embedded into a produced module file. This is

Re: r253721 - [CMake] Add support for specifying arguments to the bootstrap build.

Good to know my spelling is at least consistently wrong :-). I’ll fix this shortly. -Chris > On Nov 20, 2015, at 8:12 PM, Sean Silva wrote: > > > > On Fri, Nov 20, 2015 at 2:09 PM, Chris Bieneman via cfe-commits >

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

hfinkel added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:3421 @@ -3419,3 +3420,3 @@ public: - PPC32_SVR4_ABIInfo(CodeGen::CodeGenTypes ) : DefaultABIInfo(CGT) {} + PPC32_SVR4_ABIInfo(CodeGen::CodeGenTypes , bool SoftFloatABI) : DefaultABIInfo(CGT),

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

rjmccall added inline comments. Comment at: lib/Sema/SemaPseudoObject.cpp:57 @@ +56,3 @@ + // with a base limits the number of cases here. + assert(refExpr->isObjectReceiver()); + Well, it should be okay to call this on something that doesn't have a

r253938 - CodeGenFunction.h: Prune a \param in r253926. [-Wdocumentation]

Author: chapuni Date: Mon Nov 23 17:38:13 2015 New Revision: 253938 URL: http://llvm.org/viewvc/llvm-project?rev=253938=rev Log: CodeGenFunction.h: Prune a \param in r253926. [-Wdocumentation] Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.h Modified:

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

rjmccall added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:3548 @@ +3547,3 @@ +llvm::Value *OverflowArgArea = OverflowArea.getPointer(); +uint32_t Align = CGF.getContext().getTypeAlignInChars(Ty).getQuantity(); +if (Align > 4) { This patch

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

sfantao updated this revision to Diff 41001. sfantao added a comment. Rebase. http://reviews.llvm.org/D9888 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Action.h include/clang/Driver/CC1Options.td include/clang/Driver/Driver.h

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

sfantao updated this revision to Diff 40992. sfantao added a comment. Rebase. http://reviews.llvm.org/D12614 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/LangOptions.def include/clang/Basic/LangOptions.h include/clang/Driver/CC1Options.td

Some buildbot statistics for week of 11/15/2015 - 11/21/2015

Hello everyone, Below are some buildbot numbers for the last week of 11/15/2015 - 11/21/2015. Thanks Galina Number of commits by project: project | commits ---+--- llvm | 265 cfe |

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

sfantao updated this revision to Diff 40999. sfantao updated the summary for this revision. sfantao added a comment. Rebase. http://reviews.llvm.org/D13909 Files: tools/CMakeLists.txt tools/Makefile tools/clang-offload-bundler/CMakeLists.txt

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

Ping. On Thu, Nov 5, 2015 at 6:32 PM, Richard Smith wrote: > Ping. > > On Thu, Oct 29, 2015 at 5:21 PM, Richard Smith > wrote: > >> Hi, >> >> The attached patch undoes the revert of r249929, and adds an extension to >> allow (and ) to work

Re: [PATCH] D10834: Added functions to retrieve information about whether a vardecl is local in libclang and its python bindings.

RedX2501 added a comment. Ping http://reviews.llvm.org/D10834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

ABataev updated this revision to Diff 41004. ABataev added a comment. Renamed MCU target class http://reviews.llvm.org/D14864 Files: lib/Basic/Targets.cpp test/Sema/callingconv-iamcu.c Index: lib/Basic/Targets.cpp === ---

r253949 - Remove DataRecursiveASTVisitor; it no longer serves any purpose, since it's just an alias for RecursiveASTVisitor.

Author: rsmith Date: Mon Nov 23 21:55:01 2015 New Revision: 253949 URL: http://llvm.org/viewvc/llvm-project?rev=253949=rev Log: Remove DataRecursiveASTVisitor; it no longer serves any purpose, since it's just an alias for RecursiveASTVisitor. Removed:

r253958 - Reduce the stack usage per recursive step when RecursiveASTVisitor cannot perform data recursion.

Author: rsmith Date: Tue Nov 24 01:13:06 2015 New Revision: 253958 URL: http://llvm.org/viewvc/llvm-project?rev=253958=rev Log: Reduce the stack usage per recursive step when RecursiveASTVisitor cannot perform data recursion. Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h

Re: [PATCH] D14919: Fix IssueHash generation

o.gyorgy updated this revision to Diff 40920. o.gyorgy added a comment. Regenerate patch with context and clang format HTMLDiagnostics.cpp. http://reviews.llvm.org/D14919 Files: include/clang/StaticAnalyzer/Core/IssueHash.h lib/Basic/SourceManager.cpp

[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

nrieck created this revision. nrieck added a subscriber: cfe-commits. Herald added a subscriber: klimek. Adds an option to control whether a space is inserted between "template" and "<". Currently a space is always inserted (as the LLVM style requires), but to me this seems like the less

r253873 - clang-format: Signficantly refactor the cast detection.

Author: djasper Date: Mon Nov 23 09:55:55 2015 New Revision: 253873 URL: http://llvm.org/viewvc/llvm-project?rev=253873=rev Log: clang-format: Signficantly refactor the cast detection. No functional changes intended. Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp Modified:

r253874 - Revert part of r253813

Author: martell Date: Mon Nov 23 10:04:55 2015 New Revision: 253874 URL: http://llvm.org/viewvc/llvm-project?rev=253874=rev Log: Revert part of r253813 The new lld gnu frontend does not support the -target option Modified: cfe/trunk/lib/Driver/Tools.cpp Modified:

Re: r253813 - Driver: Specifically tell the linker the target for mingw-w64

> > This changes the linker from old-gnu to gnu. Are you sure you want to > that? Originally I didn't actually mean to commit that. I had been working on some stuff locally. Pointing to the new one should be fine as neither work for COFF atm anyway so no point in having it point to the old one.

[PATCH] D14926: Use libcxx's default rune table with the Musl C library.

vkalintiris created this revision. vkalintiris added reviewers: mclow.lists, jroelofs, EricWF, dalias. vkalintiris added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer. Also, there are no exported character type tables from Musl so we have to Fallback to the

Re: [PATCH] D14926: Use libcxx's default rune table with the Musl C library.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/__locale:411-415 @@ -410,7 +410,3 @@ #else -#if defined(_LIBCPP_HAS_MUSL_LIBC) -typedef unsigned short mask; -#else typedef unsigned

Re: [PATCH] D14926: Use libcxx's default rune table with the Musl C library.

vkalintiris added a comment. @dalias: Can you take a correctness-look at this patch? Comment at: include/__locale:411-415 @@ -410,7 +410,3 @@ #else -#if defined(_LIBCPP_HAS_MUSL_LIBC) -typedef unsigned short mask; -#else typedef unsigned long mask; -#endif static

Re: [PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

djasper added a subscriber: djasper. djasper added a comment. This has come up before (read up on the list) and the decision is not to support it. In short, this is so un-important, that it is not worth a configuration option. http://reviews.llvm.org/D14927

r253871 - clang-format: If the template list of a variable declaration spans

Author: djasper Date: Mon Nov 23 09:55:45 2015 New Revision: 253871 URL: http://llvm.org/viewvc/llvm-project?rev=253871=rev Log: clang-format: If the template list of a variable declaration spans multiple lines, also break before the variable name. Before: std::vector

Re: r253813 - Driver: Specifically tell the linker the target for mingw-w64

This changes the linker from old-gnu to gnu. Are you sure you want to that? I don't think the new linker takes a -target option. In any case, it needs a test. Cheers, Rafael On 22 November 2015 at 00:40, Martell Malone via cfe-commits wrote: > Author: martell >

Re: [PATCH] D14872: PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type

DmitryPolukhin added a comment. It seems that check for type alignment <= 8 was there practically forever http://llvm.org/viewvc/llvm-project/cfe/trunk/Sema/SemaDecl.cpp?r1=47197=47196=47197 and there is no good explanation why it was implemented. Subsequent changes only add more condition to

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

sisnkemp updated this revision to Diff 40933. http://reviews.llvm.org/D14215 Files: lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/x86_64-profiling-keep-fp.c Index: test/CodeGen/x86_64-profiling-keep-fp.c

r253898 - Driver: fallback to the location of clang if no sysroot,

Author: martell Date: Mon Nov 23 12:59:48 2015 New Revision: 253898 URL: http://llvm.org/viewvc/llvm-project?rev=253898=rev Log: Driver: fallback to the location of clang if no sysroot, hard coding /usr makes little sense for mingw-w64. If we have portable toolchains having /usr breaks that. If

Re: r253874 - Revert part of r253813

This still needs a testcase. On 23 November 2015 at 11:04, Martell Malone via cfe-commits wrote: > Author: martell > Date: Mon Nov 23 10:04:55 2015 > New Revision: 253874 > > URL: http://llvm.org/viewvc/llvm-project?rev=253874=rev > Log: > Revert part of r253813 > The

Re: r253813 - Driver: Specifically tell the linker the target for mingw-w64

On 23 November 2015 at 11:15, Martell Malone wrote: >> This changes the linker from old-gnu to gnu. Are you sure you want to >> that? > > Originally I didn't actually mean to commit that. I had been working on some > stuff locally. > Pointing to the new one should be fine

Re: r253815 - Test: Update mingw-useld.c to reflect r253813

This (and all the patches in this series) look odd. The new "gnu" is ELF only. What exactly are you trying to do? Cheers, Rafael On 22 November 2015 at 00:45, Martell Malone via cfe-commits wrote: > Author: martell > Date: Sat Nov 21 23:45:03 2015 > New Revision:

Re: [PATCH] D14686: Protect against overloaded comma in random_shuffle and improve tests

mclow.lists added inline comments. Comment at: test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35 @@ -30,1 +34,3 @@ } + +template gribozavr wrote: > gribozavr wrote: > > mclow.lists wrote: > > > This is not how I would

r253886 - Disable frame pointer elimination when using -pg

Author: davidxl Date: Mon Nov 23 11:30:31 2015 New Revision: 253886 URL: http://llvm.org/viewvc/llvm-project?rev=253886=rev Log: Disable frame pointer elimination when using -pg (Re-apply patch after bug fixing) This diff makes sure that the driver does not pass -fomit-frame-pointer or

Re: [PATCH] D14887: Make tbm-builtins.c as X86 specific unit test

This revision was automatically updated to reflect the committed changes. Closed by commit rL253887: Make tbm-builtins.c as X86 specific unit test (authored by sgundapa). Changed prior to commit: http://reviews.llvm.org/D14887?vs=40824=40940#toc Repository: rL LLVM

Re: [PATCH] D14887: Make tbm-builtins.c as X86 specific unit test

sgundapa added a comment. Merged this as r253887 Repository: rL LLVM http://reviews.llvm.org/D14887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r253887 - Make tbm-builtins.c as X86 specific unit test

Author: sgundapa Date: Mon Nov 23 11:33:49 2015 New Revision: 253887 URL: http://llvm.org/viewvc/llvm-project?rev=253887=rev Log: Make tbm-builtins.c as X86 specific unit test Differential Revision: http://reviews.llvm.org/D14887 Modified: cfe/trunk/test/CodeGen/tbm-builtins.c Modified:

Re: r253886 - Disable frame pointer elimination when using -pg

On Mon, Nov 23, 2015 at 9:30 AM, Xinliang David Li via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: davidxl > Date: Mon Nov 23 11:30:31 2015 > New Revision: 253886 > > URL: http://llvm.org/viewvc/llvm-project?rev=253886=rev > Log: > Disable frame pointer elimination when using -pg >

Re: r253815 - Test: Update mingw-useld.c to reflect r253813

> > The new "gnu" is ELF only. What exactly are you trying to do? Yes and so was the old-gnu linker. I maintained patches in msys2 so that mingw-w64 could be able to use gnu with COFF.

r253872 - clang-format: Fix incorrect cast detection.

Author: djasper Date: Mon Nov 23 09:55:50 2015 New Revision: 253872 URL: http://llvm.org/viewvc/llvm-project?rev=253872=rev Log: clang-format: Fix incorrect cast detection. Before: bool b = f(g)& After: bool b = f(g) && c; Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp

Re: r253874 - Revert part of r253813

Yes the test case was updated in r253815 to reflect the change of old-gnu to gnu On Mon, Nov 23, 2015 at 8:37 AM, Rafael Espíndola < rafael.espind...@gmail.com> wrote: > This still needs a testcase. > > On 23 November 2015 at 11:04, Martell Malone via cfe-commits >

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

DavidKreitzer added a comment. Thanks, Alexey! I think this is an improvement. I don't know if anyone else has an opinion on the name of the new class, but I would prefer X86 over I386, possibly even MCUX86_32TargetInfo. Thanks, - Dave http://reviews.llvm.org/D14864

r253914 - Fix a warning about commas at the end of enumerator lists.

Author: mcrosier Date: Mon Nov 23 15:05:04 2015 New Revision: 253914 URL: http://llvm.org/viewvc/llvm-project?rev=253914=rev Log: Fix a warning about commas at the end of enumerator lists. Modified: cfe/trunk/include/clang-c/Index.h Modified: cfe/trunk/include/clang-c/Index.h URL: