Unfortunately, the bot still seems to be unhappy:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/12246/steps/build%20fresh%20clang/logs/stdio
On Tue, Nov 24, 2015 at 6:45 PM, Richard Smith
wrote:
> Hah, looks like a rejects-valid, but it found a real bug, so *shrug*. =)
Possible to test (unit test?) the bug that GCC accidentally found here?
On Tue, Nov 24, 2015 at 6:41 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue Nov 24 20:41:42 2015
> New Revision: 254053
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254
Hah, looks like a rejects-valid, but it found a real bug, so *shrug*. =)
Hopefully fixed in r254053.
On Tue, Nov 24, 2015 at 5:14 PM, Alexey Samsonov wrote:
> Hm, looks like we can't compile Clang itself after this change (with GCC):
>
>
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux
Author: rsmith
Date: Tue Nov 24 20:41:42 2015
New Revision: 254053
URL: http://llvm.org/viewvc/llvm-project?rev=254053&view=rev
Log:
Fix typo that was being SFINAE'd away (and apparently GCC 4.7.2 rejects-valid
on this).
Modified:
cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
Modified:
Hm, looks like we can't compile Clang itself after this change (with GCC):
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/12237
On Tue, Nov 24, 2015 at 3:50 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue Nov 24 17:50:
Unfortunately, that change breaks the Clang compilation, see r254041 review
thread.
On Tue, Nov 24, 2015 at 3:54 PM, Richard Smith
wrote:
> On Tue, Nov 24, 2015 at 1:16 PM, Alexey Samsonov
> wrote:
>
>> Looks like Clang::Index/index-many-call-ops.cpp still uses too much stack
>> in ASan mode:
>
Could this initialization just be written as "mbstate_t mb = {}" & avoid
the warning entirely (I'm not entirely sure what the warning was, but I
imagine that'd avoid it)
On Tue, Nov 24, 2015 at 5:06 PM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date:
Author: marshall
Date: Tue Nov 24 19:06:36 2015
New Revision: 254050
URL: http://llvm.org/viewvc/llvm-project?rev=254050&view=rev
Log:
Silence a -Wmissing-braces warning in the tests; mbstate_t is defined
differently on different C libraries.
Modified:
libcxx/trunk/test/std/depr/depr.c.heade
On Tue, Nov 24, 2015 at 1:16 PM, Alexey Samsonov wrote:
> Looks like Clang::Index/index-many-call-ops.cpp still uses too much stack
> in ASan mode:
>
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/10177/steps/check-clang%20asan/logs/stdio
>
> ASan increases the stack
Author: rsmith
Date: Tue Nov 24 17:50:47 2015
New Revision: 254041
URL: http://llvm.org/viewvc/llvm-project?rev=254041&view=rev
Log:
Teach RAV to pass its DataRecursionQueue to derived classes if they ask for it,
to allow them to explicitly opt into data recursion despite having overridden
Travers
hfinkel added a subscriber: hfinkel.
hfinkel added a comment.
Please upload this patch with full context, see:
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
> Should we add warning about changes in layout for packed bit-fileds of char
> type? GCC has it "note:
Author: marshall
Date: Tue Nov 24 16:10:51 2015
New Revision: 254030
URL: http://llvm.org/viewvc/llvm-project?rev=254030&view=rev
Log:
Remove undefined behavior from tests; specifically, ensure that the value type
of the allocators match the value type of the containers
Modified:
libcxx/tru
bcraig abandoned this revision.
bcraig added a comment.
Largely supplanted by r253958
http://reviews.llvm.org/D14506
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Looks like Clang::Index/index-many-call-ops.cpp still uses too much stack
in ASan mode:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/10177/steps/check-clang%20asan/logs/stdio
ASan increases the stack usage, so do you think there's more to fix here,
or we should just di
Author: kli
Date: Tue Nov 24 14:50:12 2015
New Revision: 254019
URL: http://llvm.org/viewvc/llvm-project?rev=254019&view=rev
Log:
[OpenMP] Parsing and sema support for num_teams clause
http://reviews.llvm.org/D14802
Added:
cfe/trunk/test/OpenMP/teams_num_teams_messages.cpp
Modified:
cfe/
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, probinson.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This fix should solve problem with parallel configure build introduced in
D12700 as suggested by
kfunk accepted this revision.
kfunk added a comment.
Looks good to me now. I'd also appreciate another +1 from somone else, though.
http://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, once one minor nit is fixed. Thank you for working on this!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:257
@@ +256,3 @@
+ "MIPS 'interrupt' a
rjmccall added a comment.
LGTM.
http://reviews.llvm.org/D14864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
This looks fantastic, thanks for doing all that. Approved with the one minor
change.
Comment at: lib/Sema/SemaPseudoObject.cpp:175
@@ -145,1 +174,3 @@
+PSE->getType(), PSE->getValueKind(), PSE->getObjectKind(),
+PSE->getRBracke
Author: dcoughlin
Date: Tue Nov 24 13:15:11 2015
New Revision: 254007
URL: http://llvm.org/viewvc/llvm-project?rev=254007&view=rev
Log:
[analyzer] Pass value expression for inlined defensive checks when binding null
to nonnull.
The nullability checker was not suppressing false positives resultin
dvadym added a comment.
Thanks alexfh! I've addressed your comments and uploaded new patch. PTAL
Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:56
@@ +55,3 @@
+<< IsConstArg << IsVariable << IsTriviallyCopyable
+<< FixItHint::CreateRemoval(Lexer::makeF
dvadym updated this revision to Diff 41061.
dvadym marked 8 inline comments as done.
dvadym added a comment.
In this patch alexfh comments addressed
http://reviews.llvm.org/D12031
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveConstantArgument
Hi Everyone,
I am continuing with updating Lit tests to be C++11 compatible.
Here is the fifth patch. This patch contains 20 tests.
These are mostly diagnostics changes due to new C++11 features and changes in
the standard.
Here are the explanations for each test in the order that they a
probinson added a comment.
The problem is that making the install-local target will try to create the
PROJ_sharedir directory in parallel with trying to copy DESTFILES to that
directory. You need to set up the dependencies such that the directory is
guaranteed to be created first. If you move
seaneveson added a subscriber: seaneveson.
seaneveson added a comment.
> If the Decl *D pointer is nullptr the NormalizeLine would crash while getting
> the LangOptions.
Do you have a reproducible test case for this?
http://reviews.llvm.org/D14919
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253990: Fix rewrite of reserved library name in case of
-nodefaultlibs (authored by niravd).
Changed prior to commit:
http://reviews.llvm.org/D14935?vs=41040&id=41052#toc
Repository:
rL LLVM
http://
Author: niravd
Date: Tue Nov 24 10:07:21 2015
New Revision: 253990
URL: http://llvm.org/viewvc/llvm-project?rev=253990&view=rev
Log:
Fix rewrite of reserved library name in case of -nodefaultlibs
The Driver only checked if nostdlib was set when deciding to add
reserved_lib_stdcxx, but as nostdlib
Hi,
David Blaikie via cfe-commits wrote:
> On Mon, Nov 23, 2015 at 9:30 AM, Xinliang David Li via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> > Author: davidxl
> > Date: Mon Nov 23 11:30:31 2015
> > New Revision: 253886
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=253886&view=r
andreybokhanko created this revision.
andreybokhanko added reviewers: ddunbar, rnk, mkuper.
andreybokhanko added a subscriber: cfe-commits.
This patch excludes incorrect include headers paths for MCU target.
http://reviews.llvm.org/D14954
Files:
lib/Frontend/InitHeaderSearch.cpp
test/Driver/
>
> Searching for gcc on Linux is not a good idea, you'll find the system one
> not the mingw one. Searching for i686-w64-mingw32-gcc or
> x86_64-w64-mingw32-gcc should work better, that is searching for:
> getTriple().getArchName()) + "-w64-mingw32-gcc"
Moreover, this should work on Windows as
Searching for gcc on Linux is not a good idea, you'll find the system one
not the mingw one. Searching for i686-w64-mingw32-gcc or
x86_64-w64-mingw32-gcc should work better, that is searching for:
getTriple().getArchName()) + "-w64-mingw32-gcc"
Moreover, this should work on Windows as well, min
sdardis updated this revision to Diff 41041.
sdardis added a comment.
Updated text of return type/parameters warning to Aaron's suggestion.
Dropped '\' escape characters from warning/error text.
Removed mips16/nomips16 check.
Tweak of comment in handleMipsInterruptAttr.
http://reviews.llvm.org
niravd updated this revision to Diff 41040.
niravd added a comment.
Fix review issues
http://reviews.llvm.org/D14935
Files:
lib/Driver/Driver.cpp
test/Driver/nodefaultlib.c
Index: test/Driver/nodefaultlib.c
===
--- test/Driver
>
> Why not hardcode /usr for Linux hosts?
Portable toolchain packages exist but can't on linux if you do this.
but in general I'm sure most would agree that detection is much better then
hard coding.
This is why Yaron approved the patch
Well this is a custom clang it can be anywhere. Official on
Author: abataev
Date: Tue Nov 24 07:01:44 2015
New Revision: 253977
URL: http://llvm.org/viewvc/llvm-project?rev=253977&view=rev
Log:
[OPENMP] Fix crash on codegen for 'task' directive with no shared variables.
If 'task' region does not have shared variables codegen could crash on
calculation of
DavidKreitzer added a comment.
Looks good, Alexey! I have no further comments.
- Dave
http://reviews.llvm.org/D14864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
niravd created this revision.
niravd added reviewers: dougk, jyknight.
niravd added subscribers: cfe-commits, rsmith.
Checks for nostdlib should also always check nodefaultlibs or nostartfiles as
appropriate. Clang Driver misses a case
http://reviews.llvm.org/D14935
Files:
lib/Driver/Driver.c
o.gyorgy updated this revision to Diff 41024.
o.gyorgy added a comment.
Some small format changes. Based on the review.
http://reviews.llvm.org/D14919
Files:
include/clang/StaticAnalyzer/Core/IssueHash.h
lib/Basic/SourceManager.cpp
lib/StaticAnalyzer/Checkers/DebugCheckers.cpp
lib/Stati
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp:150
@@ +149,3 @@
+return getArrayRegion(Region, Polymorphic, AKind, C);
+ default:
+break;
xazax.hun wrote:
> dcoughlin wrote:
> > In general, I think it is b
xazax.hun updated this revision to Diff 41022.
xazax.hun marked 11 inline comments as done.
xazax.hun added a comment.
- Fixed some of the review comments.
- Updated to latest trunk.
http://reviews.llvm.org/D14203
Files:
lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp
test/Analysis/PR24
xazax.hun added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/IssueHash.h:42
@@ -41,1 +41,3 @@
+ llvm::StringRef BugType, const Decl *D,
+ const LangOptions& LangOpts);
Please p
On Tue, Nov 24, 2015 at 12:43 PM, Martell Malone
wrote:
>> This breaks mingw support on openSUSE :
>
> My first question is why on SUSE is clang installed in /opt while mingw-w64
> in /usr?
Well this is a custom clang it can be anywhere. Official one is in /usr.
>> x86_64-w64-mingw32-gcc is in $
ABataev updated this revision to Diff 41018.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D13336
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Basic/StmtNodes.td
include/clang/Serialization/ASTBitCodes.h
lib/AST/Expr.c
>
> This breaks mingw support on openSUSE :
My first question is why on SUSE is clang installed in /opt while mingw-w64
in /usr?
x86_64-w64-mingw32-gcc is in $PATH, and this used to work fine before
> this commit.
It doesn't look for gcc on linux that is a windows host only thing.
It didn't do t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253972: Use libcxx's default rune table with the Musl C
library. (authored by vkalintiris).
Changed prior to commit:
http://reviews.llvm.org/D14926?vs=40926&id=41016#toc
Repository:
rL LLVM
http://r
Author: vkalintiris
Date: Tue Nov 24 04:24:54 2015
New Revision: 253972
URL: http://llvm.org/viewvc/llvm-project?rev=253972&view=rev
Log:
Use libcxx's default rune table with the Musl C library.
Summary:
Also, there are no exported character type tables from Musl so we have to
Fallback to the sta
On 23 November 2015 at 22:31, Daniel Jasper wrote:
> Fixed in r253929.
Thanks!
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi,
On Mon, Nov 23, 2015 at 8:59 PM, Martell Malone via cfe-commits
wrote:
> Author: martell
> Date: Mon Nov 23 12:59:48 2015
> New Revision: 253898
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253898&view=rev
> Log:
> Driver: fallback to the location of clang if no sysroot,
>
> hard coding /
49 matches
Mail list logo
