Re: [PATCH] D14940: [OpenMP] Update target directive codegen to use 4.5 implicit data mappings.

ABataev added inline comments. Comment at: include/clang/AST/Stmt.h:2018-2020 @@ -2016,2 +2017,5 @@ break; + case VCK_ByCopy: +assert(Var && "capturing by copy must have a variable!"); +break; case VCK_VLAType: Also add asserti

r254141 - [OPENMP 4.5] Fixed rules for 'ordered' clause.

Author: abataev Date: Thu Nov 26 01:50:39 2015 New Revision: 254141 URL: http://llvm.org/viewvc/llvm-project?rev=254141&view=rev Log: [OPENMP 4.5] Fixed rules for 'ordered' clause. According to OpenMP 4.5 the parameter of 'ordered' clause must be greater than or equal to the parameter of 'collaps

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

martell updated this revision to Diff 41209. martell added a comment. Updated to reflect feedback I'm not too sure what todo for testcases on this one because they already exist for the most part. I ran the test suite and they all pass. I would have to create a mingw32-gcc and {armv7|i686|x86_6

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

yaron.keren added a comment. This always searches for something-gcc and then discards the result if sysroot was provided, which is a waste. Move the searching to a helper function and then it can be done only if sysroot was not provided, as it is now. The break is needed to avoid looking for mi

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

martell added a comment. @ismail can you test this for your setup please? :) http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r254134 - [Diagnostics] Call setMapping on the correct diagnostic states in a few places. GetCurDiagState() was being used when it shouldn't be.

Author: ctopper Date: Wed Nov 25 23:51:54 2015 New Revision: 254134 URL: http://llvm.org/viewvc/llvm-project?rev=254134&view=rev Log: [Diagnostics] Call setMapping on the correct diagnostic states in a few places. GetCurDiagState() was being used when it shouldn't be. I spotted this by inspectio

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

martell updated the summary for this revision. martell updated this revision to Diff 41208. martell added a comment. Removed the break that I didn't think was needed Can be re-added ?? Will added testcases http://reviews.llvm.org/D15006 Files: lib/Driver/MinGWToolChain.cpp Index: lib/Driver

[PATCH] D15006: Driver: Better detection of mingw-gcc

martell created this revision. martell added a reviewer: yaron.keren. martell added a subscriber: cfe-commits. As discussed after r253898 here is the better gcc detection. Note: I could add a break in the new for loop but I don't feel it is needed Thoughts? http://reviews.llvm.org/D15006 File

r254133 - Use range-based for loops. NFC

Author: ctopper Date: Wed Nov 25 23:10:07 2015 New Revision: 254133 URL: http://llvm.org/viewvc/llvm-project?rev=254133&view=rev Log: Use range-based for loops. NFC Modified: cfe/trunk/lib/Basic/Diagnostic.cpp Modified: cfe/trunk/lib/Basic/Diagnostic.cpp URL: http://llvm.org/viewvc/llvm-pro

[PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

faisalv created this revision. faisalv added a reviewer: rsmith. faisalv added a subscriber: cfe-commits. Clang currently does no real checking of the template argument list when a template-id is used to declare a constructor: template struct X { X(); // Clang erroneously accepts this. }; Bot

Re: [PATCH] D12466: Fix empty -L Path on OSX hosts

martell added a comment. > Is this testable? Seems to me the only way to add this as a test would be to add bad code to clang to purposely pass an empty LibPath argument. This is probably something we do not want to do. This is probably why Reid never asked me for one in the review. Reposito

r254123 - Update reference to final TM TS spec.

Author: rsmith Date: Wed Nov 25 20:23:21 2015 New Revision: 254123 URL: http://llvm.org/viewvc/llvm-project?rev=254123&view=rev Log: Update reference to final TM TS spec. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm-project

r254122 - P0002R1: increment on expressions of type bool is no longer allowed in C++1z.

Author: rsmith Date: Wed Nov 25 20:16:37 2015 New Revision: 254122 URL: http://llvm.org/viewvc/llvm-project?rev=254122&view=rev Log: P0002R1: increment on expressions of type bool is no longer allowed in C++1z. Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td cfe/trunk/include/

r254121 - [modules] Refactor handling of -fmodules-embed-*. Track this properly rather

Author: rsmith Date: Wed Nov 25 20:04:16 2015 New Revision: 254121 URL: http://llvm.org/viewvc/llvm-project?rev=254121&view=rev Log: [modules] Refactor handling of -fmodules-embed-*. Track this properly rather than reusing the "overridden buffer" mechanism. This will allow us to make embedded file

Re: [PATCH] D12466: Fix empty -L Path on OSX hosts

Is this testable? On Nov 25, 2015 5:56 PM, "Martell Malone via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL254117: Driver: protect from empty -L args (authored by > martell). > > Changed prior to

Re: [PATCH] D12466: Fix empty -L Path on OSX hosts

dblaikie added a subscriber: dblaikie. dblaikie added a comment. Is this testable? Repository: rL LLVM http://reviews.llvm.org/D12466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D12466: Fix empty -L Path on OSX hosts

This revision was automatically updated to reflect the committed changes. Closed by commit rL254117: Driver: protect from empty -L args (authored by martell). Changed prior to commit: http://reviews.llvm.org/D12466?vs=33510&id=41202#toc Repository: rL LLVM http://reviews.llvm.org/D12466 Fi

[libcxx] r254119 - Add static_assert to set/multiset/map/multimap/forward_list/deque that the allocator's value_type match the container's value_type. vector/unordered/list/string already do this. Add

Author: marshall Date: Wed Nov 25 19:24:04 2015 New Revision: 254119 URL: http://llvm.org/viewvc/llvm-project?rev=254119&view=rev Log: Add static_assert to set/multiset/map/multimap/forward_list/deque that the allocator's value_type match the container's value_type. vector/unordered/list/string

r254117 - Driver: protect from empty -L args

Author: martell Date: Wed Nov 25 19:02:07 2015 New Revision: 254117 URL: http://llvm.org/viewvc/llvm-project?rev=254117&view=rev Log: Driver: protect from empty -L args Differential Revision: http://reviews.llvm.org/D12466 Modified: cfe/trunk/lib/Driver/ToolChain.cpp Modified: cfe/trunk/lib

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r254114 - [analyzer] Add tests for generalized lambda capture (C++14). NFC.

Author: dcoughlin Date: Wed Nov 25 18:11:23 2015 New Revision: 254114 URL: http://llvm.org/viewvc/llvm-project?rev=254114&view=rev Log: [analyzer] Add tests for generalized lambda capture (C++14). NFC. Add tests demonstrating that the analyzer supports generalized lambda capture. This support fa

Re: [PATCH] D13980: Add "x87" in x86 target feature map

rsmith added inline comments. Comment at: lib/Basic/Targets.cpp:2548 @@ +2547,3 @@ + // All X86 processors but i386 have X87. + if (Kind != CK_i386) +setFeatureEnabledImpl(Features, "x87", true); What about `CK_Generic`? Also, if `CK_i486` can be used for th

Re: r254041 - Teach RAV to pass its DataRecursionQueue to derived classes if they ask for it,

Looks like the bots are all happy now. On Tue, Nov 24, 2015 at 11:45 PM, Alexey Samsonov wrote: > Unfortunately, the bot still seems to be unhappy: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/12246/steps/build%20fresh%20clang/logs/stdio > > On Tue, Nov 24, 2015 at

[PATCH] Don't crash when dumping objc_bridge_related attributes

Clang's AST dumping currently crashes when dumping objc_bridge_related attributes where the class method and instance method fields are left empty. The attached patch marks the two arguments as optional and updates TableGen to understand the optional flag for identifier attribute arguments when gen

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

rjmccall added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:241 @@ +240,3 @@ + return Address(PtrAsInt, Align); +} + Thank you for extracting this. First, this function deserves a doc comment now; I would suggest: /// Dynamically round a pointer up

r254107 - [analyzer] Include block capture copy expressions in the CFG.

Author: dcoughlin Date: Wed Nov 25 16:35:37 2015 New Revision: 254107 URL: http://llvm.org/viewvc/llvm-project?rev=254107&view=rev Log: [analyzer] Include block capture copy expressions in the CFG. This prevents spurious dead store warnings when a C++ lambda is casted to a block. I've also adde

Re: [PATCH] D14872: PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type

On Nov 25, 2015 1:53 PM, "hfin...@anl.gov via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > > hfinkel added inline comments. > > > Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2783 > @@ -2783,1 +2782,3 @@ > + "the newer semantic is provided here">, > + InGroup>; >

Re: [PATCH] D14872: PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type

hfinkel added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2783 @@ -2783,1 +2782,3 @@ + "the newer semantic is provided here">, + InGroup>; def warn_transparent_union_attribute_field_size_align : Warning< Calling this "a semantic" rea

r254097 - P0001R1: 'register' storage class specifier is no longer permitted in C++1z.

Author: rsmith Date: Wed Nov 25 15:34:21 2015 New Revision: 254097 URL: http://llvm.org/viewvc/llvm-project?rev=254097&view=rev Log: P0001R1: 'register' storage class specifier is no longer permitted in C++1z. We will still allow it in system headers, in macros from system headers, when combined

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

RKSimon added a subscriber: RKSimon. RKSimon closed this revision. RKSimon added a comment. Committed at http://reviews.llvm.org/rL253886 http://reviews.llvm.org/D14215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

r254083 - Stop using SFINAE to detect whether a derived-class override of Traverse* can

Author: rsmith Date: Wed Nov 25 13:33:20 2015 New Revision: 254083 URL: http://llvm.org/viewvc/llvm-project?rev=254083&view=rev Log: Stop using SFINAE to detect whether a derived-class override of Traverse* can take a queue; some supported versions of GCC believe that this substitution failure is

[clang-tools-extra] r254081 - Fix problem with Clang-tidy parallel configure build.

Author: eugenezelenko Date: Wed Nov 25 13:16:34 2015 New Revision: 254081 URL: http://llvm.org/viewvc/llvm-project?rev=254081&view=rev Log: Fix problem with Clang-tidy parallel configure build. Differential revision: http://reviews.llvm.org/D14964 Modified: clang-tools-extra/trunk/clang-tidy

Re: [PATCH] D14964: [clang-tidy] Fix problem with parallel configure build

This revision was automatically updated to reflect the committed changes. Closed by commit rL254081: Fix problem with Clang-tidy parallel configure build. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D14964?vs=41076&id=41160#toc Repository: rL LLVM http://re

Re: [PATCH] D6370: Disable frame pointer elimination when -pg is used

spatel added a comment. [I posted this in Phab, but it has not made it to the mailing list.] Abandon patch? http://reviews.llvm.org/D14215 http://reviews.llvm.org/rL253886 Also, I linked: https://llvm.org/bugs/show_bug.cgi?id=14713 https://llvm.org/bugs/show_bug.cgi?id=25535 http://reviews.llv

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

NoQ added a subscriber: NoQ. NoQ added a comment. In http://reviews.llvm.org/D13126#291763, @danielmarjamaki wrote: > I have problems with the "default" handling of expressions. > > I want to warn about loss of precision for such code: > > unsigned int x = 256; > unsigned char c; > c = x; >

Re: [PATCH] D14982: ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply Add/Subtract.

t.p.northover added a subscriber: t.p.northover. t.p.northover added a comment. Do these get the right diagnostics when used on CPUs without the new feature? I can't see how __ARM_FEATURE_QRDMX gets wired through to arm_neon.h. http://reviews.llvm.org/D14982 _

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

sepavloff added a comment. If you are going to make unit tests, consider alternative approach also. In repository `test-suite` the directory `SingleSource/UnitTests` contains runtime tests obtained from single file. You could modify Makefile that runs these tests in such a way that each test ru

Re: [PATCH] D6370: Disable frame pointer elimination when -pg is used

spatel added a subscriber: spatel. spatel added a comment. Abandon patch? http://reviews.llvm.org/D14215 http://reviews.llvm.org/rL253886 http://reviews.llvm.org/D6370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: r253958 - Reduce the stack usage per recursive step when RecursiveASTVisitor cannot perform data recursion.

Guessing this or one of the related patches introduced this build breakage? I haven't looked at it too carefully yet... http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/26570/steps/compile/logs/stdio On Mon, Nov 23, 2015 at 11:13 PM, Richard Smith via cfe-commits < cfe-commits@

Re: [PATCH] D14824: [PATCH] Add clang-tidy check for static or thread_local objects where construction may throw

aaron.ballman added a comment. In http://reviews.llvm.org/D14824#296574, @alexfh wrote: > Sorry for the delay, I was sick last week. No worries on the delay, I was sick the last two weeks as well. I hope you are feeling better! Comment at: clang-tidy/cert/StaticObjectExcepti

Re: [PATCH] D14824: [PATCH] Add clang-tidy check for static or thread_local objects where construction may throw

aaron.ballman updated this revision to Diff 41150. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updating patch based on review comments. http://reviews.llvm.org/D14824 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cer

[clang-tools-extra] r254074 - [clang-tidy] Fix a typo in my latest commit.

Author: alexfh Date: Wed Nov 25 10:38:22 2015 New Revision: 254074 URL: http://llvm.org/viewvc/llvm-project?rev=254074&view=rev Log: [clang-tidy] Fix a typo in my latest commit. Modified: clang-tools-extra/trunk/clang-tidy/misc/MoveConstantArgumentCheck.cpp Modified: clang-tools-extra/trunk/

Re: [libcxx] r254050 - Silence a -Wmissing-braces warning in the tests; mbstate_t is defined differently on different C libraries.

Is {} not portable in some way? On Nov 25, 2015 5:58 AM, "Joerg Sonnenberger via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > On Tue, Nov 24, 2015 at 05:38:23PM -0800, David Blaikie via cfe-commits > wrote: > > Could this initialization just be written as "mbstate_t mb = {}" & avoid > > the

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

alexfh added a comment. Missed a couple of comments. Anyway, I'm fixing these myself as a part of commit. Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:42 @@ +41,3 @@ +auto MoveRange = CharSourceRange::getCharRange(CallMove->getSourceRange()); +auto FileMove

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

This revision was automatically updated to reflect the committed changes. Closed by commit rL254070: [clang-tidy] Const std::move() argument ClangTidy check (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D12031?vs=41061&id=41146#toc Repository: rL LLVM http://reviews

[clang-tools-extra] r254070 - [clang-tidy] Const std::move() argument ClangTidy check

Author: alexfh Date: Wed Nov 25 09:56:11 2015 New Revision: 254070 URL: http://llvm.org/viewvc/llvm-project?rev=254070&view=rev Log: [clang-tidy] Const std::move() argument ClangTidy check ClangTidy check for finding cases when std::move() is called with const or trivially copyable arguments, tha

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

spetrovic updated the summary for this revision. spetrovic updated this revision to Diff 41142. spetrovic marked 4 inline comments as done. http://reviews.llvm.org/D14871 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/ppc-varargs-struct.c Index: test/CodeGen/ppc-varargs-struct.c

Re: [PATCH] D14919: Fix IssueHash generation

I did not create a test checker for the NormalizeLine error in the patch. Should I add a test checker for this? Do you have any suggestions where to put it if required? GetEnclosingDeclContextSignature already checks for nullptr, this should have been done in the NormalizeLine function also, but i

Re: [PATCH] D14919: Fix IssueHash generation

o.gyorgy added a subscriber: o.gyorgy. o.gyorgy marked an inline comment as done. o.gyorgy added a comment. I did not create a test checker for the NormalizeLine error in the patch. Should I add a test checker for this? Do you have any suggestions where to put it if required? GetEnclosingDeclCont

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome! Thank you for the new check! There are a couple of nits, but I'll fix these before submitting the patch. Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:42

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

a.sidorin added a comment. I understand your position. However, we cannot check that we don't import `BreakStmt` as `ContinueStmt` using just ASTMerge without any verification. As I understand, unit tests is what we need because we need to check that the overall imported type/expression is cor

Re: [PATCH] D14824: [PATCH] Add clang-tidy check for static or thread_local objects where construction may throw

alexfh added a comment. Sorry for the delay, I was sick last week. Looks mostly fine. Comment at: clang-tidy/cert/CERTTidyModule.cpp:19 @@ -18,2 +18,3 @@ #include "../misc/ThrowByValueCatchByReferenceCheck.h" +#include "StaticObjectExceptionCheck.h" #include "SetLongJmpCheck.

Re: [PATCH] D13980: Add "x87" in x86 target feature map

aturetsk added a comment. > Are there any of the intrinsics in the headers that also depend on x87? Not that I could find. Comment at: lib/Basic/Targets.cpp:2545-2546 @@ -2544,2 +2544,4 @@ - switch (getCPUKind(CPU)) { + CPUKind Kind = getCPUKind(CPU); + + // All X86 proce

Re: [PATCH] D13980: Add "x87" in x86 target feature map

aturetsk updated this revision to Diff 41137. aturetsk added a comment. Use getCPUKind once http://reviews.llvm.org/D13980 Files: lib/Basic/Targets.cpp test/CodeGen/attr-target-x86-mmx.c test/CodeGen/attr-target-x86.c Index: test/CodeGen/attr-target-x86.c

Re: [PATCH] D14582: [clang-tidy] cppcoreguidelines-pro-bounds-pointer-arithmetic: ignore generated pointer arithmetic

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Sorry for the delay, I was sick and didn't read mail. Looks good with a nit. Thanks for the fix! Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp:

Re: [libcxx] r254050 - Silence a -Wmissing-braces warning in the tests; mbstate_t is defined differently on different C libraries.

On Tue, Nov 24, 2015 at 05:38:23PM -0800, David Blaikie via cfe-commits wrote: > Could this initialization just be written as "mbstate_t mb = {}" & avoid > the warning entirely (I'm not entirely sure what the warning was, but I > imagine that'd avoid it) Or even better, just use the portable memse

Re: [PATCH] D14872: PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type

DmitryPolukhin updated this revision to Diff 41131. DmitryPolukhin added a comment. Added warning about semantic change + uploaded context. PTAL http://reviews.llvm.org/D14872 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp test/Sema/struct-packed-align.c Inde

[PATCH] D14982: ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply Add/Subtract.

labrinea created this revision. labrinea added reviewers: jmolloy, rengolin, cfe-commits. Herald added subscribers: rengolin, aemerson. The following instructions are added to AArch32 instruction set: - VQRDMLAH: Vector Saturating Rounding Doubling Multiply Accumulate Retu ing High Half - V

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

ABataev added a comment. John, thanks a lot for the review! Committed version has a fix according to your last comment. Repository: rL LLVM http://reviews.llvm.org/D13336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki added a comment. ping.. the latest patch has an alternative approach, where the checker track values of symbols. REGISTER_MAP_WITH_PROGRAMSTATE(DeclVal, const ValueDecl *, SVal) The reason I don't use normal ProgramState values is that these symbol values are truncated. I w

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rL254067: [MSVC] 'property' with an empty array in array subscript expression. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D13336?vs=41018&id=41125#toc Repository: rL LLVM

r254067 - [MSVC] 'property' with an empty array in array subscript expression.

Author: abataev Date: Wed Nov 25 06:01:00 2015 New Revision: 254067 URL: http://llvm.org/viewvc/llvm-project?rev=254067&view=rev Log: [MSVC] 'property' with an empty array in array subscript expression. MSVC supports 'property' attribute and allows to apply it to the declaration of an empty array

Re: [PATCH] D14954: [x86] Exclusion of incorrect include headers paths for MCU target

mkuper accepted this revision. mkuper added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D14954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D14977: clang-tidy: code cleanup with isAssignmentOperator

danielmarjamaki closed this revision. danielmarjamaki added a comment. Committed with 254066. http://reviews.llvm.org/D14977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r254066 - [clang-tidy] code cleanup using isAssignmentOp()

Author: danielmarjamaki Date: Wed Nov 25 05:30:00 2015 New Revision: 254066 URL: http://llvm.org/viewvc/llvm-project?rev=254066&view=rev Log: [clang-tidy] code cleanup using isAssignmentOp() Modified: clang-tools-extra/trunk/clang-tidy/misc/AssertSideEffectCheck.cpp Modified: clang-tools-ext

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev added a comment. Richard, any comments? http://reviews.llvm.org/D10599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev added a comment. Richard, could you take a look one more time, please? http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: rjmccall. DmitryPolukhin added a subscriber: cfe-commits. Fix binary compatibility issue with GCC. http://reviews.llvm.org/D14980 Files: lib/AST/RecordLayoutBuilder.cpp test/Sema/bitfield-layout.c Index: test/Sema/bitfie

Re: [PATCH] D14964: [clang-tidy] Fix problem with parallel configure build

alexfh added a comment. LG Do you need me to submit this? Repository: rL LLVM http://reviews.llvm.org/D14964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14977: clang-tidy: code cleanup with isAssignmentOperator

alexfh accepted this revision. alexfh added a reviewer: alexfh. alexfh added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D14977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D14977: clang-tidy: code cleanup with isAssignmentOperator

danielmarjamaki created this revision. danielmarjamaki added subscribers: cfe-commits, alexfh. This is a small code cleanup. No change in logical behaviour is intended. http://reviews.llvm.org/D14977 Files: clang-tidy/misc/AssertSideEffectCheck.cpp Index: clang-tidy/misc/AssertSideEffectCheck

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

rmaprath added a comment. Gentle ping. http://reviews.llvm.org/D14653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r254063 - [X86] Support for C calling convention only for MCU target.

Author: abataev Date: Wed Nov 25 03:24:26 2015 New Revision: 254063 URL: http://llvm.org/viewvc/llvm-project?rev=254063&view=rev Log: [X86] Support for C calling convention only for MCU target. For MCU only C calling convention is allowed, all other calling conventions are not supported. Differen

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

This revision was automatically updated to reflect the committed changes. Closed by commit rL254063: [X86] Support for C calling convention only for MCU target. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D14864?vs=41004&id=41115#toc Repository: rL LLVM http://re