Author: ctopper
Date: Sat Dec 12 00:30:51 2015
New Revision: 255428
URL: http://llvm.org/viewvc/llvm-project?rev=255428&view=rev
Log:
Minor formatting cleanup. NFC
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cf
Author: ctopper
Date: Sat Dec 12 00:30:48 2015
New Revision: 255427
URL: http://llvm.org/viewvc/llvm-project?rev=255427&view=rev
Log:
[Sema] Simplify a couple if statements. Explicitly check up front that only one
of the expressions is a comparision op. Then if we find that either is a
bitwise o
zaks.anna added a comment.
With respect to the issues this checker found, I suggest submitting patches for
the clang issues that can be fixed. Can the x-macro case be suppressed with the
recommended suppression? I'd also submit a patch to gtest. Submitting patches
with the fixes provides a good
Author: majnemer
Date: Fri Dec 11 23:50:32 2015
New Revision: 255424
URL: http://llvm.org/viewvc/llvm-project?rev=255424&view=rev
Log:
Try to appease a buildbot.
Modified:
cfe/trunk/test/CodeGenCXX/microsoft-abi-try-throw.cpp
Modified: cfe/trunk/test/CodeGenCXX/microsoft-abi-try-throw.cpp
UR
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255423: Update clang to use the updated LLVM EH instructions
(authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D15140?vs=42618&id=42632#toc
Repository:
rL LLVM
http://reviews.
Author: majnemer
Date: Fri Dec 11 23:39:21 2015
New Revision: 255423
URL: http://llvm.org/viewvc/llvm-project?rev=255423&view=rev
Log:
Update clang to use the updated LLVM EH instructions
Depends on D15139.
Reviewers: rnk
Differential Revision: http://reviews.llvm.org/D15140
Modified:
cfe/
zaks.anna added a comment.
Overall, looks good!
Comment at: tools/scan-view/bin/scan-view:94
@@ +93,3 @@
+import argparse
+parser = argparse.ArgumentParser()
+parser.add_argument("root", metavar="", type=str)
Please, add the tool description, like "T
zaks.anna added inline comments.
Comment at: test/Analysis/inlining/analysis-order.c:13
@@ +12,3 @@
+
+// CHECK: analysis-order.c test2
+// CHECK: analysis-order.c test1
Can you use CHECK-NEXT instead?
Repository:
rL LLVM
http://reviews.llvm.org/D15410
__
majnemer updated this revision to Diff 42618.
majnemer added a comment.
- Updated for the latest EH changes
- Updated for LLVM changes
- Address review comments
http://reviews.llvm.org/D15140
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGCleanup.h
lib/CodeGen/CGE
vsk added a comment.
Thanks! Interesting approach. I think @cmatthews would appreciate a
`generate-profdata-from-lnt` target if you're up for it :).
Comments inline --
Comment at: utils/perf-training/CMakeLists.txt:2
@@ +1,3 @@
+if(LLVM_BUILD_INSTRUMENTED AND NOT WIN32)
+ if
rsmith closed this revision.
rsmith added a comment.
Committed as r255420. Thanks for the patch!
http://reviews.llvm.org/D15470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: rsmith
Date: Fri Dec 11 20:17:54 2015
New Revision: 255420
URL: http://llvm.org/viewvc/llvm-project?rev=255420&view=rev
Log:
Preserve source location information for qualified names used in a constructor
initializer list to name a base class. Patch by Shahms King!
Added:
cfe/trunk/tes
Easwaran Raman writes:
> eraman updated this revision to Diff 42549.
> eraman added a comment.
>
> Added a test case.
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D15163
>
> Files:
> lib/CodeGen/CodeGenModule.cpp
> test/CodeGen/pgo-max-function-count.c
>
> Index: test/CodeGen/pgo-
probinson added a comment.
PS4 rejects -static unconditionally, so in that sense changing what it means
doesn't matter to us. (But I really appreciate being asked!)
Still, abstractly it seems like -static doesn't really imply noPIC.
http://reviews.llvm.org/D15455
__
silvas added a comment.
Can you elaborate on why this patch is restricted to unix?
Also, this probably requires some documentation in
http://llvm.org/docs/CMake.html
(we don't really have an analogous page just for clang currently, so the llvm
one is probably the best place right now)
Easwaran Raman writes:
> eraman added a comment.
>
> I have reverted the commit in r255416 because the test failed in many
> architectures.
You also committed without waiting for further review, despite that
David said "LGTM but please wait for other reviewers". Please don't do
that in the future
pcc added inline comments.
Comment at: lib/CodeGen/CGClass.cpp:2564
@@ -2563,16 +2563,3 @@
- SanitizerMask M;
- switch (TCK) {
- case CFITCK_VCall:
-M = SanitizerKind::CFIVCall;
-break;
- case CFITCK_NVCall:
-M = SanitizerKind::CFINVCall;
-break;
- case CFIT
echristo added a comment.
Should be pretty easy to either use CHECK-DAG or pick out the particular
instructions you want to check here. Otherwise you're just checking how the
optimizer runs. That, in particular, also sounds like a good backend check.
http://reviews.llvm.org/D15223
_
EricWF updated this revision to Diff 42612.
EricWF added a comment.
Update with correct patch this time.
http://reviews.llvm.org/D12299
Files:
include/__config
include/list
Index: include/list
===
--- include/list
+++ include/
EricWF retitled this revision from "[libcxx] ABI-Breaking Fix for ALL undefined
behavior in ." to "[libcxx] Fix for ALL undefined behavior in .".
EricWF updated the summary for this revision.
EricWF updated this revision to Diff 42557.
EricWF added a comment.
Ping.
Originally I considered this c
On Fri, Dec 11, 2015 at 2:05 PM, Ben Langmuir via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: benlangmuir
> Date: Fri Dec 11 16:05:13 2015
> New Revision: 255377
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255377&view=rev
> Log:
> Reapply "[Modules] Fix regression when an elabo
eraman added a comment.
I have reverted the commit in r255416 because the test failed in many
architectures. In many cases the linker is not able to find
libclang_rt.profile-$ARCH.a file. There are also other errors. Here is one:
0. Program arguments:
/var/lib/buildbot/slaves/hexagon-buil
On Fri, Dec 11, 2015 at 11:53 AM, Xinliang David Li via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: davidxl
> Date: Fri Dec 11 13:53:35 2015
> New Revision: 255366
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255366&view=rev
> Log:
> [PGO] Stop using invalid char in instr variab
Author: eraman
Date: Fri Dec 11 19:11:09 2015
New Revision: 255416
URL: http://llvm.org/viewvc/llvm-project?rev=255416&view=rev
Log:
Revert r254647.
Reason: The testcase fails in many architectures.
Differential Revision: http://reviews.llvm.org/D15163
Removed:
cfe/trunk/test/CodeGen/pgo-m
eugenis added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2558
@@ +2557,3 @@
+ false));
+ llvm::MDString *MDS = dyn_cast(MD);
+ llvm::Constant *TypeId =
pcc wrote:
> What happens if `MD` is not an `MDString`?
assert + check on the caller side
eugenis updated this revision to Diff 42607.
eugenis marked an inline comment as done.
Repository:
rL LLVM
http://reviews.llvm.org/D15367
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGClass.cpp
lib/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255397: Attach maximum function count to Module when using
PGO mode (authored by eraman).
Changed prior to commit:
http://reviews.llvm.org/D15163?vs=42549&id=42604#toc
Repository:
rL LLVM
http://rev
Author: eraman
Date: Fri Dec 11 18:31:02 2015
New Revision: 255397
URL: http://llvm.org/viewvc/llvm-project?rev=255397&view=rev
Log:
Attach maximum function count to Module when using PGO mode
This sets the maximum entry count among all functions in the program to the
module using module flags. T
Author: pcc
Date: Fri Dec 11 17:54:18 2015
New Revision: 255393
URL: http://llvm.org/viewvc/llvm-project?rev=255393&view=rev
Log:
docs: Document -fno-sanitize-trap= and -fsanitize-recover= flags for CFI.
Modified:
cfe/trunk/docs/ControlFlowIntegrity.rst
Modified: cfe/trunk/docs/ControlFlowIn
rizsotto.mailinglist added inline comments.
Comment at: tools/scan-build-py/libear/ear.c:142
@@ +141,3 @@
+#endif
+if (!initialized)
+initialized = bear_capture_env_t(&initial_env);
to run the full test set
> PATH=$(pwd)/bin:$PATH python -m unittest d
rsmith added a subscriber: rsmith.
Comment at: lib/Sema/SemaDeclCXX.cpp:2987
@@ +2986,3 @@
+TInfo = Context.CreateTypeSourceInfo(BaseType);
+ElaboratedTypeLoc TL = TInfo->getTypeLoc().castAs();
+TL.setElaboratedKeywordLoc(IdLoc);
You also n
shahms created this revision.
shahms added a subscriber: cfe-commits.
Resolved a FIXME to preserve source location in qualified base initializers.
This patch preserves location information for constructs such as:
namespace ns1 {
struct Base {};
struct Derived : Base {
Derived() : ns1::Base
eraman marked an inline comment as done.
eraman added a comment.
I've added a test case to check for the presence of MaxFunctionCount module
flag. I'll check in this patch soon.
Repository:
rL LLVM
http://reviews.llvm.org/D15163
___
cfe-commits
zturner added a subscriber: zturner.
zturner added a comment.
What needs to happen for this to go in? If I understand correctly, it is
either:
1. Add a new option `TreatDeclarationsLikeDefinitions`
2. Merge this option into `AlwaysBreakAfterDefinitionReturnType` and make it an
enum with 5 valu
rizsotto.mailinglist marked 6 inline comments as done.
Comment at: tools/scan-build-py/README.md:86
@@ +85,3 @@
+The 2. mode is available only on FreeBSD, Linux and OSX. Where library preload
+is available from the dynamic loader. On OSX System Integrity Protection
security
+feat
Author: rsmith
Date: Fri Dec 11 16:41:00 2015
New Revision: 255384
URL: http://llvm.org/viewvc/llvm-project?rev=255384&view=rev
Log:
[modules] If the semantic and lexical DC of a decl are the same, write out the
second one as 0 instead of writing the same bits to the module file twice.
This typica
Author: rsmith
Date: Fri Dec 11 16:39:52 2015
New Revision: 255383
URL: http://llvm.org/viewvc/llvm-project?rev=255383&view=rev
Log:
Allow non-defining declarations of class template partial specializations to
have a nested name specifier. Strictly speaking, forward declarations of class
template
thakis closed this revision.
thakis added a comment.
r255382, thanks!
http://reviews.llvm.org/D15350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Fri Dec 11 16:31:16 2015
New Revision: 255382
URL: http://llvm.org/viewvc/llvm-project?rev=255382&view=rev
Log:
[clang-cl] Let /W4 map to -Wall -Wextra instead of just -Wall.
There's no way to make a flag alias to two flags, so add a /WCL4 flag that
maps to the All, Extra diag
Author: benlangmuir
Date: Fri Dec 11 16:05:13 2015
New Revision: 255377
URL: http://llvm.org/viewvc/llvm-project?rev=255377&view=rev
Log:
Reapply "[Modules] Fix regression when an elaborated-type-specifier mentions a
hidden tag"
Now not trying to use a C++ lookup mechanism in C (d'oh). Unqualif
adek05 added a comment.
I need a brave soul to review http://reviews.llvm.org/D15443 too, so if you
know who else could take a look at it feel free to add people there.
http://reviews.llvm.org/D15444
___
cfe-commits mailing list
cfe-commits@lists.l
adek05 updated this revision to Diff 42568.
adek05 added a comment.
Moved tests to clang-tidy test suite following Eugene.Zelenko suggestion.
http://reviews.llvm.org/D15444
Files:
test/clang-tidy/modernize-use-override.cpp
Index: test/clang-tidy/modernize-use-override.cpp
===
Author: rnk
Date: Fri Dec 11 15:39:12 2015
New Revision: 255372
URL: http://llvm.org/viewvc/llvm-project?rev=255372&view=rev
Log:
Unify diagnostics for type defintitions in bad contexts
The message for a type definition in an "if" condition was different
from the other three for no particular rea
Author: nicholas
Date: Fri Dec 11 15:28:55 2015
New Revision: 255371
URL: http://llvm.org/viewvc/llvm-project?rev=255371&view=rev
Log:
Error on redeclaring with a conflicting asm label and on redeclaring with an
asm label after the first ODR-use. Detects problems like the one in PR22830
where gc
Probably my misunderstanding of how the __asm__ extension should work then.
I’ve been thinking that
void g() __asm__(“real_g”) should behave the same as
void real_g();
but thinking in terms of source-level names and assembly-level names makes
sense to me. Thanks!
From: meta...@gmail.com [mailto
LGTM
+ if (OldA->getLabel() != NewA->getLabel()) {
+ // This redeclaration changes __asm__ label.
+Diag(New->getLocation(), diag::err_different_asm_label);
Comment is underindented by one space.
On Fri, Dec 11, 2015 at 1:17 PM, Nick Lewycky wrote:
> On 11 December 2015 at 12:57, R
On 11 December 2015 at 12:57, Richard Smith wrote:
> On Fri, Dec 11, 2015 at 12:43 PM, Gao, Yunzhong via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> gcc 4.8.2 accepts the following case silently without error or warning:
>>
>> void f();
>>
>> void g() __asm__(“real_g”);
>>
>> vo
ahatanak created this revision.
ahatanak added a subscriber: cfe-commits.
This patch fixes a crash that occurs when __kindof is incorrectly used in the
type parameter list of an interface. The crash occurs because
ObjCTypeParamList::back() is called in checkTypeParamListConsistency on an
empty
On Thu, Dec 10, 2015 at 5:24 PM, Duncan P. N. Exon Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> > On 2015-Dec-10, at 15:32, Richard Smith wrote:
> >
> > On Thu, Dec 10, 2015 at 11:45 AM, Marshall Clow
> wrote:
> > On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith
> wrote:
> > Ping.
beanz created this revision.
beanz added reviewers: dexonsmith, silvas, friss, vsk, bogner, cmatthews.
beanz added a subscriber: cfe-commits.
This patch adds support for using LIT to drive generating PGO profile data for
clang.
This first pass implementation should work on Linux and Unix based p
On Fri, Dec 11, 2015 at 07:49:25PM +, Frederic Riss wrote:
> friss added a comment.
>
> Just because it makes the behavior more intuitive? If you toolchain
> does PIC by default, it's because you are mostly building shared
> objects. When you are building a static object, it's highly likely
>
On Fri, Dec 11, 2015 at 12:43 PM, Gao, Yunzhong via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> gcc 4.8.2 accepts the following case silently without error or warning:
>
> void f();
>
> void g() __asm__(“real_g”);
>
> void f() { g(); } // gcc emits a call to real_g() here
>
> void
rtrieu added a comment.
So there's three or four semi-related failures around this part template
diffing. I'm investigating the best way to handle these bugs.
http://reviews.llvm.org/D15384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
gcc 4.8.2 accepts the following case silently without error or warning:
void f();
void g() __asm__(“real_g”);
void f() { g(); } // gcc emits a call to real_g() here
void real_g() __asm__(“gold”);
void real_g() { } // gcc generates a body for gold() here
gcc 4.8.2 generates a warning for t
cjk added a comment.
Excellent. Mind committing this on my behalf? I don't have commit access.
http://reviews.llvm.org/D15445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added inline comments.
Comment at: include/list:198
@@ +197,3 @@
+__node_pointer;
+__node_base_pointer __prev_;
+__node_base_pointer __next_;
Possible ABI break here.
http://reviews.llvm.org/D12299
__
Author: davidxl
Date: Fri Dec 11 14:23:12 2015
New Revision: 255368
URL: http://llvm.org/viewvc/llvm-project?rev=255368&view=rev
Log:
[PGO] Revert r255366: solution incomplete, not handling lambda yet
Modified:
cfe/trunk/test/CoverageMapping/unused_names.c
cfe/trunk/test/Profile/Inputs/c-
jyknight added a comment.
In http://reviews.llvm.org/D15455#308532, @joerg wrote:
> As before, I don't see why a linker flag should change code generation. That
> seems to be a gross violation of layering and quite surprising.
I agree.
http://reviews.llvm.org/D15455
__
friss added reviewers: silvas, probinson.
friss added a comment.
Adding some SCE people, as their platform would be impacted by that change.
http://reviews.llvm.org/D15455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15444#308573, @adek05 wrote:
> I don't see any tests for AddOverride in tests/clang-tidy yet. Is clang-tidy
> linking everything that clang-modernizer has? If so, I can create another
> patch which just moves these tests over.
Clanag
adek05 added a comment.
I don't see any tests for AddOverride in tests/clang-tidy yet. Is clang-tidy
linking everything that clang-modernizer has? If so, I can create another patch
which just moves these tests over.
http://reviews.llvm.org/D15444
aaron.ballman added inline comments.
Comment at: lib/AST/ExprConstant.cpp:1110
@@ -1022,1 +1109,3 @@
void set(APValue::LValueBase B, unsigned I = 0, bool BInvalid = false) {
+#ifndef NDEBUG
+ // We only allow a few types of invalid bases. Enforce that here.
-
Author: davidxl
Date: Fri Dec 11 13:53:35 2015
New Revision: 255366
URL: http://llvm.org/viewvc/llvm-project?rev=255366&view=rev
Log:
[PGO] Stop using invalid char in instr variable names.
(This is part-2 of the patch -- fixing test cases)
Before the patch, -fprofile-instr-generate compile will
friss added a comment.
Just because it makes the behavior more intuitive? If you toolchain does PIC by
default, it's because you are mostly building shared objects. When you are
building a static object, it's highly likely that you don't need PIC. There
should be a way to enable it, but I find
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Should be moved to Clang-tidy, since clang-modernize is deprecated.
http://reviews.llvm.org/D15444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
eraman updated this revision to Diff 42549.
eraman added a comment.
Added a test case.
Repository:
rL LLVM
http://reviews.llvm.org/D15163
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGen/pgo-max-function-count.c
Index: test/CodeGen/pgo-max-function-count.c
=
joerg added a comment.
As before, I don't see why a linker flag should change code generation. That
seems to be a gross violation of layering and quite surprising.
http://reviews.llvm.org/D15455
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
george.burgess.iv updated this revision to Diff 42547.
george.burgess.iv marked an inline comment as done.
george.burgess.iv added a comment.
- Fixed wording in AttrDocs
- Realized I forgot to press 'submit' on comment responses after the last
update. Will correct this in ~5 seconds :)
http://r
george.burgess.iv added inline comments.
Comment at: include/clang/Basic/Attr.td:714
@@ +713,3 @@
+ let Spellings = [GCC<"alloc_size">];
+ let Subjects = SubjectList<[Function]>;
+ let Args = [IntArgument<"ElemSizeParam">, IntArgument<"NumElemsParam", 1>];
aaro
rnk added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3482
@@ +3481,3 @@
+ &EHPersonality::get(*this) ==
+ &EHPersonality::MSVC_CxxFrameHandler3) {
+// The MSVC++ personality will implicitly terminate the program if an
I gue
rnk added a comment.
Digging back through more history, I see that Richard added the call to
getTypeSize in http://reviews.llvm.org/rL230603.
http://reviews.llvm.org/D15384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
dcoughlin added inline comments.
Comment at: tools/scan-build-py/README.md:85
@@ +84,3 @@
+
+The 2. mode is available only on FreeBSD, Linux and OSX. Where library preload
+is available from the dynamic loader. On OSX System Integrity Protection
security
My comme
aaron.ballman added a comment.
I should note that the majority of the changes in this patch are to deal with
the diagnostic triggering on test cases. I tried to correct the test cases to
be idiomatic where it appears the signature of the operation was not the
purpose of the test. The other case
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, dblaikie.
aaron.ballman added a subscriber: cfe-commits.
All copy operations were created equal (as far as the core language is
concerned), but some copy operations are more equal than others (as far as the
library is co
aaron.ballman abandoned this revision.
aaron.ballman added a comment.
Abandoning this revision, will post a new patch approach shortly.
http://reviews.llvm.org/D15228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
LegalizeAdulthood added a subscriber: LegalizeAdulthood.
Comment at: test/clang-tidy/misc-string-integer-assignment.cpp:25
@@ +24,3 @@
+int main() {
+ std::string s("foobar");
+
Use {} initialization perhaps?
http://reviews.llvm.org/D15411
__
Author: stulova
Date: Fri Dec 11 11:41:19 2015
New Revision: 255346
URL: http://llvm.org/viewvc/llvm-project?rev=255346&view=rev
Log:
[OpenCL 2.0] In OpenCL v2.0 s6.5 all pointers are implicitly in generic
address space unless address space is explicitly specified.
Correct the behavior of NULL co
friss created this revision.
friss added reviewers: jyknight, rnk, joerg.
friss added a subscriber: cfe-commits.
In r245667 -static was changed not to disable -fPIC as they control
2 different concepts. On toolchains that enable -fPIC by default,
this means that now you have to pass "-static -fno-
loladiro added a comment.
@majnemer Do you like the new approach? Is there anything else to be done here?
http://reviews.llvm.org/D13330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
vsk added a subscriber: vsk.
vsk added a comment.
Thanks, comments inline --
Comment at: lib/Driver/Tools.cpp:4064
@@ -4046,1 +4063,3 @@
+ // Add runtime flag for PS4 when PGO or Coverage are enabled.
+ if (getToolChain().getTriple().isPS4CPU())
Profiling in
compnerd added inline comments.
Comment at: cmake/config-ix.cmake:45
@@ -44,3 +44,3 @@
check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB)
-check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB)
+check_library_exists(gcc_s __gcc_person
bcraig updated this revision to Diff 42524.
bcraig marked 3 inline comments as done.
bcraig added a comment.
Anna Zaks last round of review requests.
http://reviews.llvm.org/D14779
Files:
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer
Please submit patches to clang-format to reviews.llvm.org. Also, any change
no matter how easy it is to deduce from the code itself deserves a proper
change description :-). Bullet points are fine.
On Fri, Dec 11, 2015 at 4:26 PM, Manuel Klimek wrote:
> +djasper
>
> On Fri, Dec 11, 2015 at 3:40
Author: stulova
Date: Fri Dec 11 09:23:00 2015
New Revision: 255339
URL: http://llvm.org/viewvc/llvm-project?rev=255339&view=rev
Log:
Reverting r255337 as it seems to kill bots. Needs investigation.
Removed:
cfe/trunk/test/SemaOpenCL/null_literal.cl
Modified:
cfe/trunk/lib/AST/Expr.cpp
+djasper
On Fri, Dec 11, 2015 at 3:40 PM Alexander Shukaev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello everyone,
>
> Please, consider applying the attached patch or (at your option) a
> refined version of it upstream. I'd be very excited to see it make into
> the upcoming 3.8 re
bcraig marked 7 inline comments as done.
bcraig added a comment.
Somehow, I thought I was waiting on Anna, but I missed the Dec 1 update during
the Thanksgiving break, and nothing was blocking me. An updated patch should
be posted soon.
In http://reviews.llvm.org/D14779#299895, @zaks.anna wrot
Hello everyone,
Please, consider applying the attached patch or (at your option) a
refined version of it upstream. I'd be very excited to see it make into
the upcoming 3.8 release. The patch looks self-explanatory but in case
any questions should arise, feel free to ask. I can provide both
sepavloff created this revision.
sepavloff added a subscriber: cfe-commits.
Llvm module object is shared between CodeGenerator and BackendConsumer,
in both classes it is stored as std::unique_ptr, which is not a good
design solution and can cause double deletion error. Usually it does
not occur be
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun.
NoQ added a subscriber: cfe-commits.
It seems that in several places in the code Clang Static Analyzer tries to
recursively traverse the `SVal` hierarchy, so i made a visitor for `SVal`,
`SymExpr`, and `MemRegion` h
Author: stulova
Date: Fri Dec 11 07:49:15 2015
New Revision: 255337
URL: http://llvm.org/viewvc/llvm-project?rev=255337&view=rev
Log:
[OpenCL 2.0] In OpenCL v2.0 s6.5 all pointers are implicitly in generic
address space unless address space is explicitly specified.
Correct the behavior of NULL co
nemanjai added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:384
@@ +383,3 @@
+ unsigned getFloat128Width() const { return 128; }
+ unsigned getFloat128Align() const { return 128; }
+ const llvm::fltSemantics &getFloat128Format() const {
hubert.
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Funny that we don't seem to have a test for this.
http://reviews.llvm.org/D15445
___
cfe-commits mailing list
cfe-commits@lists.llv
cjk added a comment.
@djasper: Tagged you because it seems like you've reviewed a bunch recent
clang-format patches. This is my first patch to any of the projects in the LLVM
family, so please let me know if I've done something stupid, not added the
proper reviewers/lists, etc.
Cheers!
http:
Ping. http://reviews.llvm.org/D15223
-Original Message-
From: Eric Christopher [mailto:echri...@gmail.com]
Sent: 07 December 2015 19:18
To: Alexandros Lamprineas; James Molloy; renato.go...@linaro.org;
cfe-commits@lists.llvm.org
Cc: Amara Emerson
Subject: Re: [PATCH] D15223: [ARM] [AARC
majnemer added a subscriber: majnemer.
Comment at: include/clang/Basic/AttrDocs.td:214
@@ +213,3 @@
+ that we can lower to in the near future. This should cover a large number of
+ nonconst cases.
+ }];
nonconst -> non-const?
http://reviews.llvm.org/D14274
petpav01 updated this revision to Diff 42506.
petpav01 added a comment.
Updated patch adds more tests and fixes a problem introduced in the previous
revision where templates taking `__val_expr` were not correctly protected by
SFINAE from immediate context (it introduced same problem with explici
On 10 December 2015 at 17:42, Gao, Yunzhong <
yunzhong_...@playstation.sony.com> wrote:
> Out of curiosity, is the following test case possible too?
>
>
>
> void f();
>
> void g() __asm__(“real_g”); // rename g into real_g.
>
>
>
> void f() {
>
> g(); // this would actually be calling real_g()
>
MaggieYi added a comment.
Ping
http://reviews.llvm.org/D15222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
99 matches
Mail list logo
