r255447 - Revert r255445: adding a new test case

2015-12-12 Thread Xinliang David Li via cfe-commits
Author: davidxl Date: Sat Dec 12 22:45:49 2015 New Revision: 255447 URL: http://llvm.org/viewvc/llvm-project?rev=255447=rev Log: Revert r255445: adding a new test case Removed: cfe/trunk/test/Profile/cxx-static.cpp Removed: cfe/trunk/test/Profile/cxx-static.cpp URL:

r255450 - [Sema] Add -Wparentheses warnings for '^' in '|' expressions and '&' in '^' expressions to compliment '&' in '|' that is already present. Matches gcc behavior.

2015-12-12 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Dec 12 23:41:41 2015 New Revision: 255450 URL: http://llvm.org/viewvc/llvm-project?rev=255450=rev Log: [Sema] Add -Wparentheses warnings for '^' in '|' expressions and '&' in '^' expressions to compliment '&' in '|' that is already present. Matches gcc behavior.

r255449 - [Sema] Write some checks for groups of BinaryOperatorKinds in terms of the predicates already available in BinaryOperator. NFC

2015-12-12 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Dec 12 23:41:37 2015 New Revision: 255449 URL: http://llvm.org/viewvc/llvm-project?rev=255449=rev Log: [Sema] Write some checks for groups of BinaryOperatorKinds in terms of the predicates already available in BinaryOperator. NFC Modified:

Re: [PATCH] D15440: [libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of libgcc_eh.a

2015-12-12 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: cmake/config-ix.cmake:45 @@ -44,3 +44,3 @@ check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB) -check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB) +check_library_exists(gcc_s

[clang-tools-extra] r255431 - [clang-tidy] Fix PR25812.

2015-12-12 Thread Gabor Horvath via cfe-commits
Author: xazax Date: Sat Dec 12 05:31:25 2015 New Revision: 255431 URL: http://llvm.org/viewvc/llvm-project?rev=255431=rev Log: [clang-tidy] Fix PR25812. Modified: clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

2015-12-12 Thread James Molloy via cfe-commits
jmolloy resigned from this revision. jmolloy removed a reviewer: jmolloy. jmolloy added a comment. Eric is reviewing this; resigning myself. http://reviews.llvm.org/D15223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15470: Preserve source location in namespaced base ctor initializers

2015-12-12 Thread Shahms King via cfe-commits
shahms updated this revision to Diff 42608. shahms added a comment. Address comments and add CHECK for TypeRef as well http://reviews.llvm.org/D15470 Files: lib/Sema/SemaDeclCXX.cpp test/Index/namespaced-base-ctor-init.cpp Index: test/Index/namespaced-base-ctor-init.cpp

Re: [PATCH] D15470: Preserve source location in namespaced base ctor initializers

2015-12-12 Thread Shahms King via cfe-commits
shahms marked 2 inline comments as done. shahms added a comment. Thanks for taking a look at this so quickly. I've updated the test to make sure the TypeRef is correct as well, in light of the changes here. http://reviews.llvm.org/D15470 ___

Re: [PATCH] D15370: [scan-view] replace deprecated optparse with argparse

2015-12-12 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 42636. omtcyf0 added a comment. Added tool description. http://reviews.llvm.org/D15370 Files: tools/scan-view/bin/scan-view Index: tools/scan-view/bin/scan-view === ---

r255435 - [PGO] Stop using invalid char in instr variable names.

2015-12-12 Thread Xinliang David Li via cfe-commits
Author: davidxl Date: Sat Dec 12 11:28:37 2015 New Revision: 255435 URL: http://llvm.org/viewvc/llvm-project?rev=255435=rev Log: [PGO] Stop using invalid char in instr variable names. (This is part-2 of the patch of r255434 -- fixing test cases, second try) Modified:

[patch] Let -Wdelete-non-virtual-dtor mention that making the class final is a good fix too

2015-12-12 Thread Nico Weber via cfe-commits
Hi, the attached patch changes delete called on 'dnvd::B' that has virtual functions but non-virtual destructor to delete called on non-final 'dnvd::B' that has virtual functions but non-virtual destructor I'm not sure if it should only do this for c++11 and newer – the new message is

Re: [PATCH] D15440: [libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of libgcc_eh.a

2015-12-12 Thread Saleem Abdulrasool via cfe-commits
compnerd added inline comments. Comment at: cmake/config-ix.cmake:45 @@ -44,3 +44,3 @@ check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB) -check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB) +check_library_exists(gcc_s

r255436 - [PGO] add a test case with -no-integrated-as

2015-12-12 Thread Xinliang David Li via cfe-commits
Author: davidxl Date: Sat Dec 12 11:39:38 2015 New Revision: 255436 URL: http://llvm.org/viewvc/llvm-project?rev=255436=rev Log: [PGO] add a test case with -no-integrated-as Added: cfe/trunk/test/Profile/cxx-static.cpp Added: cfe/trunk/test/Profile/cxx-static.cpp URL:

r255437 - Revert 255436 : remove test that needs to be refined

2015-12-12 Thread Xinliang David Li via cfe-commits
Author: davidxl Date: Sat Dec 12 12:49:37 2015 New Revision: 255437 URL: http://llvm.org/viewvc/llvm-project?rev=255437=rev Log: Revert 255436 : remove test that needs to be refined Removed: cfe/trunk/test/Profile/cxx-static.cpp Removed: cfe/trunk/test/Profile/cxx-static.cpp URL:

Re: [PATCH] D6712: Introduce _LIBCPP_ABI_UNSTABLE to libc++

2015-12-12 Thread Eric Fiselier via cfe-commits
EricWF resigned from this revision. EricWF removed a reviewer: EricWF. EricWF added a comment. This is really old and should be closed. http://reviews.llvm.org/D6712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D15478: [MS ABI] Don't rely on terminatepad

2015-12-12 Thread David Majnemer via cfe-commits
majnemer created this revision. majnemer added a reviewer: rnk. majnemer added a subscriber: cfe-commits. We'd like to remove support for terminatepad from LLVM. To do this, we need to move Clang off of it first. The intent behind terminatepad was to carefully model exception specifications for

Re: [PATCH] D15440: [libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of libgcc_eh.a

2015-12-12 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: src/CMakeLists.txt:37 @@ +36,3 @@ + +remove_flags(-Wl,-z,defs) + compnerd wrote: > EricWF wrote: > > compnerd wrote: > > > EricWF wrote: > > > > compnerd wrote: > > > > > Do we need to worry about an alternative spelling

r255445 - Resubmit new test case after adding more constraint

2015-12-12 Thread Xinliang David Li via cfe-commits
Author: davidxl Date: Sat Dec 12 21:03:35 2015 New Revision: 255445 URL: http://llvm.org/viewvc/llvm-project?rev=255445=rev Log: Resubmit new test case after adding more constraint Added: cfe/trunk/test/Profile/cxx-static.cpp Added: cfe/trunk/test/Profile/cxx-static.cpp URL:

Re: [PATCH] D9600: Add scan-build python implementation

2015-12-12 Thread Devin Coughlin via cfe-commits
dcoughlin added inline comments. Comment at: tools/scan-build-py/libear/ear.c:142 @@ +141,3 @@ +#endif +if (!initialized) +initialized = bear_capture_env_t(_env); rizsotto.mailinglist wrote: > rizsotto.mailinglist wrote: > > to run the full test set >

Re: [PATCH] D15440: [libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of libgcc_eh.a

2015-12-12 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: src/CMakeLists.txt:37 @@ +36,3 @@ + +remove_flags(-Wl,-z,defs) + EricWF wrote: > compnerd wrote: > > EricWF wrote: > > > compnerd wrote: > > > > EricWF wrote: > > > > > compnerd wrote: > > > > > > Do we need to worry