skalinichev updated the summary for this revision.
skalinichev updated this revision to Diff 42654.
skalinichev added a comment.
Added tests
http://reviews.llvm.org/D13001
Files:
test/Index/print-type-declaration.cpp
tools/c-index-test/c-index-test.c
tools/libclang/CXType.cpp
Index:
kimgr added a subscriber: kimgr.
kimgr added a comment.
>
> Comment at: tools/scan-build-py/bin/analyze-cc:14
> @@ +13,2 @@
> +from libscanbuild.analyze import wrapper
> +sys.exit(wrapper(False))
>
>
>
> It is hard to figure out/search which
skalinichev added a subscriber: skalinichev.
skalinichev added a comment.
I've seen this bug too. Generally this patch looks good to me.
Could you also add a test for includes half-way through a file case?
Comment at: tools/c-index-test/c-index-test.c:1567
@@ -1564,1 +1566,3
george.burgess.iv updated this revision to Diff 42683.
george.burgess.iv marked an inline comment as done.
george.burgess.iv added a comment.
> Changes to ExprConstant and CGExprConstant appear to be pure cleanups; please
> check those in as a separate change
r255314, thanks.
> When this is
george.burgess.iv added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:5576
@@ +5575,3 @@
+return ExprError();
+ return ImpCastExprToType(CastExprRes.get(), DestElemTy, CK);
+}
rsmith wrote:
> Looking at `ScalarExprEmitter::VisitCastExpr`, it seems like
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255470: [clang-tidy] add check
cppcoreguidelines-pro-bounds-constant-array-index (authored by mgehre).
Changed prior to commit:
http://reviews.llvm.org/D15030?vs=42338=42671#toc
Repository:
rL LLVM
Author: mgehre
Date: Sun Dec 13 16:08:26 2015
New Revision: 255470
URL: http://llvm.org/viewvc/llvm-project?rev=255470=rev
Log:
[clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index
Summary:
This is http://reviews.llvm.org/D13746 but instead of including ,
a stub is provided.
On Thu, Dec 10, 2015 at 10:52 AM, Ekaterina Romanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: kromanova
> Date: Thu Dec 10 12:52:50 2015
> New Revision: 255281
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255281=rev
> Log:
> Do not generate DW_TAG_imported_module for
On Sat, Dec 12, 2015 at 8:45 PM, Xinliang David Li via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: davidxl
> Date: Sat Dec 12 22:45:49 2015
> New Revision: 255447
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255447=rev
> Log:
> Revert r255445: adding a new test case
>
>
Author: chapuni
Date: Sun Dec 13 16:49:37 2015
New Revision: 255475
URL: http://llvm.org/viewvc/llvm-project?rev=255475=rev
Log:
clang-tools-extra/test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index*.cpp:
Don't assume size_t were unsigned int.
Modified:
DmitryPolukhin added a comment.
John and Richard,
I think this patch fixes important ABI compatibility issue with GCC and if
there are no more comments, I think it makes sense to commit it. Could you
please approve this CL?
Thanks,
Dmitry
http://reviews.llvm.org/D14980
george.burgess.iv updated this revision to Diff 42686.
george.burgess.iv added a comment.
TIL you can use OpenCL vectors in C++ files. Fixed a bug related to not knowing
this + added tests for the constexpr cases.
Also, is there a better way to do the `bool` -> `APFloat` conversion in
12 matches
Mail list logo
