Author: abataev
Date: Thu Dec 17 23:05:56 2015
New Revision: 255986
URL: http://llvm.org/viewvc/llvm-project?rev=255986&view=rev
Log:
[OPENMP 4.5] Parsing/sema analysis for 'depend(source)' clause in 'ordered'
directive.
OpenMP 4.5 adds 'depend(source)' clause for 'ordered' directive to support
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF updated this revision to Diff 43202.
EricWF added a comment.
Address some of @mclow.lists offline comments. I cleaned up the tests.
http://reviews.llvm.org/D13750
Files:
include/__config
include/utility
test/std/utilities/utility/pairs/pairs.pair/default-sfinae.pass.cpp
test/std/
Author: ericwf
Date: Thu Dec 17 19:04:36 2015
New Revision: 255944
URL: http://llvm.org/viewvc/llvm-project?rev=255944&view=rev
Log:
Fix type in tuple test. Sorry for the noise
Modified:
libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.elem/tuple.by.type.pass.cpp
Modified:
libcxx/tr
On Thu, Dec 17, 2015 at 3:59 PM, Nick Lewycky via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 12/17/2015 10:47 AM, Kostya Serebryany wrote:
>
>> I am now observing this error message when building glibc with clang
>> (from trunk):
>> ../include/string.h:101:28: error: cannot apply asm la
Author: dgregor
Date: Thu Dec 17 18:52:31 2015
New Revision: 255943
URL: http://llvm.org/viewvc/llvm-project?rev=255943&view=rev
Log:
ObjC properties: consider ownership of properties from protocols when
synthesizing.
When determining whether ownership was explicitly written for a
property when
EricWF closed this revision.
EricWF added a comment.
r255941.
http://reviews.llvm.org/D14839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Thu Dec 17 18:36:55 2015
New Revision: 255941
URL: http://llvm.org/viewvc/llvm-project?rev=255941&view=rev
Log:
[libcxx] LWG2485: get() should be overloaded for const tuple&&. Patch from
K-Ballo.
Review: http://reviews.llvm.org/D14839
Added:
libcxx/trunk/test/std/conta
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
http://reviews.llvm.org/D14839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
On 12/17/2015 10:47 AM, Kostya Serebryany wrote:
I am now observing this error message when building glibc with clang
(from trunk):
../include/string.h:101:28: error: cannot apply asm label to function
after its first use
libc_hidden_builtin_proto (memcpy)
(many more instances)
Do you think thi
zaks.anna added inline comments.
Comment at: lib/Driver/ToolChains.cpp:368
@@ +367,3 @@
+ StringRef OS = "";
+ if (isTargetMacOS())
+OS = "osx";
samsonov wrote:
> Wait, this looks horrible. Can we teach toolchain to give us OS name?
These are not OS names; t
On Thu, Dec 17, 2015 at 6:25 PM, Richard Trieu wrote:
> The assert was the one later in the function:
> assert(getMemoizationData() && Other.getMemoizationData());
> My best guess as to what happened was my configuration had a container which
> reordered the comparison, making the QualType com
The assert was the one later in the function:
assert(getMemoizationData() && Other.getMemoizationData());
My best guess as to what happened was my configuration had a container
which reordered the comparison, making the QualType comparison happen
earlier than it would otherwise.
r255937 has a s
Author: rtrieu
Date: Thu Dec 17 17:20:57 2015
New Revision: 255937
URL: http://llvm.org/viewvc/llvm-project?rev=255937&view=rev
Log:
Add a test for r255875 & r255929, comparisons on DynTypeNode wrapped QualType.
Modified:
cfe/trunk/unittests/AST/ASTTypeTraitsTest.cpp
Modified: cfe/trunk/unit
beanz updated this revision to Diff 43192.
beanz added a comment.
One more dependency hookup fix, this one makes it so that stage2 doesn't depend
on the stage2-instrumented compiler-rt, and avoids building it when you invoke
the 'stage2' target.
http://reviews.llvm.org/D15584
Files:
CMakeLi
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
This works for me as a workaround, a comment about what's going on here would
probably be good.
-eric
http://reviews.llvm.org/D15613
___
cf
Author: tra
Date: Thu Dec 17 16:25:22 2015
New Revision: 255933
URL: http://llvm.org/viewvc/llvm-project?rev=255933&view=rev
Log:
[CUDA] runtime wrapper header tweaks
* Pull in host-only implementations of few CUDA-specific math functions.
* #nclude early to prevent its inclusion from CUDA heade
beanz updated this revision to Diff 43183.
beanz added a comment.
Updating to fix a bug in my CMake regex handling that caused the targets to not
be mapped up correctly.
http://reviews.llvm.org/D15584
Files:
CMakeLists.txt
cmake/caches/PGO-stage2.cmake
cmake/caches/PGO-stage3.cmake
cma
On Thu, Dec 17, 2015 at 5:02 PM, Richard Trieu wrote:
> On Thu, Dec 17, 2015 at 5:47 AM, Aaron Ballman
> wrote:
>>
>> On Wed, Dec 16, 2015 at 11:46 PM, Richard Trieu via cfe-commits
>> wrote:
>> > Author: rtrieu
>> > Date: Wed Dec 16 22:46:48 2015
>> > New Revision: 255875
>> >
>> > URL: http://
On Thu, Dec 17, 2015 at 5:47 AM, Aaron Ballman
wrote:
> On Wed, Dec 16, 2015 at 11:46 PM, Richard Trieu via cfe-commits
> wrote:
> > Author: rtrieu
> > Date: Wed Dec 16 22:46:48 2015
> > New Revision: 255875
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=255875&view=rev
> > Log:
> > Add Qu
manmanren added a comment.
Ping
Appreciate comments on the general direction.
Cheers,
Manman
http://reviews.llvm.org/D15314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rtrieu
Date: Thu Dec 17 15:56:22 2015
New Revision: 255929
URL: http://llvm.org/viewvc/llvm-project?rev=255929&view=rev
Log:
Fix r255875, use '<' instead of '==' for 'operator<'
Aaron Ballman pointed out a typo from the copy and paste in r255875. This will
preserve the strict weak orderi
> On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith
> wrote:
>
> This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert
> calls operator new when no insert occurs". That fix didn't apply to
> `unordered_map` because unordered_map::value_type gets packed inside:
> --
> union __val
beanz updated this revision to Diff 43177.
beanz added a comment.
Updates based on bogner's feedback.
- Target stages are now stage2-instrumented and stage2 instead of stage2 and
stage3.
- Renamed PGO-stage1.cmake to PGO.cmake
http://reviews.llvm.org/D15584
Files:
CMakeLists.txt
cmake/cac
> On Dec 17, 2015, at 11:37 AM, Justin Bogner wrote:
>
> Chris Bieneman mailto:be...@apple.com>> writes:
>> beanz created this revision.
>> beanz added reviewers: bogner, silvas, chandlerc.
>> beanz added a subscriber: cfe-commits.
>>
>> This patch adds support for the clang multi-stage bootstr
samsonov added a subscriber: samsonov.
Comment at: lib/Driver/ToolChains.cpp:368
@@ +367,3 @@
+ StringRef OS = "";
+ if (isTargetMacOS())
+OS = "osx";
Wait, this looks horrible. Can we teach toolchain to give us OS name?
http://reviews.llvm.org/D15624
_
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna created this revision.
zaks.anna added reviewers: kcc, cfe-commits.
Change the clang driver to accept ASan on iOS/watchOS/tvOS.
This change along with the corresponding changes in llvm and compiler-rt
complete ASan support for iOS/watchOS/tvOS.
http://reviews.llvm.org/D15624
Files:
rsmith added a subscriber: rsmith.
rsmith requested changes to this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision now requires changes to proceed.
I think that this will leave us with a broken token stream. In your example,
the cached token stream starts as
`NS
Chris Bieneman writes:
> beanz created this revision.
> beanz added reviewers: bogner, silvas, chandlerc.
> beanz added a subscriber: cfe-commits.
>
> This patch adds support for the clang multi-stage bootstrapping to
> support PGO profdata generation, and can build a 2 or 3 stage
> compiler.
>
>
george.burgess.iv created this revision.
george.burgess.iv added a subscriber: cfe-commits.
This keeps the ICE in https://llvm.org/bugs/show_bug.cgi?id=25836 from
happening. Long story short, the following C code will make clang overflow its
stack:
```
int Foo(struct A*) __attribute__((overload
On Wed, Dec 16, 2015 at 3:43 PM, Artem Belevich via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> @rsmith -- Richard, can you take a look at this change as well?
LGTM
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: eraman
Date: Thu Dec 17 13:14:27 2015
New Revision: 255918
URL: http://llvm.org/viewvc/llvm-project?rev=255918&view=rev
Log:
Attach maximum function count to Module when using PGO mode.
This sets the maximum entry count among all functions in the program to the
module using module flags.
Author: mcrosier
Date: Thu Dec 17 13:01:55 2015
New Revision: 255916
URL: http://llvm.org/viewvc/llvm-project?rev=255916&view=rev
Log:
[x86] Filecheck is case sensitive. Capitalize directives.
Modified:
cfe/trunk/test/CodeGen/avx512f-builtins.c
Modified: cfe/trunk/test/CodeGen/avx512f-built
> On Dec 17, 2015, at 10:16 AM, Joerg Sonnenberger via cfe-commits
> wrote:
>
> On Wed, Dec 16, 2015 at 11:59:10PM +, Bob Wilson via cfe-commits wrote:
>> We can change this to be Darwin-specific if you prefer, but we should
>> maintain compatibility with GCC and previous Clang releases in
Author: mcrosier
Date: Thu Dec 17 12:54:42 2015
New Revision: 255915
URL: http://llvm.org/viewvc/llvm-project?rev=255915&view=rev
Log:
[x86] Filecheck is case sensitive. Capitalize directives.
Modified:
cfe/trunk/test/CodeGen/avx512er-builtins.c
Modified: cfe/trunk/test/CodeGen/avx512er-bui
I am now observing this error message when building glibc with clang (from
trunk):
../include/string.h:101:28: error: cannot apply asm label to function after
its first use
libc_hidden_builtin_proto (memcpy)
(many more instances)
Do you think this is a bug in glibc code, or the error message coul
echristo added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:2758
@@ +2757,3 @@
+GA->setIFunc(true);
+GA->setLinkage(llvm::GlobalValue::LinkOnceAnyLinkage);
+ }
rjmccall wrote:
> DmitryPolukhin wrote:
> > rjmccall wrote:
> > > Can you explain
rjmccall added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1866
@@ +1865,3 @@
+ let Content = [{
+The attribute ``__attribute__((ifunc("resolver")))`` is used to mark a
function as an indirect function using the STT_GNU_IFUNC symbol type extension
to the ELF st
mclow.lists added inline comments.
Comment at: test/support/noexcept.h:43
@@ +42,3 @@
+#define try if(!setjmp(try_buf))
+#define catch(ex) else
+
This is explicitly forbidden by the standard.
[macro.names]/2:
A translation unit shall not #define or #undef names le
On Wed, Dec 16, 2015 at 11:59:10PM +, Bob Wilson via cfe-commits wrote:
> We can change this to be Darwin-specific if you prefer, but we should
> maintain compatibility with GCC and previous Clang releases in this behavior.
Who is really affected by this? I don't care too much about obscure
Da
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255911: [CUDA] Make vtable construction aware of host/device
side of CUDA compilation. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D15309?vs=42341&id=43150#toc
Repository:
rL
Author: tra
Date: Thu Dec 17 12:12:36 2015
New Revision: 255911
URL: http://llvm.org/viewvc/llvm-project?rev=255911&view=rev
Log:
[CUDA] Make vtable construction aware of host/device side of CUDA compilation.
C++ emits vtables for classes that have key function present in the
current TU. While we
davidxl added a comment.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D15163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
Thanks for the review! I'll rework this a bit early next week.
http://reviews.llvm.org/D15528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Can you also be sure to update the release notes for this change?
~Aaron
On Thu, Dec 17, 2015 at 6:49 AM, Alexander Kornienko via cfe-commits
wrote:
> Author: alexfh
> Date: Thu Dec 17 05:49:19 2015
> New Revision: 255886
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255886&view=rev
> Log:
>
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:44
@@ +43,3 @@
+
+const BinaryOperator *B = dyn_cast(Parent);
+if (!B)
Note that InitExprs of DeclStmts are not binary operators. So you will not get
a warning
MaggieYi added a comment.
Thanks Paul for your help.
Repository:
rL LLVM
http://reviews.llvm.org/D15222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zturner added a comment.
ping
http://reviews.llvm.org/D10370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin added a subscriber: a.sidorin.
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:41
@@ +40,3 @@
+const Stmt *Parent = PM.getParent(Cast);
+if (!Parent)
+ return;
Parent should always exist for an implicit cast. May be it's better
logan created this revision.
logan added reviewers: rengolin, danalbert, kevin.qin, echristo, srhines.
logan added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
This commit adds SHF_ALLOC and SHF_EXECINSTR section flags to
.text.__cxa_end_cleanup section. This fixes a l
jyknight added a comment.
> #define CC1_SPEC "%{!mkernel:%{!static:%{!mdynamic-no-pic:-fPIC}}}
That's sad.
> We can change this to be Darwin-specific if you prefer, but we should
> maintain compatibility with GCC and previous Clang releases in this behavior.
Yes, the broken behavior should b
aaron.ballman added a comment.
Ping.
http://reviews.llvm.org/D15456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
s.egerton updated this revision to Diff 43131.
s.egerton marked 4 inline comments as done.
s.egerton added a comment.
Responded to reviewers comments.
The -mips* option is now saved until all arguments have been parsed. The last
-mips* option is the only one pushed back.
The tests are now update
danielmarjamaki added a comment.
Thanks a lot for those comments. I'll try your suggestions. I will try to
upload some samples where I think the ProgramState is wrong.
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:78
@@ +77,3 @@
+
+// Can E value be greater or e
DmitryPolukhin added a comment.
John, I'm still working on new patch but meanwhile I would like to clarify few
things in your comments.
Comment at: include/clang/Basic/AttrDocs.td:1866
@@ +1865,3 @@
+ let Content = [{
+The attribute ``__attribute__((ifunc("resolver")))`` is us
On Wed, Dec 16, 2015 at 11:46 PM, Richard Trieu via cfe-commits
wrote:
> Author: rtrieu
> Date: Wed Dec 16 22:46:48 2015
> New Revision: 255875
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255875&view=rev
> Log:
> Add QualType case to operator< for DynTypedNode.
>
> This allows sorting DynType
On Thu, Dec 17, 2015 at 6:49 AM, Alexander Kornienko via cfe-commits
wrote:
> Author: alexfh
> Date: Thu Dec 17 05:49:19 2015
> New Revision: 255886
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255886&view=rev
> Log:
> Remove clang-modernize.
>
> Summary:
> clang-modernize transforms have move
pxli168 updated this revision to Diff 43121.
pxli168 added a comment.
Apply comment form http://reviews.llvm.org/D14441.
http://reviews.llvm.org/D15603
Files:
include/clang/AST/ASTContext.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/Type.h
include/clang/AST/TypeLoc.h
in
pxli168 added inline comments.
Comment at: include/clang/AST/Type.h:5020
@@ +5019,3 @@
+/// PipeType - OpenCL20.
+///
+class PipeType : public Type, public llvm::FoldingSetNode {
bader wrote:
> Xuili, could you apply the comments left by Pekka and Anastasia for th
pxli168 created this revision.
pxli168 added a reviewer: pekka.jaaskelainen.
pxli168 added subscribers: cfe-commits, Anastasia, bader.
Support for OpenCL 2.0 pipe type.
This is a bug-fix version for bader's patch reviews.llvm.org/D14441
http://reviews.llvm.org/D15603
Files:
include/clang/AST/
hokein added a comment.
Oh, this is my first attempt to submit a patch, and it isn't ready for review.
Just ignore it.
Repository:
rL LLVM
http://reviews.llvm.org/D15560
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
pxli168 added a comment.
Hi guys,
I have upload a the bugfix version for bader's patch, but I could not merge my
patch to his. It automatically became a new diff http://reviews.llvm.org/D15603.
I will upload the pipe related built-in and some bug fix patches after this is
merged, the alltogether
NoQ added a comment.
Hmm, just noticed the related work on casts in http://reviews.llvm.org/D12901,
which seems to be directly related to my hand-waving above. It might
accidentally be useful for reducing FPs of this checker as well.
http://reviews.llvm.org/D13126
__
Author: myatsina
Date: Thu Dec 17 06:51:51 2015
New Revision: 255890
URL: http://llvm.org/viewvc/llvm-project?rev=255890&view=rev
Log:
[ms-inline-asm] Add support for composite structs in MS inline asm
Add MS inline asm support for structs that contain fields that are also structs.
Differential
pgousseau updated the summary for this revision.
pgousseau updated this revision to Diff 43120.
pgousseau added a comment.
Following Gabor and Anna's advice:
- Instead of modifying assumeSymNE and assumeSymEQ, this patch adds a new
method 'SValBuilder::evalIntegralCast'.
The current workaround
Author: alexfh
Date: Thu Dec 17 05:49:19 2015
New Revision: 255886
URL: http://llvm.org/viewvc/llvm-project?rev=255886&view=rev
Log:
Remove clang-modernize.
Summary:
clang-modernize transforms have moved to clang-tidy. Removing
the old tool now.
Reviewers: klimek
Subscribers: cfe-commits
Diffe
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D15606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
bader added inline comments.
Comment at: include/clang/AST/Type.h:5020
@@ +5019,3 @@
+/// PipeType - OpenCL20.
+///
+class PipeType : public Type, public llvm::FoldingSetNode {
Xuili, could you apply the comments left by Pekka and Anastasia for the
previous versi
NoQ added a comment.
I've got a few minor code comments.
I really wish to have a look at false positives on which
> the value analysis fails and then there is not much my checker could do
either in a form of FIXME tests, or as preprocessed code samples, because i'm
currently digging the topic
Hi Anastasia,
Still LGTM.
Pekka
On 16.12.2015 16:42, Anastasia Stulova wrote:
Hi Pekka,
Re-attaching as a full patch again as something went wrong earlier with the
diff wrapping in the email.
Thanks,
Anastasia
-Original Message-
From: cfe-commits [mailto:cfe-commits-boun...@lists.l
jpienaar accepted this revision.
jpienaar added a comment.
This revision is now accepted and ready to land.
Looks good, thanks
Comment at: test/CodeGenCUDA/device-vtable.cu:37
@@ +36,3 @@
+ virtual void h_method();
+ __device__ virtual void d_method();
+};
Doe
72 matches
Mail list logo
