On Fri, Jan 22, 2016 at 3:22 PM, Nico Weber wrote:
> Every time we accept something in MS mode that isn't standards compliant,
> we should accept it with a warning (for stuff that's harmless, an Extension
> warning, for stuff that can lead to bugs a Warning warning), unless it's
> really hard to
ehsan created this revision.
ehsan added a reviewer: thakis.
ehsan added a subscriber: cfe-commits.
MSVC suppresses a trailing comma if no arguments are passed in place of
a variadic argument[1]. This patch adds a -Wmicrosoft warning when
accepting such code.
[1] https://msdn.microsoft.com/en-us
EricWF added a subscriber: EricWF.
EricWF added a comment.
How are you getting this warning? I can't generate it with Clang 3.8 on 64bit
linux with -m32. In that configuration int and long have the same size.
http://reviews.llvm.org/D16480
___
cfe-
ygao updated this revision to Diff 45784.
http://reviews.llvm.org/D15705
Files:
test/Preprocessor/bigoutput.c
test/lit.cfg
Index: test/lit.cfg
===
--- test/lit.cfg
+++ test/lit.cfg
@@ -491,4 +491,9 @@
if use_gmalloc:
conf
On Fri, Jan 22, 2016 at 10:44 AM, Duncan P. N. Exon Smith <
dexonsm...@apple.com> wrote:
>
> > On 2016-Jan-21, at 22:22, Eric Fiselier wrote:
> >
> >
> >
> > On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith <
> dexonsm...@apple.com> wrote:
> >
> > > On 2016-Jan-21, at 17:59, Eric Fiselie
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, jhen, cfe-commits.
CUDA (well, strictly speaking, NVPTX) doesn't support aliases.
http://reviews.llvm.org/D16502
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, jhen, cfe-commits.
These aliases are done to support inline asm, but there's nothing we can
do: NVPTX doesn't support aliases.
http://reviews.llvm.org/D16501
Files:
lib/CodeGen/CodeGenModule.cpp
t
Author: chapuni
Date: Fri Jan 22 19:38:20 2016
New Revision: 258598
URL: http://llvm.org/viewvc/llvm-project?rev=258598&view=rev
Log:
SemaOpenMP.cpp: Fix a warning in r258543. [-Wunused-variable]
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp
URL:
ht
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, jhen, cfe-commits.
NVPTX doesn't support aliases, so don't generate them.
http://reviews.llvm.org/D16499
Files:
lib/Driver/Tools.cpp
test/Driver/cuda-constructor-alias.cu
Index: test/Driver/cuda-
eugenis closed this revision.
eugenis added a comment.
r258596
Repository:
rL LLVM
http://reviews.llvm.org/D16496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eugenis
Date: Fri Jan 22 19:20:18 2016
New Revision: 258596
URL: http://llvm.org/viewvc/llvm-project?rev=258596&view=rev
Log:
[cfi] Do not emit bit set entry for available_externally vtables.
In the Itanium ABI, vtable may be emitted speculatively as an
available_externally global. Such v
arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: cfe-commits.
http://reviews.llvm.org/D16498
Files:
include/clang/Basic/BuiltinsAMDGPU.def
test/CodeGenOpenCL/builtins-amdgcn.cl
Index: test/CodeGenOpenCL/builtins-amdgcn.cl
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D16496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: dcoughlin
Date: Fri Jan 22 19:09:07 2016
New Revision: 258594
URL: http://llvm.org/viewvc/llvm-project?rev=258594&view=rev
Log:
[analyzer] SATestBuild.py: Remove html and log when producing reference results.
The html reports are huge -- every issue in a given file results in a separate
c
eugenis created this revision.
eugenis added reviewers: pcc, kcc.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
In the Itanium ABI, vtable may be emitted speculatively as an
available_externally global. Such vtable may not be present at the
link
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, jhen, echristo.
No functional changes.
http://reviews.llvm.org/D16495
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
Author: marshall
Date: Fri Jan 22 19:02:29 2016
New Revision: 258593
URL: http://llvm.org/viewvc/llvm-project?rev=258593&view=rev
Log:
Fix test to pass in C++03
Modified:
libcxx/trunk/test/libcxx/utilities/meta/is_referenceable.pass.cpp
Modified: libcxx/trunk/test/libcxx/utilities/meta/is_re
zaks.anna added a comment.
Looks like the 'II' pointer wasn't initialized. Should be fixed by r258591.
Repository:
rL LLVM
http://reviews.llvm.org/D15921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: zaks
Date: Fri Jan 22 18:45:37 2016
New Revision: 258591
URL: http://llvm.org/viewvc/llvm-project?rev=258591&view=rev
Log:
[analyzer] Fixup r258572 Utility to match function calls.
Initialize the IdentifierInfo pointer. Hope this fixes the buildbot breakage.
Modified:
cfe/trunk/inclu
aprantl added a comment.
The linetable produced by GCC appears to be the most accurate one (stopping at
the && for the short-circuit evaluation and then returning there for the actual
& and the branch). I would not have a problem with clang implementing it.
The downside of it is that it breaks t
krasin added a subscriber: krasin.
krasin added a comment.
FYI: this revision has likely broken the build:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/9561
FAIL: Clang :: Analysis/simple-stream-checks.c (367 of 8927)
- TEST 'Clang :: Analysis/simple-stream-checks.c' FAI
Author: adrian
Date: Fri Jan 22 17:30:56 2016
New Revision: 258582
URL: http://llvm.org/viewvc/llvm-project?rev=258582&view=rev
Log:
Module Debugging: Canonicalize the file names used as PCH module names
by stripping the path. Follow-up to r258555.
This is safe because only one PCH per CU is curr
dcoughlin updated this revision to Diff 45756.
dcoughlin marked 6 inline comments as done.
dcoughlin added a comment.
I've updated ddkilzer's patch to address Jordan's last round of comments.
Specifically, I have:
- Changed the patch to use isObjCRetainableType() to additional warn about
proper
dexonsmith updated this revision to Diff 45758.
dexonsmith added a comment.
Committed r258511 and r258575 as preps. Updated patch addresses review
comments (and skips the trivially constructible parts).
http://reviews.llvm.org/D16360
Files:
include/__hash_table
include/unordered_map
tes
I'll upload a new patch in a moment. Replies inline below.
> On 2016-Jan-21, at 23:12, Eric Fiselier wrote:
>
> EricWF added a comment.
>
> Overall the patch looks good but I have a few concerns.
>
>> - If argument.first can be trivially converted to key_type, don't alloc.
>
>
> I'm concern
alexfh added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:30
@@ +29,3 @@
+Class = Class.trim();
+if (!Class.empty())
+ Result.push_back(Class);
aaron.ballman wrote:
> > Also changed the separator to be ';' instead of '
Author: dexonsmith
Date: Fri Jan 22 16:48:02 2016
New Revision: 258575
URL: http://llvm.org/viewvc/llvm-project?rev=258575&view=rev
Log:
unordered_map: Reuse insert logic in emplace when possible, NFC
An upcoming commit will add an optimization to insert() that avoids
unnecessary mallocs when we
xur added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:440
@@ +439,3 @@
+ if (CodeGenOpts.ProfileIRInstr) {
+// Should not have ProfileInstrGenerate set -- it is for clang
+// instrumentation only.
silvas wrote:
> Then change the existing refe
Author: aaronballman
Date: Fri Jan 22 16:37:09 2016
New Revision: 258573
URL: http://llvm.org/viewvc/llvm-project?rev=258573&view=rev
Log:
Add am AST matcher for isMoveAssignmentOperator.
Patch by Jonathan Coe.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang
alexfh added a subscriber: alexfh.
alexfh added a comment.
Should be fixed in http://reviews.llvm.org/D16179.
http://reviews.llvm.org/D16377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Should be fixed in http://reviews.llvm.org/D16179.
On Jan 20, 2016 23:55, "Aaron Ballman" wrote:
> aaron.ballman updated this revision to Diff 45451.
> aaron.ballman added a comment.
>
> Now checking that both the base *and* the derived functions have names.
>
>
> http://reviews.llvm.org/D16377
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258572: [analyzer] Utility to match function calls.
(authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D15921?vs=44721&id=45748#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15
Author: xazax
Date: Fri Jan 22 16:32:46 2016
New Revision: 258572
URL: http://llvm.org/viewvc/llvm-project?rev=258572&view=rev
Log:
[analyzer] Utility to match function calls.
This patch adds a small utility to match function calls. This utility abstracts
away the mutable keywords and the lazy i
eugenis added a comment.
ping
Repository:
rL LLVM
http://reviews.llvm.org/D15699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
silvas added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:440
@@ +439,3 @@
+ if (CodeGenOpts.ProfileIRInstr) {
+// Should not have ProfileInstrGenerate set -- it is for clang
+// instrumentation only.
Then change the existing references in cla
Author: arsenm
Date: Fri Jan 22 15:56:30 2016
New Revision: 258564
URL: http://llvm.org/viewvc/llvm-project?rev=258564&view=rev
Log:
AMDGPU: Add barrier builtin
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn.cl
Modified: cfe/trunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258562: [clang-tidy] Handle decayed types and other
improvements in VirtualNearMiss… (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D16179?vs=45482&id=45739#toc
Repository:
rL
Author: xazax
Date: Fri Jan 22 15:45:51 2016
New Revision: 258562
URL: http://llvm.org/viewvc/llvm-project?rev=258562&view=rev
Log:
[clang-tidy] Handle decayed types and other improvements in VirtualNearMiss
check.
Handle decayed types, ignore qualifiers and accessibility when considering a
meth
silvas added a comment.
In http://reviews.llvm.org/D15829#333902, @davidxl wrote:
> For the longer term, one possible solution is to make FE based
> instrumentation only used for coverage testing which can be turned on
> with -fcoverage-mapping option (currently, -fcoverage-mapping can not
> b
jlebar updated this revision to Diff 45736.
jlebar marked an inline comment as done.
jlebar added a comment.
Add check for extern "C" printf -- we don't want to take just any printf!
http://reviews.llvm.org/D16484
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
tes
jlebar added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:8291-8293
@@ +8290,5 @@
+// in device-side CUDA code.
+if (NewFD->isVariadic() && (NewFD->hasAttr() ||
+NewFD->hasAttr()) &&
+!(II && II->isStr("printf") && !D.isFunctio
Author: arsenm
Date: Fri Jan 22 15:30:53 2016
New Revision: 258560
URL: http://llvm.org/viewvc/llvm-project?rev=258560&view=rev
Log:
AMDGPU: Rename builtins to use amdgcn prefix
Keep the ones still used by libclc around for now.
Emit the new amdgcn intrinsic name if not targeting r600,
in which
mcrosier added inline comments.
Comment at: lib/Driver/Tools.cpp:3279
@@ -3278,1 +3278,3 @@
+
+ Args.AddAllArgs(CmdArgs, options::OPT_fprofile_ir_instr);
}
silvas wrote:
> xur wrote:
> > mcrosier wrote:
> > > I don't think AddAllArgs is what you really want. Wh
arsenm closed this revision.
arsenm added a comment.
r258560
http://reviews.llvm.org/D16444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hjl.tools updated this revision to Diff 45735.
hjl.tools added a comment.
Add a testcase.
http://reviews.llvm.org/D16469
Files:
lib/Driver/Tools.cpp
test/Driver/split-stack-ld.c
Index: test/Driver/split-stack-ld.c
===
--- /dev
Author: adrian
Date: Fri Jan 22 15:14:41 2016
New Revision: 258555
URL: http://llvm.org/viewvc/llvm-project?rev=258555&view=rev
Log:
Module debugging: Create a parent DIModule with the PCH name for types
emitted into a precompiled header to mirror the debug info emitted for
object files importing
Thank you for fixing this!
On Fri, Jan 22, 2016 at 12:30 PM, Nico Weber wrote:
> I implemented Reid's suggestion in 258545. I tested that the test runs and
> passes when the DIA SDK is around (this is usually the case), and doesn't
> run when it isn't.
>
> On Thu, Jan 21, 2016 at 2:09 PM, Alexey
samsonov accepted this revision.
samsonov added a reviewer: samsonov.
samsonov added a comment.
LGTM
Comment at: lib/Driver/ToolChains.cpp:339
@@ +338,3 @@
+ }
+}
+
You might need `llvm_unreachable` at the very end to suppress GCC warnings
(http://llvm.org/doc
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Small nit. LGTM otherwise.
Comment at: lib/Sema/SemaDecl.cpp:8291-8293
@@ +8290,5 @@
+// in device-side CUDA code.
+if (NewFD->isVariadic() && (NewFD->hasAttr() ||
+
ahatanak added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:1962
@@ +1961,3 @@
+for (auto *U : I->users())
+ InstrsToRemove.push_back(cast(U));
+
manmanren wrote:
> Do we need to check if the user has been erased? I am not sure if the same
silvas added inline comments.
Comment at: lib/Driver/Tools.cpp:3279
@@ -3278,1 +3278,3 @@
+
+ Args.AddAllArgs(CmdArgs, options::OPT_fprofile_ir_instr);
}
xur wrote:
> mcrosier wrote:
> > I don't think AddAllArgs is what you really want. What if the user
> > sp
LegalizeAdulthood added a comment.
As a general comment, I am continually fascinated by the **huge** variety of
opinion as to matters of readability within the C++ community. I don't know
why we have so many differing opinions compared to the communities built around
other programming language
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: jhen, echristo, cfe-commits.
http://reviews.llvm.org/D16484
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/SemaCUDA/va-arg.cu
test/SemaCUDA/vararg.cu
Index: test/SemaCUDA/v
Author: sfantao
Date: Fri Jan 22 14:52:54 2016
New Revision: 258550
URL: http://llvm.org/viewvc/llvm-project?rev=258550&view=rev
Log:
[OpenMP] Remove '#if 1' hanging in target_map_messages.cpp.
Modified:
cfe/trunk/test/OpenMP/target_map_messages.cpp
Modified: cfe/trunk/test/OpenMP/target_
probinson added a comment.
Ping.
http://reviews.llvm.org/D15881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a comment.
Ping.
http://reviews.llvm.org/D16094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davidxl added a comment.
For the longer term, one possible solution is to make FE based
instrumentation only used for coverage testing which can be turned on
with -fcoverage-mapping option (currently, -fcoverage-mapping can not
be used alone and must be used together with
-fprofile-instr-generate)
jbcoe added inline comments.
Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp:52
@@ +51,3 @@
+ hasDescendant(
+ cxxMethodDecl(isMoveAssignmentOperator(), unless(isImplicit()))
+ .bind("move-assignment")),
For the longer term, one possible solution is to make FE based
instrumentation only used for coverage testing which can be turned on
with -fcoverage-mapping option (currently, -fcoverage-mapping can not
be used alone and must be used together with
-fprofile-instr-generate). To summarize:
A. Curren
Thanks, I merged it in r258549.
-Dimitry
> On 22 Jan 2016, at 21:43, Hans Wennborg wrote:
>
> It seems Richard is out of office, but perhaps he can verify this later.
>
> Dimitry: go ahead and merge it (or let me know if you'd like me to).
>
> On Fri, Jan 22, 2016 at 12:38 PM, Dimitry Andric
jbcoe updated this revision to Diff 45729.
jbcoe added a comment.
Added handling for move-constructor/move-assignment pairs.
http://reviews.llvm.org/D16376
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp
It seems Richard is out of office, but perhaps he can verify this later.
Dimitry: go ahead and merge it (or let me know if you'd like me to).
On Fri, Jan 22, 2016 at 12:38 PM, Dimitry Andric wrote:
> Hans,
>
> This change looks pretty trivial, and is required to not crash for the test
> cases i
Hans,
This change looks pretty trivial, and is required to not crash for the test
cases in PR26134. Can we merge it to release_38, please?
-Dimitry
> On 19 Jan 2016, at 19:28, Dimitry Andric via cfe-commits
> wrote:
>
> Hi Richard,
>
> I am unsure if you are specifically the code owner of
I implemented Reid's suggestion in 258545. I tested that the test runs and
passes when the DIA SDK is around (this is usually the case), and doesn't
run when it isn't.
On Thu, Jan 21, 2016 at 2:09 PM, Alexey Samsonov wrote:
> On Thu, Jan 21, 2016 at 10:58 AM, Reid Kleckner wrote:
>
>> On Thu, J
Author: sfantao
Date: Fri Jan 22 14:21:36 2016
New Revision: 258543
URL: http://llvm.org/viewvc/llvm-project?rev=258543&view=rev
Log:
[OpenMP] Update map clause SEMA to support OpenMP 4.5 possible list items.
Summary:
Extend support in the map clause SEMA for the expressions supported in the
Ope
Every time we accept something in MS mode that isn't standards compliant,
we should accept it with a warning (for stuff that's harmless, an Extension
warning, for stuff that can lead to bugs a Warning warning), unless it's
really hard to implement.
(See also
https://docs.google.com/presentation/d/
arsenm created this revision.
arsenm added a reviewer: jmolloy.
arsenm added a subscriber: cfe-commits.
Follow the naming convention that bswap uses since it's a
similar sort of operation.
http://reviews.llvm.org/D16482
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test
bcraig created this revision.
bcraig added a reviewer: mclow.lists.
bcraig added a subscriber: cfe-commits.
The old code produced a couple of these warnings...
src/string.cpp:95:11: warning: comparison of constant -2147483648 with
expression of type 'long' (range [-2147483648, 2147483647]) is al
xur added inline comments.
Comment at: lib/Driver/Tools.cpp:3279
@@ -3278,1 +3278,3 @@
+
+ Args.AddAllArgs(CmdArgs, options::OPT_fprofile_ir_instr);
}
mcrosier wrote:
> I don't think AddAllArgs is what you really want. What if the user specifies
> the option t
Do you mean only a warning for the case this patch is handling, or also for
cases such as the second test case in
https://llvm.org/bugs/show_bug.cgi?id=25875#c1 too?
(I think it would probably be a good idea to warn in both cases.)
On Fri, Jan 22, 2016 at 2:39 PM, Nico Weber wrote:
> Is it poss
Is it possible to emit some -Wmicrosoft warning in cases where this is
necessary?
On Fri, Jan 22, 2016 at 2:26 PM, Ehsan Akhgari via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ehsan
> Date: Fri Jan 22 13:26:44 2016
> New Revision: 258530
>
> URL: http://llvm.org/viewvc/llvm-projec
zaks.anna updated this revision to Diff 45720.
zaks.anna added a comment.
Thanks for spotting the bug! The bug is fixed and the tests are added in this
revision.
http://reviews.llvm.org/D15624
Files:
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/darwin-sanitizer-ld.c
te
rafael added a subscriber: rafael.
rafael added a comment.
Needs a testcase.
http://reviews.llvm.org/D16469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe planned changes to this revision.
jbcoe added a comment.
i need the matcher from http://reviews.llvm.org/D16470 to add a corresponding
pair of checks and fixes for move-constructors and move-assignment.
http://reviews.llvm.org/D16376
___
cfe-
Author: adrian
Date: Fri Jan 22 13:29:41 2016
New Revision: 258531
URL: http://llvm.org/viewvc/llvm-project?rev=258531&view=rev
Log:
Fix the build by using the correct suffix for 64 bit literals
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258530: [MSVC Compat] Accept elided commas in macro function
arguments (authored by ehsan).
Changed prior to commit:
http://reviews.llvm.org/D15670?vs=43310&id=45718#toc
Repository:
rL LLVM
http://r
Author: ehsan
Date: Fri Jan 22 13:26:44 2016
New Revision: 258530
URL: http://llvm.org/viewvc/llvm-project?rev=258530&view=rev
Log:
[MSVC Compat] Accept elided commas in macro function arguments
Summary:
This fixes PR25875. When the trailing comma in a macro argument list is
elided, we need to t
ehsan added a comment.
Sure. I'd be happy to address any comments post-landing.
Thanks!
http://reviews.llvm.org/D15670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sure. I'd be happy to address any comments post-landing.
Thanks!
On Fri, Jan 22, 2016 at 2:13 PM, Reid Kleckner wrote:
> rnk added a comment.
>
> Let's go ahead and land this. It doesn't seem high risk. Richard will be
> back on Monday, he's been skiing.
>
>
> http://reviews.llvm.org/D15670
>
Thanks!
--Vassil
On 22/01/16 20:07, Yaron Keren wrote:
Committed revision 258524.
2016-01-21 19:33 GMT+02:00 Vassil Vassilev via cfe-commits
mailto:cfe-commits@lists.llvm.org>>:
ping... (perhaps someone else with commit rights can check it it...)
--Vassil
On 18/01/16 22:07, Vass
Author: adrian
Date: Fri Jan 22 13:14:24 2016
New Revision: 258526
URL: http://llvm.org/viewvc/llvm-project?rev=258526&view=rev
Log:
Rephrase this test to help debug a buildbot issue
Modified:
cfe/trunk/test/Modules/ExtDebugInfo.cpp
Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp
URL:
htt
ehsan added a comment.
In http://reviews.llvm.org/D16465#333688, @rnk wrote:
> Your code won't catch this test case:
>
> static int x;
> extern inline const bool *f() {
> static const bool p = !&x;
> return &p;
> }
>
> Getting this exactly right is going to be a challenge. =/
Oh y
rnk added a comment.
Let's go ahead and land this. It doesn't seem high risk. Richard will be back
on Monday, he's been skiing.
http://reviews.llvm.org/D15670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
mcrosier added a subscriber: mcrosier.
mcrosier added a comment.
Would it make sense to include an additional test (in test/Driver) that shows
the -fprofile-ir-instr option being passed from the driver to the frontend?
Such a test case would land in clang_f_opt.c, which has many examples.
Committed revision 258524.
2016-01-21 19:33 GMT+02:00 Vassil Vassilev via cfe-commits <
cfe-commits@lists.llvm.org>:
> ping... (perhaps someone else with commit rights can check it it...)
> --Vassil
>
> On 18/01/16 22:07, Vassil Vassilev wrote:
>
> Thanks! Could you check it in?
> -- Vassil
> On
Author: yrnkrn
Date: Fri Jan 22 13:03:27 2016
New Revision: 258524
URL: http://llvm.org/viewvc/llvm-project?rev=258524&view=rev
Log:
Merge templated static member variables, fixes http://llvm.org/pr26179.
Patch by Vassil Vassilev!
Reviewed by Richard Smith.
Added:
cfe/trunk/test/Modules/Inp
thakis created this revision.
thakis added reviewers: rsmith, rnk.
thakis added a subscriber: cfe-commits.
Herald added subscribers: aemerson, klimek.
RecursiveASTVisitor::TraverseFunctionHelper() traverses a function's
ParmVarDecls by going to the function's getTypeSourceInfo if it exists, and `
beanz created this revision.
beanz added reviewers: echristo, chandlerc, grosbach, bob.wilson.
beanz added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This patch is provided in preparation for removing autoconf on 1/26. The
proposal to remove autoconf on 1/26 was discussed on th
Author: adrian
Date: Fri Jan 22 12:46:40 2016
New Revision: 258518
URL: http://llvm.org/viewvc/llvm-project?rev=258518&view=rev
Log:
Fix 80-column violations.
Modified:
cfe/trunk/test/Modules/ExtDebugInfo.cpp
Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp
URL:
http://llvm.org/viewvc/llvm
Author: adrian
Date: Fri Jan 22 12:46:45 2016
New Revision: 258519
URL: http://llvm.org/viewvc/llvm-project?rev=258519&view=rev
Log:
Fix a typo in r258507 and change the PCH dwoid constant to ~1UL.
rdar://problem/24290667
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
cfe/trunk/lib/Code
Author: dcoughlin
Date: Fri Jan 22 12:45:22 2016
New Revision: 258517
URL: http://llvm.org/viewvc/llvm-project?rev=258517&view=rev
Log:
[analyzer] SATestBuild.py: Handle spaces in path passed to --use-analyzer.
I missed this one in r258493.
Modified:
cfe/trunk/utils/analyzer/SATestBuild.py
xur updated this revision to Diff 45708.
xur added a comment.
This new patches integrates Sean review comments:
(1) make -fprofile-ir-instr a cc1 option instead of driver option.
(2) add one cc1 option test, and test the pass is indeed invoked.
(3) remove the driver test (runtime library).
(4) fix
davidxl added a comment.
This option is not needed for -fprofile-instr-use compilation as the compiler
can detect the flavor of the profile (patch pending review), and decide what to
do.
The question here is what the option should look like to tell the compiler
which phase to do the instrumen
rnk added a comment.
Your code won't catch this test case:
static int x;
extern inline const bool *f() {
static const bool p = !&x;
return &p;
}
Getting this exactly right is going to be a challenge. =/
Comment at: include/clang/Basic/DiagnosticASTKinds.td:151
@@
hjl.tools created this revision.
hjl.tools added a reviewer: rsmith.
hjl.tools added a subscriber: cfe-commits.
From
https://gcc.gnu.org/ml/gcc-patches/2010-09/msg01807.html
-fsplit-stack should pass --wrap=pthread_create to linker for -fsplit-stack
It is needed to initialize the stack guard. T
> On 2016-Jan-21, at 23:14, Eric Fiselier wrote:
>
> EricWF added a comment.
>
>> - Did I successfully match the coding style? (I'm kind of lost without
>> clang-format TBH.)
>
>
> The style looks pretty good. I'll comment on any nits I have.
>
>> - Should I separate the change to __constru
Author: dexonsmith
Date: Fri Jan 22 12:27:26 2016
New Revision: 258511
URL: http://llvm.org/viewvc/llvm-project?rev=258511&view=rev
Log:
unordered: Rename __construct_node_hash() to allow forwarding, NFC
Rename the version of __construct_node() that takes a hash as an
argument to __construct_node
On Thu, Jan 21, 2016 at 7:32 PM, Sean Silva wrote:
> silvas added a comment.
>
> @slingn and I had a discussion offline about the potential names and came up
> with some ideas, but none is a clear winner.
>
> Overall, my feeling is that from a user's perspective, the frontend stuff is
> probably
> On Jan 22, 2016, at 9:50 AM, David Blaikie wrote:
>
>
>
> On Fri, Jan 22, 2016 at 9:43 AM, Adrian Prantl via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: adrian
> Date: Fri Jan 22 11:43:43 2016
> New Revision: 258507
>
> URL: http://llvm.org/viewvc/llvm-project?rev=25
hokein added a subscriber: hokein.
Comment at: clang-tidy/performance/FasterStringFindCheck.h:25
@@ +24,3 @@
+/// The character literal overload is more efficient.
+///
+/// For the user-facing documentation see:
I think you need to add document about `StringLikeC
1 - 100 of 130 matches
Mail list logo
