[PATCH] D16949: Fix for: Bug 5941 - improve diagnostic for * vs & confusion

ryee88 created this revision. ryee88 added reviewers: doug.gregor, jyasskin, nicholas, rsmith. ryee88 added a subscriber: cfe-commits. This is bug 5941: https://llvm.org/bugs/show_bug.cgi?id=5941 I copied the extra suggestions from the complete type case to the incomplete type case.

r260011 - Index: provide adjustment thunk information for C++ manglings

Author: compnerd Date: Sat Feb 6 16:36:34 2016 New Revision: 260011 URL: http://llvm.org/viewvc/llvm-project?rev=260011=rev Log: Index: provide adjustment thunk information for C++ manglings Add support for exposing the adjustment thunk for virtual methods as appropriate. Modified:

Re: [PATCH] D16948: [libcxx] Filesystem TS Part 1 -- path

EricWF added a comment. In http://reviews.llvm.org/D16948#345722, @dexonsmith wrote: > Light review below, looks like great work. > > I noticed the tests seem somewhat inconsistent about whether to > glue `&` to the type or use two spaces (i.e., ` & `). Which one is > preferred in this

Re: [PATCH] D16948: [libcxx] Filesystem TS Part 1 -- path

> On 2016-Feb-06, at 15:40, Eric Fiselier wrote: > >> > +// The "hash_value" function is tested as part of [path.compare] >> > +// in class.path/path.members/path.compare.pass.cpp >> > +int main() {} >> >> Okay, I get the idea of the one above. I'm guessing this is just how >>

[PATCH] D16947: [PGO] assignment operator does not get profile data

davidxl created this revision. davidxl added a reviewer: vsk. davidxl added subscribers: llvm-commits, cfe-commits. For compiler generated assignment operator that is not trivial (calling base class operator=()), Clang FE assign region counters to the function body but does not emit profile

Re: [PATCH] D16948: [libcxx] Filesystem TS Part 1 -- path

Light review below, looks like great work. I noticed the tests seem somewhat inconsistent about whether to glue `&` to the type or use two spaces (i.e., ` & `). Which one is preferred in this codebase? Or is it laissez-faire? The rest of my comments are inline. > On 2016-Feb-06, at 12:48,

Re: [PATCH] D16948: [libcxx] Filesystem TS Part 1 -- path

dexonsmith added a subscriber: dexonsmith. dexonsmith added a comment. Light review below, looks like great work. I noticed the tests seem somewhat inconsistent about whether to glue `&` to the type or use two spaces (i.e., ` & `). Which one is preferred in this codebase? Or is it

Re: [PATCH] D16792: unordered_map: Use __hash_table::__emplace_unique(), NFC

> On 2016-Feb-06, at 13:28, Eric Fiselier wrote: > > EricWF added a comment. > > This is very subtly broken. The requirements in the standard for emplace are > > [unord.req] Table 102 > >> a_eq.emplace(args) > >> Requires: : value_type shall be EmplaceConstructible into X from

Re: [PATCH] D16738: Fix invalid casts in .

EricWF added a comment. I prefer using the `(void*)` casts when possible. In particular when doing the pointer comparisons. Could you change those back to `void*` casts then use the `__as_base` function for the rest? Repository: rL LLVM http://reviews.llvm.org/D16738

Re: [PATCH] D16792: unordered_map: Use __hash_table::__emplace_unique(), NFC

EricWF added a comment. This is very subtly broken. The requirements in the standard for emplace are [unord.req] Table 102 > a_eq.emplace(args) > Requires: : value_type shall be EmplaceConstructible into X from args. Unfortunately __hash_table doesn't know that unordered_map has this

Re: r260002 - Add a missing call to MDNode::deleteTemporary().

> On 2016-Feb-06, at 10:39, Adrian Prantl via cfe-commits > wrote: > > Author: adrian > Date: Sat Feb 6 12:39:34 2016 > New Revision: 260002 > > URL: http://llvm.org/viewvc/llvm-project?rev=260002=rev > Log: > Add a missing call to MDNode::deleteTemporary(). >

[libcxx] r260012 - Cleanup node-type handling in the unordered containers

Author: ericwf Date: Sat Feb 6 18:36:33 2016 New Revision: 260012 URL: http://llvm.org/viewvc/llvm-project?rev=260012=rev Log: Cleanup node-type handling in the unordered containers This patch is the first in a series of patches that's meant to better support unordered_map. unordered_map has a

r259998 - [analyzer] DeallocChecker: Don't warn on release of readonly assign property in dealloc.

Author: dcoughlin Date: Sat Feb 6 11:17:32 2016 New Revision: 259998 URL: http://llvm.org/viewvc/llvm-project?rev=259998=rev Log: [analyzer] DeallocChecker: Don't warn on release of readonly assign property in dealloc. It is common for the ivars for read-only assign properties to always be

[libunwind] r260001 - Introduce NetBSD support

Author: kamil Date: Sat Feb 6 12:19:29 2016 New Revision: 260001 URL: http://llvm.org/viewvc/llvm-project?rev=260001=rev Log: Introduce NetBSD support Current FreeBSD and NetBSD code is compatible. Modified: libunwind/trunk/src/AddressSpace.hpp Modified:

[libunwind] r259994 - Adapt LLVM_CMAKE_PATH for recent cmake path changes

Author: kamil Date: Sat Feb 6 10:23:18 2016 New Revision: 259994 URL: http://llvm.org/viewvc/llvm-project?rev=259994=rev Log: Adapt LLVM_CMAKE_PATH for recent cmake path changes Current LLVM installs CMake files under lib/cmake/llvm. Modified: libunwind/trunk/CMakeLists.txt Modified:

[PATCH] D16946: Add link to llvm git documentation, and recommend always building libcxx on OSX

hintonda created this revision. hintonda added a reviewer: mclow.lists. hintonda added a subscriber: cfe-commits. http://reviews.llvm.org/D16946 Files: www/get_started.html Index: www/get_started.html === --- www/get_started.html

r260002 - Add a missing call to MDNode::deleteTemporary().

Author: adrian Date: Sat Feb 6 12:39:34 2016 New Revision: 260002 URL: http://llvm.org/viewvc/llvm-project?rev=260002=rev Log: Add a missing call to MDNode::deleteTemporary(). Follow-up to r259975. Kudos to the ASAN bots! Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified:

Re: [PATCH] D10963: Implement LWG#2063: "Contradictory requirements for string move assignment"

mclow.lists abandoned this revision. mclow.lists added a comment. This has been done via another means. http://reviews.llvm.org/D10963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D16953: Enhance clang-tidy modernize-redundant-void-arg check to apply fixes to header files

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: alexfh. LegalizeAdulthood added a subscriber: cfe-commits. Update `check_clang_tidy.py` to handle fixes applied to header files by adding `--header-filter` argument that: - Passes `-header-filter` down to `clang-tidy` -

r260022 - Fix test case problem(caused by clang-format

Author: davidxl Date: Sun Feb 7 01:13:18 2016 New Revision: 260022 URL: http://llvm.org/viewvc/llvm-project?rev=260022=rev Log: Fix test case problem(caused by clang-format Modified: cfe/trunk/test/Profile/def-ctors.cpp cfe/trunk/test/Profile/def-dtors.cpp Modified:

r260019 - Driver: adjust linker invocation for GNUTools

Author: compnerd Date: Sun Feb 7 00:03:38 2016 New Revision: 260019 URL: http://llvm.org/viewvc/llvm-project?rev=260019=rev Log: Driver: adjust linker invocation for GNUTools Adjust the driver to invoke the linker more similar to gcc. -dynamic-linker is only passed if -static and -shared are

Please review: http://reviews.llvm.org/D15883 and http://reviews.llvm.org/D15781

Hi there, Could someone take a look at http://reviews.llvm.org/D15883 and http://reviews.llvm.org/D15781. I was halfway through the review process, with Logan (on to: line) as my main reviewer, but he seems to have become unresponsive. I was told by Logan to submit patch D15883 first, so as not

r260021 - [PGO] add profile/coverage test cases for defaulted ctor/ctors

Author: davidxl Date: Sun Feb 7 00:57:29 2016 New Revision: 260021 URL: http://llvm.org/viewvc/llvm-project?rev=260021=rev Log: [PGO] add profile/coverage test cases for defaulted ctor/ctors Added: cfe/trunk/test/Profile/def-ctors.cpp cfe/trunk/test/Profile/def-dtors.cpp Added:

r260016 - Sema: handle typo correction with ARC'ed objc properties

Author: compnerd Date: Sat Feb 6 20:30:55 2016 New Revision: 260016 URL: http://llvm.org/viewvc/llvm-project?rev=260016=rev Log: Sema: handle typo correction with ARC'ed objc properties We would previously assert in findCapturingExpr when performing a typo correction resulting in an assignment

r260017 - Sema: handle typo correction on ARC'ed ivar

Author: compnerd Date: Sat Feb 6 20:30:59 2016 New Revision: 260017 URL: http://llvm.org/viewvc/llvm-project?rev=260017=rev Log: Sema: handle typo correction on ARC'ed ivar The ivar ref would be transformed by the Typo Correction TreeTransform, but not be owned, resulting in the source location

Re: r245794 - Improve the performance of resolving a lookup result. We usually don't need to

On 22/08/15 23:37, Richard Smith via cfe-commits wrote: Author: rsmith Date: Sat Aug 22 16:37:34 2015 New Revision: 245794 URL: http://llvm.org/viewvc/llvm-project?rev=245794=rev Log: Improve the performance of resolving a lookup result. We usually don't need to pick the most recent