r261195 - [MSVC] Turn C++ EH on my default

2016-02-18 Thread David Majnemer via cfe-commits
Author: majnemer Date: Thu Feb 18 02:15:05 2016 New Revision: 261195 URL: http://llvm.org/viewvc/llvm-project?rev=261195&view=rev Log: [MSVC] Turn C++ EH on my default Our support for C++ EH is sufficiently good that it makes sense to enable support for it out of the box. While we are here, upda

r261196 - [CLANG] [AVX512] [BUILTIN] Adding pmovsx{b|d|w}{w|d|q}{128|256|512} builtin to clang

2016-02-18 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Thu Feb 18 03:09:34 2016 New Revision: 261196 URL: http://llvm.org/viewvc/llvm-project?rev=261196&view=rev Log: [CLANG] [AVX512] [BUILTIN] Adding pmovsx{b|d|w}{w|d|q}{128|256|512} builtin to clang Differential Revision: http://reviews.llvm.org/D16955 Modified: cfe/t

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

2016-02-18 Thread Xiuli PAN via cfe-commits
pxli168 planned changes to this revision. pxli168 added a comment. It seems it is related with the pipe type. I am still working on how to fix this problem. http://reviews.llvm.org/D16040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D17149: Consolidate and improve the handling of built-in feature-like macros

2016-02-18 Thread Andy Gibbs via cfe-commits
AndyG added a comment. Bump :o) http://reviews.llvm.org/D17149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17330: PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode

2016-02-18 Thread Andrey Bokhanko via cfe-commits
andreybokhanko abandoned this revision. andreybokhanko added a comment. @rnk, fair enough. OK, please consider this review request dropped. Andrey http://reviews.llvm.org/D17330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

r261204 - [analyzer] Add --force-analyze-debug-code option to scan-build

2016-02-18 Thread Yury Gribov via cfe-commits
Author: ygribov Date: Thu Feb 18 05:08:46 2016 New Revision: 261204 URL: http://llvm.org/viewvc/llvm-project?rev=261204&view=rev Log: [analyzer] Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings. Static Analyzer is much more effici

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

2016-02-18 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932 @@ +3900,34 @@ +// Reference types are ignored for mapping purposes. +if (auto *RefTy = ExprTy->getAs()) + ExprTy = RefTy->getPointeeType().getCanonicalType(); + +// Given that an

[PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

2016-02-18 Thread Cong Liu via cfe-commits
congliu created this revision. congliu added a reviewer: bkramer. congliu added a subscriber: cfe-commits. Add the parenthese to make it able to build. http://reviews.llvm.org/D17375 Files: tools/llvm-dwp/llvm-dwp.cpp Index: tools/llvm-dwp/llvm-dwp.cpp

Re: [PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

2016-02-18 Thread Benjamin Kramer via cfe-commits
bkramer added a comment. I think this is the wrong solution. Per http://www.dwarfstd.org/ShowIssue.php?issue=140421.1 2. Calculate a secondary hash H' = (((S >> 32) & MASK(k)) | 1). [...] 4. Let H = (H + H') modulo M. Repeat at Step 3. So the OR has to happen before the ADD. http://re

Re: [PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

2016-02-18 Thread Cong Liu via cfe-commits
congliu updated this revision to Diff 48301. congliu added a comment. - Address review comment. http://reviews.llvm.org/D17375 Files: tools/llvm-dwp/llvm-dwp.cpp Index: tools/llvm-dwp/llvm-dwp.cpp === --- tools/llvm-dwp/llvm-dwp

Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

2016-02-18 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806 @@ -3780,4 +3798,10 @@ OffloadEntriesInfoManager.registerTargetRegionEntryInfo( DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID); } +/// \brief Emit the num_teams clause

Re: [PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

2016-02-18 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. LGTM, will commit it for you. http://reviews.llvm.org/D17375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

2016-02-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261207: Add parentheses around arithmetic in operand of '|'. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D17375?vs=48301&id=48302#toc Repository: rL LLVM http://reviews.llvm.

Re: [PATCH] D16139: [MIPS] initFeatureMap() to handle empty string argument

2016-02-18 Thread Bhushan Attarde via cfe-commits
bhushan added a comment. This was observed during expression evaluation in LLDB, where LLDB does not explicitly set `clang::TargetOptions::CPU` hence it remains empty. Repository: rL LLVM http://reviews.llvm.org/D16139 ___ cfe-commits mailing li

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

2016-02-18 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4426-4431 @@ +4425,8 @@ + SourceLocation Loc) { + llvm::Value *PushNumTeamsArgs[] = { + emitUpdateLocation(CGF, Loc), getThreadID(CGF, Loc), NumTeams, + Th

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

2016-02-18 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1876-1878 @@ +1875,5 @@ + SourceLocation Loc, + OpenMPScheduleClauseKind ForSchedKind, + OpenMPDistSchedule

r261209 - [OPENMP] Fix codegen for lastprivate loop counters.

2016-02-18 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Feb 18 07:48:15 2016 New Revision: 261209 URL: http://llvm.org/viewvc/llvm-project?rev=261209&view=rev Log: [OPENMP] Fix codegen for lastprivate loop counters. Patch fixes bug with codegen for lastprivate loop counters. Also it may improve performance for lastprivates ca

[PATCH] D17376: dump_ast_matchers.py: fix replacement regexps

2016-02-18 Thread Aleksei Sidorin via cfe-commits
a.sidorin created this revision. a.sidorin added reviewers: klimek, aaron.ballman. a.sidorin added a subscriber: cfe-commits. a.sidorin set the repository for this revision to rL LLVM. Using re.sub() to replace a sample with '%'s looks strange and causes a format string error if a matcher descrip

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

2016-02-18 Thread Michael Matz via cfe-commits
Hi, On Tue, 16 Feb 2016, H.J. Lu wrote: > Here is the new definition: > > An empty type is a type where it and all of its subobjects (recursively) > are of class, structure, union, or array type. No memory slot nor > register should be used to pass or return an object of empty type. The triv

Re: [PATCH] D17376: dump_ast_matchers.py: fix replacement regexps

2016-02-18 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rL LLVM http://reviews.llvm.org/D17376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D17378: Add additional Hi/Lo registers to Clang MipsTargetInfoBase

2016-02-18 Thread Hrvoje Varga via cfe-commits
hvarga created this revision. hvarga added reviewers: hfinkel, atrick, chandlerc. hvarga added subscribers: cfe-commits, petarj. This patch fixes bug https://dmz-portal.mips.com/bugz/show_bug.cgi?id=2300 by adding additional (missing) Hi/Lo registers to the Clang `MipsTargetInfoBase` class. htt

Re: [PATCH] D17378: Add additional Hi/Lo registers to Clang MipsTargetInfoBase

2016-02-18 Thread Hrvoje Varga via cfe-commits
hvarga added a comment. I'm not sure if I added all of the necessary reviewers or even the correct ones. So please feel free to correct this if it's wrong. http://reviews.llvm.org/D17378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

Re: r261163 - Add 'nopartial' qualifier for availability attributes.

2016-02-18 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Feb-17, at 14:05, Manman Ren via cfe-commits > wrote: > > Author: mren > Date: Wed Feb 17 16:05:48 2016 > New Revision: 261163 > > URL: http://llvm.org/viewvc/llvm-project?rev=261163&view=rev > Log: > Add 'nopartial' qualifier for availability attributes. > > An optional nopartial c

r261217 - [Parse] Code complete expressions in bracket declarators.

2016-02-18 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Feb 18 09:30:24 2016 New Revision: 261217 URL: http://llvm.org/viewvc/llvm-project?rev=261217&view=rev Log: [Parse] Code complete expressions in bracket declarators. Currently we return no results when completing inside of the brackets in a 'char foo[]' declaration. Let the

[PATCH] D17380: [libcxx] Split locale management out of ibm/xlocale.h. NFCI

2016-02-18 Thread Ben Craig via cfe-commits
bcraig created this revision. bcraig added reviewers: howard.hinnant, mclow.lists. bcraig added a subscriber: cfe-commits. This is one part of many of a locale refactor. See http://reviews.llvm.org/D17146 for an idea of where this is going. For the locale refactor, the locale management functio

Re: [PATCH] D17376: dump_ast_matchers.py: fix replacement regexps

2016-02-18 Thread Yury Gribov via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261219: [analyzer] dump_ast_matchers.py: fix replacement regexps (authored by ygribov). Changed prior to commit: http://reviews.llvm.org/D17376?vs=48306&id=48316#toc Repository: rL LLVM http://revie

r261219 - [analyzer] dump_ast_matchers.py: fix replacement regexps

2016-02-18 Thread Yury Gribov via cfe-commits
Author: ygribov Date: Thu Feb 18 09:43:56 2016 New Revision: 261219 URL: http://llvm.org/viewvc/llvm-project?rev=261219&view=rev Log: [analyzer] dump_ast_matchers.py: fix replacement regexps Patch by Alex Sidorin! Differential Revision: http://reviews.llvm.org/D17376 Modified: cfe/trunk/doc

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

2016-02-18 Thread Vassil Vassilev via cfe-commits
Š¢hanks, could you (or smb else with commit perms) check it in? --Vassil On 18/02/16 03:24, Richard Smith wrote: (And otherwise this LGTM.) On Wed, Feb 17, 2016 at 5:24 PM, Richard Smith wrote: + // TODO: Check visibility. New is hidden but has a complete type. If New + // has no arra

[PATCH] D17382: [libcxx] Split locale management out of newlib/xlocale.h. NFCI

2016-02-18 Thread Ben Craig via cfe-commits
bcraig created this revision. bcraig added reviewers: jroelofs, mclow.lists. bcraig added a subscriber: cfe-commits. Herald added a subscriber: jfb. This is one part of many of a locale refactor. See http://reviews.llvm.org/D17146 for an idea of where this is going. For the locale refactor, the

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

2016-02-18 Thread Logan Chien via cfe-commits
logan added inline comments. Comment at: lib/Headers/unwind.h:61 @@ +60,3 @@ +#define _UNWIND_ARM_EHABI 0 +#endif + compnerd wrote: > logan wrote: > > compnerd wrote: > > > logan wrote: > > > > Since this is `unwind.h`, I feel that we can get a step further and us

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

2016-02-18 Thread Manman Ren via cfe-commits
On Wed, Feb 17, 2016 at 10:33 PM, Akira Hatanaka wrote: > ahatanak added a comment. > > OK, I now understand what you meant. > > > How about the following? > > > > > > else if (LocalAlignment == 8) { > > > if (NumBytesAtAlign8 == 0) { > > > // We have not seen any 8-byte aligned eleme

Re: [PATCH] D17382: [libcxx] Split locale management out of newlib/xlocale.h. NFCI

2016-02-18 Thread Jonathan Roelofs via cfe-commits
jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D17380: [libcxx] Split locale management out of ibm/xlocale.h. NFCI

2016-02-18 Thread Jonathan Roelofs via cfe-commits
jroelofs added a subscriber: jroelofs. jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17380 ___ cfe-commits mailing list

Re: [PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

2016-02-18 Thread David Blaikie via cfe-commits
Thanks all! Which compiler flagged this? Wonder if/why Clang didn't flag it for me? On Thu, Feb 18, 2016 at 5:27 AM, Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL261207: Add parent

r261221 - Add an AST matcher for real floating-point types. e.g., float, double, long double, but not complex.

2016-02-18 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Feb 18 10:36:01 2016 New Revision: 261221 URL: http://llvm.org/viewvc/llvm-project?rev=261221&view=rev Log: Add an AST matcher for real floating-point types. e.g., float, double, long double, but not complex. Modified: cfe/trunk/docs/LibASTMatchersReference.htm

Re: [PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

2016-02-18 Thread Benjamin Kramer via cfe-commits
On Thu, Feb 18, 2016 at 5:39 PM, David Blaikie wrote: > Thanks all! Which compiler flagged this? Wonder if/why Clang didn't flag it > for me? It was coming from GCC 4.9. Haven't checked if Clang also has this somewhere. > On Thu, Feb 18, 2016 at 5:27 AM, Phabricator via cfe-commits > wrote: >>

r261222 - Avoid double deletion in Clang driver.

2016-02-18 Thread Serge Pavlov via cfe-commits
Author: sepavloff Date: Thu Feb 18 10:42:09 2016 New Revision: 261222 URL: http://llvm.org/viewvc/llvm-project?rev=261222&view=rev Log: Avoid double deletion in Clang driver. Llvm module object is shared between CodeGenerator and BackendConsumer, in both classes it is stored as std::unique_ptr, w

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

2016-02-18 Thread Serge Pavlov via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261222: Avoid double deletion in Clang driver. (authored by sepavloff). Changed prior to commit: http://reviews.llvm.org/D15450?vs=46575&id=48332#toc Repository: rL LLVM http://reviews.llvm.org/D154

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

2016-02-18 Thread Akira Hatanaka via cfe-commits
On Thu, Feb 18, 2016 at 8:10 AM, Manman Ren wrote: > > > On Wed, Feb 17, 2016 at 10:33 PM, Akira Hatanaka > wrote: > >> ahatanak added a comment. >> >> OK, I now understand what you meant. >> >> > How about the following? >> >> > >> >> > else if (LocalAlignment == 8) { >> >> > if (NumBytes

r261223 - File missed from r261222

2016-02-18 Thread Serge Pavlov via cfe-commits
Author: sepavloff Date: Thu Feb 18 10:43:24 2016 New Revision: 261223 URL: http://llvm.org/viewvc/llvm-project?rev=261223&view=rev Log: File missed from r261222 Added: cfe/trunk/unittests/Frontend/CodeGenActionTest.cpp Added: cfe/trunk/unittests/Frontend/CodeGenActionTest.cpp URL: http://ll

Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

2016-02-18 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806 @@ -3780,4 +3798,10 @@ OffloadEntriesInfoManager.registerTargetRegionEntryInfo( DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID); } +/// \brief Emit the num_teams

[PATCH] D17385: clang-format: [JS] single quote double quoted strings.

2016-02-18 Thread Martin Probst via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. http://reviews.llvm.org/D17385 Files: lib/Format/Format.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp ===

Re: r257763 - clang-format: Fix incorrectly enforced linebreak with ColumnLimit 0.

2016-02-18 Thread Hans Wennborg via cfe-commits
On Thu, Jan 14, 2016 at 5:36 AM, Daniel Jasper via cfe-commits wrote: > Author: djasper > Date: Thu Jan 14 07:36:46 2016 > New Revision: 257763 > > URL: http://llvm.org/viewvc/llvm-project?rev=257763&view=rev > Log: > clang-format: Fix incorrectly enforced linebreak with ColumnLimit 0. > > Before:

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

2016-02-18 Thread Akira Hatanaka via cfe-commits
On Thu, Feb 18, 2016 at 8:47 AM, Akira Hatanaka wrote: > On Thu, Feb 18, 2016 at 8:10 AM, Manman Ren wrote: > >> >> >> On Wed, Feb 17, 2016 at 10:33 PM, Akira Hatanaka >> wrote: >> >>> ahatanak added a comment. >>> >>> OK, I now understand what you meant. >>> >>> > How about the following? >>>

Re: [PATCH] D17385: clang-format: [JS] single quote double quoted strings.

2016-02-18 Thread Martin Probst via cfe-commits
mprobst updated this revision to Diff 48338. mprobst added a comment. Fixed typo. http://reviews.llvm.org/D17385 Files: lib/Format/Format.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp === --- u

[PATCH] D17387: Add check for CERT FLP30-C

2016-02-18 Thread Aaron Ballman via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: alexfh, sbenza. aaron.ballman added a subscriber: cfe-commits. This patch adds a check for the CERT secure coding rule: FLP30-C. Do not use floating-point variables as loop counters. It flags any for loop induction expression th

[PATCH] D17389: Embed bitcode in object file (clang cc1 part)

2016-02-18 Thread Steven Wu via cfe-commits
steven_wu created this revision. steven_wu added a subscriber: cfe-commits. Herald added subscribers: dschuff, jfb. Teach clang to embed bitcode inside bitcode. When -fembed-bitcode cc1 option is used, clang will embed both the input bitcode and cc1 commandline into the bitcode in special sections

[PATCH] D17390: Introduce -fembed-bitcode driver option

2016-02-18 Thread Steven Wu via cfe-commits
steven_wu created this revision. steven_wu added a subscriber: cfe-commits. This is the clang driver part of the change to embedded bitcode. This includes: 1. -fembed-bitcode option which breaks down the compilation into two stages. The first stage emits optimized bitcode and the second stage comp

Re: [PATCH] D17389: Embed bitcode in object file (clang cc1 part)

2016-02-18 Thread Steven Wu via cfe-commits
steven_wu abandoned this revision. steven_wu added a comment. I accidentally send this patch with everything in it. I will send out patch in small chunks instead. http://reviews.llvm.org/D17389 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D17392: Embed bitcode in object file (clang cc1 part)

2016-02-18 Thread Steven Wu via cfe-commits
steven_wu created this revision. steven_wu added a subscriber: cfe-commits. steven_wu added a dependency: D17390: Introduce -fembed-bitcode driver option. Teach clang to embed bitcode inside bitcode. When -fembed-bitcode cc1 option is used, clang will embed both the input bitcode and cc1 commandli

[libcxx] r261231 - Split locale management out of newlib/xlocale.h. NFCI

2016-02-18 Thread Ben Craig via cfe-commits
Author: bcraig Date: Thu Feb 18 11:40:16 2016 New Revision: 261231 URL: http://llvm.org/viewvc/llvm-project?rev=261231&view=rev Log: Split locale management out of newlib/xlocale.h. NFCI This is one part of many of a locale refactor. See http://reviews.llvm.org/D17146 for an idea of where this is

[libcxx] r261230 - Split locale management out of ibm/xlocale.h. NFCI

2016-02-18 Thread Ben Craig via cfe-commits
Author: bcraig Date: Thu Feb 18 11:37:33 2016 New Revision: 261230 URL: http://llvm.org/viewvc/llvm-project?rev=261230&view=rev Log: Split locale management out of ibm/xlocale.h. NFCI This is one part of many of a locale refactor. See http://reviews.llvm.org/D17146 for an idea of where this is go

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

2016-02-18 Thread Manman Ren via cfe-commits
manmanren added a comment. > If Capacity is not a multiple of 8, (LocalSize + NumBytesAtAlign4) % 8 > doesn't tell you whether the new element will be 8-byte aligned. For example, > if Capacity==36, NumBytesAtAlign4==4, and LocalSize==8, (LocalSize + > NumBytesAtAlign4) equals 12 but padding

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

2016-02-18 Thread Nico Weber via cfe-commits
thakis added inline comments. Comment at: include/clang/AST/DeclCXX.h:410 @@ +409,3 @@ +}; +unsigned AllowConstDefaultInit : 3; +AllowConstDefInitKind allowConstDefInitKind() { This should be :2 of course. http://reviews.llvm.org/D16552 __

Embedded Bitcode in Object Files

2016-02-18 Thread Steven Wu via cfe-commits
Hi all I put up some patches for embedding bitcode inside the object file (-fembed-bitcode) option. As I described in the dev list before, the new option can create normal object file with bitcode embedded in a special section. You can easily recreate the same object file with the embedded bitc

Re: [PATCH] D16012: Carry raw string literal information through to the AST StringLiteral representation

2016-02-18 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. In http://reviews.llvm.org/D16012#351827, @rsmith wrote: > I'm definitely sympathetic to making `StringLiteralParser` expose information > [...] I was unaware of this class; so far I have only studied the classes appearing in the AST. I did notice that the

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

2016-02-18 Thread David Li via cfe-commits
davidxl added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:150 @@ -149,2 +149,3 @@ - if (!CodeGenOpts.InstrProfileInput.empty()) { + if (!CodeGenOpts.hasProfileIRInstr() && + !CodeGenOpts.InstrProfileInput.empty()) { Better to use if (CodeGe

[PATCH] D17397: Make deprecation message for -fsanitize-coverage= with numeric argument friendlier.

2016-02-18 Thread Nico Weber via cfe-commits
thakis created this revision. thakis added a reviewer: kcc. thakis added a subscriber: cfe-commits. http://reviews.llvm.org/D17397 Files: lib/Driver/SanitizerArgs.cpp test/Driver/fsanitize-coverage.c Index: test/Driver/fsanitize-coverage.c

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

2016-02-18 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. @Mats, I think I would prefer not to add even more special handling (i.e. error in this case) for printf. I will look into adding it as a Builtin instead. However, I would prefer to remove it from this change and submit a separate patch as it doesn't belong to Clang

Re: [PATCH] D17349: ARM: fix VFP asm constraints

2016-02-18 Thread JF Bastien via cfe-commits
jfb updated this revision to Diff 48363. jfb added a comment. - Add test. http://reviews.llvm.org/D17349 Files: lib/Basic/Targets.cpp test/CodeGen/arm-vfp-asm-constraint.c Index: test/CodeGen/arm-vfp-asm-constraint.c === --- /

Re: [PATCH] D17397: Make deprecation message for -fsanitize-coverage= with numeric argument friendlier.

2016-02-18 Thread Kostya Serebryany via cfe-commits
kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM Thanks! I don't see much value in doing this, but also don't mind. http://reviews.llvm.org/D17397 ___ cfe-commits mailing list cfe-commits@lists.

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

2016-02-18 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Thanks for the feedback! Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932 @@ +3900,34 @@ +// Reference types are ignored for mapping purposes. +if (auto *RefTy = ExprTy->getAs()) + ExprTy = RefTy->getPointeeType().getCanonic

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

2016-02-18 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: include/clang/AST/DeclCXX.h:405-416 @@ -404,1 +404,14 @@ +enum AllowConstDefInitKind { + ACDI_Unknown, + ACDI_Yes, + ACDI_No, +}; +unsigned AllowConstDefaultInit : 3; +AllowConstDefInitKind allowConstDef

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

2016-02-18 Thread Carlo Bertolli via cfe-commits
carlo.bertolli marked 4 inline comments as done. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4426-4431 @@ +4425,8 @@ + SourceLocation Loc) { + llvm::Value *PushNumTeamsArgs[] = { + emitUpdateLocation(CGF, Loc), getThreadID(CGF, Loc), N

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

2016-02-18 Thread Carlo Bertolli via cfe-commits
carlo.bertolli updated this revision to Diff 48369. carlo.bertolli added a comment. Addressed latest comments. Repository: rL LLVM http://reviews.llvm.org/D17148 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp test/OpenMP/teams_codege

Re: [PATCH] D17349: ARM: fix VFP asm constraints

2016-02-18 Thread JF Bastien via cfe-commits
jfb added a comment. Added a test. Constraint validation is lacking in LLVM: it doesn't check that the input variable matches the constraint. I do pass `mfpmath vfp` to the test in case this gets fixed, but it's not strictly necessary right now. The following is currently accepted: int oops

r261243 - [analyzer] Improve modeling of ObjC synthesized property setters.

2016-02-18 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Thu Feb 18 13:13:30 2016 New Revision: 261243 URL: http://llvm.org/viewvc/llvm-project?rev=261243&view=rev Log: [analyzer] Improve modeling of ObjC synthesized property setters. When modeling a call to a setter for a property that is synthesized to be backed by an instance

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

2016-02-18 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932 @@ +3900,34 @@ +// Reference types are ignored for mapping purposes. +if (auto *RefTy = ExprTy->getAs()) + ExprTy = RefTy->getPointeeType().getCanonicalType(); + +// Given that an

Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

2016-02-18 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806 @@ -3780,4 +3798,10 @@ OffloadEntriesInfoManager.registerTargetRegionEntryInfo( DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID); } +/// \brief Emit the num_teams clause

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

2016-02-18 Thread Nico Weber via cfe-commits
thakis updated this revision to Diff 48373. thakis marked an inline comment as done. thakis added a comment. address comments http://reviews.llvm.org/D16552 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/Sema/SemaInit.cpp lib/Serialization/ASTReader

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

2016-02-18 Thread Nico Weber via cfe-commits
thakis added a comment. thanks! Comment at: include/clang/AST/DeclCXX.h:405-416 @@ -404,1 +404,14 @@ +enum AllowConstDefInitKind { + ACDI_Unknown, + ACDI_Yes, + ACDI_No, +}; +unsigned AllowConstDefaultInit : 3; +AllowConstDefInitKind allowCons

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

2016-02-18 Thread Nico Weber via cfe-commits
thakis added inline comments. Comment at: lib/AST/DeclCXX.cpp:403-413 @@ +402,13 @@ + for (const auto *F : fields()) { +if (F->hasInClassInitializer() || F->isMutable() || F->isUnnamedBitfield()) + continue; +if (CXXRecordDecl *FieldType = F->getType()->getAsCXXRecor

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

2016-02-18 Thread Nico Weber via cfe-commits
thakis updated this revision to Diff 48376. thakis added a comment. update test http://reviews.llvm.org/D16552 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/Sema/SemaInit.cpp lib/Serialization/ASTReaderDecl.cpp lib/Serialization/ASTWriter.cpp t

r261247 - Make deprecation message for -fsanitize-coverage= with numeric argument friendlier.

2016-02-18 Thread Nico Weber via cfe-commits
Author: nico Date: Thu Feb 18 13:32:54 2016 New Revision: 261247 URL: http://llvm.org/viewvc/llvm-project?rev=261247&view=rev Log: Make deprecation message for -fsanitize-coverage= with numeric argument friendlier. http://reviews.llvm.org/D17397 Modified: cfe/trunk/lib/Driver/SanitizerArgs.

Re: [PATCH] D17397: Make deprecation message for -fsanitize-coverage= with numeric argument friendlier.

2016-02-18 Thread Nico Weber via cfe-commits
thakis closed this revision. thakis added a comment. 261247 http://reviews.llvm.org/D17397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

2016-02-18 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806 @@ -3780,4 +3798,10 @@ OffloadEntriesInfoManager.registerTargetRegionEntryInfo( DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID); } +/// \brief Emit the num_teams c

r261248 - [analyzer] Include comment mistakenly left out of r261243. NFC.

2016-02-18 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Thu Feb 18 13:37:39 2016 New Revision: 261248 URL: http://llvm.org/viewvc/llvm-project?rev=261248&view=rev Log: [analyzer] Include comment mistakenly left out of r261243. NFC. It explains why we can't just synthesize bodies of setters in BodyFarm. Modified: cfe/trunk/

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

2016-02-18 Thread Carlo Bertolli via cfe-commits
carlo.bertolli added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:187-208 @@ -185,30 +186,24 @@ + +public: /// \brief Values for bit flags used in the ident_t to describe the fields. /// All enumeric elements are named and described in accordance with the code

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

2016-02-18 Thread Carlo Bertolli via cfe-commits
carlo.bertolli updated this revision to Diff 48379. carlo.bertolli marked 4 inline comments as done. carlo.bertolli added a comment. Partially address comments to replace schedule type with schedule num in interface of static function generating call to kmpc_for_static_init. Still waiting for up

[PATCH] D17405: Use Backend_EmitMCNull for null codegen unit tests.

2016-02-18 Thread David L. Jones via cfe-commits
dlj created this revision. dlj added a subscriber: cfe-commits. Using Backend_EmitLL attemps to create a file with an empty filename. This is problematic in certain environments: an empty filename may be illegal, or the default output path may not be writable (in the case where an empty filename w

r261251 - Make test less prone to attribute changes

2016-02-18 Thread Krzysztof Parzyszek via cfe-commits
Author: kparzysz Date: Thu Feb 18 14:02:03 2016 New Revision: 261251 URL: http://llvm.org/viewvc/llvm-project?rev=261251&view=rev Log: Make test less prone to attribute changes Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c URL: http://llvm

Re: [PATCH] D17405: Use Backend_EmitMCNull for null codegen unit tests.

2016-02-18 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17405 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

2016-02-18 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 48384. ahatanak added a comment. Address Manman's review comments. Handle elements with "LocalAlignment == 8" similarly to those with "LocalAlignment == 4". http://reviews.llvm.org/D16843 Files: lib/Sema/TypeLocBuilder.cpp test/SemaObjCXX/typeloc-data

Re: [PATCH] D17405: Use Backend_EmitMCNull for null codegen unit tests.

2016-02-18 Thread David L. Jones via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261252: Use Backend_EmitMCNull for null codegen unit tests. (authored by dlj). Changed prior to commit: http://reviews.llvm.org/D17405?vs=48380&id=48386#toc Repository: rL LLVM http://reviews.llvm.o

r261252 - Use Backend_EmitMCNull for null codegen unit tests.

2016-02-18 Thread David L. Jones via cfe-commits
Author: dlj Date: Thu Feb 18 14:27:16 2016 New Revision: 261252 URL: http://llvm.org/viewvc/llvm-project?rev=261252&view=rev Log: Use Backend_EmitMCNull for null codegen unit tests. Using Backend_EmitLL attemps to create a file with an empty filename. This is problematic in certain environments:

r261253 - Missed a spot in r261251, also ignore attributes on all pointer parameters

2016-02-18 Thread Krzysztof Parzyszek via cfe-commits
Author: kparzysz Date: Thu Feb 18 14:30:40 2016 New Revision: 261253 URL: http://llvm.org/viewvc/llvm-project?rev=261253&view=rev Log: Missed a spot in r261251, also ignore attributes on all pointer parameters Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c Modified: cfe/trunk/test/CodeGen/

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

2016-02-18 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 48387. ahatanak added a comment. Fix indentation. http://reviews.llvm.org/D16843 Files: lib/Sema/TypeLocBuilder.cpp test/SemaObjCXX/typeloc-data-alignment.mm Index: test/SemaObjCXX/typeloc-data-alignment.mm

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

2016-02-18 Thread Manman Ren via cfe-commits
manmanren added a comment. Thanks Akira, LGTM. Manman http://reviews.llvm.org/D16843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17407: [Sema] PR25755 Fix crash when initializing out-of-order struct references

2016-02-18 Thread don hinton via cfe-commits
hintonda created this revision. hintonda added a reviewer: rsmith. hintonda added a subscriber: cfe-commits. Remove assert that fired whenever initialization lists had errors, and pass VerifyOnly=false to PerformEmptyInit so we'll get diagnostics. http://reviews.llvm.org/D17407 Files: lib/Sema

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

2016-02-18 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932 @@ +3900,34 @@ +// Reference types are ignored for mapping purposes. +if (auto *RefTy = ExprTy->getAs()) + ExprTy = RefTy->getPointeeType().getCanonicalType(); + +// Given

r261260 - [Sema] Fix bug in TypeLocBuilder::pushImpl

2016-02-18 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Thu Feb 18 15:05:09 2016 New Revision: 261260 URL: http://llvm.org/viewvc/llvm-project?rev=261260&view=rev Log: [Sema] Fix bug in TypeLocBuilder::pushImpl The code in TypeLocBuilder::pushImpl wasn't correctly handling the case where an element that has an 8-byte alignment w

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

2016-02-18 Thread Akira Hatanaka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261260: [Sema] Fix bug in TypeLocBuilder::pushImpl (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D16843?vs=48387&id=48392#toc Repository: rL LLVM http://reviews.llvm.org/D

[PATCH] D17410: [libcxxabi] Respect LIBCXXABI_LIBDIR_SUFFIX before an install

2016-02-18 Thread Ben Craig via cfe-commits
bcraig created this revision. bcraig added reviewers: mclow.lists, EricWF, danalbert, jroelofs. bcraig added a subscriber: cfe-commits. Prior to this patch, setting LIBCXXABI_LIBDIR_SUFFIX would confuse the check-libcxxabi target. libc++abi.* would get output to lib instead of lib${LIBCXXABI_LI

Re: [PATCH] D17410: [libcxxabi] Respect LIBCXXABI_LIBDIR_SUFFIX before an install

2016-02-18 Thread Ben Craig via cfe-commits
bcraig updated this revision to Diff 48396. bcraig added a comment. Prior version doesn't apply to master. The context was dirty from some unsubmitted patches. http://reviews.llvm.org/D17410 Files: CMakeLists.txt Index: CMakeLists.txt ===

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

2016-02-18 Thread Bruno Cardoso Lopes via cfe-commits
bruno updated this revision to Diff 48397. bruno added a comment. Updated the patch, with the following changes: Handle ".", ".." and "./" with trailing slashes while collecting files to be dumped into the vfs overlay directory. Include the support for symlinks into components. Given the

Re: [PATCH] D17360: [cfi] Fix handling of sanitize trap/recover flags in the cross-DSO CFI mode.

2016-02-18 Thread Evgeniy Stepanov via cfe-commits
eugenis added a comment. This lets us support the following case: module A checks vcalls and casts, with diagnostics module B checks vcalls but not casts (but it still has bitsets for vtables), with diagnostics then a cast check from module A with a target in module B should print diagnostics in

[PATCH] D17416: [libcxx] Reorganize locale extension fallbacks

2016-02-18 Thread Ben Craig via cfe-commits
bcraig created this revision. bcraig added reviewers: jroelofs, danalbert, mclow.lists. bcraig added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer, jfb. This is one part of many of a locale refactor. See http://reviews.llvm.org/D17146 for an idea of where th

r261271 - Remove use of builtin comma operator.

2016-02-18 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Thu Feb 18 16:34:54 2016 New Revision: 261271 URL: http://llvm.org/viewvc/llvm-project?rev=261271&view=rev Log: Remove use of builtin comma operator. Cleanup for upcoming Clang warning -Wcomma. No functionality change intended. Modified: cfe/trunk/lib/Analysis/FormatStr

[PATCH] D17418: [analyzer] Add checker callback for beginning of function.

2016-02-18 Thread Devin Coughlin via cfe-commits
dcoughlin created this revision. dcoughlin added a reviewer: zaks.anna. dcoughlin added a subscriber: cfe-commits. Add a checker callback that is called when the analyzer starts analyzing a function either at the top level or when inlined. This will be used by a follow-on patch making the DeallocC

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

2016-02-18 Thread H.J. Lu via cfe-commits
On Thu, Feb 18, 2016 at 6:35 AM, Michael Matz wrote: > Hi, > > On Tue, 16 Feb 2016, H.J. Lu wrote: > >> Here is the new definition: >> >> An empty type is a type where it and all of its subobjects (recursively) >> are of class, structure, union, or array type. No memory slot nor >> register shoul

  1   2   >