jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, echristo.
curand.h includes curand_mtgp32_kernel.h. In host mode, this header
redefines threadIdx and blockDim, giving them their "proper" types of
uint3 and dim3, respectively.
clang has its own p
Yeah, we should be doing this. Nice catch Paul and Greg.
On Tue, Feb 23, 2016, 10:34 PM Greg Bedwell
wrote:
> gbedwell added a subscriber: gbedwell.
> gbedwell added a comment.
>
> In http://reviews.llvm.org/D17550#360177, @probinson wrote:
>
> > One question I have, which shouldn't block this (
echristo added a subscriber: echristo.
echristo added a comment.
Yeah, we should be doing this. Nice catch Paul and Greg.
Repository:
rL LLVM
http://reviews.llvm.org/D17550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, echristo.
This lets you write, e.g.
uint3 a = threadIdx;
uint3 b = blockIdx;
dim3 c = gridDim;
dim3 d = blockDim;
which is legal in nvcc, but was not legal in clang.
The fact that e.g. the
gbedwell added a subscriber: gbedwell.
gbedwell added a comment.
In http://reviews.llvm.org/D17550#360177, @probinson wrote:
> One question I have, which shouldn't block this (as we've done several like
> this already):
> Is is okay to be using C++ style comments in these headers?
> (Is there
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261717: Default vaarg lowering should support indirect
struct types. (authored by jyknight).
Changed prior to commit:
http://reviews.llvm.org/D16154?vs=44785&id=48881#toc
Repository:
rL LLVM
http://
Hi,
Does anyone knows why the svn seems to be stuck after I commit this patch.
Thanks
Xiuli
-Original Message-
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
Xiuli Pan via cfe-commits
Sent: Wednesday, February 24, 2016 12:41 PM
To: cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261719: [OpenCL] Add Sema checks for OpenCL 2.0 block
(authored by pxl).
Changed prior to commit:
http://reviews.llvm.org/D17436?vs=48774&id=48880#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17
Author: pxl
Date: Tue Feb 23 22:29:36 2016
New Revision: 261719
URL: http://llvm.org/viewvc/llvm-project?rev=261719&view=rev
Log:
[OpenCL] Add Sema checks for OpenCL 2.0 block
Summary:
Add Sema checks for opencl 2.0 new features: Block.
This patch is partitioned from http://reviews.llvm.org/D1604
arsenm updated this revision to Diff 48879.
arsenm added a comment.
Add long double version. Add the short summary before linking to the intrinsic
doc
http://reviews.llvm.org/D17558
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeG
Author: jyknight
Date: Tue Feb 23 20:59:33 2016
New Revision: 261717
URL: http://llvm.org/viewvc/llvm-project?rev=261717&view=rev
Log:
Default vaarg lowering should support indirect struct types.
Fixes PR11517 for SPARC.
On most targets, clang lowers va_arg itself, eschewing the use of the
llvm
pxli168 added a comment.
It now gives a warning for both C99 and OpenCL.
But for target SPIR it gives an err only because it treat unprototyped function
as varidic function:
/// \brief Checks whether the given calling convention supports variadic
/// calls. Unprototyped calls also use the va
pxli168 updated this revision to Diff 48872.
pxli168 marked an inline comment as done.
http://reviews.llvm.org/D17437
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaType.cpp
test/CodeGenOpenCL/opencl_types.cl
test/SemaOpenCL/invalid-image.cl
test/
rsmith added a subscriber: rsmith.
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
Sure, it makes sense to expose this.
Comment at: docs/LanguageExtensions.rst:1743
@@ +1742,3 @@
+
+This pro
arsenm created this revision.
arsenm added a subscriber: cfe-commits.
http://reviews.llvm.org/D17558
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins.c
Index: test/CodeGen/builtins.c
==
On Tue, Feb 23, 2016 at 8:28 AM, H.J. Lu wrote:
> On Tue, Feb 23, 2016 at 8:15 AM, Michael Matz wrote:
>> Hi,
>>
>> On Tue, 23 Feb 2016, H.J. Lu wrote:
>>
>>> I thought
>>>
>>> ---
>>> An empty type is a type where it and all of its subobjects (recursively)
>>> are of class, structure, union, or
rtrieu added a comment.
While this change does add the intended error messages, it won't produce a
correct a typo-corrected AST. For instance:
void run(int sss) {
sss = ? : ;
}
Will produce an empty function body:
`-FunctionDecl 0x7082ef0 line:1:6 run 'void (int)'
Calling getMostRecentDecl seems like a slightly fragile way to avoid
iterator invalidation here. Instead...
@@ -214,6 +212,19 @@ namespace clang {
unsigned I = Record.size();
Record.push_back(0);
+ auto &Specializations = Common->Specializations;
+ auto &&PartialSpecializa
Author: awatry
Date: Tue Feb 23 18:52:15 2016
New Revision: 261714
URL: http://llvm.org/viewvc/llvm-project?rev=261714&view=rev
Log:
math: Fix ilogb(double) return type
Signed-off-by: Aaron Watry
Reviewed-by: Jan Vesely
Modified:
libclc/trunk/generic/lib/math/ilogb.cl
Modified: libclc/tru
xur updated this revision to Diff 48859.
xur marked 2 inline comments as done.
xur added a comment.
Integrated with David's comments.
Thanks,
-Rong
http://reviews.llvm.org/D15829
Files:
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOpti
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
OK, let's go with this as a starting point. We don't need to get
maximally-precise type information in the first iteration.
http://reviews.llvm.org/D16821
_
xur marked 4 inline comments as done.
Comment at: lib/CodeGen/CodeGenModule.cpp:151
@@ -151,1 +150,3 @@
+ if (CodeGenOpts.hasProfileClangUse() &&
+ !CodeGenOpts.InstrProfileInput.empty()) {
auto ReaderOrErr =
davidxl wrote:
> Is the second condition sti
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM.
One question I have, which shouldn't block this (as we've done several like
this already):
Is is okay to be using C++ style comments in these headers?
(Is there a C-style comment t
rtrieu added inline comments.
Comment at: lib/Sema/SemaCast.cpp:1729
@@ +1728,3 @@
+/// defined in the current TU.
+static void diagnoseCallingConvCast(Sema &Self, const ExprResult &SrcExpr,
+QualType DstType, SourceRange OpRange) {
jyknight added a comment.
Ping. I'm pretty sure you said you were going to look at this. :)
http://reviews.llvm.org/D17183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rtrieu added a comment.
A few more comments.
In http://reviews.llvm.org/D15636#358588, @AndyG wrote:
> Patch additionally re-based off r261522.
It's usually a bad idea to rebase in the middle of a string of patches.
Phabricator isn't aware of revisions, so while a base to latest patch will s
> On 2016-Feb-23, at 11:18, Aaron Ballman wrote:
>
> On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote:
>> This patch looks good to me. But I am not sure if Aaron has any comment.
>>
>> On Feb 22, 2016, at 6:19 PM, Duncan P. N. Exon Smith
>> wrote:
>>
>>
>> On 2016-Feb-22, at 17:24, Manman
Author: rsmith
Date: Tue Feb 23 17:20:51 2016
New Revision: 261705
URL: http://llvm.org/viewvc/llvm-project?rev=261705&view=rev
Log:
PR24667: fix quadratic runtime if textually-included modular headers define
large numbers of macros.
Modified:
cfe/trunk/include/clang/Lex/Preprocessor.h
c
davidxl added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.h:83
@@ -82,2 +82,3 @@
enum ProfileInstrKind {
ProfileNoInstr,// No instrumentation.
+ProfileClangInstr, // Clang instrumentation to generate execution counts
Maybe Pr
Author: dcoughlin
Date: Tue Feb 23 16:26:04 2016
New Revision: 261703
URL: http://llvm.org/viewvc/llvm-project?rev=261703&view=rev
Log:
[analyzer] Find ObjC 'self' decl even when block captures local named 'self'.
When looking up the 'self' decl in block captures, make sure to find the actual
sel
Author: hans
Date: Tue Feb 23 15:40:01 2016
New Revision: 261690
URL: http://llvm.org/viewvc/llvm-project?rev=261690&view=rev
Log:
Creating release candidate rc3 from release_380 branch
Added:
libcxx/tags/RELEASE_380/rc3/ (props changed)
- copied from r261689, libcxx/branches/release_
Author: hans
Date: Tue Feb 23 15:40:24 2016
New Revision: 261697
URL: http://llvm.org/viewvc/llvm-project?rev=261697&view=rev
Log:
Creating release candidate rc3 from release_380 branch
Added:
libunwind/tags/RELEASE_380/rc3/
- copied from r261696, libunwind/branches/release_38/
___
Author: hans
Date: Tue Feb 23 15:40:04 2016
New Revision: 261691
URL: http://llvm.org/viewvc/llvm-project?rev=261691&view=rev
Log:
Creating release candidate rc3 from release_380 branch
Added:
libcxxabi/tags/RELEASE_380/rc3/ (props changed)
- copied from r261690, libcxxabi/branches/re
On Tue, Feb 23, 2016 at 11:12 AM, Aaron Ballman wrote:
> On Tue, Feb 23, 2016 at 2:03 PM, Hans Wennborg wrote:
>> Hi Aaron,
>>
>> I'll let it sit in the tree for a bit, and will then merge it later today.
>
> Sounds great, thank you!
r261684.
>> Many thanks,
>> Hans
>>
>> On Tue, Feb 23, 2016
On Tue, Feb 23, 2016 at 1:02 PM, Nico Weber wrote:
> On Tue, Feb 23, 2016 at 3:55 PM, David Blaikie wrote:
>
>>
>>
>> On Tue, Feb 23, 2016 at 12:46 PM, Nico Weber wrote:
>>
>>> On Tue, Feb 23, 2016 at 2:44 PM, David Blaikie via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>>>
xur updated this revision to Diff 48846.
xur marked an inline comment as done.
xur added a comment.
Here is the new patch that removes the auto detection of profile kind.
In this patch, I replace the CC1 option of -fprofile-instr-use=<> with
-fprofile-instrument={llvm-use|clang-use}. For the use
On Tue, Feb 23, 2016 at 3:55 PM, David Blaikie wrote:
>
>
> On Tue, Feb 23, 2016 at 12:46 PM, Nico Weber wrote:
>
>> On Tue, Feb 23, 2016 at 2:44 PM, David Blaikie via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>>
>>>
>>> On Tue, Feb 23, 2016 at 11:30 AM, Nico Weber via cfe-commits
On Tue, Feb 23, 2016 at 12:46 PM, Nico Weber wrote:
> On Tue, Feb 23, 2016 at 2:44 PM, David Blaikie via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>>
>>
>> On Tue, Feb 23, 2016 at 11:30 AM, Nico Weber via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: nico
>>> Date:
kromanova created this revision.
kromanova added a subscriber: cfe-commits.
kromanova set the repository for this revision to rL LLVM.
Here is the patch with the doxygen comments for the intrinsincs in the header
file popcntintrin.h.
The doxygen comments are automatically generated based on SCE i
On Tue, Feb 23, 2016 at 2:44 PM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Tue, Feb 23, 2016 at 11:30 AM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: nico
>> Date: Tue Feb 23 13:30:43 2016
>> New Revision: 261674
>>
>> URL: http:
Author: cbieneman
Date: Tue Feb 23 14:33:15 2016
New Revision: 261680
URL: http://llvm.org/viewvc/llvm-project?rev=261680&view=rev
Log:
[CMake] Add install-clang-format target by migrating to add_clang_tool
This change migrates clang-format to add_clang_tool which makes a
component-based install
Author: marshall
Date: Tue Feb 23 13:48:09 2016
New Revision: 261676
URL: http://llvm.org/viewvc/llvm-project?rev=261676&view=rev
Log:
More updates
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-project/libc
Author: marshall
Date: Tue Feb 23 13:48:44 2016
New Revision: 261677
URL: http://llvm.org/viewvc/llvm-project?rev=261677&view=rev
Log:
Fix a missing closing tag
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm
On Tue, Feb 23, 2016 at 11:30 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Tue Feb 23 13:30:43 2016
> New Revision: 261674
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261674&view=rev
> Log:
> Rename Action::begin() to Action::input_begin().
>
> Al
On Sat, Feb 20, 2016 at 6:53 AM, Nico Weber wrote:
> On Fri, Feb 19, 2016 at 10:32 PM, Nico Weber wrote:
>>
>> On Fri, Feb 19, 2016 at 10:02 PM, Nico Weber wrote:
>>>
>>> On Fri, Feb 19, 2016 at 8:01 PM, Richard Smith
>>> wrote:
On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber wrote:
Author: nico
Date: Tue Feb 23 13:30:43 2016
New Revision: 261674
URL: http://llvm.org/viewvc/llvm-project?rev=261674&view=rev
Log:
Rename Action::begin() to Action::input_begin().
Also introduce inputs() that reutnrs an llvm::iterator_range.
Iterating over A->inputs() is much less mysterious than
Done in r261673.
-- adrian
> On Feb 23, 2016, at 11:23 AM, Adrian Prantl via cfe-commits
> wrote:
>
> I will carefully revert the revert of this commit on top of the current
> trunk. Thanks for the notice.
>
> -- adrian
>
>> On Feb 23, 2016, at 11:15 AM, Hans Wennborg wrote:
>>
>> I'm sor
Author: adrian
Date: Tue Feb 23 13:30:08 2016
New Revision: 261673
URL: http://llvm.org/viewvc/llvm-project?rev=261673&view=rev
Log:
Reapply r261657.
Remove an unnecessary workaround introduced in r259975. (NFC)
Now that LLVM r259973 allows replacing a temporary type with another
temporary we can
I will carefully revert the revert of this commit on top of the current trunk.
Thanks for the notice.
-- adrian
> On Feb 23, 2016, at 11:15 AM, Hans Wennborg wrote:
>
> I'm sorry, but I had to revert this in order to revert r261634. r261657
>
> On Tue, Feb 23, 2016 at 9:13 AM, Adrian Prantl v
On Tue, Feb 23, 2016 at 11:15 AM, Hans Wennborg wrote:
> I'm sorry, but I had to revert this in order to revert r261634. r261657
Meant to say the revert is in r261670.
>
> On Tue, Feb 23, 2016 at 9:13 AM, Adrian Prantl via cfe-commits
> wrote:
>> Author: adrian
>> Date: Tue Feb 23 11:13:47 2016
On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote:
> This patch looks good to me. But I am not sure if Aaron has any comment.
>
> On Feb 22, 2016, at 6:19 PM, Duncan P. N. Exon Smith
> wrote:
>
>
> On 2016-Feb-22, at 17:24, Manman Ren wrote:
>
>
>
> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon
I'm sorry, but I had to revert this in order to revert r261634. r261657
On Tue, Feb 23, 2016 at 9:13 AM, Adrian Prantl via cfe-commits
wrote:
> Author: adrian
> Date: Tue Feb 23 11:13:47 2016
> New Revision: 261657
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261657&view=rev
> Log:
> Remove a
Author: hans
Date: Tue Feb 23 13:10:16 2016
New Revision: 261670
URL: http://llvm.org/viewvc/llvm-project?rev=261670&view=rev
Log:
Revert r261634 "Supporting all entities declared in lexical scope in LLVM debug
info." and r261657
r261634 and r261633 seems to have caused PR26715. r261657 depends
sfantao updated this revision to Diff 48839.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D17019
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.h
test/OpenMP/teams_codegen.cpp
Index: test/OpenMP/teams_codegen.cpp
On Tue, Feb 23, 2016 at 2:03 PM, Hans Wennborg wrote:
> Hi Aaron,
>
> I'll let it sit in the tree for a bit, and will then merge it later today.
Sounds great, thank you!
~Aaron
>
> Many thanks,
> Hans
>
> On Tue, Feb 23, 2016 at 11:01 AM, Aaron Ballman
> wrote:
>> Hans, this should be safe to
Thanks Adrian!
On Tue, Feb 23, 2016 at 9:19 AM Adrian Prantl wrote:
> --> r261657.
>
> Author: adrian
> Date: Tue Feb 23 17:13:47 2016 +
>
> Remove an unnecessary workaround introduced in r259975. (NFC)
>
> Now that LLVM r259973 allows replacing a temporary type with another
>
Hi Aaron,
I'll let it sit in the tree for a bit, and will then merge it later today.
Many thanks,
Hans
On Tue, Feb 23, 2016 at 11:01 AM, Aaron Ballman wrote:
> Hans, this should be safe to merge into 3.8 (as Richard had mentioned
> in the review thread). Can you do the merge magic on my behalf?
Hans, this should be safe to merge into 3.8 (as Richard had mentioned
in the review thread). Can you do the merge magic on my behalf?
Thanks!
~Aaron
On Tue, Feb 23, 2016 at 1:55 PM, Aaron Ballman via cfe-commits
wrote:
> Author: aaronballman
> Date: Tue Feb 23 12:55:15 2016
> New Revision: 2616
sfantao updated this revision to Diff 48835.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D17369
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_exit_data_codegen.cpp
Index: test/OpenMP/target_exit_data_co
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! I've commit in r261669.
http://reviews.llvm.org/D17507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Tue Feb 23 12:55:15 2016
New Revision: 261669
URL: http://llvm.org/viewvc/llvm-project?rev=261669&view=rev
Log:
Amends r252104 to evaluate the controlling expression in an unevaluated
context. This eliminates false-positive diagnostics about null pointer
dereferences (
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM for trunk and 3.8.
http://reviews.llvm.org/D17507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
This patch looks good to me. But I am not sure if Aaron has any comment.
> On Feb 22, 2016, at 6:19 PM, Duncan P. N. Exon Smith
> wrote:
>
>>
>> On 2016-Feb-22, at 17:24, Manman Ren wrote:
>>
>>
>>
>>> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon Smith
>>> wrote:
>>>
>>> This patch add
sfantao updated this revision to Diff 48834.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D17368
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_enter_data_codegen.cpp
Index: test/OpenMP/target_enter_data_
Anastasia added inline comments.
Comment at: test/SemaOpenCL/invalid-block.cl:17
@@ +16,3 @@
+void f2(BlkInt *BlockPtr) {
+ BlkInt B = ^int(int I) {return 1;};
+ BlkInt *P = &B; // expected-error {{invalid argument type 'BlkInt' (aka 'int
(^)(int)') to unary expression}}
--
sfantao updated this revision to Diff 48831.
sfantao updated the summary for this revision.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D17367
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_data_codegen.c
Anastasia added inline comments.
Comment at: test/SemaOpenCL/storageclass-cl20.cl:19
@@ -15,1 +18,2 @@
+ extern int G6; // expected-error{{program scope variable must reside in
global or constant address space}}
}
Khronos bug: https://cvs.khronos.org/bugzilla/s
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeType().getCanonicalType();
+
+// Given that an
Author: marshall
Date: Tue Feb 23 12:09:38 2016
New Revision: 261661
URL: http://llvm.org/viewvc/llvm-project?rev=261661&view=rev
Log:
These new tests fail on the green-dragon bots, which use an old Apple compiler.
Since they're scheduled to be updated soon, we'll just comment out this test for
th
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: caomhin, fraggamuffin, cfe-commits.
In some cases it can be proved statically that multidimensional array section
refer to contiguous storage and can therefor
yaxunl added inline comments.
Comment at: test/SemaOpenCL/storageclass-cl20.cl:11
@@ -10,3 +10,3 @@
static global int S2 = 5;
- static private int S3 = 5;// expected-error{{program scope variable must
reside in global or constant address space}}
+ static private int S3 = 5;
Anastasia removed a reviewer: pekka.jaaskelainen.
Anastasia added a subscriber: pekka.jaaskelainen.
Anastasia updated this revision to Diff 48826.
Anastasia added a comment.
I am adding a small clean up here for duplicate code!
@Sam, could you please re-check again. Thanks!
http://reviews.llvm.
mlemay-intel added a comment.
Thank you for your feedback!
Comment at: lib/CodeGen/TargetInfo.cpp:1569
@@ +1568,3 @@
+CGF.getTarget().getTargetOpts().Features;
+ if (std::find(TargetFeatures.begin(), TargetFeatures.end(),
+"+separate-stack-seg") != TargetFea
--> r261657.
Author: adrian
Date: Tue Feb 23 17:13:47 2016 +
Remove an unnecessary workaround introduced in r259975. (NFC)
Now that LLVM r259973 allows replacing a temporary type with another
temporary we can rely on the original implementation.
It is possible for
Author: adrian
Date: Tue Feb 23 11:13:47 2016
New Revision: 261657
URL: http://llvm.org/viewvc/llvm-project?rev=261657&view=rev
Log:
Remove an unnecessary workaround introduced in r259975. (NFC)
Now that LLVM r259973 allows replacing a temporary type with another
temporary we can rely on the orig
On Tue, Feb 23, 2016 at 5:51 PM, David Blaikie wrote:
>
>
> On Tue, Feb 23, 2016 at 2:29 AM, Alexander Kornienko via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: alexfh
>> Date: Tue Feb 23 04:29:04 2016
>> New Revision: 261626
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=
Author: marshall
Date: Tue Feb 23 11:07:15 2016
New Revision: 261655
URL: http://llvm.org/viewvc/llvm-project?rev=261655&view=rev
Log:
More updates
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-project/libc
Looks like r261551's fault. Reverted in r261654.
On Mon, Feb 22, 2016 at 11:12 PM, Bruno Cardoso Lopes
wrote:
> Reverted r261552 & r261556 in r261613. Waiting for next win bot
> results to see if it's necessary to revert r261551 as well.
>
> On Mon, Feb 22, 2016 at 7:16 PM, Bruno Cardoso Lopes
>
Author: bruno
Date: Tue Feb 23 11:06:50 2016
New Revision: 261654
URL: http://llvm.org/viewvc/llvm-project?rev=261654&view=rev
Log:
Revert "[VFS] Add support for handling path traversals"
This reverts commit r261551 due to failing tests in windows bots:
http://lab.llvm.org:8011/builders/clang-x6
Author: marshall
Date: Tue Feb 23 11:01:52 2016
New Revision: 261653
URL: http://llvm.org/viewvc/llvm-project?rev=261653&view=rev
Log:
Add tests for LWG#2560. No code changes, just tests
Modified:
libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp
Modi
Anastasia added a comment.
In http://reviews.llvm.org/D16876#359786, @pekka.jaaskelainen wrote:
> In http://reviews.llvm.org/D16876#359781, @Anastasia wrote:
>
> > @Pekka, do you have any more comments?
>
>
> Nope. Looking forward to finally implementing proper pipe support to pocl.
>
> With the
pekka.jaaskelainen accepted this revision.
pekka.jaaskelainen added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D16876#359781, @Anastasia wrote:
> @Pekka, do you have any more comments?
Nope. Looking forward to finally implementing proper pipe support
On Tue, Feb 23, 2016 at 2:29 AM, Alexander Kornienko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: alexfh
> Date: Tue Feb 23 04:29:04 2016
> New Revision: 261626
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261626&view=rev
> Log:
> Fix a -Wunused-variable diagnostic.
>
> Modif
Anastasia accepted this revision.
Comment at: test/SemaOpenCL/sampler_t.cl:13
@@ -12,2 +12,3 @@
foo(5); // expected-error {{sampler_t variable required - got 'int'}}
+ sampler_t sa[] = {argsmp,const_smp}; // expected-error {{array of
'sampler_t' type is invalid in OpenCL}}
}
Anastasia added a comment.
Could you please address number 1 from my previous comment?
Otherwise, I think we should try to proceed quickly here, it will be too hard
to merge back in after long delay and also it would be nice to have as many
corrections as possible ASAP.
Could we move Richard t
Anastasia added a comment.
I agree there seems to be nothing specifically on this topic in OpenCL spec.
However, I wouldn't modify Clang and rely on its default behavior:
1. In C99 gives a warning
2. For some targets set up in a special way (i.e. SPIR) gives an error
Comment a
Author: marshall
Date: Tue Feb 23 10:25:20 2016
New Revision: 261648
URL: http://llvm.org/viewvc/llvm-project?rev=261648&view=rev
Log:
Add additional tests to ensure that we DTRT with short lists. This is LWG#2590,
but there are no code changes, just additional tests
Modified:
libcxx/trunk/
On Tue, Feb 23, 2016 at 8:15 AM, Michael Matz wrote:
> Hi,
>
> On Tue, 23 Feb 2016, H.J. Lu wrote:
>
>> I thought
>>
>> ---
>> An empty type is a type where it and all of its subobjects (recursively)
>> are of class, structure, union, or array type.
>> ---
>>
>> excluded
>>
>> struct empty
>> {
>>
Author: marshall
Date: Tue Feb 23 10:20:24 2016
New Revision: 261647
URL: http://llvm.org/viewvc/llvm-project?rev=261647&view=rev
Log:
More updates; patch for 2583 ready
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/vi
Author: alexfh
Date: Tue Feb 23 10:12:08 2016
New Revision: 261646
URL: http://llvm.org/viewvc/llvm-project?rev=261646&view=rev
Log:
Fix a typo. NFC
Modified:
cfe/trunk/docs/ClangFormatStyleOptions.rst
cfe/trunk/include/clang/Format/Format.h
Modified: cfe/trunk/docs/ClangFormatStyleOptio
Author: alexfh
Date: Tue Feb 23 10:12:00 2016
New Revision: 261645
URL: http://llvm.org/viewvc/llvm-project?rev=261645&view=rev
Log:
Clean up clang-format options documentation. NFC
Use uniform style for inline code blocks, specify language for YAML code blocks,
various formatting fixes etc.
Mod
Author: alexfh
Date: Tue Feb 23 10:11:55 2016
New Revision: 261644
URL: http://llvm.org/viewvc/llvm-project?rev=261644&view=rev
Log:
Support language selection for \code blocks.
Modified:
cfe/trunk/docs/tools/dump_format_style.py
Modified: cfe/trunk/docs/tools/dump_format_style.py
URL:
http
Author: alexfh
Date: Tue Feb 23 10:11:51 2016
New Revision: 261643
URL: http://llvm.org/viewvc/llvm-project?rev=261643&view=rev
Log:
Update clang-format options docs.
Modified:
cfe/trunk/docs/ClangFormatStyleOptions.rst
Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst
URL:
http://llvm.o
Author: alexfh
Date: Tue Feb 23 10:11:43 2016
New Revision: 261642
URL: http://llvm.org/viewvc/llvm-project?rev=261642&view=rev
Log:
Allow running dump_format_style.py from any directory.
Modified:
cfe/trunk/docs/tools/dump_format_style.py
Modified: cfe/trunk/docs/tools/dump_format_style.py
Hi,
On Tue, 23 Feb 2016, H.J. Lu wrote:
> I thought
>
> ---
> An empty type is a type where it and all of its subobjects (recursively)
> are of class, structure, union, or array type.
> ---
>
> excluded
>
> struct empty
> {
> empty () = default;
> };
Why would that be excluded? There are no
Author: mzuckerm
Date: Tue Feb 23 09:59:47 2016
New Revision: 261641
URL: http://llvm.org/viewvc/llvm-project?rev=261641&view=rev
Log:
[CLANG] [AVX512] [BUILTIN] Adding prorv{d|q}{128|256|512} builtin to clang
Differential Revision: http://reviews.llvm.org/D17512
Modified:
cfe/trunk/includ
On Tue, Feb 23, 2016 at 7:30 AM, Michael Matz wrote:
> Hi,
>
> On Tue, 23 Feb 2016, H.J. Lu wrote:
>
>> > ---
>> > An empty type is a type where it and all of its subobjects (recursively)
>> > are of class, structure, union, or array type. No memory slot nor
>> > register should be used to pass o
Hi,
On Tue, 23 Feb 2016, H.J. Lu wrote:
> > ---
> > An empty type is a type where it and all of its subobjects (recursively)
> > are of class, structure, union, or array type. No memory slot nor
> > register should be used to pass or return an object of empty type that's
> > trivially copyable.
aaron.ballman added a comment.
Mostly minor comments, but I like this approach!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7713
@@ +7712,3 @@
+def err_opencl_invalid_read_write : Error<
+ "access qualifier read_write can not be used for %0 %select{|earlier than
Ope
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Comment at: lib/Sema/SemaType.cpp:2180
@@ -2179,1 +2179,3 @@
+ // OpenCL v2.0 s6.16.13.1 - Arrays of pipe type are not supported.
+ // OpenCL v2.0 s6.9.b - Ar
1 - 100 of 123 matches
Mail list logo
