Author: rtrieu
Date: Fri Mar 4 22:04:57 2016
New Revision: 262765
URL: http://llvm.org/viewvc/llvm-project?rev=262765&view=rev
Log:
Add null check to diagnostic path for lambda captures.
Previously, the failed capture of a variable in nested lambdas may crash when
the lambda pointer is null. On
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticParseKinds.td:772
@@ +771,3 @@
+def warn_cxx14_compat_constexpr_on_lambda : Warning<
+ "constexpr on lambda expressions are incompatible with C++14">,
+ InGroup, DefaultIgnore;
are -> is
==
faisalv added a comment.
*ping*
http://reviews.llvm.org/D14905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mps
Date: Fri Mar 4 19:56:07 2016
New Revision: 262764
URL: http://llvm.org/viewvc/llvm-project?rev=262764&view=rev
Log:
Test commit: Fix run-on sentence in comment
Modified:
cfe/trunk/lib/Parse/ParseDecl.cpp
Modified: cfe/trunk/lib/Parse/ParseDecl.cpp
URL:
http://llvm.org/viewvc/
ryee88 added a subscriber: dblaikie.
ryee88 added a comment.
Anyone care to take a look?
http://reviews.llvm.org/D16965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ryee88 updated this revision to Diff 49866.
http://reviews.llvm.org/D16965
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/Parser/cxx-class.cpp
Index: test/Parser/cxx-class.cpp
===
--- test/Parser/
Author: dcoughlin
Date: Fri Mar 4 19:32:43 2016
New Revision: 262763
URL: http://llvm.org/viewvc/llvm-project?rev=262763&view=rev
Log:
[analyzer] Nullability: add option to not report on calls to system headers.
Add an -analyzer-config 'nullability:NoDiagnoseCallsToSystemHeaders' option to
the n
ariccio added a comment.
In http://reviews.llvm.org/D17688#368330, @zaks.anna wrote:
>
?
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks - already reverted and I found the problem. Will push a new version
soon.
-- Carlo
From: Nico Weber
To: Carlo Bertolli/Watson/IBM@IBMUS
Cc: cfe-commits
Date: 03/04/2016 06:09 PM
Subject:Re: r262741 - [OPENMP] Codegen for distribute directive
Looks like the new t
zaks.anna added a comment.
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Fri Mar 4 16:32:06 2016
New Revision: 262753
URL: http://llvm.org/viewvc/llvm-project?rev=262753&view=rev
Log:
Update diagnostics now that hexadecimal literals look likely to be part of
C++17.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
cfe/trunk/i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262752: PR5941 - improve diagnostic for * vs & confusion
when choosing overload… (authored by dblaikie).
Changed prior to commit:
http://reviews.llvm.org/D16949?vs=49577&id=49856#toc
Repository:
rL L
Author: dblaikie
Date: Fri Mar 4 16:29:11 2016
New Revision: 262752
URL: http://llvm.org/viewvc/llvm-project?rev=262752&view=rev
Log:
PR5941 - improve diagnostic for * vs & confusion when choosing overload
candidate with a parameter of incomplete (ref or pointer) type
Reviewers: dblaikie
Diffe
> Ah, great! I always love it when people document their ABIs.
>
> Is your ABI document public? If so, could you add it to
> docs/CompilerWriterInfo.rst?
I don't think I was aware of that page... AFAIK ours is not available
on-line, but I can raise the question internally.
--paulr
>
> On Fri,
Looks like the new tests don't pass on Windows:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10365
On Mar 4, 2016 12:29 PM, "Carlo Bertolli via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: cbertol
> Date: Fri Mar 4 14:24:58 2016
> New Revision: 262741
>
> URL: http
Author: nico
Date: Fri Mar 4 15:59:42 2016
New Revision: 262749
URL: http://llvm.org/viewvc/llvm-project?rev=262749&view=rev
Log:
clang-cl: Enable PCH flags by default.
Now that pragma comment and pragma detect_mismatch are implemented, this might
just work.
Some pragmas aren't serialized yet (
arpith-jacob marked 15 inline comments as done.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:348
@@ +347,2 @@
+ initializeEnvironment();
+}
This function will also handle global variables from the 'declare target'
construct in the future.
void CGOpenMPRunti
arpith-jacob updated this revision to Diff 49851.
arpith-jacob added a comment.
Addressed feedback; see inline comments for details.
http://reviews.llvm.org/D17877
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGOpe
djasper added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:228
@@ -226,3 +227,3 @@
/// \pre Replacements must be for the same file.
-std::vector
-calculateChangedRangesInFile(const tooling::Replacements &Replaces);
+std::vector calculateChangedRangesInFil
Author: rsmith
Date: Fri Mar 4 15:27:21 2016
New Revision: 262747
URL: http://llvm.org/viewvc/llvm-project?rev=262747&view=rev
Log:
Implement P0036R0: remove support for empty unary folds of +, *, |, &.
Modified:
cfe/trunk/lib/Sema/SemaTemplateVariadic.cpp
cfe/trunk/test/SemaTemplate/cxx
I've followed up to the original thread, but I'm fairly certain this isn't
the right patch here.
-eric
On Fri, Mar 4, 2016 at 10:28 AM Eric Christopher wrote:
> Test case?
>
> On Fri, Mar 4, 2016, 4:02 AM Bhushan D. Attarde via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: bhu
echristo added a subscriber: echristo.
echristo added a comment.
This seems wrong. You should fix setCPU instead or set a default CPU.
Repository:
rL LLVM
http://reviews.llvm.org/D16139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
ariccio updated this revision to Diff 49845.
ariccio added a comment.
Alrighty. This final version of the patch causes no test failures (vs the
unmodified build*).
*An unrelated test normally fails on my machine.
http://reviews.llvm.org/D17688
Files:
llvm/tools/clang/lib/StaticAnalyzer/Chec
Author: sfantao
Date: Fri Mar 4 15:02:14 2016
New Revision: 262744
URL: http://llvm.org/viewvc/llvm-project?rev=262744&view=rev
Log:
Revert r262741 - [OPENMP] Codegen for distribute directive
Was causing a failure in one of the buildbot slaves.
Removed:
cfe/trunk/test/OpenMP/distribute_code
Author: rsmith
Date: Fri Mar 4 15:01:14 2016
New Revision: 262743
URL: http://llvm.org/viewvc/llvm-project?rev=262743&view=rev
Log:
Update cxx_status with likely new features from Jacksonville WG21 meeting.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262742: Switch krait to use -mcpu=cortex-a15 for assembler
tool invocations. (authored by srhines).
Changed prior to commit:
http://reviews.llvm.org/D17874?vs=49791&id=49844#toc
Repository:
rL LLVM
Author: srhines
Date: Fri Mar 4 14:57:22 2016
New Revision: 262742
URL: http://llvm.org/viewvc/llvm-project?rev=262742&view=rev
Log:
Switch krait to use -mcpu=cortex-a15 for assembler tool invocations.
Summary:
Using -no-integrated-as causes -mcpu=krait to be transformed into
-march=armv7-a toda
Author: cbertol
Date: Fri Mar 4 14:24:58 2016
New Revision: 262741
URL: http://llvm.org/viewvc/llvm-project?rev=262741&view=rev
Log:
[OPENMP] Codegen for distribute directive
This patch provide basic implementation of codegen for teams directive,
excluding all clauses except dist_schedule. It a
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 262741.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
weimingz accepted this revision.
weimingz added a comment.
This revision is now accepted and ready to land.
Ana is OK with it.
http://reviews.llvm.org/D17874
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
pcc added inline comments.
Comment at: include/clang/Basic/Attr.td:1543
@@ +1542,3 @@
+ let Subjects = SubjectList<[Record]>;
+ let Documentation = [Undocumented];
+}
aaron.ballman wrote:
> No new undocumented attributes, please. Same below.
Yes, sorry, forgot t
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
I may have more comments when I catch up on email next week. Just a drive-by as
I added myself as reviewer.
Comment at: include/clang/Basic/Attr.td:154
Ah, great! I always love it when people document their ABIs.
Is your ABI document public? If so, could you add it to
docs/CompilerWriterInfo.rst?
On Fri, Mar 4, 2016 at 11:54 AM, Robinson, Paul
wrote:
>> It'd be nice to have a comment here that mentions that the clang
>> behavior which is being
jbcoe added a comment.
I think there are some minor issues with the tests, easily fixed. I wonder if
the matchers can catch things inside implementation-defined inline namespaces
like `std::_v1_::experimental::library_fundamentals_v1::string_view`.
Comment at: clang-tidy/misc/
Author: jyknight
Date: Fri Mar 4 13:00:41 2016
New Revision: 262737
URL: http://llvm.org/viewvc/llvm-project?rev=262737&view=rev
Log:
Make TargetInfo store an actual DataLayout instead of a string.
Use it to calculate UserLabelPrefix, instead of specifying it (often
incorrectly).
Note that the
This revision was automatically updated to reflect the committed changes.
jyknight marked an inline comment as done.
Closed by commit rL262737: Make TargetInfo store an actual DataLayout instead
of a string. (authored by jyknight).
Changed prior to commit:
http://reviews.llvm.org/D17183?vs=4776
arpith-jacob added a comment.
Thanks for the quick review! The test cases are the same as the CUDA version
so it should be fine.
http://reviews.llvm.org/D17890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Test case?
On Fri, Mar 4, 2016, 4:02 AM Bhushan D. Attarde via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bhushan.attarde
> Date: Fri Mar 4 00:56:29 2016
> New Revision: 262691
>
> URL: http://llvm.org/viewvc/llvm-project?rev=262691&view=rev
> Log:
> [MIPS] initFeatureMap() to ha
Author: dcoughlin
Date: Fri Mar 4 12:09:58 2016
New Revision: 262729
URL: http://llvm.org/viewvc/llvm-project?rev=262729&view=rev
Log:
[analyzer] Add diagnostic in ObjCDeallocChecker for use of -dealloc instead of
-release.
In dealloc methods, the analyzer now warns when -dealloc is called dire
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
Didn't look carefully at the test (let me know if you'd like me to). The rest
looks good to me.
http://reviews.llvm.org/D17890
___
cfe-commits
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D17682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
> It'd be nice to have a comment here that mentions that the clang
> behavior which is being preserved for Darwin, FreeBSD, and PS4 is a
> *bug* which is being intentionally left unfixed. The previous clang
> behavior directly contradicts the x86_64 ABI document, which I believe
> all of these plat
arpith-jacob created this revision.
arpith-jacob added a reviewer: jlebar.
arpith-jacob added subscribers: carlo.bertolli, sfantao, caomhin, cfe-commits.
Support for CUDA printf is exploited to support printf for an NVPTX OpenMP
device.
To reflect the support of both programming models, the file
It'd be nice to have a comment here that mentions that the clang
behavior which is being preserved for Darwin, FreeBSD, and PS4 is a
*bug* which is being intentionally left unfixed. The previous clang
behavior directly contradicts the x86_64 ABI document, which I believe
all of these platforms clai
sfantao marked an inline comment as done.
Comment at: lib/Sema/SemaOpenMP.cpp:9127
@@ +9126,3 @@
+// whose base type is \a BaseQTy.
+static bool CheckArrayExpressionDoesNotReferToUnitySize(Sema &SemaRef,
+ const Expr *E,
--
sfantao updated this revision to Diff 49827.
sfantao added a comment.
- Change return value from int to bool.
http://reviews.llvm.org/D17547
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOpenMP.cpp
test/OpenMP/target_map_messages.cpp
Index: test/OpenMP/target_map_message
amehsan updated this revision to Diff 49822.
amehsan added a comment.
added -ferror-limit 0 to the command line for no-altivec test.
fixed indentation of RUN commands
confirmed that all tests pass in a release and minrelsize build types
changed {{[0-9]*}} to {{.*}} (it was fine but no need to put
amehsan marked 4 inline comments as done.
amehsan added a comment.
http://reviews.llvm.org/D17816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 3/4/2016 6:23 AM, Joerg Sonnenberger via cfe-commits wrote:
On Thu, Mar 03, 2016 at 04:50:11PM -0800, Nico Weber via cfe-commits wrote:
On Thu, Mar 3, 2016 at 4:28 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
On Thu, Mar 03, 2016 at 02:09:17PM -0800, Nico Webe
Author: bcraig
Date: Fri Mar 4 08:25:13 2016
New Revision: 262717
URL: http://llvm.org/viewvc/llvm-project?rev=262717&view=rev
Log:
Reducing stack usage of test
This test has a lot of classes with large amounts of manually inserted padding
in them, presumably to prevent various optimizations. T
Author: d0k
Date: Fri Mar 4 08:18:52 2016
New Revision: 262716
URL: http://llvm.org/viewvc/llvm-project?rev=262716&view=rev
Log:
Move class into anonymous namespace. NFC.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Check
On Thu, Mar 03, 2016 at 04:50:11PM -0800, Nico Weber via cfe-commits wrote:
> On Thu, Mar 3, 2016 at 4:28 PM, Joerg Sonnenberger via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> > On Thu, Mar 03, 2016 at 02:09:17PM -0800, Nico Weber via cfe-commits wrote:
> > > On Thu, Mar 3, 2016 at 1:5
Author: bhushan.attarde
Date: Fri Mar 4 00:56:29 2016
New Revision: 262691
URL: http://llvm.org/viewvc/llvm-project?rev=262691&view=rev
Log:
[MIPS] initFeatureMap() to handle empty string argument
SUMMARY:
This patch sets CPU string to its default value when it is not supplied by
ca
ioeric updated this revision to Diff 49807.
ioeric added a comment.
- removed unused forward declarations.
http://reviews.llvm.org/D17852
Files:
include/clang/Basic/SourceManager.h
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
ioeric added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:237
@@ +236,3 @@
+/// related to the same file entry are put into the same vector.
+FileToReplacementsMap groupReplacementsByFile(const Replacements &Replaces,
+
ioeric updated this revision to Diff 49806.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Moved formatAndApplyAllReplacements to Tooling/Refactoing; added an
overloaded version of formatAndApplyAllReplacements that takes no Style;
groupReplacementsByFile groups Replacements
Author: labath
Date: Fri Mar 4 04:00:08 2016
New Revision: 262700
URL: http://llvm.org/viewvc/llvm-project?rev=262700&view=rev
Log:
[SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations
Summary:
While diagnosing a CXXNewExpr warning, we were calling isInSystemHeader(),
which
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262700: [SemaExprCXX] Avoid calling isInSystemHeader for
invalid source locations (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D17847?vs=49725&id=49805#toc
Repository:
rL LL
Author: abataev
Date: Fri Mar 4 03:22:22 2016
New Revision: 262699
URL: http://llvm.org/viewvc/llvm-project?rev=262699&view=rev
Log:
[OPENMP 4.0] Codegen for 'declare reduction' construct.
Emit function for 'combiner' part of 'declare reduction' construct and
'initialilzer' part, if any.
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262698: [clang-tidy] Make 'modernize-use-nullptr' check work
on multiple nested… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17849?vs=49736&id=49802#toc
Repository:
rL LLV
Author: hokein
Date: Fri Mar 4 02:55:54 2016
New Revision: 262698
URL: http://llvm.org/viewvc/llvm-project?rev=262698&view=rev
Log:
[clang-tidy] Make 'modernize-use-nullptr' check work on multiple nested
implicit cast expressions.
Summary:
For some test cases like:
```
int func(int, void*, vo
Author: vedantk
Date: Fri Mar 4 02:07:15 2016
New Revision: 262697
URL: http://llvm.org/viewvc/llvm-project?rev=262697&view=rev
Log:
[Coverage] Fix the start/end locations of switch statements
While pushing switch statements onto the region stack we neglected to
specify their start/end locations
62 matches
Mail list logo