Author: dpolukhin
Date: Fri Mar 11 01:58:34 2016
New Revision: 263202
URL: http://llvm.org/viewvc/llvm-project?rev=263202&view=rev
Log:
[OpenMP] NFC fix compilation warning about unused variable
lib/Sema/SemaOpenMP.cpp:9243:13: warning: variable ‘IsRightMostExpression’ set
but not used
Modified
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D18024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: chandlerc
Date: Fri Mar 11 03:02:43 2016
New Revision: 263210
URL: http://llvm.org/viewvc/llvm-project?rev=263210&view=rev
Log:
Update to include the new header file providing createGVNPass.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk/lib/CodeGen/BackendUtil.c
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Patch looks good, only one cosmetic comment.
Comment at: clang-tidy/modernize/UseNullptrCheck.cpp:232
@@ +231,3 @@
+ if (!getMacroAndArgLocations(StartLoc, ImmediateMar
hokein updated this revision to Diff 50409.
hokein added a comment.
Format code.
http://reviews.llvm.org/D17958
Files:
clang-tidy/modernize/UseNullptrCheck.cpp
test/clang-tidy/modernize-use-nullptr.cpp
Index: test/clang-tidy/modernize-use-nullptr.cpp
===
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D17958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Fri Mar 11 05:40:08 2016
New Revision: 263221
URL: http://llvm.org/viewvc/llvm-project?rev=263221&view=rev
Log:
[clang-tidy] Make 'modernize-use-nullptr' check ignores NULL marcos used in
other macros.
Reviewers: bkramer, alexfh
Subscribers: cfe-commits
Differential Revisi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263221: [clang-tidy] Make 'modernize-use-nullptr' check
ignores NULL marcos used in… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17958?vs=50409&id=50414#toc
Repository:
rL
DmitryPolukhin updated this revision to Diff 50416.
DmitryPolukhin added a comment.
Re-base to resolve merge conflicts with r263109.
http://reviews.llvm.org/D18035
Files:
lib/AST/ItaniumMangle.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCXX/mangle-abi-tag.cpp
test/SemaCXX/attr-abi-tag-syn
aaron.ballman added a comment.
I think this change is good, but it likely needs to be replicated to
PointerUnion3 and PointerUnion4, doesn't it?
http://reviews.llvm.org/D18076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
dsanders added subscribers: eugenis, ygorshenin.
dsanders added a comment.
I think it refers to MCTargetOptions::SanitizeAddress but I don't know where
we'd get that information from. Unfortunately, it seems that the original
author (@ygorshenin) might not be on the list anymore (phabricator sho
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263245: Add tests for ARM Cortex-R8 (authored by alelab01).
Changed prior to commit:
http://reviews.llvm.org/D18052?vs=50303&id=50429#toc
Repository:
rL LLVM
http://reviews.llvm.org/D18052
Files:
Author: alelab01
Date: Fri Mar 11 09:03:40 2016
New Revision: 263245
URL: http://llvm.org/viewvc/llvm-project?rev=263245&view=rev
Log:
Add tests for ARM Cortex-R8
Add command-line tests for ARM Cortex-R8 checking that the driver calls
clang -cc1 with the correct little-endian/big-endian, and ARM/
Author: nico
Date: Fri Mar 11 09:26:06 2016
New Revision: 263246
URL: http://llvm.org/viewvc/llvm-project?rev=263246&view=rev
Log:
Revert r263036, it's ABI-breaking.
Modified:
libcxx/trunk/include/string
libcxx/trunk/test/std/strings/basic.string/string.cons/substr.pass.cpp
libcxx/tru
I reverted this in 263246 for now. I think the right fix is just to
add _LIBCPP_INLINE_VISIBILITY to the new constructor, but I'm not 100% sure.
On Thu, Mar 10, 2016 at 10:21 AM, Nico Weber wrote:
> I think this is ABI-breaking. On OS X, new libc++ headers must work with
> old system libc++.dyli
mspertus added a comment.
Good catch. Give me two minutes
http://reviews.llvm.org/D18076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I agree with Nico. Adding _LIBCPP_INLINE_VISIBILITY should fix the problem,
but it's a bit of a hack. Also we should only *add* additional signatures
if possible since existing signatures already exist in the dylib so we
can't modify them.
On Fri, Mar 11, 2016 at 8:32 AM, Nico Weber via cfe-commit
mspertus updated this revision to Diff 50432.
mspertus added a comment.
Applying same logic to PointerUnion3 and PointerUnion4 as suggested by Aaron
http://reviews.llvm.org/D18076
Files:
llvm.natvis
Index: llvm.natvis
===
--- ll
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D18076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
There's a longer term fix involving availability attributes. My patch to the
test system for deployment targets is holding up a series of patches that tell
the compiler when API was introduced (with a 'strict' flag). This moves link
time errors (and load time errors when back deploying) to co
sbenza added a comment.
The reason we haven't fixed hasAnyArgument is that it can potentially break its
users.
I'd prefer if you separated the fix from the addition.
That way we can revert the fix if needed.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4796
@@ +4795,3 @@
baloghadamsoftware added a comment.
In http://reviews.llvm.org/D17986#373134, @sbenza wrote:
> The reason we haven't fixed hasAnyArgument is that it can potentially break
> its users.
> I'd prefer if you separated the fix from the addition.
> That way we can revert the fix if needed.
I will
On Fri, Mar 11, 2016 at 8:52 AM, Duncan Exon Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> There's a longer term fix involving availability attributes. My patch to
> the test system for deployment targets is holding up a series of patches
> that tell the compiler when API was intr
rnk added a comment.
In http://reviews.llvm.org/D17981#372823, @alexfh wrote:
> If this issue is specific to MS inline asm, then the additional dependencies
> should only be added, when we care about MS inline asm (windows builds only?).
Clang is always a cross compiler, we never know what we
beanz created this revision.
beanz added a reviewer: bob.wilson.
beanz added a subscriber: cfe-commits.
This patch adds a new driver warning -Wincompatible-sdk which notifies the user
when they are mismatching the version min options and the sysroot.
The patch works by checking the sysroot (if p
Anastasia added inline comments.
Comment at: include/clang/AST/OpenCLImageTypes.def:39
@@ +38,3 @@
+
+IMAGE_READ_TYPE(image1d, OCLImage1d)
+IMAGE_READ_TYPE(image1d_array, OCLImage1dArray)
bader wrote:
> Minor comment: any image access qualifier can be applied to a
EricWF added a subscriber: EricWF.
EricWF added a comment.
I tried to do this over the summer. The author of the annotations insisted that
it would be a bad idea to apply them to libc++ since it would break existing
code. Should these be off by default?
Also at the time the annotations were uns
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Driver/Tools.cpp:8948
@@ -8947,5 +8947,3 @@
break;
- case ToolChain::RLT_Libgcc:
-AddLibgcc(TC.getTriple(), D, CmdArgs, Args);
-break;
- }
+c
omtcyf0 added a comment.
@alexfh, why? I've deleted these headers both from sources and from testset,
didn't I?
http://reviews.llvm.org/D17990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: mehdi_amini
Date: Fri Mar 11 11:15:44 2016
New Revision: 263257
URL: http://llvm.org/viewvc/llvm-project?rev=263257&view=rev
Log:
Remove compile time PreserveName switch based on NDEBUG
Summary:
Following r263086, we are now relying on a flag on the Context to
discard Value names in relea
EricWF added a comment.
I generated an updated patch with a sample test case (and the LIT changes
needed to run it).
https://gist.github.com/EricWF/12f77078e4efc6610572
http://reviews.llvm.org/D14731
___
cfe-commits mailing list
cfe-commits@lists.l
Author: mehdi_amini
Date: Fri Mar 11 11:32:58 2016
New Revision: 263267
URL: http://llvm.org/viewvc/llvm-project?rev=263267&view=rev
Log:
Fix build: use -> with pointers and not .
Silly typo.
From: Mehdi Amini
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeG
Author: rnk
Date: Fri Mar 11 11:36:16 2016
New Revision: 263269
URL: http://llvm.org/viewvc/llvm-project?rev=263269&view=rev
Log:
[SEH] Remove nounwind/noinline from outlined finally funclets
With the new EH representation this is no longer necessary.
Modified:
cfe/trunk/lib/CodeGen/CGExcept
alexfh added a comment.
In http://reviews.llvm.org/D17990#373177, @omtcyf0 wrote:
> @alexfh, why? I've deleted these headers both from sources and from testset,
> didn't I?
I think, you misunderstood Richard's comment. The check should remove includes
of these three headers from the code, sin
alexfh added a comment.
In http://reviews.llvm.org/D17981#373153, @rnk wrote:
> In http://reviews.llvm.org/D17981#372823, @alexfh wrote:
>
> > If this issue is specific to MS inline asm, then the additional
> > dependencies should only be added, when we care about MS inline asm
> > (windows bui
Chad and I talked about this off-list (my fault!) a couple of weeks
ago; finally moving this to an actual review thread.
> On 2016-Jan-06, at 06:35, Chad Rosier via cfe-commits
> wrote:
>
> Author: mcrosier
> Date: Wed Jan 6 08:35:46 2016
> New Revision: 256937
>
> URL: http://llvm.org/viewvc
mspertus closed this revision.
mspertus added a comment.
Committed as svn revision 263270
http://reviews.llvm.org/D18076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jamesr added a comment.
Thank you for posting the LIT changes - that's the part I was unable to figure
out. I have a number of additional failure test cases that I will add.
I don't know what sort of code this could break, although I certainly don't
claim to know more about these annotations t
Author: mehdi_amini
Date: Fri Mar 11 12:48:02 2016
New Revision: 263273
URL: http://llvm.org/viewvc/llvm-project?rev=263273&view=rev
Log:
Fix clang crash: when CodeGenAction is initialized without a context, use the
member and not the parameter
From: Mehdi Amini
Modified:
cfe/trunk/lib/Cod
EricWF added a comment.
Unfortunately the discussion was offline so it's not available.
Anybody using `std::mutex` with `std::unique_lock` or their own lock guards
will probably experience some breakage.
Heres an example of code that will now not compile with "-Werror=thread-safety"
std::mut
Author: tejohnson
Date: Fri Mar 11 12:52:42 2016
New Revision: 263276
URL: http://llvm.org/viewvc/llvm-project?rev=263276&view=rev
Log:
Update test case for llvm summary format changes in D17592.
Modified:
cfe/trunk/test/Misc/thinlto.c
Modified: cfe/trunk/test/Misc/thinlto.c
URL:
http://llv
Author: rnk
Date: Fri Mar 11 12:59:12 2016
New Revision: 263279
URL: http://llvm.org/viewvc/llvm-project?rev=263279&view=rev
Log:
Allow sizeof(UnrelatedClass::field) in C++11 class template methods
This feature works outside of templates by forming a DeclRefExpr to a
FieldDecl instead of a Member
EricWF added a comment.
My suggestion would be to make these annotations OFF by default and allow users
to turn them on with a macro.
http://reviews.llvm.org/D14731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
jamesr added a comment.
Ah, that's true. I didn't think of that case. With the design of these
annotations the author of that function would have to disable checks in each
piece of code that uses these patterns.
What about adding a different guard for these annotations in libc++ that
consume
jamesr added a comment.
In http://reviews.llvm.org/D14731#373289, @EricWF wrote:
> My suggestion would be to make these annotations OFF by default and allow
> users to turn them on with a macro.
Our comments crossed streams but suggested the same thing :). Any suggestions
on a naming convent
EricWF added a comment.
In http://reviews.llvm.org/D14731#373301, @jamesr wrote:
> In http://reviews.llvm.org/D14731#373289, @EricWF wrote:
>
> > My suggestion would be to make these annotations OFF by default and allow
> > users to turn them on with a macro.
>
>
> Our comments crossed streams b
Author: rnk
Date: Fri Mar 11 13:17:53 2016
New Revision: 263285
URL: http://llvm.org/viewvc/llvm-project?rev=263285&view=rev
Log:
Add missing triple to instantiate-sizeof.cpp test
Modified:
cfe/trunk/test/SemaTemplate/instantiate-sizeof.cpp
Modified: cfe/trunk/test/SemaTemplate/instantiate-s
eugenis added inline comments.
Comment at: tools/driver/cc1as_main.cpp:413-416
@@ -412,6 +414,6 @@
// FIXME: init MCTargetOptions from sanitizer flags here.
MCTargetOptions Options;
std::unique_ptr TAP(
TheTarget->createMCAsmParser(*STI, *Parser, *MCII, Options))
sbenza added a comment.
> I will separate it, OK. In the Clang there is one use case that I fixed,
> although it did not break the tests. Neither of the other "has..." checkers
> (except the general ones) ignore implicit casts and parenthesized expressions
> so this one should not do it either
Hi Aaron, Hi Juergen,
Could you review this simple patch? Is it OK to merge or are there any changes
to be made?
Thanks,
Roman
> On Mar 9, 2016, at 7:25 PM, Roman Levenstein wrote:
>
> swiftix created this revision.
> swiftix added reviewers: ributzka, aaron.ballman.
> swiftix added a subsc
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ariccio marked an inline comment as done.
ariccio added a comment.
In http://reviews.llvm.org/D16873#371736, @a.sidorin wrote:
> Alexander, could you update status of this review?
It's become a zombie review. I should just abandon it, as I'll be away for two
weeks starting tomorrow.
http://r
Author: jrose
Date: Fri Mar 11 15:14:40 2016
New Revision: 263295
URL: http://llvm.org/viewvc/llvm-project?rev=263295&view=rev
Log:
Fix ObjCMethodDecl::findPropertyDecl for class properties.
This affects code completion and a few other things; hopefully the code
completion
test is sufficient to
rnk added a comment.
I guess I'm OK with the approach.
Comment at: lib/CodeGen/CodeGenFunction.cpp:1967
@@ +1966,3 @@
+
+void CodeGenFunction::cleanupNakedFunction() {
+ llvm::SmallPtrSet InstrsToRemove;
This isn't the right approach. Look at Function::dropAllR
Author: bwilson
Date: Fri Mar 11 15:55:37 2016
New Revision: 263299
URL: http://llvm.org/viewvc/llvm-project?rev=263299&view=rev
Log:
Add fix-it for format-security warnings.
Added:
cfe/trunk/test/SemaObjC/format-strings-objc-fixit.m
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
cfe/t
bob.wilson accepted this revision.
bob.wilson added a reviewer: bob.wilson.
bob.wilson added a comment.
This revision is now accepted and ready to land.
Thanks Ben. Committed in r263299
http://reviews.llvm.org/D17941
___
cfe-commits mailing list
cfe
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM, nice catch Daniel.
(Yes, weird that nothing changed in the IR, but the patch is correct).
-eric
http://reviews.llvm.org/D18015
___
cf
djasper added a comment.
Want me to run clang-format on the file/diff?
http://reviews.llvm.org/D18015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added a comment.
Since you're changing everything anyways? Sure why not! :)
-eric
http://reviews.llvm.org/D18015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper closed this revision.
djasper added a comment.
Formatted and submitted as r263302.
http://reviews.llvm.org/D18015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:726
@@ +725,3 @@
+ let Args = [StringArgument<"Message", 1>,
+ // An optional string argument that enables us to provide a Fix-It.
+ StringArgument<"Replacement", 1>];
The
pete added a comment.
Hi John
Sorry, getting back to this after way too long!
In http://reviews.llvm.org/D14737#294218, @rjmccall wrote:
> In http://reviews.llvm.org/D14737#293967, @pete wrote:
>
> > Added a couple of tests for retain returning types other than id.
> > Returning a pointer sho
aaron.ballman added a comment.
In http://reviews.llvm.org/D18025#373373, @cfe-commits wrote:
> Could you review this simple patch? Is it OK to merge or are there any
> changes to be made?
The usual rule of thumb is to wait about a week before pinging a review --
sometimes the backlogs for rev
jamesr updated this revision to Diff 50481.
jamesr added a comment.
This patch guards the new annotations with
_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS and adds a number of tests to check
that the annotations produce errors when the annotations are enabled that code
violates the thread safety r
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, kkwli0.
carlo.bertolli added subscribers: caomhin, sfantao, arpith-jacob, fraggamuffin,
cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
This patch adds support for codegen of private clause
carlo.bertolli updated this revision to Diff 50489.
carlo.bertolli added a comment.
[OPENMP] Add testing for 32-bit arch
Repository:
rL LLVM
http://reviews.llvm.org/D18105
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_private_codegen.cpp
Index: test/OpenMP/target_private_cod
swiftix added a comment.
Thanks for the hint about adding subscribers, because I was not aware it is
possible in the Web-GUI. That was the reason why a new review was created.
And thanks for the comments. I'll address your comments and upload the new
patch for review.
http://reviews.llvm.org/
eugenis created this revision.
eugenis added a reviewer: EricWF.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
std::addressof may be used on a storage of an object before the start
of its lifetime (see std::allocate_shared for example). CFI flags
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D18107
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: eugenis
Date: Fri Mar 11 17:50:57 2016
New Revision: 263310
URL: http://llvm.org/viewvc/llvm-project?rev=263310&view=rev
Log:
Disable CFI checks in std::addressof.
std::addressof may be used on a storage of an object before the start
of its lifetime (see std::allocate_shared for example).
I think http://clang.llvm.org/docs/InternalsManual.html#fix-it-hints says
that if a fixit is on a warning, then clang should process the code as if
the fixit had been applied. That's not the case here, so I think the fixit
should be on a note instead.
On Fri, Mar 11, 2016 at 4:55 PM, Bob Wilson vi
Did anyone file a PR for this?
> On 2015-Oct-19, at 15:52, Richard Smith via cfe-commits
> wrote:
>
> Ugh, looks like I missed a submodule for stdio.h :(
>
> On Oct 19, 2015 11:34 AM, "Adrian Prantl" wrote:
> While building module 'std' imported from
> /Volumes/Data/llvm/_build.ninja.release
eugenis closed this revision.
eugenis added a comment.
r263310
Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D18107
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I’m not sure how to interpret that. It says: "Clang must recover from errors as
if the fix-it had been applied.” I suppose that format-security could be an
error if you’re building with -Werror, but I had been interpreting that to mean
an error that would block further compilation. Can someone c
On Fri, Mar 11, 2016 at 4:14 PM, Bob Wilson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I’m not sure how to interpret that. It says: "Clang must recover from
> errors as if the fix-it had been applied.” I suppose that format-security
> could be an error if you’re building with -Werror,
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: fraggamuffin, caomhin, cfe-commits.
Target regions require globals to be captured. The capturing scope has been
determine by matching the scope of the capture
pcc added subscribers: majnemer, rnk.
pcc added a comment.
Done (this also affects `_purecall` in the MS ABI; I don't think this change
should break anything there, but someone working on that might want to
comment). Since this patch is now specific to virtual tables anyway, I've
incorporated a
pcc updated this revision to Diff 50500.
pcc added a comment.
Restrict to functions referenced in virtual tables
http://reviews.llvm.org/D18071
Files:
lib/CodeGen/CGVTables.cpp
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCXX/virtual-function-attrs.cpp
test/CodeGenCXX/vtt-layout.cpp
Index
OK. I will do that.
> On Mar 11, 2016, at 4:15 PM, David Blaikie wrote:
>
>
>
> On Fri, Mar 11, 2016 at 4:14 PM, Bob Wilson via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> I’m not sure how to interpret that. It says: "Clang must recover from errors
> as if the fix-it had been
manmanren updated this revision to Diff 50502.
http://reviews.llvm.org/D17865
Files:
include/clang/Basic/Attr.td
lib/Lex/PPMacroExpansion.cpp
lib/Sema/SemaDeclAttr.cpp
test/SemaCXX/attr-deprecated-replacement-error.cpp
test/SemaCXX/attr-deprecated-replacement-fixit.cpp
test/SemaCXX/cx
manmanren marked 3 inline comments as done.
manmanren added a comment.
Upload patch to address review comments.
Thanks,
Manman
http://reviews.llvm.org/D17865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: fraggamuffin, caomhin, cfe-commits.
The current offloading implementation is using -omptargets and
-omp-host-ir-file-path options in the frontend. This causes
pcc created this revision.
pcc added reviewers: rsmith, rjmccall.
pcc added a subscriber: cfe-commits.
The relative vtable ABI will use a struct rather than an array as the type
of a vtable. LLVM only allows 32-bit integers as struct indices, so we need
to use 32-bit integers to get addresses of a
swiftix added inline comments.
Comment at: include/clang/Basic/Attr.td:1394
@@ -1393,1 +1393,3 @@
+def PreserveMost : InheritableAttr {
+ let Spellings = [GNU<"preserve_most">];
aaron.ballman wrote:
> Do these attributes do anything on targets other than AArch6
Author: echristo
Date: Fri Mar 11 19:47:11 2016
New Revision: 263320
URL: http://llvm.org/viewvc/llvm-project?rev=263320&view=rev
Log:
Temporarily revert these patches:
commit 60d9845f6a037122d9be9a6d92d4de617ef45b04
Author: Mehdi Amini
Date: Fri Mar 11 18:48:02 2016 +
Fix clang crash
swiftix updated this revision to Diff 50508.
swiftix added a comment.
This patch revision addresses all issues mentioned by reviewers:
- DocCatCallingConvs is used instead of DocCatVariable.
- ObjectiveC is replaced by Objective-C in the docs.
- Tests for preserve_most and preserve_all are combin
To be clear these were due to test failures under Release (no Asserts)
coming from clang. Mehdi already has a fix in mind.
The bot I mention in followup to the original patch has the test failures.
-eric
On Fri, Mar 11, 2016 at 5:52 PM Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.or
dexonsmith created this revision.
dexonsmith added a reviewer: EricWF.
dexonsmith added a subscriber: cfe-commits.
Modernize the test from r239666 as a precursor for making similar fixes
to unordered_map.
http://reviews.llvm.org/D18115
Files:
test/libcxx/containers/unord/unord.set/insert_dup_
carlo.bertolli updated this revision to Diff 50512.
carlo.bertolli added a comment.
[OPENMP] Add missing check macros in regression test and remove reference to
firstprivate (will come in next patch).
Repository:
rL LLVM
http://reviews.llvm.org/D18105
Files:
lib/CodeGen/CGOpenMPRuntime.cp
dexonsmith updated this revision to Diff 50514.
dexonsmith added a comment.
A few updates:
- Rebased on top of http://reviews.llvm.org/D18115.
- Rewrote the test to match suggested style.
- Updated the code to catch unordered_set::emplace as well, using a
__can_extract_key trait and a companion
EricWF added a comment.
No worries, I'll try and take a look this weekend. Thanks.
http://reviews.llvm.org/D16360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
91 matches
Mail list logo
