r264533 - Remove unused support for replacing declarations from chained AST files.

Author: rsmith Date: Sun Mar 27 00:52:25 2016 New Revision: 264533 URL: http://llvm.org/viewvc/llvm-project?rev=264533=rev Log: Remove unused support for replacing declarations from chained AST files. Modified: cfe/trunk/include/clang/Serialization/ASTBitCodes.h

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

LegalizeAdulthood updated this revision to Diff 51727. LegalizeAdulthood added a comment. Update release notes http://reviews.llvm.org/D16529 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/RawStringLiteralCheck.cpp

[clang-tools-extra] r264531 - Add clang-tools-extra release notes

Author: legalize Date: Sun Mar 27 00:06:57 2016 New Revision: 264531 URL: http://llvm.org/viewvc/llvm-project?rev=264531=rev Log: Add clang-tools-extra release notes Added: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst

r264530 - Use the correct alignment for uuid descriptors

Author: majnemer Date: Sat Mar 26 23:46:14 2016 New Revision: 264530 URL: http://llvm.org/viewvc/llvm-project?rev=264530=rev Log: Use the correct alignment for uuid descriptors The _GUID_ descriptors emitted by MSVC have alignment 8 for 64-bit builds: we should do the same if the linker picks

r264529 - Improve the representation of CXXUuidofExpr

Author: majnemer Date: Sat Mar 26 23:46:07 2016 New Revision: 264529 URL: http://llvm.org/viewvc/llvm-project?rev=264529=rev Log: Improve the representation of CXXUuidofExpr Keep a pointer to the UuidAttr that the CXXUuidofExpr corresponds to. This makes translating from __uuidof to the

Re: [PATCH] Proper detection and handling of RHEL and variants

New patch attached. I've also removed RHEL4 which is now four years past EOL and certainly incapable of building or running any recent version of llvm/clang. -Michael Rafael Espíndola wrote: - if (IsRedhat(Distro)) + if (Distro == Fedora || Distro == RHEL7) RHEL8 will probably use

[PATCH] D18495: Check default arguments of template template parameters for compatibility.

faisalv created this revision. faisalv added a reviewer: rsmith. faisalv added a subscriber: cfe-commits. I'm not sure why this check wasn't being done at template definition time. I can't devise a test case to trigger the concerns in the deleted comments below. Anything I might be missing by

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

faisalv closed this revision. faisalv marked 3 inline comments as done. faisalv added a comment. Committed as r263921 http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160321/153258.html http://reviews.llvm.org/D18139 ___ cfe-commits

Re: [PATCH] D17811: [clang-tidy] Add check to detect dangling references in value handlers.

alexfh added a comment. Still LG. Thank you! http://reviews.llvm.org/D17811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14905: [constexpr-lambda] Support parsing of constexpr specifier (and its inference) on lambda expressions

faisalv closed this revision. faisalv marked 3 inline comments as done. faisalv added a comment. Closed by r264513. http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160321/153846.html http://reviews.llvm.org/D14905 ___ cfe-commits mailing

Re: r264522 - [NFC] Tweak diagnostic for template template arguments, to include template aliases.

Thanks for pointing that out - makes sense - sorry about that! Faisal Vali On Sat, Mar 26, 2016 at 4:11 PM, Richard Smith wrote: > On 26 Mar 2016 1:52 p.m., "Faisal Vali via cfe-commits" > wrote: >> >> Author: faisalv >> Date: Sat Mar 26

Re: [PATCH] D17491: Add performance check to flag function parameters of expensive to copy types that can be safely converted to const references.

flx added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:26 @@ +25,3 @@ + return (Name.empty() ? llvm::Twine('#') + llvm::Twine(Index + 1) + : llvm::Twine('\'') + Name + llvm::Twine('\'')) + .str();

Re: r264522 - [NFC] Tweak diagnostic for template template arguments, to include template aliases.

On 26 Mar 2016 1:52 p.m., "Faisal Vali via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > > Author: faisalv > Date: Sat Mar 26 15:46:45 2016 > New Revision: 264522 > > URL: http://llvm.org/viewvc/llvm-project?rev=264522=rev > Log: > [NFC] For future reference, a change to diagnostic wording

r264522 - [NFC] Tweak diagnostic for template template arguments, to include template aliases.

Author: faisalv Date: Sat Mar 26 15:46:45 2016 New Revision: 264522 URL: http://llvm.org/viewvc/llvm-project?rev=264522=rev Log: [NFC] Tweak diagnostic for template template arguments, to include template aliases. The prior diagnostic (err_template_arg_not_class_template) would state that the

Re: [PATCH] D18489: [PGO, clang] Comment how function pointers for indirect calls are mapped to function names

davidxl added inline comments. Comment at: lib/CodeGen/CodeGenPGO.cpp:758 @@ -757,1 +757,3 @@ + // During instrumentation, function pointers are collected for the different + // indirect call targets. Then as part of the conversion from raw to merged

Possible inaccuracy in CallAndMessageChecker

I'm working on a simple checker for objc block calls and faced some strange behaviour of ConstraintsManager. Even for simple case like this: - (void) callObjcBlock:(void(^)(void)) blockVar { blockVar(); } ConstraintsManager believes that called 'blockVar' is constrained to be non null, not

r264519 - Check if a path is already absolute before trying to make it so.

Author: bwilson Date: Sat Mar 26 13:55:13 2016 New Revision: 264519 URL: http://llvm.org/viewvc/llvm-project?rev=264519=rev Log: Check if a path is already absolute before trying to make it so. The FileSystem::makeAbsolute function has been calculating the current working directory

r264513 - [Cxx1z-constexpr-lambda-P0170R1] Support parsing of constexpr specifier (and its inference) on lambda expressions

Author: faisalv Date: Sat Mar 26 11:11:37 2016 New Revision: 264513 URL: http://llvm.org/viewvc/llvm-project?rev=264513=rev Log: [Cxx1z-constexpr-lambda-P0170R1] Support parsing of constexpr specifier (and its inference) on lambda expressions Support the constexpr specifier on lambda

Re: [PATCH] Proper detection and handling of RHEL and variants

- if (IsRedhat(Distro)) + if (Distro == Fedora || Distro == RHEL7) RHEL8 will probably use --no-add-needed. Can you change this to "if (IsRedhat(Distro) && !old_rhel_distro) "? Cheers, Rafael On 22 March 2016 at 22:07, Michael Lampe via cfe-commits wrote: > -

Re: [PATCH] D11797: [LIbClang] Report the named type for ElaboratedType

skalinichev added a comment. Ok, If there are no objections, I'll commit this revision next week then. http://reviews.llvm.org/D11797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

skalinichev added inline comments. Comment at: tools/libclang/CIndex.cpp:4311 @@ -4311,1 +4310,3 @@ + C.kind == CXCursor_ConversionFunction || + C.kind == CXCursor_FunctionDecl) { if (pieceIndex > 0) What about function templates? E.g.: template

[PATCH] D18489: [PGO] Comment how function pointers for indirect calls are mapped to function names

anemet created this revision. anemet added reviewers: bogner, davidxl. anemet added a subscriber: cfe-commits. Hopefully this will make it easier for the next person to figure all this out... http://reviews.llvm.org/D18489 Files: lib/CodeGen/CodeGenPGO.cpp Index: lib/CodeGen/CodeGenPGO.cpp