[PATCH] D18510: [cxx1z-constexpr-lambda] Make conversion function constexpr

faisalv created this revision. faisalv added a reviewer: rsmith. faisalv added a subscriber: cfe-commits. Mark the lambda's conversion to function-pointer as incontrovertibly constexpr. auto L = [](auto a) { return a; }; constexpr int* (*fp)(int*) = L; // This is now allowed. By itself this is

[PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: alexfh. LegalizeAdulthood added a subscriber: cfe-commits. Update `add_new_check.py` to stub out information in the release notes for the new check. http://reviews.llvm.org/D18509 Files: clang-tidy/add_new_check.py

[clang-tools-extra] r264563 - clang-tidy: Fix broken buildbot

Author: legalize Date: Sun Mar 27 23:15:41 2016 New Revision: 264563 URL: http://llvm.org/viewvc/llvm-project?rev=264563=rev Log: clang-tidy: Fix broken buildbot VS 2013 does not support char16_t or char32_t Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.cpp

Re: r264529 - Improve the representation of CXXUuidofExpr

Good call, fixed in r264562. On Sun, Mar 27, 2016 at 12:29 AM, Richard Smith wrote: > On Sat, Mar 26, 2016 at 9:46 PM, David Majnemer via cfe-commits > wrote: > > Author: majnemer > > Date: Sat Mar 26 23:46:07 2016 > > New Revision: 264529 > >

r264562 - Fix serialization/deserialization for __uuidof

Author: majnemer Date: Sun Mar 27 22:19:50 2016 New Revision: 264562 URL: http://llvm.org/viewvc/llvm-project?rev=264562=rev Log: Fix serialization/deserialization for __uuidof I broke this back in r264529 because I forgot to serialize the UuidAttr member. Fix this by replacing the UuidAttr

Re: [PATCH] D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up

mspertus updated this revision to Diff 51764. mspertus added a comment. Adding missing period in comment! http://reviews.llvm.org/D18497 Files: CMakeLists.txt utils/LLVMVisualizers/CMakeLists.txt utils/LLVMVisualizers/llvm.natvis utils/llvm.natvis Index: utils/llvm.natvis

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

mspertus updated this revision to Diff 51762. mspertus added a comment. Incorporating ariccio's comments and fixing some html http://reviews.llvm.org/D18498 Files: CMakeLists.txt utils/ClangVisualizers/CMakeLists.txt utils/ClangVisualizers/clang.natvis utils/clang.natvis

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

mspertus marked an inline comment as done. mspertus added a comment. http://reviews.llvm.org/D18498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

mspertus marked an inline comment as done. Comment at: utils/ClangVisualizers/CMakeLists.txt:2 @@ +1,3 @@ +# Do this by hand instead of using add_llvm_utilities(), which +# tries to create a corresponding executable, which we don't want +if

Re: [PATCH] D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up

mspertus added a comment. In http://reviews.llvm.org/D18497#384351, @ariccio wrote: > `utils/llvm.natvis` is a duplicate of `utils/LLVMVisualizers/llvm.natvis`? The file was moved to a more appropriate directory (Otherwise, the project files were stepping on each other). `svn mv

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

ariccio added a comment. Assuming everything builds correctly, LGTM. Your CMake is better than mine, so I'm not sure if there're better ways to do this ;) Comment at: utils/ClangVisualizers/CMakeLists.txt:2 @@ +1,3 @@ +# Do this by hand instead of using add_llvm_utilities(),

Re: [PATCH] D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up

ariccio added a comment. `utils/llvm.natvis` is a duplicate of `utils/LLVMVisualizers/llvm.natvis`? Otherwise, assuming everything builds correctly, LGTM. Once again, thanks for doing this! http://reviews.llvm.org/D18497 ___ cfe-commits mailing

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

mspertus updated this revision to Diff 51759. mspertus added a comment. Now that we are generating projects for native visualizers, have it properly reflected in the directory structure http://reviews.llvm.org/D18498 Files: CMakeLists.txt utils/ClangVisualizers/CMakeLists.txt

Re: [PATCH] D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up

mspertus updated this revision to Diff 51754. mspertus added a comment. Since this is now creating a project, we should do some housekeeping to move the files to different directories so that the build tree has an LLVMVisualizers project directory. http://reviews.llvm.org/D18497 Files:

Re: [PATCH] D18501: Fix compilation on FreeBSD

dim added a comment. Note that these compilation errors came up specifically because @bdrewery is doing cross-compilation of FreeBSD with recent versions of gcc. Apparently clang does not give the same errors on these undefined identifiers, but I'm not entirely sure why not...

[PATCH] D18501: Fix compilation on FreeBSD

dim created this revision. dim added reviewers: mclow.lists, EricWF, emaste. dim added subscribers: cfe-commits, bdrewery. Herald added a subscriber: emaste. On FreeBSD, a number of math.h functions are actually defined as macros, such as `signbit()`, `fpclassify()` and others. Since libc++'s

r264540 - [modules] When encoding SourceLocations in bitcode, rotate the 'is macro' flag

Author: rsmith Date: Sun Mar 27 15:13:24 2016 New Revision: 264540 URL: http://llvm.org/viewvc/llvm-project?rev=264540=rev Log: [modules] When encoding SourceLocations in bitcode, rotate the 'is macro' flag bit from the top bit to the bottom bit, so that we don't need 6 VBR6 hunks for each macro

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

Yea sounds fine On Sun, Mar 27, 2016 at 12:20 PM Mike Spertus wrote: > mspertus added a comment. > > I understand your concerns, but on balance, I don't see a better course of > action than what I've done. If I have some time, I'll submit a CMake change > so we can eventually

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

mspertus added a comment. I understand your concerns, but on balance, I don't see a better course of action than what I've done. If I have some time, I'll submit a CMake change so we can eventually migrate to having CMake generate a Natvis tag, but that will take a long time to propagate, so I

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

Ahh that's surprising. If it works even with the none tag, i guess my concerns are not valid On Sun, Mar 27, 2016 at 12:11 PM Mike Spertus wrote: > mspertus added a comment. > > No. Testing shows that it works fine in the project with the `` tag. > VS2015 empirically looks at

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

mspertus added a comment. No. Testing shows that it works fine in the project with the `` tag. VS2015 empirically looks at the extension. http://reviews.llvm.org/D18498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

If it's not using a natvis tag in the vcxproj (which it isn't since CMake doesn't support it during generation) then the new natvis project file support won't work right? In which case the files would need to be copied into documents\vs2015, otherwise it won't work, unless I'm misunderstanding

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

mspertus added a comment. I'm not sure I understand. I'm not installing anything for VS2013. You still have to manually copy into `Documents\VS2013`. The purpose of this change is to eliminate this manual step for VS2015 by leveraging the new Natvis project support. Am I missing something?

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

Code paths. For vs2013 you're installing the natvis files, can we just do that for vs2015 as well? On Sun, Mar 27, 2016 at 11:23 AM Mike Spertus wrote: > mspertus added a comment. > > What do you mean by "making both paths the same"? > > > http://reviews.llvm.org/D18498 > > > >

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

mspertus added a comment. What do you mean by "making both paths the same"? http://reviews.llvm.org/D18498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

Yea, CMake doesn't actually support natvis files. You'd have to actually patch CMake to make it work. Can you make the vs2015 and vs2013 paths the same? It will still work for 2015 i think, just that 2015 also supports putting them in the project file On Sun, Mar 27, 2016 at 10:04 AM Mike Spertus

Re: r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

Hi Daniel, Thanks a lot for your answer and clarifications. Sorry for the long answer, TLDR at the beginning (and end for code examples). To answer your 2 questions immediately: - It happens a lot more than I thought, about 10% of the few thousands file I checked had instances of this. - Yes,

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

mspertus added a comment. Hmmm, I just tried adding ` set_source_files_properties(utils/clang.natvis LANGUAGE natvis)` similar to what you suggest in http://lists.llvm.org/pipermail/llvm-dev/2016-January/093887.html, but it still produces the `None` tag in the `.vcxproj` file. Any suggestion

Re: [PATCH] D18458: [CUDA] Mangle __host__ __device__ functions differently than __host__ or __device__ functions.

jlebar added a comment. > OK, so the question for you is, how much ABI compatibility with NVCC are you > prepared to give up in order to allow HD / D overloading and HD / H > overloading? At the moment, getting this feature to work seems more important than maintaining ABI compatibility with

[clang-tools-extra] r264539 - clang-tidy: Add check modernize-raw-string-literal

Author: legalize Date: Sun Mar 27 11:43:44 2016 New Revision: 264539 URL: http://llvm.org/viewvc/llvm-project?rev=264539=rev Log: clang-tidy: Add check modernize-raw-string-literal Added: clang-tools-extra/trunk/clang-tidy/modernize/RawStringLiteralCheck.cpp

Re: [PATCH] D18495: Check default arguments of template template parameters for compatibility.

faisalv updated this revision to Diff 51742. faisalv marked 2 inline comments as done. faisalv added a comment. Updated the patch with the following: - while checking dependent template template arguments at template definition time, we must accept the more general (pack) as compatible with the

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

mspertus added a comment. In http://reviews.llvm.org/D18498#384233, @zturner wrote: > For vs2015, the files still need to be in the project right? (In the > vcxproj with a tag) This change puts the natvis files in the project for VS2015 but it appears to use the `none` tag

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

For vs2015, the files still need to be in the project right? (In the vcxproj with a tag) On Sun, Mar 27, 2016 at 9:09 AM Mike Spertus wrote: > mspertus updated this revision to Diff 51741. > mspertus added a comment. > > Apply whitespace comments from

Re: [PATCH] D18495: Check default arguments of template template parameters for compatibility.

faisalv marked 2 inline comments as done. Comment at: lib/Sema/SemaTemplate.cpp:793-800 @@ -792,10 +792,2 @@ if (!Default.isInvalid()) { -// Check only that we have a template template argument. We don't want to -// try to check well-formedness now, because our

Re: [PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

mspertus updated this revision to Diff 51741. mspertus added a comment. Apply whitespace comments from http://reviews.llvm.org/D18497 mutatis mutandis to this change http://reviews.llvm.org/D18498 Files: CMakeLists.txt utils/clang.natvis www/hacking.html Index: www/hacking.html

Re: [PATCH] D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up

mspertus marked an inline comment as done. mspertus added a comment. http://reviews.llvm.org/D18497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up

mspertus updated this revision to Diff 51740. mspertus added a comment. Missed one (the missing period in llvm.natvis). http://reviews.llvm.org/D18497 Files: CMakeLists.txt utils/llvm.natvis Index: utils/llvm.natvis === ---

Re: [PATCH] D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! http://reviews.llvm.org/D18497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up

mspertus marked 3 inline comments as done. mspertus added a comment. http://reviews.llvm.org/D18497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up

mspertus updated this revision to Diff 51739. mspertus added a comment. Accepting Aaron's suggestions http://reviews.llvm.org/D18497 Files: CMakeLists.txt utils/llvm.natvis Index: utils/llvm.natvis === --- utils/llvm.natvis

Re: [PATCH] D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up

aaron.ballman added a comment. This is fantastic! Just a few nits, but nothing substantial. Comment at: CMakeLists.txt:739 @@ +738,3 @@ +# tries to create a corresponding executable, which we don't want +if(LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION) + set( LLVM_VISUALIZERS

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

LegalizeAdulthood updated this revision to Diff 51738. LegalizeAdulthood added a comment. Remove brace initializers from test code. http://reviews.llvm.org/D16529 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

Re: [PATCH] D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up

mspertus updated this revision to Diff 51735. mspertus added a comment. Correctly handle non-Visual Studio case (e.g., Linux) http://reviews.llvm.org/D18497 Files: CMakeLists.txt utils/llvm.natvis Index: utils/llvm.natvis ===

[PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

mspertus created this revision. mspertus added reviewers: ariccio, aaron.ballman, zturner. mspertus added a subscriber: cfe-commits. This change uses the [[ https://blogs.msdn.microsoft.com/vcblog/2014/06/12/project-support-for-natvis/ | Project Support for Natvis ]] added in VS2015 to

[PATCH] D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up

mspertus created this revision. mspertus added reviewers: ariccio, aaron.ballman, zturner. mspertus added a subscriber: cfe-commits. This change uses the [[ https://blogs.msdn.microsoft.com/vcblog/2014/06/12/project-support-for-natvis/ | Project Support for Natvis ]] added in VS2015 to

r264534 - Encapsulate a couple of on-disk structures a little more.

Author: rsmith Date: Sun Mar 27 02:28:06 2016 New Revision: 264534 URL: http://llvm.org/viewvc/llvm-project?rev=264534=rev Log: Encapsulate a couple of on-disk structures a little more. Modified: cfe/trunk/include/clang/Serialization/ASTBitCodes.h

Re: r264529 - Improve the representation of CXXUuidofExpr

On Sat, Mar 26, 2016 at 9:46 PM, David Majnemer via cfe-commits wrote: > Author: majnemer > Date: Sat Mar 26 23:46:07 2016 > New Revision: 264529 > > URL: http://llvm.org/viewvc/llvm-project?rev=264529=rev > Log: > Improve the representation of CXXUuidofExpr > > Keep a