ariccio added inline comments.
Comment at: utils/ClangVisualizers/CMakeLists.txt:3
@@ +2,3 @@
+# tries to create a corresponding executable, which we don't want.
+if (LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION)
+ set(CLANG_VISUALIZERS clang.natvis)
Hmm, that's gonna
Hi Jean-Philippe,
no, you have not convinced me with those examples. There is not a single
one, I find more readable. Many of them I find equally unreadable and would
write the code differently. But I would never have chose AlwaysBreak for my
own code in the first place and I rarely work in a code
Author: abataev
Date: Mon Mar 28 04:53:43 2016
New Revision: 264569
URL: http://llvm.org/viewvc/llvm-project?rev=264569&view=rev
Log:
[OPENMP] Allow runtime insert its own code inside OpenMP regions.
Solution unifies interface of RegionCodeGenTy type to allow insert
runtime-specific code before/a
Author: abataev
Date: Mon Mar 28 05:12:03 2016
New Revision: 264570
URL: http://llvm.org/viewvc/llvm-project?rev=264570&view=rev
Log:
Revert "[OPENMP] Allow runtime insert its own code inside OpenMP regions."
This reverts commit 3ee791165100607178073f14531a0dc90c622b36.
Modified:
cfe/trunk/l
Hi Daniel,
Thanks, I understand why your users would have requested that and why you
need to provide this improvement for them.
I will survey the other people writing code with me on whether they are
happy with this improvement considering both the readability of the
statements and the relatively
Author: mzuckerm
Date: Mon Mar 28 07:23:09 2016
New Revision: 264574
URL: http://llvm.org/viewvc/llvm-project?rev=264574&view=rev
Log:
[CLANG][avx512][BUILTIN] Adding fixupimm{pd|ps|sd|ss}
getexp{sd|ss} getmant{sd|ss} kunpck{di|si} loada{pd|ps} loaddqu{di|hi|qi|si}
max{sd|ss} min{sd|ss} kmov16 bu
---
tools/clang-format/clang-format-diff.py | 4 +--
tools/clang-format/clang-format.py | 6 ++---
tools/clang-format/git-clang-format | 42 --
tools/scan-build/bin/set-xcode-analyzer | 24 -
tools/scan-view/bin/scan-view | 11 --
Author: abataev
Date: Mon Mar 28 07:52:58 2016
New Revision: 264576
URL: http://llvm.org/viewvc/llvm-project?rev=264576&view=rev
Log:
[OPENMP] Allow runtime insert its own code inside OpenMP regions.
Solution unifies interface of RegionCodeGenTy type to allow insert
runtime-specific code before/a
Author: abataev
Date: Mon Mar 28 07:58:34 2016
New Revision: 264577
URL: http://llvm.org/viewvc/llvm-project?rev=264577&view=rev
Log:
Revert "[OPENMP] Allow runtime insert its own code inside OpenMP regions."
Reverting because of failed tests.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.
ikudrin updated the summary for this revision.
ikudrin updated this revision to Diff 51782.
ikudrin added a comment.
Make cxa_exception.cpp and cxa_exception_storage.cpp to use the same emergency
memory pool.
http://reviews.llvm.org/D17815
Files:
libcxxabi/trunk/src/CMakeLists.txt
libcxxab
jpienaar added a comment.
Friendly ping.
http://reviews.llvm.org/D17002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:701
@@ -699,1 +700,3 @@
+def OpenCLNoSVM : Attr {
+ let Spellings = [GNU<"nosvm">];
yaxunl wrote:
> aaron.ballman wrote:
> > yaxunl wrote:
> > > aaron.ballman wrote:
> > > > Since the
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/AvoidStdBindCheck.cpp:116
@@ +115,3 @@
+ Finder->addMatcher(
+ callExpr(callee(namedDecl(isStdBind())),
+ hasArgument(0, declRefExpr(to(functionDecl().bind("f")
alexfh
On Fri, Mar 25, 2016 at 7:01 PM, Richard Smith
wrote:
> On Fri, Mar 25, 2016 at 10:55 AM, David Blaikie via cfe-commits
> wrote:
> >
> >
> > On Fri, Mar 25, 2016 at 10:46 AM, Samuel Benzaquen via cfe-commits
> > wrote:
> >>
> >> Author: sbenza
> >> Date: Fri Mar 25 12:46:02 2016
> >> New Revisi
tstellarAMD added inline comments.
Comment at: lib/Basic/Targets.cpp:1854-1857
@@ -1853,1 +1853,6 @@
+ bool isCLZForZeroUndef() const override {
+// It is -1 instead of expected for intrinsic.
+return true;
+ }
+
Why do we need to add this if it's the
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D18472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
aaron.ballman added inline comments.
Comment at: include/clang-c/Index.h:19
@@ -18,1 +18,3 @@
+#ifdef __cplusplus
+#include
Is this produced by the deprecated headers check? If not, what value does ctime
add over time.h?
Comment at: lib/Lex/M
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
Comment at: clang-tidy/misc/AssignOperatorCheck.cpp:74
@@ +73,3 @@
+ } else {
+std::string Name = Method->getParent()->getName();
+
This can be lowered into the if
Author: nico
Date: Mon Mar 28 09:55:24 2016
New Revision: 264582
URL: http://llvm.org/viewvc/llvm-project?rev=264582&view=rev
Log:
Reduce size of DefinitionData from 120 to 96 bytes on Windows.
In the Microsoft ABI, only bitfields with identical types get
packed together, so use unsigned consiste
aaron.ballman added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:94
@@ +93,3 @@
+ bool Bool{false};
+ // CHECK-FIXES: bool Bool{false};
+};
flx wrote:
> aaron.ballman wrote:
> > Why is this checking a fix? I thought tha
aaron.ballman added a comment.
Generally looks good to me, but you should wait for @rsmith as he may have
other ideas on the error recovery.
Comment at: lib/Sema/SemaDecl.cpp:6295
@@ +6294,3 @@
+ Diag(NewVD->getLocation(), diag::err_concept_specialized)
+
aaron.ballman added a subscriber: aaron.ballman.
Comment at: clang-tidy/readability/RedundantStringCStrCheck.cpp:129
@@ +128,3 @@
+ // Detect: 'dst += str.c_str()' -> 'dst += str'
+ // Detect: 's == str.c_str()' -> 's == str'
+ Finder->addMatcher(
I think t
majnemer added a subscriber: majnemer.
Comment at: lib/CodeGen/TargetInfo.cpp:6592-6594
@@ +6591,5 @@
+
+ static bool isRegisterSize(unsigned Size) {
+return (Size == 8 || Size == 16 || Size == 32);
+ }
+
Is this used? A quick grep didn't find any callers.
beanz added a comment.
Perhaps naming this warning 'incompatible-sdk' isn't the best name. I can see
how it would cause some confusion for Visual Studio users. On Darwin the SDK is
the collection of headers and libraries you link against, not the toolkit you
have installed.
Perhaps calling the
On 27 Mar 2016 9:56 a.m., "Justin Lebar via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> jlebar added a comment.
>
> > OK, so the question for you is, how much ABI compatibility with NVCC
are you prepared to give up in order to allow HD / D overloading and HD / H
overloading?
>
>
> At the
anemet added inline comments.
Comment at: lib/CodeGen/CodeGenPGO.cpp:758
@@ -757,1 +757,3 @@
+ // During instrumentation, function pointers are collected for the different
+ // indirect call targets. Then as part of the conversion from raw to merged
davidxl w
> That would break the semantics of things like static local variables in
> inline functions, uniqueness of local types in inline functions, etc. For an
> HD function, that's likely to be fine since HD already breaks those
> properties by creating two independent versions of the function (as not
davidxl added inline comments.
Comment at: lib/CodeGen/CodeGenPGO.cpp:758
@@ -757,1 +757,3 @@
+ // During instrumentation, function pointers are collected for the different
+ // indirect call targets. Then as part of the conversion from raw to merged
anemet w
Author: nico
Date: Mon Mar 28 12:28:06 2016
New Revision: 264597
URL: http://llvm.org/viewvc/llvm-project?rev=264597&view=rev
Log:
Windows: Shrink sizeof(MacroInfo) from 256 to 248, MacroDirective 24 to 16
In the Microsoft ABI, only bitfields with identical types get packed together,
so use consi
anemet added inline comments.
Comment at: lib/CodeGen/CodeGenPGO.cpp:758
@@ -757,1 +757,3 @@
+ // During instrumentation, function pointers are collected for the different
+ // indirect call targets. Then as part of the conversion from raw to merged
davidxl w
On Mon, Mar 28, 2016 at 10:40 AM, Adam Nemet wrote:
> anemet added inline comments.
>
>
> Comment at: lib/CodeGen/CodeGenPGO.cpp:758
> @@ -757,1 +757,3 @@
>
> + // During instrumentation, function pointers are collected for the
> different
> + // indirect call targets. Then as
mspertus added a comment.
This is still showing as "Needs review" Are there any further changes required
or can someone accept it? I installed both VS2015 and VS2013 on my laptop and
saw the correct solution files built by cmake.
http://reviews.llvm.org/D18498
__
bruno added a comment.
Ping :-)
http://reviews.llvm.org/D18304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping :-)
http://reviews.llvm.org/D18296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Jean-Philippe,
I have also been thinking some more about the naming and I think it is not
entirely inaccurate. It is a setting of the option AlignAfterOpenBracket
and setting that to "AlwaysBreak" means "always break instead of aligning".
And it kind of makes sense that one-parameter functions
jpienaar updated this revision to Diff 51806.
jpienaar marked 6 inline comments as done.
jpienaar added a comment.
Removed unnecessary floating point classification (only integer is supported)
and performed suggested cleanups.
http://reviews.llvm.org/D17002
Files:
lib/Basic/Targets.cpp
lib
jpienaar added a comment.
Updated, thanks
Comment at: lib/CodeGen/TargetInfo.cpp:6622-6626
@@ +6621,7 @@
+
+ if (const BuiltinType *BT = T->getAs()) {
+BuiltinType::Kind K = BT->getKind();
+if (K == BuiltinType::Float || K == BuiltinType::Double)
+ return Float;
+
rnk added a subscriber: rnk.
Comment at: lib/Driver/Driver.cpp:2541
@@ +2540,3 @@
+/// no extra characters remaining at the end.
+bool Driver::GetReleaseVersion(const char *Str, unsigned MaxDigits,
+ MutableArrayRef Digits) {
You don'
mspertus closed this revision.
mspertus added a comment.
Committed as revisions 264601 and 264602
http://reviews.llvm.org/D18497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mps
Date: Mon Mar 28 13:03:37 2016
New Revision: 264603
URL: http://llvm.org/viewvc/llvm-project?rev=264603&view=rev
Log:
Use VS2015 Project Support for Natvis to eliminate the need to manually install
clang native visualizer
This is the clang equivalent to llvm commit 264601. When using
mspertus added a comment.
Commited as revision 264603
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus closed this revision.
mspertus added a comment.
Closing diff after commit
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
This patch builds a length-1 `ConversionSpecifier` but includes the complete
code point in the length of the overall format specifier, which is
inconsistent. Please either treat the trailing bytes as part of the
`ConversionSpecifier` or revert the changes to `ParsePrintf
Author: mps
Date: Mon Mar 28 13:24:22 2016
New Revision: 264610
URL: http://llvm.org/viewvc/llvm-project?rev=264610&view=rev
Log:
Convert to Unix line endings due to previous commit error.
Modified:
cfe/trunk/CMakeLists.txt
Modified: cfe/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm
beanz updated this revision to Diff 51813.
beanz added a comment.
Updates based on review feedback.
http://reviews.llvm.org/D18088
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/incompatible_sysroot.c
Index: test/Driver
ariccio added a comment.
In http://reviews.llvm.org/D18498#384711, @mspertus wrote:
> I installed both VS2015 and VS2013 on my laptop and saw the correct solution
> files built by cmake.
Btw, make sure you're running the latest updates for both Visual Studio, else
you'll get funny build error
sepavloff updated this revision to Diff 51817.
sepavloff added a comment.
Changed implementation
This implementation uses another approach. Previous version of the patch put
friend functions
into redeclaration chains but modified search algorithm so that it skipped such
functions. In
this versi
2016-03-18 20:50 GMT+06:00 Richard Smith :
> rsmith added a comment.
>
> Can we instead not add the function to the redeclaration chain until it's
> instantiated (like we do if it's dependent)?
>
>
I prepared implementation that uses this approach. In this variant
information about potential defin
Author: mps
Date: Mon Mar 28 14:08:27 2016
New Revision: 264621
URL: http://llvm.org/viewvc/llvm-project?rev=264621&view=rev
Log:
This file was accidentally committed with bad line endings. Fixed...
Modified:
cfe/trunk/utils/ClangVisualizers/CMakeLists.txt
Modified: cfe/trunk/utils/ClangVisu
yaxunl removed rL LLVM as the repository for this revision.
yaxunl updated this revision to Diff 51821.
yaxunl marked 4 inline comments as done.
yaxunl added a comment.
Revised by Aaron's and Anastasia's comments.
Changed error/warning message for invalid usage of nosvm attribute.
http://review
anemet added inline comments.
Comment at: lib/CodeGen/CodeGenPGO.cpp:758
@@ -757,1 +757,3 @@
+ // During instrumentation, function pointers are collected for the different
+ // indirect call targets. Then as part of the conversion from raw to merged
anemet wr
On Mon, Mar 28, 2016 at 12:31 PM, Adam Nemet wrote:
> anemet added inline comments.
>
>
> Comment at: lib/CodeGen/CodeGenPGO.cpp:758
> @@ -757,1 +757,3 @@
>
> + // During instrumentation, function pointers are collected for the
> different
> + // indirect call targets. Then as
What I meant is that putting the comments in InstrProfData.inc file, and
update the one in CodeGenPGO.cpp to reference that.
David
On Mon, Mar 28, 2016 at 12:35 PM, Xinliang David Li
wrote:
>
>
> On Mon, Mar 28, 2016 at 12:31 PM, Adam Nemet wrote:
>
>> anemet added inline comments.
>>
>> =
anemet added a comment.
In http://reviews.llvm.org/D18489#384851, @davidxl wrote:
> What I meant is that putting the comments in InstrProfData.inc file, and
> update the one in CodeGenPGO.cpp to reference that.
Sounds good. You mean CGCall.cpp instead of CodeGenPGO.cpp though, correct?
So to
Sure.
thanks,
David
On Mon, Mar 28, 2016 at 12:41 PM, Adam Nemet wrote:
> anemet added a comment.
>
> In http://reviews.llvm.org/D18489#384851, @davidxl wrote:
>
> > What I meant is that putting the comments in InstrProfData.inc file, and
> > update the one in CodeGenPGO.cpp to reference that
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM with the comments from David addressed and the comment below addressed.
Comment at: lib/Basic/Targets.cpp:6000-6001
@@ +5999,4 @@
+ break;
+default:
+
echristo added a subscriber: echristo.
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
LGTM, thanks.
-eric
http://reviews.llvm.org/D17002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
bruno updated this revision to Diff 51828.
bruno added a comment.
Thanks Reid. The original idea was to have MaxDigits despite the size of the
input array (but bounded by its size). But since there are no other users up to
this point, your suggestion seems better, updated the patch to reflect it
Author: rnk
Date: Mon Mar 28 15:13:55 2016
New Revision: 264642
URL: http://llvm.org/viewvc/llvm-project?rev=264642&view=rev
Log:
Paper over the Windows-only enum initialization test failure until the bug is
fixed
Modified:
cfe/trunk/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp
Modified:
I made the test pass in r264642 with a triple. We should deal with this
properly at some point, though.
On Sun, Mar 27, 2016 at 11:08 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Mon Mar 28 01:08:37 2016
> New Revision: 264564
>
> URL: http://llv
Author: dcoughlin
Date: Mon Mar 28 15:30:25 2016
New Revision: 264647
URL: http://llvm.org/viewvc/llvm-project?rev=264647&view=rev
Log:
[analyzer] Nullability: Don't warn along paths where null returned from
non-null.
Change the nullability checker to not warn along paths where null is returned
bruno added a comment.
In http://reviews.llvm.org/D18296#384766, @rsmith wrote:
> This patch builds a length-1 `ConversionSpecifier` but includes the complete
> code point in the length of the overall format specifier, which is
> inconsistent. Please either treat the trailing bytes as part of t
aaron.ballman requested changes to this revision.
This revision now requires changes to proceed.
Comment at: lib/Sema/SemaDeclAttr.cpp:5210
@@ +5209,3 @@
+static void handleOpenCLNoSVMAttr(Sema &S, Decl *D, const AttributeList &Attr)
{
+ if (!S.LangOpts.OpenCL) {
+S.Diag(Att
Author: rnk
Date: Mon Mar 28 15:42:41 2016
New Revision: 264651
URL: http://llvm.org/viewvc/llvm-project?rev=264651&view=rev
Log:
Update the description of Clang's MSVC compatibility flags
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org
Author: jpienaar
Date: Mon Mar 28 16:02:54 2016
New Revision: 264655
URL: http://llvm.org/viewvc/llvm-project?rev=264655&view=rev
Log:
[lanai] Add Lanai backend to clang driver.
Changes to clang to add Lanai backend. Adds a new target, ABI and toolchain.
General Lanai backend discussion on llvm-
This revision was automatically updated to reflect the committed changes.
jpienaar marked an inline comment as done.
Closed by commit rL264655: [lanai] Add Lanai backend to clang driver. (authored
by jpienaar).
Changed prior to commit:
http://reviews.llvm.org/D17002?vs=51806&id=51838#toc
Repos
Author: rsmith
Date: Mon Mar 28 16:31:09 2016
New Revision: 264664
URL: http://llvm.org/viewvc/llvm-project?rev=264664&view=rev
Log:
[modules] If both a module file and a module map for the same module are
explicitly provided, and the module map lists a header that does not exist,
unmark the modul
Author: spyffe
Date: Mon Mar 28 16:43:01 2016
New Revision: 264669
URL: http://llvm.org/viewvc/llvm-project?rev=264669&view=rev
Log:
Improvements to the ASTImporter to support LLDB top-level Clang expressions.
The testcase for this is in LLDB, adeed by r264662.
This patch adds support for a vari
> On Mar 25, 2016, at 2:23 PM, Akira Hatanaka via cfe-commits
> wrote:
>
>>
>> On Mar 25, 2016, at 2:06 PM, David Majnemer via cfe-commits
>> mailto:cfe-commits@lists.llvm.org>> wrote:
>>
>>
>>
>> On Fri, Mar 25, 2016 at 12:57 PM, Akira Hatanaka via cfe-commits
>> mailto:cfe-commits@lists
anemet accepted this revision.
anemet added a reviewer: anemet.
anemet added a comment.
This revision is now accepted and ready to land.
Was accepted by davidxl.
http://reviews.llvm.org/D18489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
chandlerc added a comment.
I don't know anything about MIPS and this seems a highly MIPS specific change,
so I can't provide any useful review here. You have someone with MIPS specific
knowledge on the review though, so you seem to have the appropriate people
looped in...
http://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264678: [PGO] More comments how function pointers for
indirect calls are mapped (authored by anemet).
Changed prior to commit:
http://reviews.llvm.org/D18489?vs=51713&id=51845#toc
Repository:
rL LLVM
Author: anemet
Date: Mon Mar 28 17:18:53 2016
New Revision: 264681
URL: http://llvm.org/viewvc/llvm-project?rev=264681&view=rev
Log:
[PGO] More comments how function pointers for indirect calls are mapped
to function names
Summary:
Hopefully this will make it easier for the next person to figure
anemet added a comment.
The summary of commits:
llvm: http://reviews.llvm.org/rL264678
compiler-rt: http://reviews.llvm.org/rL264680
clang: http://reviews.llvm.org/rL264681
Repository:
rL LLVM
http://reviews.llvm.org/D18489
___
cfe-commits maili
Author: dcoughlin
Date: Mon Mar 28 18:55:58 2016
New Revision: 264687
URL: http://llvm.org/viewvc/llvm-project?rev=264687&view=rev
Log:
[analyzer] Use BodyFarm-synthesized body even when actual body available.
Change body autosynthesis to use the BodyFarm-synthesized body even when
an actual body
ygao created this revision.
ygao added subscribers: craig.topper, bogner, cfe-commits.
Hi,
The addcarry and subborrow variants of the builtins do not require the adx
target attribute. Only the addcarryx variants require them.
This patch attempts to remove the target attribute requirements from th
bruno updated this revision to Diff 51859.
bruno added a comment.
Update after Richard's review.
- Handle scanf
- Properly update `ConversionSpecifier`
http://reviews.llvm.org/D18296
Files:
include/clang/Analysis/Analyses/FormatString.h
lib/Analysis/FormatString.cpp
lib/Analysis/FormatSt
hintonda marked 7 inline comments as done.
Comment at: lib/Sema/SemaInit.cpp:1815-1816
@@ -1814,3 +1814,4 @@
// worthwhile to skip over the rest of the initializer, though.
RecordDecl *RD = DeclType->getAs()->getDecl();
RecordDecl::field_iterator FieldEnd = RD->field_end(
sfantao added a comment.
Ping!
http://reviews.llvm.org/D18110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Ping!
http://reviews.llvm.org/D16749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: lib/Sema/SemaInit.cpp:1818-1823
@@ +1817,8 @@
+ RecordDecl::field_iterator FieldStart = Field;
+ unsigned FieldSize = [FieldStart, FieldEnd]() mutable -> unsigned {
+unsigned i = 0;
+for (; FieldStart != FieldEnd; ++FieldStart, +
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Analysis/FormatString.cpp:276
@@ +275,3 @@
+ // UTF-8 sequence. If that's the case, adjust the length accordingly.
+ if (llvm::sys::locale::isPrint(FirstByte))
+return false;
dcoughlin added a subscriber: dcoughlin.
dcoughlin added a comment.
Thanks for fixing this!
Repository:
rL LLVM
http://reviews.llvm.org/D18363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
hintonda added a comment.
I'm probably missing something, but isn't
InitListChecker::CheckStructUnionTypes() called recursively, if indirectly? In
which case we'd want to start from the Field iterator we were given, not the
look at all the fields.
http://reviews.llvm.org/D17407
__
jlebar abandoned this revision.
jlebar added a comment.
New plan, R2: Let nvcc win.
After much discussion, we're abandoning this because we want to maintain abi
compatibility with nvcc. I'm about to upload a revised approach to
http://reviews.llvm.org/D18380 that won't require this.
http://r
jlebar created this revision.
jlebar added a reviewer: rsmith.
jlebar added a subscriber: cfe-commits.
IsOverload has a param named UseUsingDeclRules. But as far as I can
tell, it should be called UseMemberUsingDeclRules. That is, it only
applies to "using" declarations inside classes or structs
jlebar created this revision.
jlebar added reviewers: rnk, rsmith, tra.
jlebar added a subscriber: cfe-commits.
This is necessary for a future patch which will make all constexpr
functions implicitly host+device. cmath may declare constexpr
functions, but these we do *not* want to be host+device.
jlebar added a comment.
Updated as discussed -- please have a look.
http://reviews.llvm.org/D18380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 51868.
jlebar added a comment.
Update per changes to patch description. Now a constexpr becomes implicitly HD
unless there's a preceeding __device__ overload.
http://reviews.llvm.org/D18380
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang
hintonda added inline comments.
Comment at: lib/Sema/SemaInit.cpp:1926-1927
@@ +1925,4 @@
+ assert(Field != FieldEnd);
+ if (SeenFields[i])
+continue;
+ if (!Field->isUnnamedBitfield() && !Field->hasInClassInitializer() &&
rsmith wrote:
> Us
tra added a comment.
I wonder if we can find a way to decide whether particular constexpr function
should be treated as HD or not without relying on particular order the
functions are seen by compiler (or whether they come from system headers).
Right now we're relying on checking overloads of c
Author: flx
Date: Mon Mar 28 21:42:38 2016
New Revision: 264694
URL: http://llvm.org/viewvc/llvm-project?rev=264694&view=rev
Log:
[clang-tidy] Add performance check to flag function parameters of expensive to
copy types that can be safely converted to const references.
Reviewers: alexfh
Subscri
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264694: [clang-tidy] Add performance check to flag function
parameters of expensive… (authored by flx).
Changed prior to commit:
http://reviews.llvm.org/D17491?vs=51385&id=51869#toc
Repository:
rL LL
zaks.anna added inline comments.
Comment at: test/Analysis/MPIChecker.cpp:98
@@ +97,3 @@
+
+ MPI_Request req;
+ MPI_Ireduce(MPI_IN_PLACE, &buf, 1, MPI_DOUBLE, MPI_SUM, 0, MPI_COMM_WORLD,
&req); // expected-note{{Request is previously used by nonblocking call here.}}
---
LegalizeAdulthood added a comment.
Squeak
http://reviews.llvm.org/D17482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LegalizeAdulthood added a subscriber: LegalizeAdulthood.
LegalizeAdulthood added a comment.
Can you add something to the docs/ReleaseNotes.rst for this new check, please?
Repository:
rL LLVM
http://reviews.llvm.org/D17491
___
cfe-commits mailing
jlebar added a comment.
In http://reviews.llvm.org/D18380#385240, @tra wrote:
> What if instead of permanently sticking HD attributes on the constexpr
> function, we instead postpone decision to the point of overload resolution
> and figure out effective attributes or call preference based on c
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rsmith.
george.burgess.iv added a subscriber: cfe-commits.
This patch aims to fix a bug encountered by compiling code with C++14.
Specifically, when evaluating `p` in `__builtin_object_size(p, n)`, we start
speculativel
george.burgess.iv added inline comments.
Comment at: test/SemaCXX/constant-expression-cxx1y.cpp:182
@@ -181,4 +181,3 @@
- // FIXME: We should be able to reject this before it's called
- constexpr void f() {
+ constexpr void f() { // expected-error{{constexpr function never pr
Author: abataev
Date: Tue Mar 29 00:34:15 2016
New Revision: 264700
URL: http://llvm.org/viewvc/llvm-project?rev=264700&view=rev
Log:
[OPENMP] Allow runtime insert its own code inside OpenMP regions.
Solution unifies interface of RegionCodeGenTy type to allow insert
runtime-specific code before/a
1 - 100 of 102 matches
Mail list logo
