Re: [PATCH] D17142: SystemZ: Check required features when handling builtins

jonpa updated this revision to Diff 52026. jonpa added a comment. Tests updated to run with -verify and now work as expected. http://reviews.llvm.org/D17142 Files: include/clang/Basic/BuiltinsSystemZ.def lib/Basic/Targets.cpp test/CodeGen/builtins-systemz-generic0.c test/CodeGen/builtin

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

On Tue, Mar 29, 2016 at 12:03:46PM -0700, Adrian Prantl via cfe-commits wrote: > > > On Mar 29, 2016, at 12:00 PM, Joerg Sonnenberger > > wrote: > > > > On Tue, Mar 29, 2016 at 06:47:24PM +, Adrian Prantl via cfe-commits > > wrote: > >> This code in this patch listens to the driver option

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin added a comment. Friendly ping, please take a look! http://reviews.llvm.org/D18035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki updated this revision to Diff 52029. danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. Minor fixes of review comments. Renamed functions to "isNegative" and "isGreaterEqual" and return bool. Updated comment. Added testcases for false positives I h

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki added a comment. In http://reviews.llvm.org/D13126#381772, @zaks.anna wrote: > Could you add the reduced false positives to the tests file? > > > As far as I see the diagnostics are showing the proper path now.. > > > What do you mean? Does this refer to supplying more information

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste marked 3 inline comments as done. Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIBugReporter.cpp:95 @@ +94,3 @@ + if (Optional SP = N->getLocation().getAs()) { +if (const CallExpr *CE = clang::dyn_cast(SP->getStmt())) { + zaks.anna wr

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

alexfh added a comment. Adding the original author in case he has something to say here. Comment at: clang-tidy/misc/AssignOperatorCheck.h:24 @@ +23,3 @@ +/// * Works with move-assign and assign by value. +/// * Private and deleted operators are ignored. +class AssignOperato

Re: [PATCH] D18210: [analyzer] Fix an assertion fail in hash generation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264851: [analyzer] Fix an assertion fail in hash generation. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D18210?vs=50819&id=52033#toc Repository: rL LLVM http://reviews.llv

r264851 - [analyzer] Fix an assertion fail in hash generation.

Author: xazax Date: Wed Mar 30 05:08:59 2016 New Revision: 264851 URL: http://llvm.org/viewvc/llvm-project?rev=264851&view=rev Log: [analyzer] Fix an assertion fail in hash generation. In case the (uniqueing) location of the diagnostic is in a line that only contains whitespaces there was an asse

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

baloghadamsoftware added a comment. Are there any other comments please? http://reviews.llvm.org/D18243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

alexfh accepted this revision. alexfh added a reviewer: alexfh. alexfh added a comment. No, thank you for the fix! LG http://reviews.llvm.org/D18243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

r264853 - [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

Author: abataev Date: Wed Mar 30 05:43:55 2016 New Revision: 264853 URL: http://llvm.org/viewvc/llvm-project?rev=264853&view=rev Log: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive. Initial parsing/sema/serialization/deserialization support for '#pragma omp declare simd' di

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264853: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D10599?vs=44833&id=52034#toc Repository: rL LLVM

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

baloghadamsoftware marked an inline comment as done. Comment at: clang-tidy/misc/MiscTidyModule.cpp:54 @@ -55,1 +53,3 @@ +CheckFactories.registerCheck( +"misc-assign-operator"); CheckFactories.registerCheck( alexfh wrote: > Check names usually con

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

Anastasia accepted this revision. Anastasia added a comment. LGTM, except for one tiny comment that can be addressed before committing. Comment at: test/SemaOpenCL/nosvm.cl:11 @@ +10,3 @@ +// expected-warning@-4 {{'nosvm' attribute is deprecated and ignored in OpenCL version 2.

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

xazax.hun added a comment. What about NonIdiomaticAddignOperator or UnchainableAssignOperator? http://reviews.llvm.org/D18265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

baloghadamsoftware added a comment. Unchainable is not enough: the original checker (which was extended) also checks for parameters and other qualifiers such as const or virtual. http://reviews.llvm.org/D18265 ___ cfe-commits mailing list cfe-commi

Re: [PATCH] D17142: SystemZ: Check required features when handling builtins

uweigand added a comment. I don't think we actually need the builtins-systemz-z13.c test, it only duplicates tests already done by builtins-systemz.c and builtins-systemz-vector.c. (Note that those tests implicitly verify that there is no compiler error by checking the compiler exit code.) Al

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

alexfh added a comment. > What about NonIdiomaticAddignOperator or UnchainableAssignOperator? Yep, "unchainable" doesn't cover all problems the check detects. `misc-non-idiomatic-assign-operator` seems good though. I'd wait for the original author to chime in before making the change. http:/

r264855 - [ASTMatchers] Existing matcher hasAnyArgument fixed

Author: xazax Date: Wed Mar 30 06:22:14 2016 New Revision: 264855 URL: http://llvm.org/viewvc/llvm-project?rev=264855&view=rev Log: [ASTMatchers] Existing matcher hasAnyArgument fixed Summary: A checker (will be uploaded after this patch) needs to check implicit casts. The checker needs matcher

Re: [PATCH] D18408: readability check for const params in declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL264856: [clang-tidy] readability check for const params in declarations (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D18408?vs=51954&id=52037#toc Repository: rL LLVM http:/

[clang-tools-extra] r264856 - [clang-tidy] readability check for const params in declarations

Author: alexfh Date: Wed Mar 30 06:31:33 2016 New Revision: 264856 URL: http://llvm.org/viewvc/llvm-project?rev=264856&view=rev Log: [clang-tidy] readability check for const params in declarations Summary: Adds a clang-tidy warning for top-level consts in function declarations. Reviewers: hokei

Re: [PATCH] D18408: readability check for const params in declarations

alexfh added a comment. Actually, we missed one thing: may I ask you to update docs/ReleaseNotes.rst with a short description of the new check? Repository: rL LLVM http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang-tools-extra] r264858 - [docs] Added 3.8 clang-tidy release notes, fixed formatting.

Author: alexfh Date: Wed Mar 30 07:05:33 2016 New Revision: 264858 URL: http://llvm.org/viewvc/llvm-project?rev=264858&view=rev Log: [docs] Added 3.8 clang-tidy release notes, fixed formatting. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/Rel

Re: [clang-tools-extra] r264856 - [clang-tidy] readability check for const params in declarations

This doesn't build on Windows: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11018/steps/build%20stage%201/logs/stdio d:\buildslave\clang-x64-ninja-win7\llvm\tools\clang\tools\extra\clang-tidy\readability\../ClangTidyModule.h(61) : error C2660: 'clang::tidy::readability::AvoidCons

[clang-tools-extra] r264859 - [clang-tidy] Adjust dangling references check to ASTMatcher changes.

Author: xazax Date: Wed Mar 30 07:16:09 2016 New Revision: 264859 URL: http://llvm.org/viewvc/llvm-project?rev=264859&view=rev Log: [clang-tidy] Adjust dangling references check to ASTMatcher changes. Modified: clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.cpp Modified: clang-t

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a nit. Thank you! Comment at: docs/ReleaseNotes.rst:129 @@ +128,3 @@ + + This check looks for procedures (functions returning no value) with `return` + state

Re: r264855 - [ASTMatchers] Existing matcher hasAnyArgument fixed

Looks like this broke clang-tidy/misc-dangling-handle.cpp ( http://lab.llvm.org:8011/builders/clang-bpf-build/builds/9704). Can you take a look? On Wed, Mar 30, 2016 at 4:22 AM, Gabor Horvath via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: xazax > Date: Wed Mar 30 06:22:14 2016 > N

Re: r264855 - [ASTMatchers] Existing matcher hasAnyArgument fixed

Sure, this should be fixed in http://reviews.llvm.org/rL264859 On 30 March 2016 at 14:24, Nico Weber wrote: > Looks like this broke clang-tidy/misc-dangling-handle.cpp ( > http://lab.llvm.org:8011/builders/clang-bpf-build/builds/9704). Can you > take a look? > > On Wed, Mar 30, 2016 at 4:22 AM,

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

alexfh added a comment. A few more nits. Comment at: docs/ReleaseNotes.rst:68 @@ +67,3 @@ + + This check flags calls to ``system()``, ``popen()``, and ``_popen()``, which + execute a command processor. I'd remove "This check" at the start of all check descript

[clang-tools-extra] r264862 - [clang-tidy] Fix MSVC build.

Author: alexfh Date: Wed Mar 30 07:35:05 2016 New Revision: 264862 URL: http://llvm.org/viewvc/llvm-project?rev=264862&view=rev Log: [clang-tidy] Fix MSVC build. Modified: clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.h Modified: clang-tools-extra/trunk/clang-tidy/r

Re: [clang-tools-extra] r264856 - [clang-tidy] readability check for const params in declarations

Thanks for letting me know! Should be fixed in r264862. On Wed, Mar 30, 2016 at 2:19 PM, Nico Weber wrote: > This doesn't build on Windows: > > > http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11018/steps/build%20stage%201/logs/stdio > > d:\buildslave\clang-x64-ninja-win7\llvm\too

[PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

michael_miller created this revision. michael_miller added reviewers: flx, alexfh. michael_miller added a subscriber: cfe-commits. Added the remaining features needed to satisfy C++ Core Guideline Type.6: Always initialize a member variable to cppcoreguidelines-pro-type-member-init. The check no

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

aaron.ballman added a comment. In http://reviews.llvm.org/D18265#386676, @alexfh wrote: > > What about NonIdiomaticAddignOperator or UnchainableAssignOperator? > > > Yep, "unchainable" doesn't cover all problems the check detects. > `misc-non-idiomatic-assign-operator` seems good though. I'd wai

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

alexfh added a comment. In http://reviews.llvm.org/D18265#386717, @aaron.ballman wrote: > In http://reviews.llvm.org/D18265#386676, @alexfh wrote: > > > > What about NonIdiomaticAddignOperator or UnchainableAssignOperator? > > > > > > Yep, "unchainable" doesn't cover all problems the check detect

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

xazax.hun added a comment. In http://reviews.llvm.org/D18265#386717, @aaron.ballman wrote: > In http://reviews.llvm.org/D18265#386676, @alexfh wrote: > > > > What about NonIdiomaticAddignOperator or UnchainableAssignOperator? > > > > > > Yep, "unchainable" doesn't cover all problems the check det

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

baloghadamsoftware added a comment. Actually, there was nothing wrong with assign operator signatures per se either although the original name of the checker was AssignOperatorSignature. The only change here is that it does not check the signature only anymore, but also the body (if present).

Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too

realincubus added a comment. @bkramer I can verify that after building this with clang 3.9 in release mode it does not work anymore like expected. everything is fine in debug mode if i look at the output generated from llvm::sys::DynamicLibrary::LoadLibraryPermanently in 1761 CompilerInstanc

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

On Wed, Mar 30, 2016 at 8:56 AM, Alexander Kornienko wrote: > alexfh added a comment. > > In http://reviews.llvm.org/D18265#386717, @aaron.ballman wrote: > >> In http://reviews.llvm.org/D18265#386676, @alexfh wrote: >> >> > > What about NonIdiomaticAddignOperator or UnchainableAssignOperator? >> >

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

On Wed, Mar 30, 2016 at 8:52 AM, Gábor Horváth wrote: > xazax.hun added a comment. > > In http://reviews.llvm.org/D18265#386717, @aaron.ballman wrote: > >> In http://reviews.llvm.org/D18265#386676, @alexfh wrote: >> >> > > What about NonIdiomaticAddignOperator or UnchainableAssignOperator? >> > >>

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

alexfh added a comment. In http://reviews.llvm.org/D18265#386720, @baloghadamsoftware wrote: > Actually, there was nothing wrong with assign operator signatures per se > either although the original name of the checker was AssignOperatorSignature. > The only change here is that it does not chec

Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too

bkramer added a comment. If we really want to go down this route we should drop the exports file, putting random symbols in there is not going to fly. I'm not sure what that would break for libclang users though. Also make sure that your building without BUILD_SHARED_LIBS, otherwise you'll get

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

baloghadamsoftware added a comment. misc-unconventional-assign-operator? http://reviews.llvm.org/D18265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18338: AMDGPU: Add frexp_exp builtins

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D18338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

On Wed, Mar 30, 2016 at 9:23 AM, Alexander Kornienko wrote: > alexfh added a comment. > > In http://reviews.llvm.org/D18265#386720, @baloghadamsoftware wrote: > >> Actually, there was nothing wrong with assign operator signatures per se >> either although the original name of the checker was >>

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda added a comment. Will do, but that will have to be done in it's own patch. http://reviews.llvm.org/D18575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18595: MPI-Checker test helper

Alexander_Droste created this revision. Alexander_Droste added a reviewer: zaks.anna. Alexander_Droste added subscribers: dcoughlin, xazax.hun, cfe-commits. This file contains definitions that help to test MPI-Checker functionality, on functions not visible to the analyzer, as they are defined in

Re: [PATCH] D18408: readability check for const params in declarations

My attempts to do this end with: $ arc diff Linting... No lint engine configured for this project. Running unit tests... No unit test engine is configured for this project. SKIP STAGING Unable to determine repository for this change. Exception ERR_CLOSED: This revision has already been closed. (

r264868 - Prepare tests for change to emit Module SourceFileName to LLVM assembly

Author: tejohnson Date: Wed Mar 30 08:59:49 2016 New Revision: 264868 URL: http://llvm.org/viewvc/llvm-project?rev=264868&view=rev Log: Prepare tests for change to emit Module SourceFileName to LLVM assembly Modify these tests to ignore the source file name when looking for the expected string. I

Re: [PATCH] D18408: readability check for const params in declarations

fowles added a subscriber: fowles. fowles added a comment. My attempts to do this end with: $ arc diff Linting... No lint engine configured for this project. Running unit tests... No unit test engine is configured for this project. SKIP STAGING Unable to determine repository for this change. Ex

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. I *really* like this as a modernize check, especially since (throwing) dynamic exception specifications may be removed in C++1z. However, I think this check doesn't do e

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

Eugene.Zelenko added a comment. It's much better to add information in release notes in same patch as check itself. See also http://reviews.llvm.org/D18509 for related add_new_check.py improvement. http://reviews.llvm.org/D18575 ___ cfe-commits ma

Re: [PATCH] D18110: [OpenMP] Fix SEMA bug in the capture of global variables in template functions.

sfantao added a comment. Hi Alexey, Thanks for the review. Comment at: lib/Sema/SemaOpenMP.cpp:816-822 @@ -801,6 +815,9 @@ + + // A DSA refers to this captured region if the parent contexts match. + auto *ParentContext = RSI->TheCapturedDecl->getParent(); for (auto I = Sta

Re: [PATCH] D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment. I'd like to see some Sema tests for sanity checking; like applying __unaligned to a non-pointer type, to a declaration, when -fno-ms-extensions is enabled, etc. Comment at: include/clang/Basic/Attr

[PATCH] D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier

andreybokhanko created this revision. andreybokhanko added reviewers: rnk, majnemer. andreybokhanko added a subscriber: cfe-commits. This patch implements proper mangling for MS-specific "__unaligned" qualifier. The mangling part itself is tiny; most of the patch is required to convert "__unalig

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste updated this revision to Diff 52059. Alexander_Droste added a comment. - fix typo http://reviews.llvm.org/D12761 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/MPI-Checker/MPIBugReporter.cpp lib/Stat

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste updated the summary for this revision. Alexander_Droste updated this revision to Diff 52056. Alexander_Droste added a comment. - added test that uses wrapper functions around MPI functions - added test to check behavior in case MPI functions are used in other translation units -

Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

yaxunl marked 6 inline comments as done. Comment at: lib/AST/ASTContext.cpp:7613 @@ +7612,3 @@ +if (getLangOpts().OpenCL) { + if (LHS.getUnqualifiedType() != RHS.getUnqualifiedType() || + LQuals.getCVRQualifiers() != RQuals.getCVRQualifiers()) An

Re: [PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

DmitryPolukhin updated this revision to Diff 52070. DmitryPolukhin added a comment. - Added test for templates in declare target region http://reviews.llvm.org/D18542 Files: include/clang/AST/ASTMutationListener.h include/clang/AST/Attr.h include/clang/Basic/Attr.td include/clang/Basic/

Re: [PATCH] D18457: [clang-tidy] Add a new checker to detect missing comma in initializer list.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a few comments. Further functionality improvements can be done in a follow up, I think. Please update docs/ReleaseNotes.rst. Comment at: clang-tidy/misc/Susp

r264873 - [SystemZ] Specify required features for builtins.

Author: jonpa Date: Wed Mar 30 10:51:24 2016 New Revision: 264873 URL: http://llvm.org/viewvc/llvm-project?rev=264873&view=rev Log: [SystemZ] Specify required features for builtins. BuiltinsSystemZ.def is extended to include the required processor features per intrinsic. New test test/CodeGen/bu

Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

yaxunl added inline comments. Comment at: test/SemaOpenCL/address-spaces-conversions-cl2.0.cl:276 @@ +275,3 @@ + constant char *arg_const_ch; + var_void_const = 0 ? var_cond : arg_const_ch; +#ifndef CONSTANT Anastasia wrote: > btw, what happens if we assign into

Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

yaxunl updated this revision to Diff 52073. yaxunl marked 6 inline comments as done. yaxunl added a comment. Revised by Anastasia's comments. Added comments to code for cases 1a-c and 2a-c. Added codegen test for missing cases of 1a-b and 2a-b. Rename variables in sema test. http://reviews.llvm

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda added a comment. Sounds like a good idea. I'll add the additional transformations you mentioned and remove s/noexcept(true)/noexcept/. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:24 @@ +23,3 @@ + char delimiter) { + SmallVector Cand

Re: [PATCH] D17142: SystemZ: Check required features when handling builtins

jonpa added a comment. Tests updated per instructions, and commited as r264873. http://reviews.llvm.org/D17142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18457: [clang-tidy] Add a new checker to detect missing comma in initializer list.

xazax.hun added inline comments. Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:75 @@ +74,3 @@ + diag(ConcatenatedLiteral->getLocStart(), + "suspicious string literal, probably missing a comma"); +} alexfh wrote: > We need to add a recommendati

r264874 - [c-index-test] Delete dead function, NFC

Author: vedantk Date: Wed Mar 30 11:03:02 2016 New Revision: 264874 URL: http://llvm.org/viewvc/llvm-project?rev=264874&view=rev Log: [c-index-test] Delete dead function, NFC Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modified: cfe/trunk/tools/c-index-test/c-index-test.c URL: htt

Re: [PATCH] D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier

rnk added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1970 @@ +1969,3 @@ + +This modifier makes sense for IPF targets only; Clang supports proper mangling +of the variables with ``unaligned`` modifier, but it doesn't affect generated I don't think

Re: [PATCH] D18457: [clang-tidy] Add a new checker to detect missing comma in initializer list.

alexfh added inline comments. Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:75 @@ +74,3 @@ + diag(ConcatenatedLiteral->getLocStart(), + "suspicious string literal, probably missing a comma"); +} xazax.hun wrote: > alexfh wrote: > > We need to

Re: [PATCH] D18567: Block: Fix a crash when we have type attributes or qualifiers with omitted return type.

Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-block.cl:9 @@ -8,3 +8,3 @@ int (^const bl2)(); // expected-error{{invalid block variable declaration - must be initialized}} - int (^const bl3)() = ^const(){ + int (^const bl3)() = ^(){ // expected-error{{i

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

yaxunl updated this revision to Diff 52077. yaxunl marked an inline comment as done. yaxunl added a comment. Insert an empty line to the test for clarity. http://reviews.llvm.org/D17861 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKi

Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM, please correct two small issues commented here! Comment at: lib/Sema/SemaExpr.cpp:169 @@ -168,4 +168,3 @@ break; - bool Warn = !D->getAttr()->isIn

Re: [PATCH] D17811: [clang-tidy] Add check to detect dangling references in value handlers.

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. Can you add a synopsis of this new check to `docs/ReleaseNotes.rst` please? Repository: rL LLVM http://reviews.llvm.org/D17811 ___ cfe-commits mailing lis

Re: [PATCH] D18408: readability check for const params in declarations

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. You can submit the release notes changes in a new patch. Repository: rL LLVM http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. Please summarize this check in `docs/ReleaseNotes.rst`. There is a pending review that will stub this out automatically, but it hasn't been approved yet http://reviews.llvm.org/D18265 ___

Re: [PATCH] D18408: readability check for const params in declarations

fowles added a comment. that is what I was trying to do. I can't seem to make arc play nice. Repository: rL LLVM http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. Please summarize the improvements in `docs/ReleaseNotes.rst` in the clang tidy section. http://reviews.llvm.org/D18396 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D18136: boost-use-to-string check

LegalizeAdulthood added a comment. Please summarize this check in `docs/ReleaseNotes.rst` in the clang-tidy section. http://reviews.llvm.org/D18136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

yaxunl updated this revision to Diff 52080. yaxunl marked 3 inline comments as done. yaxunl added a comment. Add back a blank line deleted by accident. Add OpenCL to a comment. http://reviews.llvm.org/D17412 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/AST/ASTContext.cpp lib/Sema

Re: [PATCH] D18408: readability check for const params in declarations

LegalizeAdulthood added a comment. Maybe you need to rebase first? I haven't used arc. Repository: rL LLVM http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D18457: [clang-tidy] Add a new checker to detect missing comma in initializer list.

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. Can you summarize this check in `docs/ReleaseNotes.rst` in the clang-tidy section, please? http://reviews.llvm.org/D18457 ___ cfe-commits mailing list cfe-c

Re: [PATCH] D18475: [clang-tidy] Add more detection rules for redundant c_str calls.

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. Can you summarize the improvements in `docs/ReleaseNotes.rst` please? http://reviews.llvm.org/D18475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

LegalizeAdulthood added inline comments. Comment at: docs/ReleaseNotes.rst:143 @@ -71,3 +142,3 @@ Improvements to ``modularize`` ^^ The formatting here has been changed on trunk. Please rebase with a full file context so we can se

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. Can you summarize the improvements in `docs/ReleaseNotes.rst`, please? http://reviews.llvm.org/D18584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D18608: note for top-level consts in function decls tidy

fowles created this revision. fowles added a reviewer: alexfh. fowles added a subscriber: cfe-commits. Add missing release note http://reviews.llvm.org/D18608 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs

Re: [PATCH] D18408: readability check for const params in declarations

Helped by sbenza@ http://reviews.llvm.org/D18608 On Wed, Mar 30, 2016 at 12:54 PM, Richard wrote: > LegalizeAdulthood added a comment. > > Maybe you need to rebase first? I haven't used arc. > > > Repository: > rL LLVM > > http://reviews.llvm.org/D18408 > > > > ___

Re: [PATCH] D18408: readability check for const params in declarations

fowles added a comment. Helped by sbenza@ http://reviews.llvm.org/D18608 Repository: rL LLVM http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier

majnemer added a comment. I didn't implement a mangling for `__unaligned` because our implementation of it is broken. It should not be modeled as an attribute, it should be modeled as a qualifier because it is possible to overload on it. http://reviews.llvm.org/D18596 __

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

> On Mar 29, 2016, at 10:06 PM, David Blaikie wrote: > > > > On Tue, Mar 29, 2016 at 12:03 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > > > On Mar 29, 2016, at 12:00 PM, Joerg Sonnenberger > > wrote: > > > > On Tue, Mar 29,

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

Alexander_Droste added inline comments. Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:653 @@ +652,3 @@ +// name by calling 'getDescriptiveName' recursively. +else { + std::string Idx = ER->getDescriptiveName(false); I wasn't able to build a test c

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

> On Mar 30, 2016, at 12:50 AM, Joerg Sonnenberger via cfe-commits > wrote: > > On Tue, Mar 29, 2016 at 12:03:46PM -0700, Adrian Prantl via cfe-commits wrote: >> >>> On Mar 29, 2016, at 12:00 PM, Joerg Sonnenberger >>> wrote: >>> >>> On Tue, Mar 29, 2016 at 06:47:24PM +, Adrian Prantl v

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:653 @@ +652,3 @@ +// name by calling 'getDescriptiveName' recursively. +else { + std::string Idx = ER->getDescriptiveName(false); Alexander_Droste wrote: > I wasn't abl

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:653 @@ +652,3 @@ +// name by calling 'getDescriptiveName' recursively. +else { + std::string Idx = ER->getDescriptiveName(false); xazax.hun wrote: > Alexander_Droste wr

Re: [PATCH] D15031: CFG: Add CFGElement for automatic variables that leave the scope

rsmith added a comment. Please add a test that builds and dumps a CFG and checks it has the right shape. It's generally not sufficient for the only tests for one LLVM project to exist in a different LLVM project. See test/Analysis/cfg.cpp for an example of how to do this. Com

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko added a comment. Which style I should use? Suggested by Richard or just provide links to documentation as in updated version? Repository: rL LLVM http://reviews.llvm.org/D18582 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

Alexander_Droste added inline comments. Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:653 @@ +652,3 @@ +// name by calling 'getDescriptiveName' recursively. +else { + std::string Idx = ER->getDescriptiveName(false); zaks.anna wrote: > xazax.hun wr

Re: [PATCH] D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash

iid_iunknown updated this revision to Diff 52092. iid_iunknown added a comment. Test case added. Repository: rL LLVM http://reviews.llvm.org/D18557 Files: lib/AST/ASTContext.cpp test/PCH/Inputs/arm-__va_list_tag.h test/PCH/arm-__va_list_tag.c Index: test/PCH/arm-__va_list_tag.c ==

Re: [PATCH] D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash

iid_iunknown added a comment. Thank you for your remark, Richard. I added the test. Could you check if the patch is good now, please? Repository: rL LLVM http://reviews.llvm.org/D18557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D18613: [PassManager] Make PassManagerBuilder::addExtension take an std::function, rather than a function pointer.

jlebar created this revision. jlebar added a reviewer: chandlerc. jlebar added a subscriber: cfe-commits. Herald added a subscriber: joker.eph. This gives callers flexibility to pass lambdas with captures, which lets callers avoid the C-style void*-ptr closure style. (Currently, callers in clang

Re: [PATCH] D18380: [CUDA] Make unattributed constexpr functions (usually) implicitly host+device.

jlebar added a comment. (Just to be clear, I'm waiting on Richard's review here, even though he lg'ed an version of this patch.) http://reviews.llvm.org/D18380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

  1   2   3   >