courbet added a comment.
In http://reviews.llvm.org/D18649#389363, @alexfh wrote:
> Thank you for working on the new clang-tidy check!
>
> We usually recommend authors to run their checks on a large code base to
> ensure it doesn't crash and doesn't generate obvious false positives. It
> would
RedX2501 created this revision.
RedX2501 added reviewers: EricWF, MatzeB, echristo, jroelofs.
RedX2501 added a subscriber: cfe-commits.
http://reviews.llvm.org/D18752
Files:
docs/CommandGuide/lit.rst
Index: docs/CommandGuide/lit.rst
=
MatzeB added a comment.
Most patterns and several of the ones coming from lit.local.cfg are explained
in TestingGuide.rst as well. On the other hand it makes sense to explain the
lit specific substitutions in the lit docu, maybe just add an additional link
to the TestingGuide.rst to reference t
sepavloff updated this revision to Diff 52527.
sepavloff added a comment.
Updated patch
Added a check for presence of template declaration corresponding to the friend
function. Presence of similar functions but with specializations as argument
types is also checked now.
Made an atempt to make me
RedX2501 updated this revision to Diff 52530.
RedX2501 added a comment.
Added reference to testing infrastructure document.
http://reviews.llvm.org/D18752
Files:
docs/CommandGuide/lit.rst
Index: docs/CommandGuide/lit.rst
===
---
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
I'd probably go for a term like "pattern" instead of macro (there is no
parameters or anything more complicated). The explanation for %t/%T is not
helpful in the current form. Maybe something
a.sidorin added a subscriber: a.sidorin.
a.sidorin added a comment.
Matthias,
Could you take a look at http://reviews.llvm.org/D16403? It looks like a
duplicating work but it should cover not Objective-C only.
http://reviews.llvm.org/D15031
___
cf
RedX2501 updated this revision to Diff 52531.
RedX2501 added a comment.
I had a hard time myself figuring out what tmpbase and tmpdir are. I have used
your wording.
Somebody else needs to commit this as I don't have any rights for it.
http://reviews.llvm.org/D18752
Files:
docs/CommandGuide/
hokein updated this revision to Diff 52532.
hokein marked an inline comment as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D18180
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/StaticDefiniti
hokein updated this revision to Diff 52533.
hokein marked 3 inline comments as done.
hokein added a comment.
Remove dump code.
http://reviews.llvm.org/D18180
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/StaticDefiniti
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4393-4431
@@ +4392,41 @@
+/// retrieved from the provided map clause expression.
+DeclarationMapInfoEntry(const Expr *MCE, OpenMPMapClauseKind MapType,
+OpenMPMapClauseKi
hokein updated this revision to Diff 52534.
hokein added a comment.
doc update.
http://reviews.llvm.org/D18180
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/StaticDefinitionInAnonymousNamespaceCheck.cpp
clang-tidy/re
AndyG updated this revision to Diff 52535.
AndyG marked 5 inline comments as done.
AndyG added a comment.
Implemented comments.
http://reviews.llvm.org/D17149
Files:
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/PPMacroExpansion.cpp
test/Preprocessor/feature_tests.c
test/Preprocesso
AndyG added inline comments.
Comment at: lib/Lex/PPMacroExpansion.cpp:1456-1457
@@ +1455,4 @@
+
+// Parse next non-comment, non-annotation token.
+do PP.LexUnexpandedNonComment(Tok); while (Tok.isAnnotation());
+
rsmith wrote:
> If we get an annotation tok
dsanders added a subscriber: dsanders.
Comment at: test/Preprocessor/init.c:3295
@@ +3294,3 @@
+// MIPSN32BE: #define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4 1
+// MIPSN32BE: #define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8 1
+// MIPSN32BE-NOT: __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16
---
Author: abataev
Date: Mon Apr 4 05:12:15 2016
New Revision: 265287
URL: http://llvm.org/viewvc/llvm-project?rev=265287&view=rev
Log:
[OPENMP 4.0] Support for 'inbranch|noinbranch' clauses in 'declare
simd'.
Added parsing/semantic analysis for 'inbranch|notinbranch' clauses of
'#pragma omp declar
Rob updated this revision to Diff 52539.
Rob added a comment.
adding -std=c++11 and it works as expected. yay
http://reviews.llvm.org/D18396
Files:
clang-tidy/modernize/UseOverrideCheck.cpp
docs/ReleaseNotes.rst
test/clang-tidy/modernize-use-override-ms.cpp
test/clang-tidy/modernize-use
courbet updated this revision to Diff 52541.
courbet marked 2 inline comments as done.
courbet added a comment.
cosmetics + more documentation
http://reviews.llvm.org/D18649
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
cla
courbet added inline comments.
Comment at:
docs/clang-tidy/checks/cppcoreguidelines-interfaces-global-init.rst:7
@@ +6,3 @@
+This check flags initializers of globals that access extern objects,
+and therefore can lead to order-of-initialization problems.
+
alexfh
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
> OK to commit then?
Yeah, looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D18319
___
cfe-commits mailing list
cfe-commits@lists.l
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with one nit. Thank you for the patch!
Please tell, if you need someone to commit the patch for you.
Comment at: docs/ReleaseNotes.rst:73
@@ +72,3 @@
+
+ The fix-
alexfh added inline comments.
Comment at: test/clang-tidy/modernize-use-override-ms.cpp:2
@@ +1,3 @@
+// RUN: %check_clang_tidy %s modernize-use-override %t -- -- -fms-extensions
-std=c++11
+
+// This test is designed to test ms-extension __declspec(dllexport) attributes.
---
alexfh added a comment.
In http://reviews.llvm.org/D18649#390862, @courbet wrote:
> In http://reviews.llvm.org/D18649#389363, @alexfh wrote:
>
> > Thank you for working on the new clang-tidy check!
> >
> > We usually recommend authors to run their checks on a large code base to
> > ensure it doe
alexfh added inline comments.
Comment at:
clang-tidy/readability/StaticDefinitionInAnonymousNamespaceCheck.cpp:52
@@ +51,3 @@
+ "anonymous namespace; static is redundant here")
+ << Def->getName();
+ Token Tok;
`DiagnosticBuild
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
1. Looks like `modernize` would be a better fit for this check, since it
targets a pattern common for pre-standard C++ (or C code).
2. Please clang-format the code.
3. Please run the
Rob updated this revision to Diff 52543.
Rob added a comment.
Adding back quotes in the docs
http://reviews.llvm.org/D18396
Files:
clang-tidy/modernize/UseOverrideCheck.cpp
docs/ReleaseNotes.rst
test/clang-tidy/modernize-use-override-ms.cpp
test/clang-tidy/modernize-use-override.cpp
In
Rob added a comment.
ok, I'm not sure if its worth rolling back the change to
modernize-use-override-ms.cpp, see ammended comments above.
Apart from this it should be good to go.
I think I am going to need someone to submit the patch for me, I can't use svn
due to 'error 400' so I've been usin
ioeric updated this revision to Diff 52547.
ioeric added a comment.
- Added fix for empty namespace.
- Merge multiple continuous token deletions into one big replacement; minor
code styling.
- refactored code to reduce redundancy.
http://reviews.llvm.org/D18551
Files:
include/clang/Format/Fo
hokein updated this revision to Diff 52549.
hokein marked 7 inline comments as done.
hokein added a comment.
Update.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-confi
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This landed way back in http://reviews.llvm.org/rL214306.
http://reviews.llvm.org/D4619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hokein updated this revision to Diff 52550.
hokein marked an inline comment as done.
hokein added a comment.
Remove redundant code.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Input
hokein marked an inline comment as done.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:329
@@ +328,3 @@
+for (const std::string& Check : EnabledChecks) {
+ for (const ClangTidyOptions::StringPair &CheckSource:
+ EffectiveOptions.CheckSources) {
alexfh added a comment.
The patch doesn't apply cleanly. Please rebase it on top of HEAD.
http://reviews.llvm.org/D18396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
In http://reviews.llvm.org/D18396#391031, @Rob wrote:
> ok, I'm not sure if its worth rolling back the change to
> modernize-use-override-ms.cpp, see ammended comments above.
No, the test is fine as it is.
> Apart from this it should be good to go.
>
> I think I am
hokein updated this revision to Diff 52552.
hokein marked 3 inline comments as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D18180
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/StaticDefiniti
hokein added inline comments.
Comment at:
clang-tidy/readability/StaticDefinitionInAnonymousNamespaceCheck.cpp:52
@@ +51,3 @@
+ "anonymous namespace; static is redundant here")
+ << Def->getName();
+ Token Tok;
alexfh wrote:
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265295: Add a PragmaHandler Registry for plugins to add
PragmaHandlers to (authored by john.brawn).
Changed prior to commit:
http://reviews.llvm.org/D18319?vs=51168&id=52553#toc
Repository:
rL LLVM
Author: john.brawn
Date: Mon Apr 4 09:22:58 2016
New Revision: 265295
URL: http://llvm.org/viewvc/llvm-project?rev=265295&view=rev
Log:
Add a PragmaHandler Registry for plugins to add PragmaHandlers to
This allows plugins which add AST passes to also define pragmas to do things
like only enable
Author: alexfh
Date: Mon Apr 4 09:31:36 2016
New Revision: 265298
URL: http://llvm.org/viewvc/llvm-project?rev=265298&view=rev
Log:
[clang-tidy] fix a couple of modernize-use-override bugs
Fix for __declspec attributes and const=0 without space
This patch is to address 2 problems I found with
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265298: [clang-tidy] fix a couple of modernize-use-override
bugs (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D18396?vs=52543&id=52555#toc
Repository:
rL LLVM
http://review
courbet added a comment.
In http://reviews.llvm.org/D18649#391001, @alexfh wrote:
> In http://reviews.llvm.org/D18649#390862, @courbet wrote:
>
> > In http://reviews.llvm.org/D18649#389363, @alexfh wrote:
> >
> > > Thank you for working on the new clang-tidy check!
> > >
> > > We usually recommen
aturetsk added a comment.
Ping.
http://reviews.llvm.org/D18398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe added a comment.
The other python test fix has been applied in r263170 (Differential Revision:
http://reviews.llvm.org/D17226).
Has anyone had a chance to look at _this_ patch yet?
Repository:
rL LLVM
http://reviews.llvm.org/D17180
___
cf
alexfh added a comment.
In http://reviews.llvm.org/D18396#391084, @alexfh wrote:
> The patch doesn't apply cleanly. Please rebase it on top of HEAD.
Actually, the conflict was only in the ReleaseNotes.rst file, which I had to
change anyway to fix the formatting around the place you changed. Th
sbenza added a comment.
As Alex mentioned, we have a test like this.
It also adds a hardcoded list of user-defined types that are known to be better
when passed by value (eg. StringRef)
One big difference is that we decided to not trigger on typedefs.
We can't know that the typedef is documented
alexfh added a comment.
In http://reviews.llvm.org/D18649#391112, @courbet wrote:
> In http://reviews.llvm.org/D18649#391001, @alexfh wrote:
>
> > In http://reviews.llvm.org/D18649#390862, @courbet wrote:
> >
> > > In http://reviews.llvm.org/D18649#389363, @alexfh wrote:
> > >
> > > > Thank you f
ikudrin added a comment.
Ping...
http://reviews.llvm.org/D17815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:329
@@ +328,3 @@
+for (const std::string& Check : EnabledChecks) {
+ for (const ClangTidyOptions::StringPair &CheckSource:
+ EffectiveOptions.CheckSources) {
hokein wrot
alexfh added inline comments.
Comment at:
clang-tidy/readability/StaticDefinitionInAnonymousNamespaceCheck.cpp:49
@@ +48,3 @@
+
+ DiagnosticBuilder Diag =
+ diag(Def->getLocation(), "%0 is a static definition in "
nit: `auto`?
Comment at:
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D18509#388071, @hintonda wrote:
> With this change, won't you need to update 2 different repos: clang and
> extra? Is it possible to update both with a single Phabricator patch?
This is updating the release notes in the extra repos
LegalizeAdulthood added a comment.
As it stands currently, you can't commit a header with `CHECK-MESSAGES` and
`CHECK-FIXES` lines and have them verified.
That's the whole point of this changeset.
Currently you have to do something very hacky in order to verify changes made
to headers.
http:
sdowney added a comment.
At least in my codebase, skipping templates is too strong. I run across ones
where the const& parameter is not one controlled by a template. It's often a
size_t.
I could easily see not fixing the typedef'd refs, also, although I think
warning on them is still useful. P
carlo.bertolli added a comment.
Hi Alexey
I understand your concerns and share the danger of working on optimizations
before a correct implementation is actually in place.
I do not think this is the case. My comment was very precise about the
cause-effect: the OpenMP specification was defined i
Author: chapuni
Date: Mon Apr 4 10:30:44 2016
New Revision: 265301
URL: http://llvm.org/viewvc/llvm-project?rev=265301&view=rev
Log:
AnnotateFunctions: Tweak for mingw.
- Externalize the registry.
- Update libdeps.
Modified:
cfe/trunk/examples/AnnotateFunctions/CMakeLists.txt
cfe/tr
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D17482#390237, @alexfh wrote:
> My main concern is that this change makes the already complicated and
> unobvious testing mechanism [...]
The complexity and obtuseness of the existing testing mechanism is unrelated to
this changese
Is it worth teaching FileCheck about lit-defined keywords, and
reject check-prefixes that end in one of them?
Offhand that would be UNSUPPORTED, RUN, REQUIRES, XFAIL
(I haven't actually gone to look at what lit knows).
--paulr
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-bo
sbenza added a comment.
In http://reviews.llvm.org/D18191#391168, @sdowney wrote:
> At least in my codebase, skipping templates is too strong. I run across ones
> where the const& parameter is not one controlled by a template. It's often a
> size_t.
The only check we are doing (other than mat
Author: etienneb
Date: Mon Apr 4 10:46:38 2016
New Revision: 265303
URL: http://llvm.org/viewvc/llvm-project?rev=265303&view=rev
Log:
[clang-tidy] Reduce false-positive ratio in misc-suspicious-missing-comma check.
Summary:
This patch is adding detection of common string literal patterns
that sh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265303: [clang-tidy] Reduce false-positive ratio in
misc-suspicious-missing-comma check. (authored by etienneb).
Changed prior to commit:
http://reviews.llvm.org/D18695?vs=52365&id=52563#toc
Repository
Author: cbertol
Date: Mon Apr 4 10:55:02 2016
New Revision: 265304
URL: http://llvm.org/viewvc/llvm-project?rev=265304&view=rev
Log:
[OPENMP] Codegen for teams directive for NVPTX
This patch implements the teams directive for the NVPTX backend. It is
different from the host code generation path
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 265304.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
probinson added a subscriber: probinson.
probinson added a comment.
In http://reviews.llvm.org/D18752#390906, @RedX2501 wrote:
> Somebody else needs to commit this as I don't have any rights for it.
When someone else commits for you, our practice is to attribute the correct
author in the commi
Rob added a comment.
Thanks :)
Repository:
rL LLVM
http://reviews.llvm.org/D18396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RedX2501 added a comment.
Thanks for the advice.
Please use Guilherme Bufolo as the name for the commit.
Am 04.04.2016 21:33 schrieb "Paul Robinson" <
paul_robin...@playstation.sony.com>:
> probinson added a subscriber: probinson.
> probinson added a comment.
>
> In http://reviews.llvm.org/
Author: marshall
Date: Mon Apr 4 11:08:54 2016
New Revision: 265306
URL: http://llvm.org/viewvc/llvm-project?rev=265306&view=rev
Log:
Fix for Bug #27193; 'std::acos on complex does not agree with C'. Tests need
work; so the bug will stay open.
Modified:
libcxx/trunk/include/complex
Modifi
Prazek added a comment.
In http://reviews.llvm.org/D18745#390739, @Eugene.Zelenko wrote:
> Isn't readability-implicit-bool-cast¶ should catch such issues? If not, I
> think will be good idea to improve that check instead of introducing new one.
I wouldn't add this functionality there. I see th
d.zobnin.bugzilla added a comment.
Richard, thank you for the review and explanation!
I don't have any examples of useful code using this extension, I was trying to
fix the PR... So, do you think we should add this GCC extension to Clang (with
a proper warning, of course) for compatibility reaso
dsanders created this revision.
dsanders added a reviewer: vkalintiris.
dsanders added a subscriber: cfe-commits.
dsanders added a dependency: D18753: [mips][sanitizer_common] Don't use `ld` in
internal_clone() on 32-bit MIPS..
The MIPS IAS can now pass 'ninja check-all' and recurse now that the
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
The clang-tidy documentation generation was broken since commit :
http://reviews.llvm.org/D18457
I ran locally the documentation generation and I fixed errors related to that
specific ch
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Lgtm I suppose the test worked fine because it still found the right magic
bytes.
http://reviews.llvm.org/D18747
___
cfe-commits mailing list
cfe-comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265314: Document standard substitutions defined by lit.
(authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D18752?vs=52531&id=52578#toc
Repository:
rL LLVM
http://reviews.llvm
george.burgess.iv added a comment.
Ping ;)
http://reviews.llvm.org/D18425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D18540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a subscriber: bruno.
bruno added a comment.
Hi Andrey,
Comment at: include/clang/Driver/Options.td:1281
@@ -1280,1 +1280,3 @@
+def miamcu : Flag<["-"], "miamcu">, Group, Flags<[DriverOption,
CoreOption]>,
+ HelpText<"Use Intel MCU ABI.">;
def malign_functions_EQ :
Anastasia added a comment.
LG, apart from renaming the test file.
Btw, there is another place in lib/CodeGen/CGExprScalar.cpp with
CreateAddrSpaceCast call too. I am wondering if that could have the same
issue... if yes, may be we should fix it already now.
Comment at: test/C
Hello,
Here's a little one-off patch that fixes
https://llvm.org/bugs/show_bug.cgi?id=19986 for me, by allowing a few
more things inside [] when trying to match a lambda capture section.
I hope someone can help it find its way into the main repo.
Cheers,
Jacek
Index: lib/Format/UnwrappedLinePars
Anastasia added a subscriber: Matt.
Anastasia added a comment.
Cool, thanks! I think we should commit this ASAP.
@Xiuli/@Matt, do you have any more comments here?
http://reviews.llvm.org/D17412
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Matt added a comment.
In http://reviews.llvm.org/D17412#391322, @Anastasia wrote:
> Cool, thanks! I think we should commit this ASAP.
>
> @Xiuli/@Matt, do you have any more comments here?
Hi! I think that "Matt" for this one would be @arsenm :-)
http://reviews.llvm.org/D17412
_
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: alexfh.
george.burgess.iv added a subscriber: cfe-commits.
This patch seems trivial, but I've never touched clang-tidy before, so I'm just
making sure I didn't miss something obvious. :)
--
Clang has a parameter attrib
sbenza created this revision.
sbenza added a reviewer: alexfh.
sbenza added a subscriber: cfe-commits.
The check detects multi-statement macros that are used in unbraced conditionals.
Only the first statement will be part of the conditionals and the rest will fall
outside of it and executed uncond
jyknight added a comment.
Done and done.
http://reviews.llvm.org/D17933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jyknight updated this revision to Diff 52587.
jyknight marked 2 inline comments as done.
jyknight added a comment.
review fixes
http://reviews.llvm.org/D17933
Files:
lib/Basic/Targets.cpp
lib/Frontend/InitPreprocessor.cpp
test/CodeGen/atomic-ops.c
test/CodeGen/ms-volatile.c
test/CodeG
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:782
@@ +781,3 @@
+LLVM_ATTRIBUTE_UNUSED_RESULT bool noteUnrecoverableFailure() {
+ // This is a little bit icky. We leave HasSideEffects unchange if we
+ // aren't going to keep running, because eval
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, doug.gregor.
aaron.ballman added a subscriber: cfe-commits.
Currently, attribute subject lists attempt to automatically determine what
diagnostic to emit when the attribute does not appertain to a given
declaration. It d
Author: rjmccall
Date: Mon Apr 4 13:33:08 2016
New Revision: 265324
URL: http://llvm.org/viewvc/llvm-project?rev=265324&view=rev
Log:
IRGen-level lowering for the Swift calling convention.
Added:
cfe/trunk/include/clang/CodeGen/SwiftCallingConv.h
cfe/trunk/lib/CodeGen/SwiftCallingConv.cp
Author: rjmccall
Date: Mon Apr 4 13:33:00 2016
New Revision: 265323
URL: http://llvm.org/viewvc/llvm-project?rev=265323&view=rev
Log:
Add a couple of convenience operations to CharUnits.
Modified:
cfe/trunk/include/clang/AST/CharUnits.h
Modified: cfe/trunk/include/clang/AST/CharUnits.h
URL:
yaxunl added a comment.
> Btw, there is another place in lib/CodeGen/CGExprScalar.cpp with
> CreateAddrSpaceCast call too. I am wondering if that could have the same
> issue... if yes, may be we should fix it already now.
I cannot find another CreateAddrSpaceCast in lib/CodeGen/CGExprScalar.cp
dblaikie abandoned this revision.
dblaikie added a subscriber: rsmith.
dblaikie added a comment.
In http://reviews.llvm.org/D3635#44720, @rsmith wrote:
> Implementation LGTM, if you decide that you want to go in this direction.
Just looking over some old patches/git branches I had lying around.
On Mon, Apr 4, 2016 at 11:33 AM, John McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rjmccall
> Date: Mon Apr 4 13:33:00 2016
> New Revision: 265323
>
> URL: http://llvm.org/viewvc/llvm-project?rev=265323&view=rev
> Log:
> Add a couple of convenience operations to CharUnits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265325: Add copyright notice to the modulemap file.
(authored by ygao).
Changed prior to commit:
http://reviews.llvm.org/D18709?vs=52414&id=52590#toc
Repository:
rL LLVM
http://reviews.llvm.org/D187
Author: ygao
Date: Mon Apr 4 13:46:09 2016
New Revision: 265325
URL: http://llvm.org/viewvc/llvm-project?rev=265325&view=rev
Log:
Add copyright notice to the modulemap file.
The module.modulemap file in the lib/Headers directory was missing the LLVM
copyright notice. This patch adds the copyrigh
I forgot to edit the message.
Do you think it's worth going back and fixing the log message at this point?
Kit Barton, Ph.D.LLVM Development on POWERIBM Toronto Lab, D2/929/8200/MKM8200 Warden Ave, Markham, L6G 1C7(905) 413-3452kbar...@ca.ibm.com
- Original message -From: Eric Christo
> On Apr 4, 2016, at 11:49 AM, Sean Silva wrote:
> On Mon, Apr 4, 2016 at 11:33 AM, John McCall via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: rjmccall
> Date: Mon Apr 4 13:33:00 2016
> New Revision: 265323
>
> URL: http://llvm.org/viewvc/llvm-project?rev=265323&view=rev
Author: rjmccall
Date: Mon Apr 4 13:53:01 2016
New Revision: 265328
URL: http://llvm.org/viewvc/llvm-project?rev=265328&view=rev
Log:
Assignment operators should return by reference.
Thanks to Sean Silva for pointing this out.
Modified:
cfe/trunk/include/clang/AST/CharUnits.h
Modified: cfe
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:2489
@@ -2485,1 +2488,3 @@
+ bool MissingImplicitThis = false,
+ bool *FailedDueToValueDependentExpr = nullptr);
I'd just call this `Dep
Thanks, r265324 fixed the assert.
On Fri, Apr 1, 2016 at 8:25 PM, John McCall wrote:
> On Apr 1, 2016, at 3:50 PM, Nico Weber wrote:
> On Thu, Mar 10, 2016 at 8:30 PM, John McCall via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rjmccall
>> Date: Thu Mar 10 22:30:31 2016
>> N
Please accept this diff as a change to support dllimport of objective c
interfaces on windows. I've included a new test and changes to an existing test
as well. All clang tests pass on Linux & Windows. This change is required for
Microsoft's use of the clang compiler in support of objective c on
etienneb updated this revision to Diff 52601.
etienneb marked 3 inline comments as done.
etienneb added a comment.
add options, configurable list of function names, support for ! pattern.
http://reviews.llvm.org/D18703
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
djasper added inline comments.
Comment at: include/clang/Format/Format.h:770
@@ +769,3 @@
+/// \brief Returns the replacements corresponding to applying, fixing, and
+/// reformatting \p Replaces.
+tooling::Replacements fixReplacements(StringRef Code,
I think we s
etienneb updated this revision to Diff 52602.
etienneb added a comment.
nits
http://reviews.llvm.org/D18703
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.h
docs/cla
1 - 100 of 147 matches
Mail list logo
