r265889 - test: add additional tests for SVN r265888

2016-04-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Apr 9 22:31:09 2016 New Revision: 265889 URL: http://llvm.org/viewvc/llvm-project?rev=265889=rev Log: test: add additional tests for SVN r265888 Add test cases for AArch64 as well as that was changed as part of that change. Modified:

r265888 - Add support for __gnu_mcount_nc as the pg interface

2016-04-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Apr 9 22:19:47 2016 New Revision: 265888 URL: http://llvm.org/viewvc/llvm-project?rev=265888=rev Log: Add support for __gnu_mcount_nc as the pg interface This adds support to optionally support using `__gnu_mcount_nc` as the mcount interface rather than `mcount` for

Re: [PATCH] D18868: [Sema] PR27155: Fix a template argument deduction bug with base classes

2016-04-09 Thread Erik Pilkington via cfe-commits
erik.pilkington updated this revision to Diff 53164. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. Avoid another copy when Arg is not a record type. Richard: I don't think it's possible to avoid copying Deduced when Arg is not a complete type, because we

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

2016-04-09 Thread Piotr Padlewski via cfe-commits
Prazek added inline comments. Comment at: clang-tidy/modernize/UseUsingCheck.cpp:26 @@ +25,3 @@ +/// AST representation of type. +std::string removeExtraASTWords(std::string subject) { + std::pair subs[] = { add static

r265878 - Basic: thread TargetOptions into TargetInfo

2016-04-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Apr 9 14:09:25 2016 New Revision: 265878 URL: http://llvm.org/viewvc/llvm-project?rev=265878=rev Log: Basic: thread TargetOptions into TargetInfo This threads TargetOptions into the TargetInfo hierarchy. This is a rework of the original attempt to thread additional

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

2016-04-09 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list

r265877 - ObjC kindof: check the context when inserting methods to global pool.

2016-04-09 Thread Manman Ren via cfe-commits
Author: mren Date: Sat Apr 9 13:59:48 2016 New Revision: 265877 URL: http://llvm.org/viewvc/llvm-project?rev=265877=rev Log: ObjC kindof: check the context when inserting methods to global pool. To make kindof lookup work, we need to insert methods with different context into the global pool,

Re: [PATCH] D18919: Add check "modernize use using"

2016-04-09 Thread Jakub StaroĊ„ via cfe-commits
staronj added inline comments. Comment at: clang-tidy/modernize/UseUsingCheck.h:19 @@ +18,3 @@ + +/// FIXME: Write a short description. +/// Fix the FIXME. Comment at: test/clang-tidy/modernize-use-using.cpp:76 @@ +75,1 @@ +// CHECK-FIXES: using

[PATCH] D18919: Add check "modernize use using"

2016-04-09 Thread Krystyna via cfe-commits
krystyna created this revision. krystyna added reviewers: Prazek, mnbvmar, staronj, alexfh. krystyna added a subscriber: cfe-commits. http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

Re: [PATCH] D18919: Add check "modernize use using"

2016-04-09 Thread Piotr Padlewski via cfe-commits
Prazek added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-using.rst:13 @@ +12,3 @@ + typedef int variable; + +After: add cases with pointers to function / members http://reviews.llvm.org/D18919

Re: [PATCH] D18136: boost-use-to-string check

2016-04-09 Thread Piotr Padlewski via cfe-commits
Prazek updated the summary for this revision. Prazek updated this revision to Diff 53121. Prazek marked 5 inline comments as done. http://reviews.llvm.org/D18136 Files: clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/boost/UseToStringCheck.cpp

Re: [PATCH] D18914: [clang-tidy] new readability-redundant-inline

2016-04-09 Thread Matthias Gehre via cfe-commits
mgehre added a comment. I'm thinking about extending the check to the following issue and would like to hear your opinion. In C++, the following three code snippets all have identical meaning 1: struct S { int f(); }; inline int S::f() { return 0; } 2: struct S {

Re: [PATCH] D18914: [clang-tidy] new readability-redundant-inline

2016-04-09 Thread Matthias Gehre via cfe-commits
mgehre updated this revision to Diff 53118. mgehre added a comment. Update for review comments http://reviews.llvm.org/D18914 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/RedundantInlineCheck.cpp

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

2016-04-09 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 53114. Prazek marked 2 inline comments as done. Prazek added a comment. Used isMacroID to determinate if it's macro http://reviews.llvm.org/D18821 Files: clang-tidy/modernize/BoolToIntegerConversionCheck.cpp

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

2016-04-09 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 53113. Prazek marked 2 inline comments as done. http://reviews.llvm.org/D18821 Files: clang-tidy/modernize/BoolToIntegerConversionCheck.cpp clang-tidy/modernize/BoolToIntegerConversionCheck.h clang-tidy/modernize/CMakeLists.txt