Author: mehdi_amini
Date: Sat Apr 23 22:44:55 2016
New Revision: 267321
URL: http://llvm.org/viewvc/llvm-project?rev=267321&view=rev
Log:
Make thinlto clang test more robust against LLVM changes.
We should just test the effect of the clang level option here, i.e.
that a summary is correctly emitt
EricWF abandoned this revision.
EricWF added a comment.
Abandoning after advice from @mclow.lists
http://reviews.llvm.org/D19247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ctopper
Date: Sat Apr 23 21:08:22 2016
New Revision: 267313
URL: http://llvm.org/viewvc/llvm-project?rev=267313&view=rev
Log:
Fix a couple assertions that can never fire because the condition ANDed with
the string is just true or 1.
Modified:
cfe/trunk/lib/Frontend/Rewrite/RewriteMod
srhines added a comment.
Anna, if I scroll over the new include file in phabricator, it shows as a
proper file move (in a yellow column at the start of the right diff - hover for
it to say this). Every line is the same from the original file, as this is
being moved only to fix up the relative p
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM!
One thing to be aware here is that a const pointer could be deleted, so we
should be able to delete a parent object without a warning. (I think that
should work with this patch si
zaks.anna added a comment.
Thanks for working on this!
The main unfinished task here is to investigate ways of reducing the
performance hit. See more info below.
> The patch was tested on Android open-source platform source code.
Just to double check, have you compare the pre and after result
Author: dexonsmith
Date: Sat Apr 23 17:29:26 2016
New Revision: 267302
URL: http://llvm.org/viewvc/llvm-project?rev=267302&view=rev
Log:
DebugInfo: DIGlobalVariables became 'distinct' in LLVM r267301
Update testcases due to DIBuilder change.
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-glo
zaks.anna added a comment.
"Since we are adding support for so many new APIs that are only available on
Windows, could you please condition checking them only when we build for
Windows. You probably can look and Language Options to figure that out."
By this, I was suggesting that we should be c
zaks.anna added a comment.
Would it be possible to generate the diff that shows that the file moved as
opposed to being deleted and added?
http://reviews.llvm.org/D19393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: dexonsmith
Date: Sat Apr 23 16:08:27 2016
New Revision: 267297
URL: http://llvm.org/viewvc/llvm-project?rev=267297&view=rev
Log:
DebugInfo: Adapt to loss of DITypeRef in LLVM r267296
LLVM stopped using MDString-based type references, and DIBuilder no
longer fills 'retainedTypes:' with eve
etienneb added a comment.
Tested over LLVM code, no false positives.
Two catches:
http://reviews.llvm.org/D19460
http://reviews.llvm.org/D19451
http://reviews.llvm.org/D19451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added a subscriber: cfe-commits.
Herald added a reviewer: tstellarAMD.
Herald added a subscriber: arsenm.
The expression is detected as a redundant expression.
Turn out, this is probably a bug.
```
/home/etienneb/llvm/llvm/l
etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added a subscriber: cfe-commits.
The expression is redundant on both side of operator |.
detected by : http://reviews.llvm.org/D19451
http://reviews.llvm.org/D19459
Files:
lib/Transforms/InstCombine/InstCombineAndOrXor.c
etienneb updated this revision to Diff 54785.
etienneb added a comment.
addressed eugene requests.
http://reviews.llvm.org/D19451
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/RedundantExpressionCheck.cpp
clang-tidy/misc/RedundantExpressionChec
etienneb added a comment.
> Will check catch more complicated cases, like
[..]
It is not "yet" catching these cases:
if ((Point2.x > Point1.x) && (Point1.x < Point2.x)) ?
I believe the AreEquivalentExpression should be extended, and probably llifted
to utils.
Here again, I propose to do it i
etienneb added a comment.
In http://reviews.llvm.org/D19451#410014, @Eugene.Zelenko wrote:
> Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
>
> Will check catch more complicated cases, like
>
> if ((Point1.x < Point2.x) && (Point1.x < Point2.x)) ?
It is catching t
Kessoufi updated this revision to Diff 54762.
Kessoufi added a comment.
- my previous fix was applied on the wrong location and accidentally worked.
now applied on the right location
- previous tests still pass
- added a specific test to highlight my issue
http://reviews.llvm.org/D19194
Files
chapuni added a subscriber: chapuni.
chapuni added a comment.
This had been failing. Fixed in r267290.
See also http://bb.pgr.jp/builders/msbuild-llvmclang-x64-msc19-DA/builds/349
Comment at:
clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:120
@@
Author: chapuni
Date: Sat Apr 23 09:54:28 2016
New Revision: 267290
URL: http://llvm.org/viewvc/llvm-project?rev=267290&view=rev
Log:
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp: Use
raw_string_ostream::str() to flush the buffer explicitly.
Modified:
clang-tools-extra/trunk/clan
Author: marshall
Date: Sat Apr 23 09:31:00 2016
New Revision: 267287
URL: http://llvm.org/viewvc/llvm-project?rev=267287&view=rev
Log:
Rename a few tests that had typos in their names. No functional change. Thanks
to STL for the catch
Added:
libcxx/trunk/test/std/input.output/iostreams.base
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Will check catch more complicated cases, like
if ((Point1.x < Point2.x) && (Point1.x < Point2.x)) ?
Will be good idea to add such case
21 matches
Mail list logo
